aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-01-01Add a "failed" return for tap packet routines.Guy Harris147-715/+788
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-01Move some command-line-oriented routines from wsutil to ui.Guy Harris48-86/+72
cmdarg_err() is for reporting errors for command-line programs and command-line errors in GUI programs; it's not something for any of the Wireshark libraries to use. The various routines for parsing numerical command-line arguments are not for general use, they're just for use when parsing arguments. Change-Id: I100bd4a55ab8ee4497f41d9651b0c5670e6c1e7f Reviewed-on: https://code.wireshark.org/review/31281 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-01Add some new symbols.Guy Harris1-0/+4
Change-Id: I1652b4357ca93913696a89a9254e4bfe9c2484b7 Reviewed-on: https://code.wireshark.org/review/31282 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-31WSDG: Update the find and goto images and descriptions.Gerald Combs4-70/+64
Change-Id: I3e8fcc3b2c940e241d4c38c2b03d4ec44bcd319e Reviewed-on: https://code.wireshark.org/review/31280 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31Export ITS-AppId/psId names from IEEE1609Christophe GUERBER10-96/+414
PsId and ITS-AID are defined in several documents and listed in ieee1609.12. Put these definitions in ieee1609.2 ASN1 definition and export it so that GeoNetworking and wsmp dissectors may use it. Change-Id: Ia3ac181a4c9092b555decb3ee7c5e78adcece5c0 Reviewed-on: https://code.wireshark.org/review/31236 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31CESoETH: Add dissection of MEF 8 CES over EthernetJaap Keuter5-0/+520
Add dissection of Metro Ethernet Forum specification of Implementation Agreement for the Emulation of PDH Circuits over Metro Ethernet Networks [MEF 8]. This includes the introduction of a RTP shim header dissection function, as is not uncommon in PW and CES services. Signed-off-by: Jaap Keuter <jaap.keuter@aimvalley.nl> Change-Id: I6de81007ce11793cd5352fadadd80d3f6f45ae0d Reviewed-on: https://code.wireshark.org/review/31239 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-31Accept v1 of GeoNetworking and improve item treeChristophe GUERBER1-16/+77
Accept version value 1 for geonetworking, dissect last 4 bytes of SHB and traffic class as per EN 302 636-4. Change-Id: I254e48f888aae063d2f4b5178c2e0eadc839f8ea Reviewed-on: https://code.wireshark.org/review/31245 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31Improve capture-on-pipe error messages.Guy Harris1-7/+26
Add "Please report this to us" and "Please report this to whoever wrote the program that's writing to the pipe" secondary error messages. Use the latter for most of the errors, as the most likely cause is that the program writing to the pipe is messing up somehow. If we don't recoginze the first 4 bytes of the file, say "Data written to the pipe is neither in a supported pcap format nor in pcapng format." - it's not necessarily a pcap file. Speak of "pcap" rather than "libpcap" format - it's not completely tied to libpcap (although two of the libraries not called "libpcap" that read it are basically libpcap+a Windows driver+a library for the Windows driver, at this point), and the suffix generally used it ".pcap". Change-Id: Ifb5518af5cade788294c93a7ac416893f57f6bc8 Reviewed-on: https://code.wireshark.org/review/31273 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31WSDG: Update packet list and popup images and descriptions.Gerald Combs8-104/+331
Update the images and descriptions for the packet list, column header popup, packet list popup, and packet detail popups. Add images and descriptions for the byte view popup. Use title case in more places. Change-Id: Icf3af426c97c6e7cf97dee377c20039b7b8791ce Reviewed-on: https://code.wireshark.org/review/31271 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31asn2wrs.py: use BASE_VAL64_STRING and val64_stringChristophe GUERBER1-5/+24
When UINT64 contains value strings, in addition to using VALS64 to give the list of names, the type of the structure has to be val64_string and the display parameter has to be ORed with BASE_VAL64_STRING. Change-Id: I0a619c91027df1eaae8209ada816f45b85d6431d Reviewed-on: https://code.wireshark.org/review/31268 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31CMake: clean up FindGNUTLS.cmakePeter Wu1-39/+27
Use consistent capitalization and whitespace. Remove library names from find_library that are unsuitable. No functional change intended. Change-Id: Ic40516542777d768b6eef656fe5c0a0af143fb7e Reviewed-on: https://code.wireshark.org/review/31264 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31Windows: Upgrade GnuTLS to 1.6.3Peter Wu3-7/+9
Upgrade to GnuTLS 3.6.3-1, using MinGW binaries from Fedora 29 packages: mingw64-gnutls-3.6.3-1.fc29.noarch.rpm mingw64-gcc-8.2.0-3.fc29.x86_64.rpm mingw64-gmp-6.1.2-4.fc29.noarch.rpm mingw64-nettle-3.4-2.fc29.noarch.rpm mingw64-p11-kit-0.23.7-5.fc29.noarch.rpm mingw64-libffi-3.1-4.fc29.noarch.rpm mingw64-libtasn1-4.13-3.fc29.noarch.rpm mingw64-winpthreads-5.0.4-2.fc29.noarch.rpm This includes libgcc_s_seh-1.dll (64-bit, new) and libgcc_s_sjlj-1.dll (32-bit, previously included with glib2). Built with https://git.lekensteyn.nl/peter/wireshark-notes/tree/windows-libs/make-gnutls-libs-zip.sh?id=b86878e458d5d7deb21218ce6598b98af4ed7ec2 The main motivation is improved PKCS #11 support: - 3.6.0: fix potential compatibility issue with SafeNet HSMs https://gitlab.com/gnutls/gnutls/merge_requests/398/ - 3.6.2: gnutls_pkcs11_token_get_flags now forwards token info. - 3.6.3: new APIs for low-level PKCS #11 token or object operations. Change-Id: I235774e3b27f3426cb74d3d9c0ab593d06870e89 Reviewed-on: https://code.wireshark.org/review/31128 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31SMPP: General improvementsMichael Mann1-913/+841
1. Use proto_tree_add_item (and friends) instead of a protocol specific wrapper for integer types 2. Create #defines for command IDs and properly sort them in the their value_string 3. Improve heuristics for command specific parameters to reduce false positives 4. Use length value in TLV for strings 5. Remove "sub tvb" creation. The tvb passed into the pdu should be used. 6. Use proto_tree_add_bitmask_list and proto_tree_add_bitmask_list_value where applicable 7. Allow empty fields for vendor-specific TLVs. 8. Treat version fields as FT_UINT8 and use format with BASE_CUSTOM 9. Condense all command response codes to a single range_string. Bug: 5206 Bug: 15267 Change-Id: I49751d287af1ebb9e27ae7463c08f4724ee60c07 Reviewed-on: https://code.wireshark.org/review/31267 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31KNET: Validate the length field before claiming packetMichael Mann1-0/+8
Heuristic is weak, but length of packet should be non-zero. Change-Id: I68d6d85092c84d5d421731be3ada008fe7a5b06f Reviewed-on: https://code.wireshark.org/review/31266 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31GSM over IP: Require a valid message type for dissection.Michael Mann1-10/+24
Protects against some false positives because by default GSM over IP claims some "frequently used" ports. Change-Id: I94736ecef8ac1422bb330a364a3f77edd9a52a2b Reviewed-on: https://code.wireshark.org/review/31265 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31Update the comment again.Guy Harris1-6/+12
The third URL works, but let's go https: for it. The other two don't. Line-wrap another part of the comment while we're at it. Change-Id: I744770c859b317ace2a71e82f86e2419b6d7ef2b Reviewed-on: https://code.wireshark.org/review/31276 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-31Update a comment.Guy Harris1-3/+5
(Thanks for killing off a bunch of comment mechanisms, not saving the old comments and placing them somewhere useful, and not even allowing the Wayback Machine to archive at least some of those sites, Microsoft.) Change-Id: Ie4258250a0176a56ee33be77604acf43c6886e0f Reviewed-on: https://code.wireshark.org/review/31274 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-31Use size_t, not int, for sizes.Guy Harris1-60/+89
Change-Id: I421acce006692d6415a3d647b262843d38858cf7 Reviewed-on: https://code.wireshark.org/review/31272 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-30Qt: traffic table: remove a tap listener only onceMartin Kaiser2-6/+0
Class TrafficTableTreeWidget is used by the conversation and enpoint dialogs, both of which are subclasses of WiresharkDialog. Those dialogs use WiresharkDialog::registerTapListener() to register tap listeners. When the dialog is closed, those listeners are removed by WiresharkDialog::removeTapListeners(). TrafficTableTreeWidget's destructor tries to remove its tap listener a 2nd time after WiresharkDialog did its cleanup. This causes warnings Warn remove_tap_listener(): no listener found with that tap data Don't call remove_tap_listener() from TrafficTableTreeWidget's destructor. The destructor is now empty and can be removed completely. Change-Id: I3143fa1c5116203f4a0be791bd4c5f08135aefb0 Reviewed-on: https://code.wireshark.org/review/31259 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-30CMake: clean up FindGCRYPT.cmakePeter Wu1-31/+32
Use consistent lowercase capitalization and whitespace. Windows: clarify libgpg-error names and remove libgcc_s (1.7.6/1.8.3 do not need it). Change-Id: I5d1b1a67f7a992ccfca4c28d0e19bbbfc41b7a4d Reviewed-on: https://code.wireshark.org/review/31244 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-30srt: fix not a Doxygen trailing comment [-Wdocumentation]Alexis La Goutte1-10/+10
Change-Id: I78de1d2fc55ac64542d7d031c33c3b4bc58b10ff Reviewed-on: https://code.wireshark.org/review/31199 Reviewed-by: Maxim Sharabayko <maxim.sharabayko@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-30asn2wrs.py: fix regression introduced by gf4b0b2109Pascal Quantin1-1/+2
FT_(U)INT64 are restricted to integer types only currently. Do not use VALS64() for other types. Change-Id: Id2299a9291c53ef246b90d732eb84811510ccb85 Reviewed-on: https://code.wireshark.org/review/31257 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-30[Automatic update for 2018-12-30]Gerald Combs8-232/+288
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic8eac1cb4b08b5d567ef5bd3a52062eca095458c Reviewed-on: https://code.wireshark.org/review/31254 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-30Revert "Add routines to load Lua programs that assume the path is UTF-8 on ↵Peter Wu2-171/+2
Windows." This reverts commit 5953756305388724545f0df46d286be2f02c048a. The public API should not be polluted with Windows-specific hacks. As we already override dofile/loadfile, those should be fixed instead. Ping-Bug: 15118 Change-Id: Ia9d5e64e8ef14032f982f695ffd4cac59067bb17 Reviewed-on: https://code.wireshark.org/review/31134 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-30Fixes ASN.1 generation for VALS using 64 bitsChristophe GUERBER1-1/+4
VALS generation did not take into account the constraints on integers. We now generate VALS if no constraints are present and VALS64 if the interger needs 64 bits. Change-Id: Ia044ee1ba1bd5b45554c19a458876e20110b1b7f Reviewed-on: https://code.wireshark.org/review/31252 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-30Use cmdarg_err() to report errors in CLI taps.Guy Harris21-37/+68
Change-Id: Ic6b35220e394f8c67848ed067e4bbddb980d5bc0 Reviewed-on: https://code.wireshark.org/review/31253 Reviewed-by: Guy Harris <guy@alum.mit.edu> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot
2018-12-29CMake output: Show Windows paths for the VC redist filesGraham Bloice2-3/+4
Purely cosmetic, show the various VC redist paths using the native format. Change-Id: I96d0b088f703e3e8dea6623ec258139eff066d90 Reviewed-on: https://code.wireshark.org/review/31251 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-29Fix indentation.Guy Harris1-11/+10
Change-Id: I6cc3373d043e6a8203a5f70eb03f03bb6cd8a6d9 Reviewed-on: https://code.wireshark.org/review/31246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-29Add support for RSA decryption using PKCS #11 tokensPeter Wu11-15/+431
Add support for loading RSA private key files from PKCS #11 tokens, identified by PKCS #11 URIs. Add a new 'pkcs11_libs' UAT which can dynamically load PKCS #11 provider libraries that are not found by p11-kit. The configuration GUI will need additional code to discover available PKCS #11 tokens and will be added later. This feature requires GnuTLS 3.4 with PKCS #11 support, so Windows, macOS via Homebrew, Ubuntu 16.04, Debian Stretch. Not supported: RHEL7. Currently macOS via official packages disables PKCS #11 support, so that will also not work. Change-Id: I20646bfd69c6bd13c8c2d27cb65c164a4b0b7a66 Reviewed-on: https://code.wireshark.org/review/30855 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-29Lua: fix crash in reloading Lua plugins that use FileHandlerPeter Wu2-19/+52
Reloading Lua plugins did not actually remove registered FileHandler instances which resulted in a use-after-free of lua_State. Fix this by tracking instances and release them in wslua_deregister_filehandlers. Other required fixes to allow reregistration after reloading: - Fix END_FILEHANDLER_ROUTINE not to block all new registrations. - wtap file subtypes are apparently persistent, even after "unregistering". Fix this by looking up the previous subtype that matches the FileHandler short name. Add a small sanity check to wtap_register_file_type_subtypes to prevent internal handlers from being overwritten. This patch creates a potential memleak of registered_file_handlers as wslua_deregister_filehandlers is not called on program exit (yet?). Bug: 13264 Change-Id: I4f5935cde6ff8dc4de333359bad3efca96d4fb9b Reviewed-on: https://code.wireshark.org/review/31068 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-29Add jsonraw to tshark's -T man page synopsisJim Young1-1/+1
Change-Id: Icf3dacb143b19a55788a30dac297787ab3d2c3f0 Reviewed-on: https://code.wireshark.org/review/31242 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29docsis: enhancements and additions for DOCSIS TLVs 5.20 and 5.40Andrii Vladyka1-4/+7
Change-Id: If819d1f7e75b458d5fc28e23b28fa260637491fb Reviewed-on: https://code.wireshark.org/review/31240 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29test: add tests for Unicode paths in Lua and tshark -G foldersPeter Wu4-1/+119
Check for potential Unicode-related problems on Windows. Change-Id: I147c07749c5073a9ae00f07914dd80347d17c40f Ping-Bug: 15118 Reviewed-on: https://code.wireshark.org/review/31154 Tested-by: Petri Dish Buildbot Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29Windows: fix handling of Unicode paths in LuaPeter Wu3-7/+14
Lua internally uses ANSI C APIs (such as fopen). On many systems (macOS and Linux for example) these work fine with UTF-8. Windows however requires special Unicode APIs (such as _wfopen), so patch the Lua library to interpret paths are UTF-8 and call appropriate Unicode APIs. Changes compared to the previous LuaBinaries zip archive: - Patched with UTF-8 support for loadfile, os.execute, etc. - Built with VS 2015 (VCRUNTIME140.dll) instead of MinGW (MSVCRT.dll). - Includes PDB file for lua52.dll - Includes lua52.exe and luac52.exe with UTF-8 argv support (wmain). - Includes build scripts, source files and README.md. - Extra subdirectory named after the zip file. These zip files are taken from https://github.com/Lekensteyn/lua-unicode (the "prepared" source zips can be found here as well.) Bug: 15118 Change-Id: I219f046d6e0fd5093287b5d6503a48ba7d1fc6a4 Reviewed-on: https://code.wireshark.org/review/31165 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29Fix typo: aplications to applicationsJim Young2-2/+2
Change-Id: I14948f563a7638b5bd28f4450ffe1bd98a491e6a Reviewed-on: https://code.wireshark.org/review/31243 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29Add interface name when outputting packets dropped.Michael Mann5-18/+34
Add interface name (colon delimited) to SP_DROPS ('D') message so when dropped packets are outputted, they include the interface name for clarity. Bug: 13498 Change-Id: I68cdde4f20a574580f089dc5096d815cde5d3357 Reviewed-on: https://code.wireshark.org/review/31218 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29Small cleanups.Guy Harris1-3/+4
Get rid of an extra blank line in a comment. Change another comment to refer to "error packets", as we do elsewhere. Fix indentation. Change-Id: I4d81b8856ea876f20914352f962b1df0e115404c Reviewed-on: https://code.wireshark.org/review/31241 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-28Fixed ASTERIX 6bit callsign decodingAtli Guðmundsson1-10/+11
The callsign was being truncated to 7 letters. This affects the following fields: - I004/100#01.AN - I004/170#08.MS1 - I004/170#08.MS2 - I025/020.SD - asterix.AI, which is included in: -- I021/170 -- I048/240 -- I062/245 -- I062/380#02 -- I062/380#03_v0_17 Change-Id: Idbbb3891d96e906053fc1f0c447e37bae87d207a Reviewed-on: https://code.wireshark.org/review/31230 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-28Correct PsId dissection in WSMPChristophe GUERBER1-19/+27
Get rid of length determinant in the value returned for psid. Length determinant is not part of the value. This helps comparison with other protocols possibly containing a psid also. Change-Id: I2bd93bd6849f8bfa686f0574f05b0a65f587e4ad Reviewed-on: https://code.wireshark.org/review/31235 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-28DNS: Use seconds as resolution for stat response time.Michael Mann1-3/+3
This keeps it in the same resolution as the dns.time field. Ping-Bug: 15382 Change-Id: Ibacf8761819c0fac2e87fa147f7381336ce5cb39 Reviewed-on: https://code.wireshark.org/review/31223 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-28Allow floating point values for stats_treeMichael Mann22-193/+401
Bug: 4234 Change-Id: Ibd59809b2dd9890a7851eb57ef7af384e280a74b Reviewed-on: https://code.wireshark.org/review/31222 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-28GTPv2: fix dissection of APN IEPascal Quantin1-35/+29
The total maximum length of the APN with Network Identifier and Operator Identifier is 100 bytes. Bug: 15383 Change-Id: Ib74eac1f18f2235c2788e58370f50eeb9a678357 Reviewed-on: https://code.wireshark.org/review/31225 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-28NAS EPS: upgrade dissector to v15.5.0Pascal Quantin1-4/+18
Change-Id: I3464365a821e92f02e601304552823d24cf11c35 Reviewed-on: https://code.wireshark.org/review/31227 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-283GPP NAS: upgrade dissector to v15.5.0Pascal Quantin3-5/+57
Change-Id: I8cd60558ef6fb80d916f30aa79028cd87542d956 Reviewed-on: https://code.wireshark.org/review/31226 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-28Z39.50: Implementation of Z39.50 Information Retrieval protocolCraig Jackson13-2/+17552
NISO Z39.50 is a protocol used by libraries and library vendors for information retrieval and catalog manipulation. It is defined using ASN.1 using BER encoding. It has an assigned TCP port of 210. This is an initial implementation. Features: - The Z39.50 standard OIDs are defined. - The bib-1 attribute set is decoded. - The bib-1 diagnostics are decoded. - Some OCTET STRINGs which are nearly always printable ASCII are special-cased. - The MARC (MAchine Readable Cataloging) format is decoded. Only the MARC21 variant is currently handled, but this is one of the most common variants. The most common tags are decoded. The MARC dissector is included in the Z39.50 dissector, but the code is structured in such away that it could be pulled out. Todo: - Add information to the Wiki about Z39.50. As part of this work, the definition of isdigit_string() was fixed to avoid const complaints. Change-Id: I29a7db53375ef8be83738a1ab98707761d878717 Reviewed-on: https://code.wireshark.org/review/31209 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-27test: fix import in suite_dissectors/group_asterix.Dario Lombardo1-1/+1
Change-Id: I88a97168f318c4d900dadf8443e4068c60ba342f Reviewed-on: https://code.wireshark.org/review/31212 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-27Qt: Show Python scripts as links in the about box.Stig Bjørlykke2-10/+4
Extcap utilities can be Python scripts. Show the files as URLs and allow double click to open. Change-Id: I214caa2683896b89fbe6243562eee9b12d4ae217 Reviewed-on: https://code.wireshark.org/review/31221 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-27DNS: Use microsecond resolution for request/response statistics.Michael Mann1-2/+3
The stat tree API only supports 32-bit integers and if nanosecond resolution is used correctly it's easy to hit integer overflow issues on even a fairly small capture file trying to sum up response times. Bug: 15382 Change-Id: I15d2cfbdbec7b0bef2bcfe1afe4f6eb6fc1d2456 Reviewed-on: https://code.wireshark.org/review/31217 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-27ebhscr: fixing WTAP_ENCAP_EBHSCRPantar Ana3-1/+8
Change-Id: Ie5ab56f1ee80d14032969cbe7f31e086fb2b4b91 Reviewed-on: https://code.wireshark.org/review/31159 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-27json_dumper: add json_dumper_value_va_list().Dario Lombardo3-4/+20
Change-Id: I8effb701b505e5ce0c06be42ab524c458e1839ce Reviewed-on: https://code.wireshark.org/review/31207 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 00:54:40 +0000