aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26HTTPS (almost) everywhere.Guy Harris1842-1851/+1851
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26Initialize newly-allocated iap_conversation_t before fetching packet data.Guy Harris1-4/+6
If we do it after trying to fetch packet data, the attempt to fetch might throw an exception, and the structure won't be fully initialized. Bug: 15934 Change-Id: If50a8c18232d934c1e33512cddb40a011a4eaef7 Reviewed-on: https://code.wireshark.org/review/34087 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26Debian: remove symbolsPascal Quantin1-7/+0
Those functions are defined as inline in proto.h and are not exported functions. The change g76e227bcef had an impact on this check and now they are flagged as missing. Let's remove them. Bug: 15944 Change-Id: I58a0bd41283ce20aa7441ca08173e3d8d469a0ec Reviewed-on: https://code.wireshark.org/review/34088 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot
2019-07-253.1.0 > 3.1.1.Gerald Combs5-1397/+11
Change-Id: Idc7ab6cfe38cffa4053d0d8ce710cb95b33aa6ac Reviewed-on: https://code.wireshark.org/review/34084 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-25Build 3.1.0.Gerald Combs3-2837/+1442
Change-Id: Iced73e36e00018ace596b671959bc087b3541765 Reviewed-on: https://code.wireshark.org/review/34082 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-25debian-setup.sh: Add package lsb-releaseJuergen Kosel1-1/+2
The package lsb-release is a build requirement. Especially needed to build wireshark in a docker container based on debian:stable. This change is a prerequisite for the change discussed in https://code.wireshark.org/review/#/c/34042 Change-Id: Ib8ec73c8bffcb8761ad5748882aa9418e8cd7948 Signed-off-by: Juergen Kosel <juergen.kosel@gmx.de> Reviewed-on: https://code.wireshark.org/review/34071 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-25Qt: fix compilation with older Qt versions.Dario Lombardo1-2/+2
../ui/qt/widgets/copy_from_profile_menu.cpp:52:30: error: no matching function for call to 'QAction::QAction(QString&)' pa = new QAction(name); ^ ../ui/qt/widgets/copy_from_profile_menu.cpp:52:30: note: candidates are: In file included from /usr/include/qt5/QtWidgets/qmenu.h:40:0, from /usr/include/qt5/QtWidgets/QMenu:1, from ../ui/qt/widgets/copy_from_profile_menu.h:16, from ../ui/qt/widgets/copy_from_profile_menu.cpp:10: /usr/include/qt5/QtWidgets/qaction.h:174:5: note: QAction::QAction(QActionPrivate&, QObject*) QAction(QActionPrivate &dd, QObject *parent); Change-Id: Ib7cb7cf522f1a95d5f4c16b1dc8f2ada8e46793c Reviewed-on: https://code.wireshark.org/review/34081 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-25Qt: Export profilesRoland Knall7-7/+272
Allow for the export of profiles. The currently selected profile may be selected, as well as all user-defined profiles Fixes: Bug, where invalid data has been written into the profiles not present inside the original file Change-Id: I7c6310920a1f3a064cfcedc7774b742ff01c9b9e Reviewed-on: https://code.wireshark.org/review/34077 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-25Don't format printable non-ASCII Unicode characters as escape sequences.Guy Harris2-155/+590
Note that even strings fetched with ENC_ASCII may contain them - bytes with the 8th bit set get mapped to REPLACEMENT CHARACTER. This means we can format STR_UNICODE fields with format_text(); do so. Bug: 1372 Change-Id: Ia32c3a92d220ac5174ecd25f33e2d1f85cfb8cb8 Reviewed-on: https://code.wireshark.org/review/34080 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-25USBLL: Verify DATA packets CRC-16Tomasz Moń7-1/+93
Ping-Bug: 15908 Change-Id: Idda280545665184aca40c694ea6d639c9317307a Reviewed-on: https://code.wireshark.org/review/34016 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-25USBLL: Initial USB 2.0 Link Layer dissectorTomasz Moń5-0/+364
Dissect raw USB Packets. The actual USB packets to transaction conversion (which is needed to pass the data to existing USB URB dissector) is not implemented yet. Ping-Bug: 15908 Change-Id: Ia75d58882d770fdd8650622d318241743069ad8f Reviewed-on: https://code.wireshark.org/review/34006 Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-25Qt: Fix copy indicator for profileRoland Knall1-1/+1
If a profile has been created as a copy from a user profile, and a global profile exists with the same name as the parent user profile, deleting the parent user profile mistakenly indicates, that the copy has been cerated with the parent global profile not the then deleted user profile Change-Id: I4d4c91de64b623a8553a3c51ad449988dfe8eec5 Reviewed-on: https://code.wireshark.org/review/34079 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-25Qt: Various Profile UI UpdatesRoland Knall4-73/+60
Correct the text for delete and copy profiles, which better display if they have been copied from a system-profile or if the original entry has been deleted Move Import button into the button box, as this seems to be the consensus with applications and gives the info label more room Tooltips now behave the same way as they did before the refactoring and copying from a new element creates the correct names Only one element could be deleted any given time, if the default element was to be resetted Change-Id: Ieb902b68627cb9bda5d2483b39de6479ff8d4533 Reviewed-on: https://code.wireshark.org/review/34070 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-24Update the release notes for 3.1.0.Gerald Combs1-9/+33
Change-Id: I85b2a8088e1968bd8e2fb707fe269e11fb2e0c90 Reviewed-on: https://code.wireshark.org/review/34078 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-24Use tvb_get_raw_bytes_as_string() to fetch the verb and reply code.Guy Harris1-3/+3
Change-Id: I615feb257274fdc44b8791078c0da512a4a7bd88 Reviewed-on: https://code.wireshark.org/review/34076 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Qt: Profile Treeview updates now after importing profilesRoland Knall2-11/+35
The Treeview was not updated after a successful import. Change-Id: I66d1873f75f1fca1ad1212130deb463a44253083 Reviewed-on: https://code.wireshark.org/review/34059 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-24Use g_ascii_isalpha(), not is_rfc2234_alpha().Guy Harris1-22/+3
Use GLib's locale-independent "is this alphabetic?" routine, rather than rolling our own. Change-Id: I841de09d534867ec7510bd680fd97387719b2850 Reviewed-on: https://code.wireshark.org/review/34075 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Use tvb_get_raw_bytes_as_string() to fetch the reply code.Guy Harris1-1/+1
Change-Id: Ida31fd962a6c2c792f19ac438697948c155e3f45 Reviewed-on: https://code.wireshark.org/review/34074 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Handle multiple PDUs per TCP segment and reassembly of multi-segment PDUs.Guy Harris1-114/+167
Use tcp_dissect_pdus(). Put the packet length and packet type into the protocol tree as items. Pass to routines dissecting various packet types an offset to the data past the packet type indication. While we're at it: Clear the Info column, so it doesn't contain TCP-level stuff. Use the new tvb_get_raw_bytes_as_string() to get the first 4 bytes of the payload as a string. Fix the capitalization of some field names. Change-Id: I3d5b8f4b4115d7b3675fbebc68a5e67976aba27b Reviewed-on: https://code.wireshark.org/review/34073 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Add a routine to fetch raw bytes into a fixed-length buffer as a string.Guy Harris3-0/+41
That's what the remaining calls to tvb_get_nstringz() and tvb_get_nstringz0() are being used to do, even though those routines were not intended for that purpose - the calls are extracting from a text protcool, meaning that the strings are *not* null-terminate in the packet. Strings - even null-terminated ones - should, in almost all cases, be extracted by tvb_get_string_enc() or routines that call it, so that an encoding is specified. In the few cases where we're fetching strings only to be compared to ASCII constants, or to parse as numbers, we can get away with this. Change-Id: I29f0532902c4ade2207de7f06db69c32eafd4132 Reviewed-on: https://code.wireshark.org/review/34072 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Clean up handling of group lists.Guy Harris1-26/+18
Use a wmem_strbuf_t for the group list, so it expands as necessary, rather than a static string buffer. Pass it to dissect_group() through dissect_rpc_list(). For each group, get the group name from the call to dissect_rpc_string(), and append it to the wmem_strbuf_t. Change-Id: I65b36a9b6d34dd1e88babd005fc60ab46331b382 Reviewed-on: https://code.wireshark.org/review/34069 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Remove an extra backslash.Guy Harris1-1/+1
The only backslashes in invalid_dir_chars on Windows should be the one escaping " and the one escaping \ itself; there's no need for one to escape | and, in fact, MSVC warns about that. Change-Id: I7622f5123df7da3049352dc0e86322b11f8c4150 Reviewed-on: https://code.wireshark.org/review/34068 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24debian/control: sync downstream wireshark-gtk changesPeter Wu1-8/+9
Add package relations to the deprecated wireshark-gtk package. The transitional package added by "Stop shipping Wireshark's GTK+ GUI" has not been incorporated however. The Standards-Version version bump done in 2.0.5+ga3be9c6-1 (2 Aug 2016) required no changes. Note that both Debian Stretch and Ubuntu 16.04 have debian-policy 3.9.8. Change-Id: Idb6f106ea03d47bcf87ba60f5470754e9ae4369e Reviewed-on: https://code.wireshark.org/review/34047 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24debian: libwireshark-dev must depend on libwiretap-devGregor Jasny1-1/+2
because wireshark/epan/packet_info.h (libwireshark-dev) depends on wireshark/wiretap/wtap.h (libwiretap-dev) Change-Id: I76eb17c2c0502f4ea53c6ce934aeaea5ff5cfdd9 Reviewed-on: https://code.wireshark.org/review/34046 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24debian: Add autopkgtest for testing starting GUI and CLIBalint Reczey4-0/+39
Incorporates debian/tests/ changes up to upstream/3.0.0-76-ge634555b61: * Add autopkgtest for testing starting GUI * Add missing autopkgtest dependencies * Use automatic xvfb server number in tests * Use GLX extension in autopkgtest, Qt needs it * Install at-spi2-core in gui autopkgtest to avoid error messages * debian/test/gui: Ignore stderr from wireshark-gtk since upstream deprecated it * debian/tests/gui: Redirect stderr to stdout because Lua prints to stderr * Stop shipping Wireshark's GTK+ GUI Change-Id: I840fa17fb5ac2bc7b4fed36c4286ea97742f7369 Reviewed-on: https://code.wireshark.org/review/28519 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24debian: Fix permission change in case of local diversionsTopi Miettinen1-1/+1
/usr/bin/dumpcap may be locally diverted to somewhere else, so let's query dpkg-divert for the current location. Change-Id: I4347d390b2c1e94383308d274b113a23bec62f5b Reviewed-on: https://code.wireshark.org/review/34040 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24f5ethtrailer: type-version subdissector tableJason Cohen1-26/+12
Add a subdissector table to the noise provider. This allows for extendability via a plugin to support new versions or message types of trailer noise. The original f5ethtrailer was distrubuted as a plugin. Since including it as part of libwireshark it has been impossible to add support for changes in the data this dissector decodes once Wireshark is released without patching and compiling on your own (or possibly building a git dev branch). This provides a mechanisim to add additional support to the dissector via plugin without needing to rebuild Wireshark. Change-Id: I1912ab497e0cfd34dcd92a893b819333665e23cd Reviewed-on: https://code.wireshark.org/review/34063 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24f5ethtrailer - Collapsible-Header trailer headerJason Cohen1-41/+66
Brings some less needed info from the trailer header into a tree collapsible tree. This save several lines in the packet decode tree. Bug: 15880 Change-Id: I7a3330a0a870e1e10f115e26ad7923b46de41f2e Reviewed-on: https://code.wireshark.org/review/34060 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24Suqlech a -Wpointer-sign warning.Guy Harris1-1/+1
Change-Id: I193ff3b2faf37930128bdc02b4da36e32e306b4a Reviewed-on: https://code.wireshark.org/review/34067 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Insert REPLACEMENT CHARACTER for various UTF-16 errors.Guy Harris1-20/+19
Change-Id: I2f62a409548b2c743864ca8da5733f7a73872b3c Reviewed-on: https://code.wireshark.org/review/34066 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24E1AP: upgrade dissector to v15.4.0Pascal Quantin9-130/+511
Change-Id: Ic9a19804b5e46ca63f3d1256e13173a92fc39f9b Reviewed-on: https://code.wireshark.org/review/34065 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-24Windows+CMake: Updates for Visual Studio 2019.Gerald Combs2-2/+7
Update our redistributable search logic for VS 2019. Change-Id: Icccc550bbe062a91206d4ffddeef7bbfbdb8829b Reviewed-on: https://code.wireshark.org/review/34064 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-23WSUG: Corrected keyboard shortcuts for Edit MenuMoshe Kaplan1-10/+10
Change-Id: Id65a56c179bdcf60772239f0f371efa4b79a652b Reviewed-on: https://code.wireshark.org/review/34062 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-22iso7816: link a transaction to a payload dissectorMartin Kaiser1-7/+14
When an iso7816 request is forwarded to a payload dissector, store its handle in the transaction info. Call the new helper function to get the selected payload dissector's handle. Use the stored dissector handle to pass the response to the same payload dissector that handled the request. Change-Id: Idc6f7fbee978c095719aea937ab3179eac17f2a7 Reviewed-on: https://code.wireshark.org/review/33934 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-22Qt: Stop profile import when action pendingRoland Knall3-0/+29
When a reset/delete/add/rename action is pending, profiles cannot be imported. Change-Id: I4521b8a265ec4346b7028bc5a7173fd531be24c2 Reviewed-on: https://code.wireshark.org/review/34057 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-22Qt: Fix invalid characters for profilesRoland Knall1-1/+3
Change-Id: Ic44f075b2723e2d5d95e29b485791e89134315e8 Reviewed-on: https://code.wireshark.org/review/34056 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-22Qt: Fix filename checkRoland Knall1-2/+8
On *nix only check for the separator, on Windows for all invalid characters as defined in https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file Change-Id: I5842ca9f0926cc9d6ce9b839be226051497cf647 Reviewed-on: https://code.wireshark.org/review/34055 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-22Qt: Cleanup data() method and interfaceRoland Knall5-148/+189
Interface resembles the old interface Change-Id: I7301f8bb6e00d30c20d7e5fdc9252a6a1765ff97 Reviewed-on: https://code.wireshark.org/review/34054 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-22wslua: pinfo: make p2p_dir accessible to lua dissectorsMartin Kaiser3-0/+11
Some dissectors populate pinfo->p2p_dir with a packet's direction (incoming / outgoing). Make this info available to lua dissectors. Add a simple test for Pinfo's new p2p_dir attribute to the wslua test suite. It checks that p2p_dir is unknown for dhcp packets. (The dhcp dissector does not set p2p_dir). Change-Id: I8cc39a11cff840d10ef7fa94d30cbac8bf9b533f Reviewed-on: https://code.wireshark.org/review/33935 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-22helper function to get a payload dissector table's current handleMartin Kaiser3-0/+16
Add a simple helper function to get the dissector handle that's currently selected in a given payload dissector table. We have similar functions already for string and uint dissector tables. Change-Id: Ia1092fe2b8d038bae2b26db99fd08cd9d6979fcd Reviewed-on: https://code.wireshark.org/review/33933 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-21Extend epan library plugins with a tap registration callbackJoão Valverde2-0/+11
tap_register_plugin() is not sufficient for an extension language implementation because the epan plugin is initialized before proto_init(), therefore before dissectors have registered taps. Change-Id: Ief213f85ff4f7182f9af985e5f45476355cc2b86 Reviewed-on: https://code.wireshark.org/review/34048 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-07-21Qt: Remove unwanted TABsStig Bjørlykke1-2/+2
Change-Id: Ia7ae4fb47dc0695fb5dadee2926516c38894c0e0 Reviewed-on: https://code.wireshark.org/review/34052 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-07-21Qt: Improve profile import messagesStig Bjørlykke3-20/+41
Only show the message "No profiles found for import" when no profiles actually found, not when found but all are skipped. Add correct numerus translation for imported and skipped counts. Change-Id: I0425aafb09fc4722cc765ae4f20ce8248b767c44 Reviewed-on: https://code.wireshark.org/review/34050 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21Qt: Fix deletionRoland Knall1-7/+9
- If a profile, based on a system default, is being deleted the selected profile should switch back to the default - The default profile is not a system profile Change-Id: I267a0e14b9f974fdabe5a9b21187ad0673265b01 Reviewed-on: https://code.wireshark.org/review/34051 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21Lua: remove lua_data_handlePeter Wu3-7/+2
Use call_data_dissector directly for the same effect as lua_data_handle. Remove the special case where DissectorTable.get_dissector() returns the data dissector for an unsupported type. The documentation says that nil is returned if the handle is not found, that seems more appropriate. Change-Id: I128ef90b79bda925a4329202a0b9956e1cf16200 Reviewed-on: https://code.wireshark.org/review/34032 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-21Qt: Fix copy-from menuRoland Knall3-16/+46
It stopped working after moving to the ProfileModel Change-Id: I20d095ece8ce842e9ded4489fd8e062b35ffc968 Reviewed-on: https://code.wireshark.org/review/34030 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21Qt: Allow profile import from directoryRoland Knall6-57/+116
To allow for easy import of profiles, one can select a directory to import profiles from Change-Id: I12f66e3dc6bd272d34baa76093152dce412b0158 Reviewed-on: https://code.wireshark.org/review/34038 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21Remove ABI compliance checker code.João Valverde10-231/+3
It's broken, unmaintained, poorly implemented and obsoleted by saner debug-info methods. Note: To do the compliance check properly would require much more extensive work to clearly define public and private interfaces (without manual bookeeping of files or symbols either, of course, because who would want that...). Change-Id: Ib801f3c152ca2369f95ca1f4af4d37cd8cc7c47a Reviewed-on: https://code.wireshark.org/review/33928 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt>
2019-07-21Qt: Fix iconsize of info labelRoland Knall1-0/+1
Fix the icon size of the info label Change-Id: I46a156f567602f0e2da5a8697b798aa6b238483f Reviewed-on: https://code.wireshark.org/review/34041 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21IEEE80211: handle symbol proprietary tag seperatelyJaap Keuter5-7/+105
The contents of the Symbol Proprietary TLV was assumbed to be the same as the Vendor Specific TLV. This proved not to be the case, at least for Zebra Extreme networks nodes. This change implements the dissection of the format as defined in the bug. Bug: 15909 Change-Id: I4c14dde386d33302d187680f9f09f8b5bb1ef213 Reviewed-on: https://code.wireshark.org/review/34023 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>