aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2002-02-28Handle NBSS messages where the NBSS *header* is split across TCP segmentGuy Harris1-16/+50
boundaries. svn path=/trunk/; revision=4831
2002-02-28In follow.c, initialize data_out_file to NULL, as it used toGilbert Ramirez3-6/+5
be initialized in gtk/follow_dlg.c In gtk/follow_dlg.c, declare data_out_file as 'extern'. In tethereal.c, no longer define 'data_out_file', as the storage for it is now in follow.c. svn path=/trunk/; revision=4830
2002-02-28Declare osinl_subdissector_table as 'extern'.Gilbert Ramirez1-2/+2
svn path=/trunk/; revision=4829
2002-02-27Fix the declaration of "addr_call_dissector" to match the functionGuy Harris1-2/+2
signature of "call_dissector()". svn path=/trunk/; revision=4828
2002-02-27Remove unused variables, structure definitions, and functions.Gilbert Ramirez2-65/+23
From Joerg Mayer. svn path=/trunk/; revision=4827
2002-02-27Support for IEEE 802.1w RST BPDUs, from Alex Ruzin.Guy Harris3-8/+62
svn path=/trunk/; revision=4825
2002-02-27From Joerg Mayer:Guy Harris16-29/+84
In the "configure.in" files, add -D_U_="__attribute__((unused))" to CFLAGS if we're using GCC, and add -D_U_="" otherwise, so _U_ can be used to mark arguments as unused. Add -D_U_="" arguments to the Makefile.nmake files as well, so _U_ works with Microsoft Visual C++ as well. Add comments and RCS IDs to the Makefile.nmake files that don't already have them. svn path=/trunk/; revision=4824
2002-02-27From Joerg Mayer: remove unused variables and declarations ofGuy Harris19-57/+40
non-existent functions. Remove the "filetype" argument from the "can_write_encap" functions for particular capture file types - the argument value is implicit, in that the routine being called is the routine for that particular file type. svn path=/trunk/; revision=4823
2002-02-27Label the data source for various forms of reassembled data with theGuy Harris5-10/+10
protocol that fragmented them, rather than just calling them "Reassembled". Do the same with uncompressed WCP data. svn path=/trunk/; revision=4822
2002-02-27Display a different message in the COL_INFO field for anonymous sessionTim Potter1-3/+9
setup packets. svn path=/trunk/; revision=4818
2002-02-27From John Mackenzie: register GIOP dissector as a UDP heuristicGuy Harris2-1/+4
dissector. svn path=/trunk/; revision=4817
2002-02-27Fix "create_dissector_handle()" to properly create a handle for anGuy Harris1-2/+3
old-style dissector. svn path=/trunk/; revision=4816
2002-02-26From Kari Tiirikainen: use the SNMP library, if present, to print theGuy Harris1-50/+189
textual names of the PIB OIDs. svn path=/trunk/; revision=4814
2002-02-26Properly (for English) pluralize names beginning with "s".Guy Harris1-5/+30
svn path=/trunk/; revision=4813
2002-02-26From Ronnie Sahlberg: add "alias name" and "group name" fields for aliasGuy Harris1-3/+13
and group names, and use them instead of the numeric "alias" and "group" fields when putting the names into the protocol tree. svn path=/trunk/; revision=4812
2002-02-26Allow dissectors to be registered as "old-style" or "new-style"Guy Harris4-83/+286
dissectors. "Old-style" dissectors return nothing. "New-style" dissectors return one of: a positive integer, giving the number of bytes worth of data in the tvbuff that it considered to be part of the PDU in the tvbuff; zero, if it didn't consider the data in the tvbuff to be a PDU for its protocol; a negative integer, giving the number of additional bytes worth of data in needs to get the complete PDU (for use with fragmentation/segmentation when the length of the PDU isn't known to the protocol atop the one the dissector is dissecting). Have "call_dissector()" return the return value of new-style dissectors, and the length of the tvbuff handed to it for old-style dissectors. Have "dissector_try_port()" return FALSE if the subdissector is a new-style dissector and returned 0. Make the EAP dissector a new-style dissector, and have a "EAP fragment" dissector that is also a new-style dissector and handles fragmentation of EAP messages (as happens above, for example, RADIUS). Also, clean up some signed vs. unsigned comparison problems. Reassemble EAP-Message AVPs in RADIUS. svn path=/trunk/; revision=4811
2002-02-26From Michael Tuexen: support for another message type.Guy Harris1-1/+4
svn path=/trunk/; revision=4810
2002-02-26Just put a full EAP tree under the EAP-message TLV; we will eventuallyGuy Harris2-58/+46
use that tree to stick fragment information when we reassemble EAP-message fragments. Fix up some "tvb_new_subset()" calls to set the actual length to the minimum of the data left in the tvbuff and the length of the subset. svn path=/trunk/; revision=4809
2002-02-25Don't give the raw data for SSL-encapsulated stuff in an EAP message itsGuy Harris1-4/+2
own protocol tree item; instead, use the SSL protocol tree for that, and put it under the EAP tree. (I infer from mail from Adam Sulmicki that this is a change he had but couldn't generate and submit due to CVS problems.) svn path=/trunk/; revision=4808
2002-02-25Editorial corrections, from Michael Tuexen.Guy Harris1-10/+26
svn path=/trunk/; revision=4807
2002-02-25Add an EAP dissector that doesn't create a top-level tree and doesn'tGuy Harris4-50/+137
set the columns, for use with EAP payloads inside RADIUS packets. From Adam Sulmicki: dissect SSL-encoded stuff inside EAP. svn path=/trunk/; revision=4806
2002-02-25Mark the columns non-writable before calling the EAP dissector, so theGuy Harris1-1/+14
frame is still marked as a RADIUS packet. svn path=/trunk/; revision=4805
2002-02-25Small fix from Adam Sulmicki to an off-by-2 problem.Guy Harris1-2/+2
svn path=/trunk/; revision=4804
2002-02-25Note that we could save some overhead if we require the name argument toGuy Harris1-1/+6
"add_new_data_source()" to be a string constant (or some other static data item). svn path=/trunk/; revision=4803
2002-02-25Get rid of a bunch of initializations of variables that aren'tGuy Harris1-24/+23
necessary; most of them also provoke compiler warning with some compilers, as they assign -1 to unsigned variables. Also use "guint8" instead of "unsigned char" for 8-bit unsigned integer variables. Get rid of one "tvb_get_letohl()"/"proto_tree_add_uint_format()" combination in favor of "proto_tree_add_item()". svn path=/trunk/; revision=4802
2002-02-25Typo fix, from Adam Sulmicki.Guy Harris1-2/+2
svn path=/trunk/; revision=4801
2002-02-24Put all the capture options into a structure.Guy Harris6-187/+227
Move the ringbuffer capture options from the "capture_file" structure to the structure for capture options, as they're a property of an in-progress capture, not a property of a particular capture file. svn path=/trunk/; revision=4799
2002-02-24Don't copy the entire EAP header, just extract stuff from it a field atGuy Harris1-25/+27
a time, so we dissect as far as we can. Set the length of the EAP protocol item to the length of an EAP header. Put information into the Info column about the EAP code and, for a request or response, the EAP type. svn path=/trunk/; revision=4798
2002-02-24Get rid of "init_all_protocols()"; instead, have a routineGuy Harris4-56/+29
"init_dissection()" which calls "epan_conversation_init()", does the work that "init_all_protocols()" did, and then calls "reassemble_init()", so that the standard sequence of dissection initialization is done in one place, rather than having multiple places call the same sequence of routines. svn path=/trunk/; revision=4797
2002-02-24Have "get_positive_int()" really check for positive integers, not justGuy Harris3-46/+17
non-negative integers. Get rid of unused "get_positive_int()" routine in "gtk/capture_dlg.c". svn path=/trunk/; revision=4796
2002-02-24"autostop_filesize" and "autostop_duration" don't need to be in theGuy Harris6-73/+123
"capture_file" structure - they're a property of an in-progress capture, not a property of an open capture file. Make them just variables. The maximum number of packets to be captured should be a variable separate from the "count" field in the "capture_file" structure - the latter is a count of the packets in the capture file in question. Have Boolean variables indicating whether a maximum packet count, maximum capture file size, and maximum capture duration were specified. If an option isn't set, and we're doing an "update list of packets in real time" capture, don't pass the option to the child process with a command-line argument. Don't create "stop when the capture file reaches this size" or "stop when the capture's run for this long" conditions if a maximum capture file size or a maximum capture duration, respectively, haven't been specified. Don't test or free a condition if it wasn't created. Don't allow a 0 argument to the "-c" flag - the absence of a "-c" flag is the way you specify "no limit on the number of packets". Initialize the check boxes and spin buttons for the "maximum packets to capture", "maximum capture size", and "maximum capture duration" options to the values they had in the last capture. If an option wasn't specified, don't read its value from the dialog box and set the variable. svn path=/trunk/; revision=4795
2002-02-24Free all the stuff pointed to by elements in the "tcp_segment_table"Guy Harris1-10/+16
hash table before freeing the memory chunks for those elements. Destroy that hash table when we're done, and set the pointer to it to null so that we'll reallocate it. svn path=/trunk/; revision=4794
2002-02-24From Peter Valchev: fix editcap to assign the result of "getopt()" to anGuy Harris7-11/+17
"int" and to check "getopt()"s return value with -1 rather than EOF. Fix other "getopt()" loops to check against -1 as well (EOF is -1 on most if not all platforms, but the Single UNIX Specification says "getopt()" returns -1, so we should check against -1, not EOF). svn path=/trunk/; revision=4793
2002-02-23In the Q.931-over-TPKT-over-TCP dissector, if the TCP segment we'reGuy Harris2-27/+37
handed looks as if it contains only a TPKT header (4 bytes long, and those 4 bytes look like a TPKT header according to "is_tpkt()"), call the "dissect TPKT over a TCP stream" routine. If we're doing reassembly, that routine will force a reassembly because the TPKT payload isn't in that segment, and the various heuristic XXX-over-TPKT dissectors will be called again, this time with enough data for them to say whether the TPKT payload is for them or not; if we're not doing reassembly, we'll dissect the TPKT header and then call the "dissect a Q.931 PDU" routine, which will throw an exception because there isn't any payload from which to fetch data (and that's what we want to happen). In the "dissect TPKT over a TCP stream" routine, if reassembly is enabled, do the check to see if we need to do reassembly to get the payload before dissecting the TPKT header, so that we don't dissect the TPKT header and then decide "oops, we need some more data to get the TPKT payload". svn path=/trunk/; revision=4792
2002-02-23"is_tpkt()" is always used to check a TCP segment to see if it mightGuy Harris4-28/+33
have a TPKT header at the beginning, so there's not need for it to have an offset as an argument; its callers don't have to know how big the TPKT header is (or we can put a #define in "packet-tpkt.h" for it). Get rid of the second argument. svn path=/trunk/; revision=4791
2002-02-23From John Mackenzie: put missing initializations of table entries inGuy Harris3-4/+25
"plugins.c". svn path=/trunk/; revision=4790
2002-02-22Dissect the payload of EAPOL Key messages.Guy Harris1-34/+132
Put in a comment noting that the payload of EAPOL Encapsulated ASF Alert messages should perhaps be dissected as SNMP Trap messages. Put the type of the message into the Info column. svn path=/trunk/; revision=4789
2002-02-22Add some necessary "volatile" declarations.Guy Harris3-7/+7
svn path=/trunk/; revision=4788
2002-02-22Get rid of an unnecessary "volatile".Guy Harris2-21/+22
Give the type field a value_string array, and use that field when putting the type into the protocol tree. Display the data under the EAPOL tree, as it's part of the EAPOL PDU. Just use "next_tvb" as the tvbuff for the data; don't create a new one that, the different fourth argument to "tvb_new_subset()" nonwithstanding, refers to the same data as "next_tvb". Call the EAP dissector through a handle. Nobody directly calls the EAP dissector any more, they all call it through handles; make it static. svn path=/trunk/; revision=4787
2002-02-22From Adam Sulmicki: dissect EAP messages inside RADIUS.Guy Harris3-10/+29
svn path=/trunk/; revision=4786
2002-02-22Fixed up value_string for SMBE_unknownlevel error.Tim Potter1-2/+2
svn path=/trunk/; revision=4785
2002-02-22Set "snaplen", not "has_snaplen", to the snapshot length specified inGuy Harris1-6/+6
the capture preferences dialog box. svn path=/trunk/; revision=4783
2002-02-22Catch the ReportedBoundsError exception in the DNS and TPKT dissectorsGuy Harris3-5/+80
when dissecting messages over TCP, so that an error in one message doesn't stop us from dissecting the next message in the segment, if any. Put an XXX comment before the code that constructs the tvbuff for each message inside a TCP segment, noting that we really want tvbuffs to have three lengths and to have a new type of exception thrown if you go past the second length but not past the reported length. svn path=/trunk/; revision=4782
2002-02-22COPS-PR extension support, from Kari Tiirikainen.Guy Harris3-33/+753
Add support for desegmentation of COPS messages and for multiple COPS messages per TCP segment. svn path=/trunk/; revision=4781
2002-02-22From Adam Sulmicki: additional AVPs for RADIUS. and makingGuy Harris2-2/+33
RD_TP_CONNECT_INFO a RADIUS_STRING rather than a RADIUS_STRING_TAGGED. svn path=/trunk/; revision=4780
2002-02-22From Adam Sulmicki <adam[AT]cfar.umd.edu>:Guy Harris3-24/+36
Add more type values for EAP. Fix off-by-one bug when displaying Code of EAP message. Get rid of an unnecessary "volatile". Give the code and type fields value_string arrays, and use them when putting the code and type into the protocol tree. Base the decision of whether to put the type field into the tree on the request code, not on the length of the packet. Display the Type-Data field, under that name, under the EAP tree, as it's part of the EAP PDU. svn path=/trunk/; revision=4779
2002-02-22Handle TPKT packets split across segment boundaries, and multiple TPKTGuy Harris8-110/+200
packets per segment. Instead of having a routine for dissectors such as the Q.931 dissector to call to dissect the TPKT header, have a routine that does all the reassembly and multiple-packets-per-segment work, and have the Q.931 dissector call it. Export "is_tpkt()", and the new routine, to plugins. Add preferences for TPKT and Q.931 reassembly. svn path=/trunk/; revision=4778
2002-02-22Properly set the length of the top-level item.Guy Harris1-6/+12
svn path=/trunk/; revision=4777
2002-02-22Redo the DNS-over-TCP code to handle the DNS-over-TCP header being splitGuy Harris1-32/+59
across segment boundaries and to, for each DNS-over-TCP PDU, create a tvbuff containing the header and the body of the PDU, handing that to the DNS PDU dissector. svn path=/trunk/; revision=4776
2002-02-22From Dermot Bradley:Guy Harris3-9/+719
support for Openwave-specific WSP headers; support for Openwave-specific field names; support for additional content types from Openwave; support for additional language values. svn path=/trunk/; revision=4775