aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-03-05rsvp: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-0/+1
found by gcc7 Change-Id: I6e9d15ef9306433b982d6aff670c38ca8a0b4e85 Reviewed-on: https://code.wireshark.org/review/20410 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05packetbb: fix this statement may fall through ↵Alexis La Goutte1-1/+1
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: Id1fb00f95608e7ad09f9eb48f1d98f5849ae575b Reviewed-on: https://code.wireshark.org/review/20409 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05nstrace: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-5/+5
found by gcc7 Change-Id: I1943798d8dc7449e962856fef6286b9d74be0d34 Reviewed-on: https://code.wireshark.org/review/20407 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05nasdap-itch: fix this statement may fall through ↵Alexis La Goutte1-0/+4
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: I1a0038219271c9346c0c66738b75ab087b78be82 Reviewed-on: https://code.wireshark.org/review/20406 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05erf: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-0/+3
found by gcc7 Change-Id: I377a62a2702b89242a0abfb51f5617f265f698f3 Reviewed-on: https://code.wireshark.org/review/20403 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05gsm_a_bssmap: fix this statement may fall through ↵Alexis La Goutte1-1/+1
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: Ic45f7e7bbeb73e0a222d4837694bb781157ae042 Reviewed-on: https://code.wireshark.org/review/20402 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-3/+3
found by gcc7 Change-Id: I11b943736a4f0835e8432db95b7d471244b08a16 Reviewed-on: https://code.wireshark.org/review/20401 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05bacapp: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-1/+3
found by gcc7 Change-Id: I35174c0a94f4fc36435541b136f4f899e24e6867 Reviewed-on: https://code.wireshark.org/review/20398 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05ieee802154: add modelines infoAlexis La Goutte1-0/+13
Change-Id: Ieaa9b9db97cd1753e3c395f19ae005c4df1bee3a Reviewed-on: https://code.wireshark.org/review/20394 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05ieee80211: fix indent (missing spaces)Alexis La Goutte1-1/+1
Change-Id: Ic10c9aff5058f75d31029f5d4ac7b0ce38dcc8c7 Reviewed-on: https://code.wireshark.org/review/20393 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05[Automatic update for 2017-03-05]Gerald Combs12-3782/+4258
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I074b964d75082adc6ab216514c36abf3d54c6a0a Reviewed-on: https://code.wireshark.org/review/20395 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-03-05lemon: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-1/+1
found by gcc7 Change-Id: If52bc0092f1baa833e35a9f4c107faf72c3b64d1 Reviewed-on: https://code.wireshark.org/review/20392 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05tools: add more entries to valgrind suppression file (libc).Dario Lombardo1-0/+11
Remove leak from dl_init. Change-Id: Iaefc20bd0c71157d604f8f0b2538dc2481fc56db Reviewed-on: https://code.wireshark.org/review/20248 Reviewed-by: Evan Huus <eapache@gmail.com>
2017-03-05tools: add more entries to valgrind suppression file (glib).Dario Lombardo1-3/+51
Remove leaks coming from glib. Change-Id: I05fc6b1143e2d20c953a2c602989cec0cc786f27 Reviewed-on: https://code.wireshark.org/review/20247 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05DOF: ensure to return a value different from 0 when asking for more dataPascal Quantin1-2/+2
Bug: 13453 Change-Id: I331fb5f662f152c9c16b0d8ccbe228cded8ca85d Reviewed-on: https://code.wireshark.org/review/20389 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-03-05DOF: fix an infinite loop in sid_buffer_hash_fn()Pascal Quantin1-1/+1
The sid buffer can contain up to 255 bytes of data, so the loop counter must be a guint16 at least. Bug: 13453 Change-Id: I997ce1a737532d94796586d7e109d89b2dc1911b Reviewed-on: https://code.wireshark.org/review/20388 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-03-05wmem: Ensure callbacks are initialized and not accidentally unregisteredMichael Mann2-7/+4
Start the "callback register ID" at 1, so that zeroed out callback IDs are not found during unregister. Change-Id: I1d7d70f53d89c40e07d1637e1e195dd027855ed3 Reviewed-on: https://code.wireshark.org/review/20385 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2017-03-05Add wmem_tree_destroyMichael Mann2-0/+44
Allows the cleanup of NULL scoped wmem trees Change-Id: I7c49a224ca7e2f7ddfe0e38d3ea0e79aa2cb057c Reviewed-on: https://code.wireshark.org/review/20382 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2017-03-04Add wmem_tree_count.Michael Mann3-0/+30
There are cases where wmem_tree needs to know its number of nodes. Change-Id: I6411cf4275fd4d85a1d76382e1922d236be3b176 Reviewed-on: https://code.wireshark.org/review/20005 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-04packet-hp-erm.c: Add is_tagged flagGene Cumm1-21/+26
Remove the high bit from hp_erm.unknown3 for hp_erm.is_tagged flag. This value was found by observation. Also realign the static value declarations and some other cleanup Change-Id: I8ca701cad0456c1af561fe4238e4686dc9c83c40 Signed-off-by: Gene Cumm <gene.cumm@gmail.com> Reviewed-on: https://code.wireshark.org/review/20288 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-04Logcat-text: use GRegex optimizationsMichal Labedzki1-8/+8
"G_REGEX_OPTIMIZE - Optimize the regular expression. If the pattern will be used many times, then it may be worth the effort to optimize it to improve the speed of matches." - Glib documentation. It is possible to capture a lot of Logcat logs or these log may flooding us. Optimizations are welcome. Change-Id: If753e795efe30b014a5fad11c8ebbcd4da3824a6 Reviewed-on: https://code.wireshark.org/review/20357 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-04RPKI-RTR: Add new error codeAlexis La Goutte1-0/+1
From RFC-ietf-sidr-rpki-rtr-rfc6810-bis-09 Change-Id: Ice24416515448c633eb436f5f08320561c2a6a6a Reviewed-on: https://code.wireshark.org/review/20384 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-04extcap: Minor improvementsRoland Knall3-16/+62
Add method for searching for tools by ifname and minor improvements in the interface callback to save time and space Change-Id: I0073c96fbee846cc5ff6304823fa14564ff36c22 Reviewed-on: https://code.wireshark.org/review/20376 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-04Fix the calculation of the number of levels in the radix tree.Guy Harris1-5/+19
The algorithm being used calculated the number of levels in a 1024-leaf-node tree as being 2, but it's 1 - 0 elements means 0 levels, 1 through 1024 elements means 1 level, 1025 through 1024^2 elements means 2 levels, etc.. With a count of 1024, the loop would bump the level count from 0 to 1, and divide the element count by 1024, yielding 1, so the loop would not terminate, and the level count would them go from 1 to 2 and the element count would go to 0. This could cause problems if exactly 1024 packets were seen. Just use an if chain, similar to the one used when adding elements to the tree. Bug: 13433 Change-Id: I3eaeaf374bb65b37b38a59e95f77cac6690614ed Reviewed-on: https://code.wireshark.org/review/20379 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-03-04Bluetooth: HCI: A few minor improvementsMichal Labedzki2-8/+5
1. According to ESR05 there is no event called "Bluetooth Logo Testing". 2. According to ESR09 error code 0x23 is also "LL Procedure Collision" 3. Add some HCI status for event for HCI Summary bthci_evt is now up-to-date with Bluetooth Core 4 + CSA4 + CSS6 and ERS09 - nothing to implementing... Change-Id: Ief9e2de61be91942ab2211de6bc44a8f15d12426 Reviewed-on: https://code.wireshark.org/review/20355 Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-04Qt: Apply selected bookmark display filterStig Bjørlykke3-4/+12
When selecting a display filter from the bookmark list this filter should be applied, because that's the most common action for a user. Holding down the the Alt key will only prepare the filter. Change-Id: I567ee8a2a70a3de07fea33fa5763d9efba591de3 Reviewed-on: https://code.wireshark.org/review/20317 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-04pluginIF: Allow en-/disable of elementsRoland Knall6-9/+92
Allow the enable/disable of an element Change-Id: I9652e8d74b261ba259cebfba53e7bc7ef560d347 Reviewed-on: https://code.wireshark.org/review/20370 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-03Check profile directory before personal directory for services and subnets fileMichael Mann2-7/+30
Bug: 11228 Change-Id: Id8bcc51ff694ef9f2019bc7509e440021d049d22 Reviewed-on: https://code.wireshark.org/review/19735 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-03-03Fix compile error about missing intializer.Joerg Mayer1-1/+1
Change-Id: I5ff757c199df5cf78d9c625bf2f69e9c62dc3f61 Reviewed-on: https://code.wireshark.org/review/20375 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-03-03Bluetooth: HCI_EVT: Implement all remaining events/commandsMichal Labedzki1-6/+369
Event: Authenticated Payload Timeout Expired Commands: Set Connectionless Slave Broadcast Set Connectionless Slave Broadcast Receive Set MWS Signaling Read Synchronization Train Parameters Write Synchronization Train Parameters Read Secure Connections Host Support Read Authenticated Payload Timeout Read Local OOB Extended Data Read Extended Page Timeout Read Extended Inquiry Length LE Read Suggested Default Data Length LE Write Suggested Default Data Length LE Read Resolving List Size LE Read Peer Resolvable Address LE Read Local Resolvable Address LE Read Maximum Data Length Change-Id: Id57693b284151b054b7e06237744629a6af98057 Reviewed-on: https://code.wireshark.org/review/20354 Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-03Qt: Fix goto next/prev packet toolbar buttonsStig Bjørlykke1-4/+6
Use bitwise AND to check if a modifier bit is set. Also changed from MetaModifier to AltModifier to match the comment and the modifier key used in "Next/Previous Packet in History". Change-Id: I89072a1dfdd14a2beb7344a672cbc18a3ace8924 Reviewed-on: https://code.wireshark.org/review/20359 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-03Update documentation with reference to $XDG_CONFIG_HOMEPeter Wu4-19/+30
Since v2.1.0rc0-184-gb0b53fa593, $XDG_CONFIG_HOME/wireshark (instead of $HOME/.wireshark) is used, clarify this in the WSUG and manuals. Change-Id: I74a6f9b86bd8d54ee326ca83d7536e091d6da08a Reviewed-on: https://code.wireshark.org/review/20364 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-03SIP: Add digest verification functionalityerikdejong1-9/+254
Added functionality to verify SIP authorization lines. With this functionality it's possible to find faulty passwords that were added to configuration by automatic processes (eg having unescaped '&' characters in XML config files) resulting in authorization failures that cannot be diagnosed otherwise. Other uses include bug hunting in SIP stacks. Bug: 13444 Change-Id: I5abecd048480c8f5130a5112c531587c5993f12f Reviewed-on: https://code.wireshark.org/review/20314 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-03IAX2: Add a timestamp check.Gerald Combs1-16/+24
Don't try to process timestamps that are more than 60 seconds apart. Avoids the infinite loop in bug 13432. Bug: 13432 Change-Id: I05aea4c733c94cbfe832f03ba826c74a41e6bb2f Reviewed-on: https://code.wireshark.org/review/20366 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-03-03Qt: reduce minimum window size requirementPeter Wu2-2/+2
Strip some padding from the main welcome screen and lower the minimum width to allow the window to be shrinked. Even when a capture file was open, the minimum dimensions from the main welcome screen would apply. The minimum dimensions on Arch Linux with Qt 5.8.0-5 and Plasma 5.9.2 (with the default Breeze theme) for a window have changes as follows: - main screen/pcap loaded: 746x626 -> 702x590 - with search bar opened: 826x658 -> 826x622 (These numbers exclude 35x10 window decoration.) Change-Id: Iccc43ee55803abb8105c0d9664368aab09e8cfcf Reviewed-on: https://code.wireshark.org/review/20343 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-03-03pluginIf: Add/Remove single entries from selectorRoland Knall6-35/+179
Allow to add and remove single items from a selector list and also fixing the selection of items in a selector list Change-Id: I0c69ea97db6ca1a6932939f0df9049c6fb720f77 Reviewed-on: https://code.wireshark.org/review/20363 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-03-03WSDG: update for $XDG_CONFIG_HOMEPeter Wu1-1/+2
Since v2.1.0rc0-184-gb0b53fa593, the config directory has changed. Change-Id: Idbeb62f2393d1a4ec192da2d85e6bfb76782aeb8 Reviewed-on: https://code.wireshark.org/review/20365 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-03-03ieee80211: fix minimum TCLAS lengthMarcin Rokicki1-2/+2
TCLAS IE contains a set of parameters to identify incoming frames with a TS. During verification with various types of classifier types Wireshark prints Error/Malformed message for type 2 (IEEE802.1Q) IEEE802.11e defines that for classifier type 2 frame length is 5 not 6. Change-Id: Icf61f7fb65e5b119aedbb664b4adaee1f1e9fde8 Signed-off-by: Marcin Rokicki <marcin.rokicki@gmail.com> Reviewed-on: https://code.wireshark.org/review/20361 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-03-03Having business-as-usually unused words for specific "users" in TIPC not shownMartin Peylo1-64/+137
as needlessly highlighted expert info but as normal text in the protocol tree. Change-Id: I41028b00c6c5cdb85e399c959df721d768f674e1 Reviewed-on: https://code.wireshark.org/review/20360 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Diameter 3GPP: update Rx Feature-List AVPPascal Quantin1-2/+9
Change-Id: Ia4fa3687173f8642f80e650df3e713a26e9a17b5 Reviewed-on: https://code.wireshark.org/review/20362 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Bluetooth: HCI_EVT: Implement "Read Local Supported Codecs"Michal Labedzki1-3/+95
Implement event reponse for command "Read Local Supported Codecs". Change-Id: I38946f4744b2d2d586384125700e937db698038c Reviewed-on: https://code.wireshark.org/review/20353 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Bluetooth: HCI_EVT: Add missing unit for generated fieldMichal Labedzki1-1/+1
Add missing unit [ms] for "Command-Response Delta" Change-Id: I7ba31fc6bf3baae161608432ea5fcd1015414604 Reviewed-on: https://code.wireshark.org/review/20356 Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Qt: Add selection history navigation.Gerald Combs7-6/+131
Add the ability to move back and forth in the packet selection history similar to GTK+. Update the documentation accordingly. Change-Id: If1fdc1e59b240c0588c292dc0f7f0a5f083c30e1 Reviewed-on: https://code.wireshark.org/review/20320 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03BT-DHT: add IPv6 support for find_node responsesFlorian Adamsky1-11/+42
Change-Id: I4ce38892b6c287c2dc51f438a12a5be5920197b6 Reviewed-on: https://code.wireshark.org/review/20323 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Qt: allow Packet Bytes view to be shrinkedPeter Wu2-0/+7
Even if a packet has only one or two lines for the byte view, Qt autoresizing insists to require a minimum of 5.5 lines (or 7.5 lines for packets without multiple data sources). Remove this artificial requirement and allow the packet bytes view to be resized to show nothing (except for possible data sources tabs). This makes it easier to fit more packets and details for screenshots. Change-Id: I3ea997b9effa8292b396dc2ceb2ab1c35cead410 Reviewed-on: https://code.wireshark.org/review/20342 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-03Squelch a warning from VS Code Analysis.Guy Harris1-2/+2
It warns that a 32-bit value is being shifted left and then converted to a 64-bit type; presumably it means "this might overflow and not give you the result you expect". That's unlikely to be the case here, as few UN*X file systems have a recommended I/O block size > 2^30, but we might as well throw in a cast so the convert-to-a-64-bit-type is done first. Change-Id: Id6ab11d750d5cf4cc03d060d63edc01b66cd179d Reviewed-on: https://code.wireshark.org/review/20352 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-03-03Fix compilation with old libcrypt versions.Guy Harris1-1/+13
Change-Id: If9c0631435e5380d3f158ebe6578adaf65a429bb Reviewed-on: https://code.wireshark.org/review/20351 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-03-03erf: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I7214adc58362902790c006e1e22f77104be5df2e Reviewed-on: https://code.wireshark.org/review/20341 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-02Rewrite dissectors to use Libgcrypt functions.Erik de Jong41-2437/+831
As discussed on the mailinglist, rewriting dissectors to use Libgcrypt functions as Libgcrypt will be mandatory after change 20030. Removal of following functions: - crypt_md4 - crypt_rc4* - aes_cmac_encrypt_* - md5_* - sha1_* - sha256_* Further candidates: - aes_* - rijndael_* - ... Added functions: - ws_hmac_buffer Added const macros: - HASH_MD5_LENGTH - HASH_SHA1_LENGTH Changes on epan/crypt/* verified with captures from https://wiki.wireshark.org/HowToDecrypt802.11 Changes on packet-snmp.c and packet-radius.c verified with captures from https://wiki.wireshark.org/SampleCapture Changes on packet-tacacs.c verified with capture from http://ccie-in-3-months.blogspot.nl/2009/04/decoding-login-credentials-regardless.html Change-Id: Iea6ba2bf207cf0f1bf2117068fb1abcfeaafaa46 Link: https://www.wireshark.org/lists/wireshark-dev/201702/msg00011.html Reviewed-on: https://code.wireshark.org/review/20095 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-03-02Remove a cast that now causes rather than squelching warnings.Guy Harris1-1/+1
We're now comparing an unsigned with an expression made mostly of unsigned, so there's no need to cast the expression to long to squelch signed vs. unsigned warnings. Change-Id: I3b8c6f6faf26a9c252eb55d9e69fb298a3ad4c3b Reviewed-on: https://code.wireshark.org/review/20347 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-02 04:14:17 +0000