aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-04at: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+3
Change-Id: Ibe42807cfbf3ed57791d4f4beb8e95cc71ba39f4 Reviewed-on: https://code.wireshark.org/review/28942 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Darien Spencer <cusneud@mail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-08-04rfc7648: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: Idc37628b7f3022e83b53a34f388ce976aab0888e Reviewed-on: https://code.wireshark.org/review/28941 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-08-04[GSM A RR]: fix APDU ID/Flags parsing for Application InfoVadim Yanitskiy1-2/+8
According to 3GPP TS 04.08, table 9.1.53.1, Application Information message has two mandatory fields encoded in a single octet: - APDU ID (section 10.5.2.48) M V 1/2, - APDU Flags (section 10.5.2.49) M V 1/2. For some reason, they were dissected incorrectly: GSM A-I/F DTAP - Application Information Protocol Discriminator: Radio Resources Management messages (6) .... 0110 = Protocol discriminator: Radio Resources Management messages (0x6) 0000 .... = Skip Indicator: No indication of selected PLMN (0) DTAP Radio Resources Management Message Type: Application Information (0x38) APDU ID .... 0000 = APDU ID: RRLP (GSM 04.31) LCS (0x0) Missing Mandatory element APDU ID, rest of dissection is suspect [Expert Info (Error/Protocol): Missing Mandatory element APDU ID, rest of dissection is suspect] [Missing Mandatory element APDU ID, rest of dissection is suspect] [Severity level: Error] [Group: Protocol] APDU Flags 0000 .... = APDU Flags: Unknown (0x0) APDU Data [...] Change-Id: Ibb248104289da8e602ac15da15ae9e8eadb42c42 Reviewed-on: https://code.wireshark.org/review/28947 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-08-03RANAP: decrease the min length to 7 bytesVasil Velichkov2-2/+2
The min length was increased to 8 in d9c70acaf4 but there are valid 7 bytes long RANAP messages that are not recognized by the heuristic function. Revert the value to 7 as in 482a3cd1f1c Change-Id: I5096cd905c24c87dccbc2aa4bbdccc7b0febead7 Reviewed-on: https://code.wireshark.org/review/28945 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-08-03LISP: add support for Reliable Transport messagesLorand Jakab4-74/+398
These messages are defined in [0], and are used in some deployed products already. [0] https://tools.ietf.org/html/draft-kouvelas-lisp-map-server-reliable-transport-04 Change-Id: Idfbc777175c1596d3e0fa1df39602a68ee1c488f Signed-off-by: Lorand Jakab <ljakab@ac.upc.edu> Reviewed-on: https://code.wireshark.org/review/28503 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-03ospf: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: Ic40eb2ddeef30aa4f3f2d31dc7f91cec55e62508 Reviewed-on: https://code.wireshark.org/review/28926 Reviewed-by: Khalifa NDIAYE <khalifa.ndiaye@orange.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-03tap_export_pdu: Fix two memory leaksVasil Velichkov2-8/+12
253 (8 direct, 245 indirect) bytes in 1 blocks are definitely lost in loss record 87 of 93 at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) by 0xBC4B3C5: g_malloc (gmem.c:99) by 0x13E225: exp_pdu_open (tap_export_pdu.c:128) 372 (40 direct, 332 indirect) bytes in 1 blocks are definitely lost in loss record 88 of 93 at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) by 0xBC4B3C5: g_malloc (gmem.c:99) by 0xBC62FF6: g_slice_alloc (gslice.c:1025) by 0xBC16984: g_array_sized_new (garray.c:194) by 0x13E143: exp_pdu_open (tap_export_pdu.c:93) Change-Id: I24a3cec1dc4491032232c282b01fea04a23872b3 Reviewed-on: https://code.wireshark.org/review/28934 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-03PTP: fix typo path_delay -> peer_delayAlexis La Goutte1-9/+9
reported by Donn Lee Bug: 15026 Change-Id: I54bb65338a22c3d9cb691618baeb011a869182d3 Reviewed-on: https://code.wireshark.org/review/28939 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-03Fix bug in RFC 5447 dictionary.Guy Harris1-2/+6
Pick up the current version ("current" as in "picked up from a recent checkout of the FreeRADIUS/freeradius-server repository on GitHub") of dictionary.rfc5447. See https://github.com/FreeRADIUS/freeradius-server/issues/2269 and some of the discussion in https://github.com/the-tcpdump-group/tcpdump/pull/636 Change-Id: Ib21838684ac250ff1f02fcea6c1e5ca865b4b6ff Reviewed-on: https://code.wireshark.org/review/28935 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-02tds: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I951a69b44959fd4c2f24f9ce70e40cf95dd2aa2e Reviewed-on: https://code.wireshark.org/review/28927 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-02PFCP: fix DL Buffering Duration timeMichal Slavka1-1/+0
Variable units is shifted two times,in proto_tree_add_item_ret_unit and again in the dissector. Change-Id: Ia93bfe59730a7634201de26b37dcc8111515eea5 Reviewed-on: https://code.wireshark.org/review/28931 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-08-02lwm2mtlv: Update for changes in wmem_strsplit()Stig Bjørlykke1-12/+12
The implementation of wmem_strsplit() has changed to behave like g_strsplit(), and this affects splitting strings starting with the delimiter. Update URI Path splitting for the new behaviour. Ping-Bug: 14980 Change-Id: Id50cca24861b6d0969077e604ea199d864a9036c Reviewed-on: https://code.wireshark.org/review/28930 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-08-02rsvp: fix this ‘if’ clause does not guard... ↵Alexis La Goutte1-5/+7
[-Werror=misleading-indentation] Change-Id: I84d68dfd485c04042fd5f4e106ac0d79883085cd Reviewed-on: https://code.wireshark.org/review/28929 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-08-02rsvp: fix unused variable 'rsvp_xro_sobj_type_vals' [-Wunused-const-variable]Alexis La Goutte1-0/+2
Change-Id: I82e3ea93bbcee87618ab461d8026e4d91a01bc22 Reviewed-on: https://code.wireshark.org/review/28925 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Khalifa NDIAYE <khalifa.ndiaye@orange.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-08-02gtp: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: Iac8e93a17c88f2117fc23fcda93b3769925114ab Reviewed-on: https://code.wireshark.org/review/28928 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-08-02GMPLS extensions to RSVP-TEKhalifa NDIAYE1-298/+331
- Ethernet line LSP encoding (RFC 6004) - flexi-grid label (RFC 7699) - codepoint for network-assigned label (RFC 8359) - clean-up and bug fixes on ERO/RRO/XRO - full support of RFC 8001, including error code Change-Id: I3fadc59f6a3a8e5dc12f319073472324702f9aa1 Signed-off-by: khalifaND <khalifa.ndiaye@orange.com> Reviewed-on: https://code.wireshark.org/review/28741 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01kafka: fix builds without Snappy or LZ4 supportDario Lombardo1-8/+8
Avoid passing an uninitialized "raw" pointer to "proto_tree_add_item". Change-Id: Ic7d3542b4aa5650f452aad7ac3b783769cb44eb7 Reviewed-on: https://code.wireshark.org/review/28922 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-01rfc7468: Usability improvementsStig Bjørlykke1-2/+6
Put base64 decoded data on top level tree. Set COL_PROTOCOL and add label to COL_INFO. Change-Id: Iea68523c9b2cee0f62fd86510c216b9c00f39f2a Reviewed-on: https://code.wireshark.org/review/28921 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01msgpack: make return value optional.Dario Lombardo1-24/+47
Change-Id: I76ca5b4cdff51c68975fbc1698ecec4329382cde Reviewed-on: https://code.wireshark.org/review/28851 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01msgpack: fix return value for map and array.Dario Lombardo1-1/+5
Change-Id: I438b9ed310ca9d5553a00c7d0b633d8597b4f5bc Reviewed-on: https://code.wireshark.org/review/28881 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01commit-msg: fixup whitespace and blank lines around "Bug" tagsPeter Wu1-0/+84
About 90 commits so far have a newline after the "Bug" tag. That breaks the issue tracker integration and tools such as git-interpret-trailers, so ensure that such blank lines are removed. Change-Id: Ib73e0ab1bbf99c8c200e74a03facc5d359c82436 Reviewed-on: https://code.wireshark.org/review/28828 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01tshark: Allow exporting of PDUs to stdoutVasil Velichkov2-5/+16
The following command will export the PDUs to stdout tshark -r ./test.pcapng -U "OSI layer 3" -w - Change-Id: Idddded6bfcac458d82cdc033babc7546b67f7327 Reviewed-on: https://code.wireshark.org/review/28919 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01Cast the result of g_realloc().Guy Harris1-1/+1
That squelches warnings if C++ compatibility is being checked. Change-Id: Ia3dd9852df0fbf6353a84d299a385ef63c9f1acd Reviewed-on: https://code.wireshark.org/review/28920 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Kafka: add info when we lack decompression supportTim Cuthbertson1-2/+8
Change-Id: I4c1b5d84bd1a6dfa811fd8ffbd576ac8dfd448af Reviewed-on: https://code.wireshark.org/review/28749 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01RFC 7468 is PEM-inspired, but it's not PEM.Guy Harris5-22/+22
Do some renaming. Change-Id: If8fa85370014f9618df38d97048dd1c52a4c389f Reviewed-on: https://code.wireshark.org/review/28918 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01No need to tell the BER dissector the file name for RFC 7468 files.Guy Harris1-2/+1
It's just a hack for "raw BER data" files, giving them a file name that includes the OID to use for the syntax. For RFC 7468 files, the syntax is determined from the label in the pre-encapsulation boundary. Change-Id: Ia656f20f123d2c6a85041f83714a3a1cfefb70b1 Reviewed-on: https://code.wireshark.org/review/28916 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Don't hide dissected data under a "Data" item.Guy Harris1-7/+8
Only put otherwise-undissectable BER data under that item. That removes an extra layer that needs to be opened up. Change-Id: I6b025a782ff7199c84bad46160c7c286e79b0580 Reviewed-on: https://code.wireshark.org/review/28915 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01AT: Dissect commandsDarien Spencer1-29/+1672
This commit introduces dissection of the different parts of the command, showing of the command direction and origin entity, generic dissection of 'unsupported' commands, detailed dissection of several 'supported' commands and aggregated commands dissection. Most of the code has been taken from BT-HFP (A protocol of AT commands over bluetooth). Change-Id: I3516ec9c28581df8ef9c0c37f9b6ee9ec0c55938 Reviewed-on: https://code.wireshark.org/review/28699 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01radiotap: Add support for 0-length PSDUs.Richard Sharpe3-3/+55
Change-Id: I386c6cd84a74eda5dff32fb93b0a35eb54bc6b4b Reviewed-on: https://code.wireshark.org/review/28884 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01Do most of the RFC 7468 file processing in the dissector.Guy Harris9-120/+578
Have the Wiretap code just do a heuristic test to see if the file looks like a RFC 7468 file and just had the entire blob of raw file data to the caller, with an encapsulation type of WTAP_ENCAP_RFC7468. Have a file-rfc7468.c dissector that processes the lines of the file, displaying all of them. Have it extract the label from the pre-encapsulation boundary line, and, after it's decoded the base64-encoded data lines into a blob of data, try handing the tvbuff with the blob to dissectors that have registered in the "pem.preeb_label" dissector table with the appropriate label value, and hand it to the raw BER dissector only if that fails. This allows some files to have the content dissected as more than just a raw blob of BER-encoded data. Change-Id: I98db9f0beb86e5694fb8e886005a2df4fc96ba71 Reviewed-on: https://code.wireshark.org/review/28914 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Revert "Have find_or_create_conversation() use pinfo->conv_endpoint if present."Guy Harris4-30/+32
This reverts commit ba202ef36225b59eb797c5a48b8d4a4665b479c7. Creating endpoints, and corresponding conversations, for protocols atop which TCP or UDP runs can potentially cause attempts to look up the conversation to find the conversation for that protocol rather than for TCP/UDP, which can confuse protocols running atop TCP or UDP. Change-Id: I3ca522e54e67cc4f996d0ee841c6bb40ee6a9976 Reviewed-on: https://code.wireshark.org/review/28912 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Get rid of a no-longer-used dissector handle.Guy Harris1-4/+0
Change-Id: I3e5bdc0339a0f229f40a6538f93c699106941e28 Reviewed-on: https://code.wireshark.org/review/28910 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Have find_or_create_conversation() use pinfo->conv_endpoint if present.Guy Harris4-32/+30
Add conversation_new_pinfo(), which uses the endpoint if present, and have find_or_create_conversation() use it rather than conversation_new(). Remove find_or_create_conversation_by_id() - it's no longer needed. Bug: 15018 Change-Id: Ib13e539751af0f071aede4ee0ed751d0cb72ba3f Reviewed-on: https://code.wireshark.org/review/28908 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Export some more conversation functions.Guy Harris2-4/+10
They're used by built-in dissectors; I see no reason whatsoever to forbid plugins from using them. See https://ask.wireshark.org/question/4366/compile-plugin-with-call-to-conversation_set_port2/ Change-Id: I6a04df961c164a09b88abd8f46a1fe3420a21661 Reviewed-on: https://code.wireshark.org/review/28906 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31For ISDN, don't create an endpoint by ID and then use it.Guy Harris4-3/+29
That isn't working, because it depends on the notion that for every "endpoint type" there's a "port type" for the packet_info structure; that's not true for ISDN channels. The whole point of "use the packet_info structure when trying to find a conversation and create it if it doesn't exist" is to use address information *already filled in by somebody for use by other dissectors*; we don't do that with the ISDN channel number, because there's no *need* to do so. So just add a new find_or_create_conversation_by_id() routine, which passes the packet_info structure to get the frame number, and explicitly passes the endpoint type and ID. Use that in the ISDN dissector. Bug: 15018 Change-Id: Id0e997254b0eaf7cbc9261a2adff639ecbf083c0 Reviewed-on: https://code.wireshark.org/review/28904 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Improve debugging messages.Guy Harris1-10/+36
For various attempted matches, print what we're matching against. Change-Id: Ib915aa9bc6e6e1ea6cc7a273f261db2a4952c0c4 Reviewed-on: https://code.wireshark.org/review/28900 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Frame numbers are unsigned.Guy Harris1-11/+11
Change-Id: I07641b0a759058fe5111e10c3ccd4c8f69eeccef Reviewed-on: https://code.wireshark.org/review/28894 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Clean up white space.Guy Harris1-45/+46
Change-Id: Id1eb5ec743581a0d05b82e94c78f262e7dc33f7b Reviewed-on: https://code.wireshark.org/review/28892 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31radiotap: fix indent (use tab)Alexis La Goutte2-3/+3
Change-Id: I9fc2320ecd760f2be92b53d57fe1e12152edf198 Reviewed-on: https://code.wireshark.org/review/28890 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot
2018-07-31wmem_interval_tree: fix no previous prototype for ↵Alexis La Goutte1-1/+1
‘update_edges_after_rotation’ [-Wmissing-prototypes] Change-Id: I60085243d0e57ac072246bf3374ed3b7f6078497 Reviewed-on: https://code.wireshark.org/review/28889 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31No need to initialize cursorname_len.Guy Harris1-1/+1
Not initializing it also means that we'll get an error from compilers with sufficiently good dataflow analysis if we use it in, or before, the call itself, which is a Good Thing as we *shouldn't* use it before we know it. Change-Id: I99aa3fedd2a04f5bb6e60e0f6f8b0a3682263351 Reviewed-on: https://code.wireshark.org/review/28888 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31TDS: Fix bad proto_tree_add_item_ret_string_and_length call.Craig Jackson1-1/+1
I'm not sure why this compiled in all of the test environments. (Ubuntu and Windows, plus Buildbot.) Change-Id: I15d281010f3f463f3929aff8918ade8b71cffff7 Reviewed-on: https://code.wireshark.org/review/28887 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31sccp: Make "lr" a generated item rather than hidden to make it obvious that ↵Vasil Velichkov1-2/+2
it exists. Similar to the TCAP transaction IDs - hf_tcap_tid, hf_tcap_dtid and hf_tcap_otid. Change-Id: Idf55c894f5c0e60844c03b7de89b56f632d0ed36 Reviewed-on: https://code.wireshark.org/review/28885 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31tds: fix uninitialized var.Dario Lombardo1-1/+1
../epan/dissectors/packet-tds.c:2659:27: error: variable 'cursorname_len' is uninitialized when used here [-Werror,-Wuninitialized] tvb, cur + 1, cursorname_len, tds_get_char_encoding(tds_info)|ENC_NA, ^~~~~~~~~~~~~~ ../epan/dissectors/packet-tds.c:2653:29: note: initialize the variable 'cursorname_len' to silence this warning guint cursorname_len; ^ = 0 1 error generated. Change-Id: I21a1e34997af95097d3a916589f69b86a6fe0418 Reviewed-on: https://code.wireshark.org/review/28883 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31Relax ERF heuristicStephen Donnelly1-2/+2
Allow forward timestamp deltas up to 1 year, up from 7 days. Surprisingly this was overly restrictive in some real cases. Change-Id: I8a4bd1ca791b978aa5d2be40f7f8dd8e23db8837 Reviewed-on: https://code.wireshark.org/review/28882 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30Add WTAP_ENCAP_RUBY_MARSHAL to the table of encapsulation names.Guy Harris1-0/+3
Change-Id: If7362bc4e1da3c3dc22df08b52c7cadcd43d3b81 Reviewed-on: https://code.wireshark.org/review/28886 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-30SCTPGraphDialog: fix displaying a single TSNVasil Velichkov1-3/+2
When the SCTP association contains a single DATA/SACK chunk in direction the max and min TSN values are equal and as a result the Y axis range is (maxTSN, maxTSN) or (0, 0) and the dots for the TSN are not visible To fix this always set the Y axis maximum to maxTSN + 1 similar to the X axis maximum of max_secs + 1 Also removed one unused local variable Change-Id: Id38eb4dbd13a8ebbba98d4df00f3707331bd1464 Reviewed-on: https://code.wireshark.org/review/28862 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30SCTPGraphArwndDialog: Detect max arwnd value when startArwnd is not setVasil Velichkov2-1/+6
When the capture does not contains SCTP INIT and INAT_ACK packets the startArwnd value is 0 (not set) and as a result the Y axis range is (0,0) and the dots are not visible Change-Id: Iafb1981e62f28fe09b106138836c866d0dbebb27 Reviewed-on: https://code.wireshark.org/review/28861 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30GMPLS extensions to OSPF-TEKhalifa NDIAYE1-4/+184
- optical spectrum occupation for fixed grid WDM links (RFC 7688) - optical spectrum occupation for flexi-grid WDM links (RFC 8363) Change-Id: I7a4d8f0bd0b863b51dde60bb4b04f4756a7ca99b Signed-off-by: khalifaND <khalifa.ndiaye@orange.com> Reviewed-on: https://code.wireshark.org/review/28751 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30Add basic support for TDS 5 (Sybase) cursors.Craig Jackson1-11/+839
Change-Id: Ie04489b5445dc473d9bc6d772c1c33270da9b363 Reviewed-on: https://code.wireshark.org/review/28835 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 14:41:25 +0000