aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-01-03doc/README.display_filter: Fix typo: asser -> assertJim Young1-1/+1
Change-Id: If49baf3e2b4e01f4ca4ea85415a3a291f8c04c92 Reviewed-on: https://code.wireshark.org/review/31354 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-03epan: remove redundant casts.Dario Lombardo9-17/+17
Found by clang-tidy. Change-Id: Iaf6cf84c33b03ddfcd39a333b49f4987002afa56 Reviewed-on: https://code.wireshark.org/review/31338 Petri-Dish: Dario Lombardo <lomato@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03file: remove redundant cast.Dario Lombardo1-1/+1
Found by clang-tidy. Change-Id: I58c11e09ed89e99457635dd843311ce3cf3c6bae Reviewed-on: https://code.wireshark.org/review/31334 Petri-Dish: Dario Lombardo <lomato@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03sharkd: remove redundant cast.Dario Lombardo1-1/+1
Found by clang-tidy. Change-Id: Ie02a77ffc17050743de216594d40faa65e1dabc2 Reviewed-on: https://code.wireshark.org/review/31336 Petri-Dish: Dario Lombardo <lomato@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03extcap: remove redundant casts.Dario Lombardo1-3/+3
Found by clang-tidy. Change-Id: Icd4a72d840092ce9c5e18e3d16a94b785b4521dc Reviewed-on: https://code.wireshark.org/review/31333 Petri-Dish: Dario Lombardo <lomato@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03rawshark: remove redundant cast.Dario Lombardo1-1/+1
Found by clang-tidy. Change-Id: I50912055e0230173af3a6b008fafb12144b02f8d Reviewed-on: https://code.wireshark.org/review/31335 Petri-Dish: Dario Lombardo <lomato@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03Put a period at the end of a sentence.Guy Harris1-1/+1
Change-Id: Ifad6b9a09bc052d687cefe3ccda8c07ad765abda Reviewed-on: https://code.wireshark.org/review/31350 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03Slight fixup for where the capture code lives.Guy Harris1-2/+3
The full explanation is a bit more complicated - we'd have to mention the dumpcap/*shark split, and the code on both sides of the split. Change-Id: I43f8fc3c589bdf900e20714b55a3b4f544879bc2 Reviewed-on: https://code.wireshark.org/review/31349 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03WSDG: Miscellaneous updates and fixes.Gerald Combs9-125/+170
Update the Windows CRT text to mention the Universal CRT. Replace references to WinPcap with Npcap. Update the Qt LTS text. Add a WiX / .msi section Use curly quotes. Use the {cpp} attribute so that the "++" in "C++" doesn't trigger monospace formatting. Make the various "Unix" and "Windows" subsection title names uniform. Give them the "discrete" attribute so that they don't clutter up the TOC. Title-case section titles. Remove the reference to m4. As far as I can tell we don't require it. Change-Id: I73f851adae640f77205781d6c4962002c2d53f49 Reviewed-on: https://code.wireshark.org/review/31343 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-03test: print command output for dfiltertest failuresPeter Wu1-1/+2
The buildbot detects random errors on Windows. Log some more details in order to understand the problem better. Change-Id: I903457894985273a63b8907b6784a2897cd93d93 Reviewed-on: https://code.wireshark.org/review/31340 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-03Avoid definition collisions for INVALID_SOCKET.Guy Harris1-0/+2
Newer versions of libpcap define it (due to the somewhat infelicitous API for "active mode" remote capture, which returns a socket); don't define it ourselves if it's already defined. Change-Id: I620576620fd2708ebd503da696e17b472bc20472 Reviewed-on: https://code.wireshark.org/review/31344 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03Fix indentation.Guy Harris1-1/+1
Change-Id: I60d9b7b5dce04dae560a68feb329041c0374c241 Reviewed-on: https://code.wireshark.org/review/31342 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03tshark: remove redundant casts.Dario Lombardo1-5/+5
Found by clang-tidy. Change-Id: I7fe1c3219758d8daf411d094e2df17916f2eb57b Reviewed-on: https://code.wireshark.org/review/31330 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03capture_sync: use the same var name as in other places.Dario Lombardo1-1/+1
error_message -> error_msg. Change-Id: Ie1bc1b72800dc6c93e481cfffa202d5bd0743b5c Reviewed-on: https://code.wireshark.org/review/31329 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03doc: update README.display_filter for new test locationPeter Wu1-30/+19
Change-Id: I29bb00dbec43692d940ef6f389743af56dfd6995 Reviewed-on: https://code.wireshark.org/review/31341 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-03release-notes: document TLS and library changesPeter Wu1-0/+11
Change-Id: I3af4cb96a6c87205cdd6c85c27977366cb77291f Reviewed-on: https://code.wireshark.org/review/31327 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-03epan: use json_dumper for json outputs.Dario Lombardo4-356/+216
They include -Tjson, -Tjsonraw, -Tek. Change-Id: Ib3d700482ce5c29727c3f778cc3c46a1bf7756c4 Reviewed-on: https://code.wireshark.org/review/31000 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-03json_dumper: make json_dumper_bad fatal.Dario Lombardo1-1/+1
A call to this function means a programming error. g_error makes it fatal and terminates the program, making the debug easier. Change-Id: I5c9e82507482733b4d450ed6c3a9fc17fb0fcdca Reviewed-on: https://code.wireshark.org/review/31310 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-03GeoNetworking cleanup and minor correctionsChristophe GUERBER2-48/+28
Removes obsoleted dissector tables, cleanup comments, correct elevation display and intx display. Change-Id: I7224bede0cecbbd5cab91630193e17a7e12615b1 Reviewed-on: https://code.wireshark.org/review/31323 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03debian: update symbols.Dario Lombardo1-0/+1
Change-Id: I550dd3b6bdf29cb8c5a80ba8d08b29ffbe3246cd Reviewed-on: https://code.wireshark.org/review/31321 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03ieee80211: print the RU Allocation in decimalEmmanuel Grumbach1-2/+2
The RU Allocation is really a decimal number and the standard uses it as a decimal number. It is not a bitmap. Print it in decimal. Change-Id: I2f8ff9798aa1af855ad3c8b0a26704282fe18189 Reviewed-on: https://code.wireshark.org/review/31315 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03knsxip: fix headerAlexis La Goutte2-4/+4
it is no longer Ethereal (=> Wireshark) Change-Id: I2a59aa0ec4e18b05612bbce6ede18db9ae350e49 Reviewed-on: https://code.wireshark.org/review/31317 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03geonw: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+3
Change-Id: Ib1e26cc20ad30889a56455bcf529ba404f14506f Reviewed-on: https://code.wireshark.org/review/31320 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03knxip: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-11/+11
Change-Id: Ifa64a819d50b730eae4a5c2447b502580a871f16 Reviewed-on: https://code.wireshark.org/review/31318 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03Add dissector for Great Britain Companion Specification (GBCS)Kenneth Soerensen3-0/+1773
The Smart Metering Equipment Technical Specifications (SMETS) requires that Gas Smart Metering Equipment (GSME), and Electricity Smart Metering Equipment (ESME) including variants, meet the requirements described in the Great Britain Companion Specification (GBCS). GBCS messages are end-to-end and contains ZigBee, DLMS or ASN.1 formatted payloads. The GBCS messages are transported via IPor via the ZigBee Tunneling cluster. https://smartenergycodecompany.co.uk/document-download-centre/download-info/gbcs-v2-1/ Bug: 15381 Change-Id: I28ca9831fc266a6abd310db103306b98786e63f9 Reviewed-on: https://code.wireshark.org/review/31168 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Martin Boye Petersen <martinboyepetersen@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03Couchbase: Fixup a shadow variable.Gerald Combs1-4/+4
Rename index to byte_idx. Change-Id: I49d09d6db71d5db9e1c65f2abadc1413b3ccb7ec Reviewed-on: https://code.wireshark.org/review/31313 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03Windows: use lua-unicode as built with VS 2017Peter Wu1-4/+4
These binaries were built by AppVeyor using VS 2017 (MSVC 19.16.27025.1) and replaces locally built binaries using VS 2015 (MSVC 19.0.24215.1). I believe that these are the same as both of them use VCRUNTIME140.dll and import the same symbols. Using a newer compiler should however remove any doubt of compatibility with VS 2017 and should address concerns from Anders and Graham. These files are actually the "msvc2017_*.zip" files from https://github.com/Lekensteyn/lua-unicode/releases/tag/5.2.4-release1 Change-Id: Ib3fdf4678267fa10c0729f98ae0ce3153ac278a4 Reviewed-on: https://code.wireshark.org/review/31307 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02Don't fall out of the loop on a write error.Guy Harris1-1/+1
Doing so means we'd close the FD, but we've already closed it. Addresses Coverity CID 1442274. Change-Id: I5aab1bd4b82e9ac0901bcdbc1ddb6b16eec30573 Reviewed-on: https://code.wireshark.org/review/31312 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-026lowpan: don't try to use (new) TVB that wasn't created.Jeff Morriss1-1/+2
If the IPHC TVB wasn't created then bail out of dissection before trying to use it. Bug: 15217 Change-Id: I6e297590cdf86e13b0185f75f1d409888f2498d8 Reviewed-on: https://code.wireshark.org/review/31308 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-01-02tools: fix trailing messages.Dario Lombardo1-3/+8
Change-Id: If4f213daaa27f51b1659939244945d9fdddc7772 Reviewed-on: https://code.wireshark.org/review/31309 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-02IEEE1609.2: Allow Service Specific Permissions dissectionChristophe GUERBER6-40/+604
IEEE1609 and GeoNetworking secured packets containing certificate contain Service Specific Permission items that was not dissected. This patch allows dissection of SSP both in IEEE1609dot2 dissector and in the geonetworking dissector. It also provides SSP dissectors for ETSI DEN and CA basic services. Change-Id: Ic5efe403f7c4337c7e51a4eab9a9d674d2fe1cf6 Reviewed-on: https://code.wireshark.org/review/31303 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02cli_main: remove real_main from stack traces for non-WindowsPeter Wu18-28/+29
Restore the "main" name since that is used everywhere else except for Windows. On Windows, "main" is renamed via a macro to avoid a conflict with "wmain" and to allow it to be called in cli_main.c. For those wondering, GUI applications (such as Qt) have a different entry point, namely WinMain. In Qt5, src/winmain/qtmain_win.cpp defines WinMain, but seems to convert its arguments from Unicode to CP_ACP (ASCII). It might not support UTF-8, but I did not verify this. Change-Id: I93fa59324eb2ef95a305b08fc5ba34d49cc73bf0 Reviewed-on: https://code.wireshark.org/review/31208 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02nas5gs: Add dissection of QoS flow descriptions.Anders Broman1-404/+503
While there renumber according to latest spec. and fix some indentation. Change-Id: Ib9b4590d72c3124ffcb96fd719a9a19cadb4c494 Reviewed-on: https://code.wireshark.org/review/31300 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02Diameter: Add 3GPP avp name="eDRX-Related-RAT" code="1705"Anders Broman1-1/+5
Change-Id: Ib95113f12831eed298c28998e4e6106bb4df8019 Reviewed-on: https://code.wireshark.org/review/31299 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02Updates and bugfixes of ASTERIX I062Atli Guðmundsson1-168/+323
I062 v1.18 updates (now the default) - Updated I062/380#10.STAT, new enum values (6 & 7) - Added asterix.062/080.SFC - Added asterix.062/080.IDD - Added asterix.062/080.IEC I062 v1.17 updates - Added asterix.062/060.V - Added asterix.062/060.G I062 bugfixes: - Fixed I062 Capitalisation inconsistencies - Fixed I062/080.FPLT, incorrect value mask - Fixed I062/080.SDS, incorrect value mask - Fixed I062/110#1.M5, incorrect name (was I062/110#1.MD5) - Fixed I062/110#4, incorrect abbreviation (was asterix.062_11_04) - Fixed I062/110#4, missing spare bit - Fixed I062/110#4.RES, incorrect value mask - Fixed I062/110#6, incorrect abbreviation (was asterix.062_11_06) - Fixed I062/136.MFL, incorrect abbreviation (was asterix.062_136_ALT) - Fixed I062/245.STI, was missing - Fixed I062/245, did not display anything - Fixed I062/290, incorrect abbreviation, (was asterix.062_) - Fixed I062/295#7.MHG, incorrect name (was I062/295#07.MHD) - Fixed I062/340#4/5, incorrect abbreviations (was asterix.062_340_) - Fixed I062/380#4, incorrect abbreviation (was asterix.062_380_4) - Fixed I062/380#4.IAS, incorrect scaling (depends on IM bit) - Fixed I062/380#6.ALT, incorrect type (was unsigned) - Fixed I062/380#7.ALT, incorrect type (was unsigned) - Fixed I062/380#9.NC, incorrect value mask - Fixed I062/380#9.TD, incorrect field size - Fixed I062/380#9.TTR, incorrect type (was signed) - Fixed I062/380#17.TA, incorrect type (was signed) - Fixed I062/380#19.VUC, incorrect field size - Fixed I062/390#3, incorrect type (was 32-bit), incorrect value mask - Fixed I062/390#n, incorrect abbreviations (was asterix.062_nn) - Fixed I062/500#3.APWLAT, incorrect type (was signed) - Fixed I062/500#3.APWLON, incorrect type (was signed) - Fixed I062/500#n, incorrect abbreviations (was asterix.062_nn) - Fixed I062/510, missing support for slaved trackers - Fixed I062/510.SUD, incorrect name (was I062/510.SID) - Fixed I062/510.SUD, incorrect type (was 24-bit), incorrect value mask - Fixed I062/510.STN, incorrect value mask - Updated I062/RE.CST.SAC/SIC, now reports as asterix.SAC/SIC - Updated I062/RE.CSNT.SAC/SIC, now reports as asterix.SAC/SIC Note: incorrect value masks and field sizes would in most cases cause an exception when trying to decode those fields. Change-Id: If6b9662d20619dd30b4fe28907ab0630c6d55e44 Reviewed-on: https://code.wireshark.org/review/31214 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02Make dissect_icmp_extension_structure into a dissector function.Michael Mann3-22/+13
That way there isn't a need for packet-icmp-int.h. Change-Id: Ib523c36ab2fdf6a43ee6ff32dadfcd53e9d9bf14 Reviewed-on: https://code.wireshark.org/review/31290 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02dpaux: Minor improvementsMichael Mann3-66/+41
1. Pass dissector data to dpaux dissector directly instead of using p_get_proto_data. 2. Don't assume dissector data will always be present and default to "sink" if that is the case. 3. tvb_memdup isn't needed for proto_tree_add_bytes 4. Use value_string to save switch cases. 5. Bugfix major/minor version dissection. Change-Id: I018d923537ce276fda8be1884f5bb3a8b2eef862 Reviewed-on: https://code.wireshark.org/review/31297 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-02wsutil: fix crash due to corruption of the "small_buffers" arrayPeter Wu1-0/+3
Gracefully handle repeated calls of ws_buffer_free on the same buffer to avoid strange crashes in other new users that allocate a "small" buffer. The first call to ws_buffer_free would store data pointer in the 'small_buffers' array for reuse and set the pointer to NULL. Result: (gdb) p cfile.rec.options_buf $2 = { data = 0x0, allocated = 2048, // Oops, not modified! start = 0, first_free = 0 } All users of Buffer (including ws_buffer_free) however asssume that 'allocated' reflects the actual size of 'data'. If this is not the case (if ws_buffer_free is called again), then a data pointer (NULL!) will be stored and the next ws_buffer_init request for a "small buffer" will result in unexpected behavior (including crashes). Fix the issue by clearing the 'allocated' field as well. Add assertions to catch such issues earlier rather than crashing at random users of these buffers (such as frame_tvbuff). Bug: 15263 Change-Id: I0b491c3fccac8c6fddd43779629343d721638ca9 Reviewed-on: https://code.wireshark.org/review/31278 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01No need to report "some files could not be saved".Guy Harris6-34/+12
We've already reported the files that couldn't be saved; no need to tell the user something they already know by that point. Change-Id: I8251a46134342df6b40a6324aa76a5237fde7c93 Reviewed-on: https://code.wireshark.org/review/31298 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-01lorawan: fix this condition has identical branches [-Wduplicated-branches]Alexis La Goutte1-2/+0
Change-Id: I9bf885dcd9b8c15212062f8e6205816521e707c3 Reviewed-on: https://code.wireshark.org/review/31292 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Erik de Jong <erikdejong@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-01-01Always report errors in eo_save_entry().Guy Harris4-11/+8
If a particular save failed, always let the user know. Change-Id: I618e0ff82813cd4249ab7b1714f9a50e095a1ea8 Reviewed-on: https://code.wireshark.org/review/31296 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-01Limit the maximum *file* name length for exported objects.Guy Harris4-35/+33
Limiting the maximum *path* name length is bogus; if the user wants to store the file in some directory deep under the root (UN*X) or the root of the drive (Windows), that's their choice - don't prevent them from saving in a directory with a path longer than some maximum or limit the file name based on the length of the path leading up to it. Limiting the maximum *file* name is presumably to cope with, for example, HTTP objects with a URL that had a very long query component, so it makes sense. Change-Id: Idfc7de8124ee80bdd4950341ff2239834eb9f6f6 Reviewed-on: https://code.wireshark.org/review/31295 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-01Get rid of local_eo_save_entry().Guy Harris2-58/+5
Have eo_save_entry() use the report_ routines to report errors, so they pop up a dialog in Wireshark and print an error message in command-line programs such as TShark. Use it instead of local_eo_save_entry(). Change-Id: I689fd880ff2a31486372374560129ee9d9692b1e Reviewed-on: https://code.wireshark.org/review/31294 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-01Fixes GeoNetworking secured packets dissectionChristophe GUERBER3-59/+73
Secured packets contain Common and Extended header. Change-Id: I60b5ed35811c19c9596bd142c1315b341d760968 Reviewed-on: https://code.wireshark.org/review/31238 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Use dissector table to dissect content of ieee1609Christophe GUERBER6-21/+113
For unsecured and signed data, the dissector uses a dissector table to determine the next dissector. It uses the psId field to index the table. In the case no psId is provided inside, the caller can set a default psid if it is provided beforehand. If none is provided, data are not dissected. Change-Id: I6f9d6989cd87dd373a155a5b893c460344a0c857 Reviewed-on: https://code.wireshark.org/review/31237 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Qt: Pluralize "Copy Row(s)"Stig Bjørlykke2-3/+7
Properly pluralize "Copy Row(s)" entry in the popup menu. Change-Id: Ifc4f9c69ab63d2d2594648db3115087ba51a941f Reviewed-on: https://code.wireshark.org/review/31269 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-01Z39.50: Eliminate unnecessary header.Craig Jackson2-25/+0
I decided that packet-z3950.h was unnecessary at this time, but I didn't eliminate all trace of it. Change-Id: Iaff41e143bac6bf42779de49f7390ac129cef3e1 Reviewed-on: https://code.wireshark.org/review/31288 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-01-01Fix asn2wrs.py: always add BASE_VAL64_STRINGChristophe GUERBER1-6/+2
In some cases (e.g. when a field has a user defined dissection function) the type reported for this field is a 'virtual' one and the latter is not contained in selt.type. Consequently, BASE_VAL64_STRING is not set. Function eth_get_type_attr should return all the attributes of a type and it seems resonable to expect it to return the BASE_VAL64_STRING. This will solve the above mentioned error and may solve any possible issue in other parts that call this function. Change-Id: Iaee9ce5bd30f2a768cfcecf628df23bf1ed54e55 Reviewed-on: https://code.wireshark.org/review/31287 Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-01-01Happy New Year 2019!Stig Bjørlykke2-3/+3
Change-Id: Ic140aafdb32e649e88bf3f00bda3cec9404e555a Reviewed-on: https://code.wireshark.org/review/31284 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-01krb5: fix parsing of PA-S4U-X509-USER in AS-REQIsaac Boukris3-55/+83
Per [MS-SFU] 2.2.2 PA_S4U_X509_USER in AS-REQ consists of the certificate data instead of the corresponding struct. Also, the subject-certificate field in the struct consists of the certificate data as well, so let's decode it as such. Change-Id: I6f03a66eac74b7d42c0893f63cab772d8ddcb803 Signed-off-by: Isaac Boukris <iboukris@gmail.com> Reviewed-on: https://code.wireshark.org/review/31279 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-21 07:30:41 +0000