aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-09-04packet-gmr1_rr: Add support for Immediate Assignement Type 4 decodingsylvain/gmr1Sylvain Munaut1-9/+717
This includes all the CSN.1.infrastructure and all the IEs needed for this particular message. Change-Id: I297ecb408952453878c0eaf0e5211e9cd1a3cdcc Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2019-09-01packet-gmr1_rr: Update Request Reference IE to GMR-1 3GSylvain Munaut1-13/+20
Change-Id: I248ad927f4616d172f955fb70d1a6abc46960aae Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2019-09-01packet-gmr1_rr: Add new RR message names from v3.4.1 of GMR-1 3G 44.008Sylvain Munaut1-1/+17
Change-Id: I4212e7ea323a7ebd24cfa49f02c0a9315be2f6f5 Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2019-08-30isakmp: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I318fec3f9cf8d86eaa4260f00e8747683a049e6e Reviewed-on: https://code.wireshark.org/review/34407 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30ieee1722: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ia056c5591369924f88762490b22e72e10f3bc392 Reviewed-on: https://code.wireshark.org/review/34406 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30NAS 5GS: update 5GSM capability IE dissectionPascal Quantin1-2/+8
Change-Id: I64b063aba78e64193fa5e8dc5e15955bd93093de Reviewed-on: https://code.wireshark.org/review/34409 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: fix PDU session identity dissectionPascal Quantin1-4/+4
Values 1 to 4 are allowed Change-Id: Ifa0bc9185af9a16c261d7cbd939a07f77f03b330 Reviewed-on: https://code.wireshark.org/review/34408 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30Qt: ProtoTree combine menusRoland Knall2-162/+94
The menu for a prototree when opened from a packetdialog was different than the one opened underneath packetlist. Those two are now the same. Change-Id: I57572287daa5a3b1de1f5bc8e95b382d5869af6e Reviewed-on: https://code.wireshark.org/review/34395 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-30Qt: Add macro for g_list_next for C++Roland Knall28-185/+196
Using a simple (type *) cast on g_list_next results in a warning with modern compilers "old-style cast" Adding a warning for g_list_next and data access to avoid the warning A good overview why reinterpret_cast has been used can be found here: https://stackoverflow.com/questions/332030/when-should-static-cast-dynamic-cast-const-cast-and-reinterpret-cast-be-used It is a 1:1 replacement in this case, but does not use any of the new cast styles and therefore should be used with caution. Change-Id: I989f237afc39aaf40133a788b1c0bbd7a51bf974 Reviewed-on: https://code.wireshark.org/review/34284 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-30NAS 5GS: update 5GSM cause tablePascal Quantin1-4/+8
Change-Id: I88c9015e0ec31c6d04fe653aee1753d2a604976f Reviewed-on: https://code.wireshark.org/review/34405 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: small cleanupPascal Quantin1-8/+1
Remove a useless assignment and a few useless return. Change-Id: I38d868fe8cb81cd86683cf660a6a6699c1e8a54b Reviewed-on: https://code.wireshark.org/review/34403 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: fix dissection of 5GSM capability IEPascal Quantin1-4/+7
This IE has a variable length to allow future extension. Change-Id: I158ef8a8aa2f5cace992113a9efeb324beebe1aa Reviewed-on: https://code.wireshark.org/review/34402 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: add dissection of Maximum number of supported packet filters IEPascal Quantin1-4/+23
Change-Id: I771cb6d2542a5069641fd5c57836e776802da199 Reviewed-on: https://code.wireshark.org/review/34401 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30ASTERIX: addition of CAT021 v0.23 and v0.26 decodingIvan Quach1-1/+323
Added ability to decode CAT021 version 0.23 and version 0.26 ASTERIX messages Change-Id: I242ae3055f0af805e3a9eb126494d545702f836f Reviewed-on: https://code.wireshark.org/review/34343 Reviewed-by: Ivan Quach <ivan.quach@aireon.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30genl: Always call subdissectorIdo Schimmel2-9/+14
Commit 61c5e8e76d21 ("genl: make subdissectors responsible for header") changed the generic netlink dissector to only call a sub-dissector if there is a payload after the generic netlink header. However, there are commands in certain generic netlink families that do not have any payload. For example, 'NET_DM_CMD_START' in the 'NET_DM' family. This means that the command will not be dissected by the subdissector, as it will never be invoked. Change the generic netlink dissector to always call a subdissector, if it is present. Prevent the subdissectors from trying to dissect past the end of the packet by adding checks in the two existing subdissectors, for the 'nlctrl' and 'nl80211' families. Change-Id: I4d2f48531dee92b11dc45000081a8d2d3dd875c6 Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-on: https://code.wireshark.org/review/34350 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-29mpeg(dsmcc): Fixed default switch conditionAnthony Crawford1-0/+2
A default condition was missing within the switch statement in dissect_dsmcc_un_session_resources Bug: 16025 Change-Id: I34a2c3715923ba80be456aa9b03f84f1dae58bd3 Reviewed-on: https://code.wireshark.org/review/34399 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-29Gryphon: Prevent endless loopMichael Mann1-1/+5
Bug: 16020 Change-Id: I59c24d3bdb3f3a85f6e498683594ee12db9642a8 Reviewed-on: https://code.wireshark.org/review/34392 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-29Add proto_tree_add_item_ret_time_stringMichael Mann15-222/+237
A few dissectors need the functionality of adding a time field to a proto_tree while also needing the "time to string" value (typically to show on a tree above). The functionality to do "get value from tvb and convert to string" was being done in packet-ntp.c. Instead proto_tree_add_item_ret_time_string can be used with various encoding to get the necessary functionality with less code duplication. ENC_TIME_MIP6 was added as a result of the refactoring. ABSOLUTE_TIME_NTP_UTC was added as another potential "base" type for time fields. Change-Id: Ie460c33370b0af59ef60bdab893ce9d6eb23b94f Reviewed-on: https://code.wireshark.org/review/34390 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-29Qt: Extend filterbutton context menuRoland Knall5-65/+43
The filterbutton context menu allows for appending the filter button expression to an already existing display filter and copying the filterbutton filter expression to the clipboard Bug: 15980 Change-Id: I7b24007e597b9a9800729339926378d0ff264c73 Reviewed-on: https://code.wireshark.org/review/34394 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29Qt: Apply Invert/Enable/Disable only to selected listRoland Knall6-89/+121
Also, put the search field on top, as this is the default for search fields and apply the change of enable/disable and invert-all only to the selected items, instead of all items. Bug: 16013 Change-Id: If4ef1c5ce63eef6fa72db679cdcbf52dcb0e8fb6 Reviewed-on: https://code.wireshark.org/review/34393 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29Qt: Move Apply/Prepare to general QMenu handlerRoland Knall8-233/+49
Also clarify the method by which the filter can be selected. From the main menu only selected filters from a ProtoTree can be selected, therefore the code for PacketList handling has been removed. Change-Id: I5e5827d763ab3b25db14a384581f283238f96d28 Reviewed-on: https://code.wireshark.org/review/34384 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-28cmake: fix issue when zstd is missing.Dario Lombardo1-10/+12
We need to check the library version only when the it's present, otherwise we hit an error. Change-Id: I6323b19d0023d466bfb6ae4b5751f376fc213fa4 Reviewed-on: https://code.wireshark.org/review/34387 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-28DOCSIS: FDX: Added decoding for SW-RBABruno Verstuyft1-1/+97
Change-Id: Ic55c2393e20c69866a266a5a8213faa84e17fac1 Reviewed-on: https://code.wireshark.org/review/34389 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28eCPRI: Update value string.Anders Broman1-3/+19
Change-Id: I7e5f5fa00b168578e00191089b482082e290f2d0 Reviewed-on: https://code.wireshark.org/review/34388 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28Use g_hash_table_replace() when key depends on dataTomasz Moń2-2/+2
Using g_hash_table_insert() in cases where the key is contained within value is error prone. Use g_hash_table_replace() to eliminate the risk of ending up with incoherent hash table state. Change-Id: I595457476a2682e927d2c56b2692404aef4dc43a Reviewed-on: https://code.wireshark.org/review/34385 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27Kafka: fixed OffsetForLeaderEpoch dissectionPiotr Smolinski1-132/+155
Bug: 16023 Change-Id: I78e1354ac5509707c818d7968c7067583fb469ba Reviewed-on: https://code.wireshark.org/review/34379 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-27cmake: check minimum zstd library version.Dario Lombardo2-2/+15
The APIs used in the kafka dissector have been introduced in version 1.0.0, then we need at least that version to work. Change-Id: I80ded2362d4f324ec26392bd7a9781ea6d9ba630 Reviewed-on: https://code.wireshark.org/review/34382 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27kafka: remove unused hf/ei entries.Dario Lombardo1-15/+0
Change-Id: I98a3a1456fbfeb726a1a81a0b46714556fe951cd Reviewed-on: https://code.wireshark.org/review/34383 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27Add tooltip for clearing display filterMoshe Kaplan2-1/+5
Change-Id: I11f8c7ba00ffdc3028c85b1f0957bd6f95092dce Reviewed-on: https://code.wireshark.org/review/34357 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27SMTP: Add support for multiline responsesMichael Mann1-22/+53
Commands with "-" at the end mean another line with the same command will follow. Group all of those lines in a single response tree and don't append the command value in the Info column for the additional lines. Bug: 15933 Change-Id: Icba167f2f1d22ebaf53a6844285ba83ed8a20106 Reviewed-on: https://code.wireshark.org/review/34381 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27DCERPC: workaround that pidl always emits dissect_deferred_pointers()Ralph Boehme1-2/+7
Commit f57cf9e56c90c0c0c724f415eff35821afaaf849 introduced a DISSECTOR_ASSERT() that revealed a deficiency in pidl: currently pidl unconditionally adds calls to dissect_deferred_pointers() which breaks dissecting any RPC function that has only scalar arguments: Warn Dissector bug, protocol RPCMDSSVC, in packet 51: epan/dissectors/packet-dcerpc.c:2940: failed assertion "list_ndr_pointer_list" Bug: 16022 Change-Id: I9d3522a3e17ef79b9a8a5acb018104ab398a512a Reviewed-on: https://code.wireshark.org/review/34364 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27DCERPC: update mdssvc DCERPC dissector from upstream SambaRalph Boehme2-99/+278
Change-Id: I13871e093b294a1865be6c47cb86275165002855 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-on: https://code.wireshark.org/review/34365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt: Create Apply/Prepare in PacketlistRoland Knall2-20/+32
Create the menu for apply/prepare inside Packetlist. At the same time disabled the "..." methods if no filter has been set yet Move the action list to FilterAction as well Change-Id: Ia18a4021cc95562702ff516a24fb029063096f94 Reviewed-on: https://code.wireshark.org/review/34377 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Add Apply/Prepare to Packet DialogRoland Knall1-1/+20
Add the possibility to apply/prepare a field entry to the packet dialog. This works also if the corresponding source file had already been closed. Bug: 3537 Change-Id: I448ad6d5cb37f2cbb2c2f649512b1f3e5acde2de Reviewed-on: https://code.wireshark.org/review/34372 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Remove unnecessary code for context menusRoland Knall5-68/+59
This code is no longer required, as context menus should be bound to local events. As for "Reloading LUA plugins" - the keyboard shortcut would be able to trigger while the menu is open, except Qt explicitely prevents that Change-Id: Id18a3a17d62bae1ff547a6ef96772e12a2535219 Reviewed-on: https://code.wireshark.org/review/34371 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Make Apply/Prepare filter independentRoland Knall5-22/+84
The context menu should only use information readily available at the point of creation. Copying actions from the mainwindow introduces a bunch of synchronization and consistency issues. This is a first step to move away from a centralized approach of managing actions, towards a distributed approach. As a side effect, this also solves the old issue of having the apply items greyed out in context menu Bug: 16001 Bug: 15323 Change-Id: I10c6df11cbab0a89386f5bf1d27759103df2a012 Reviewed-on: https://code.wireshark.org/review/34370 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26coap: Distinguish observe option for request and responseStig Bjørlykke3-11/+24
The observe option has different values for request and response. For request it identifies register or deregister, and for response it is a sequence number for reordering detection. RFC 7641 chapter 2. Change-Id: I09515864997a32f7259e344532ea770b74030b04 Reviewed-on: https://code.wireshark.org/review/34368 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26coap: Improve request/response trackingStig Bjørlykke2-23/+50
Use both Token and Message ID in request/response tracking and retransmission detection. The token is the same when using observables but the message id is increasing. Change-Id: I545416ce139328e6a8eb67258d7b51bddb6b278e Reviewed-on: https://code.wireshark.org/review/34367 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26Qt: Fix memory leak in ProfileModel constructorTomasz Moń1-0/+1
Change-Id: I4a0ccaebe7ab821a22b86ce1155328fd714caf50 Reviewed-on: https://code.wireshark.org/review/34376 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26Qt: Fix copy from default profileRoland Knall1-1/+1
The default profile was available to be selected, even if it was the active profile. Bug: 16021 Change-Id: If08a563f243f18f32e17cb2169180ec0b1274a9a Reviewed-on: https://code.wireshark.org/review/34366 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26SCTP: Use proto_tree_add_bitmask_list() for data chunk flags.Anders Broman1-11/+18
Change-Id: I9da080982d5ca85cbd3747008cd1f2b3670b6baa Reviewed-on: https://code.wireshark.org/review/34369 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt (zip_helper): Fix Dead StoreAlexis La Goutte1-1/+2
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ib16fc6c0783adda8485056d5e20973cf078e7d7e Reviewed-on: https://code.wireshark.org/review/34321 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-26log3gpp: fix no previous prototype for functionAlexis La Goutte1-0/+6
log3gpp.c:459:10: warning: no previous prototype for function 'log3gpp_dump[|open|finish]' [-Wmissing-prototypes] Change-Id: I1d896f90d91dc04b68b12f48ae06526556a428d4 Reviewed-on: https://code.wireshark.org/review/33963 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: Correct typos in new GDOI fieldsMichael Mann1-3/+3
Change-Id: I29872cb116dfc66c93d59b51a44161e627d3cfec Reviewed-on: https://code.wireshark.org/review/34363 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: added support for GDOIGandharav Katyal1-64/+262
Bug: 15693 Change-Id: I790da95c1fa64596bd5131b491237fa084c0be49 Reviewed-on: https://code.wireshark.org/review/33382 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt: Move CopyFrom from menu to buttonRoland Knall13-97/+126
Move the CopyFromProfile implementation from a menu to a button to ease integration in existing code Change-Id: I4fb4e952e89665eda99d162e891ac6d3516a6f02 Reviewed-on: https://code.wireshark.org/review/34266 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26NFS: Fix hash table key memory corruptionTomasz Moń1-1/+1
When the same (as determined by key_equal_func) key gets added to the GHashTable, old value gets freed and replaced with the new one. This is fine for hash tables where the key validity is not tightly coupled to the actual data. In the nfs_name_snoop_matched hash table the key becomes invalid once the value gets destroyed (because it shares the data pointed to by fh, which gets freed once the value is destroyed). A problematic capture includes packets such that the matching fh gets added twice to the nfs_name_snoop_matched hash table. Prior to this change the hash table would end up in a state where the new value is associated with the old key (which contains pointer to already freed memory). According to the nfs_name_snoop_matched_equal(), the old key was equal to the key intended for new value *at the time* of insertion. This change fixes the bug by using g_hash_table_replace() which does update the key in case it already exists in the GHashTable. Bug: 16017 Bug: 16019 Change-Id: Ib3943f1e27e82c05d9abaa1e436554b37a98488e Reviewed-on: https://code.wireshark.org/review/34360 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26SIP: Ensure session-id is not emptyMichael Mann1-6/+14
Add expert info if session-id is empty. Bug: 15951 Change-Id: I48ffe4ca26fd94f522ad1a668c99ed8f1f5e2c01 Reviewed-on: https://code.wireshark.org/review/34356 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-25show interface name in frame line caption if setMartin Fesser1-1/+8
Change-Id: Ib6cb86bc20dae9f88fdeb469983c2380bcc9216d Reviewed-on: https://code.wireshark.org/review/34335 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-25usb-audio: fix conflictAlexis La Goutte1-3/+3
'usbaudio.as_if_gen.bmFormats.rsv' exists multiple times with NOT compatible types: FT_UINT32 and FT_BOOLEAN Change-Id: I908b815bfa0f96f2ec421367995d971040f423a1 Reviewed-on: https://code.wireshark.org/review/34283 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-26 20:36:41 +0000