aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-03-11Use explicit casts.Anders Broman3-56/+57
svn path=/trunk/; revision=48239
2013-03-11From: Erik Hugne Anders Broman1-13/+4
tipc: update link header according to spec The bcastsequence gap have been removed, and the sequence field is now 13 bits. svn path=/trunk/; revision=48238
2013-03-11"Capture ! Options ! Manage Interfaces": Cleanup handling of Window epansion.Bill Meier1-15/+17
Improves 'expand' handling for both Gtk2 & Gtk3; Adapted (with additions by me) from a proposed patch by Peter Hatina (Bug #8315). Also: 1. Don't use gtk_widget_set_size() in several cases when a single use of gtk_window_set_default_size() for the "Manage Interfaces" window is sufficient. 2. Add an XXX comment as to a specific call to 'gtk_window_destroy_with_parent' actually being a no-op on Windows. svn path=/trunk/; revision=48237
2013-03-10Allocate zeroed memory instead of manually zeroing some of the fields. We wereEvan Huus1-5/+14
missing a few anyways. Fixes the rest of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8456 Also, add modelines. svn path=/trunk/; revision=48236
2013-03-10Use col_append_sep_str instead of col_set_str. Fixes another piece ofEvan Huus1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8456 Fix suggested by Jakub in comment #5. svn path=/trunk/; revision=48235
2013-03-10Off by one error in name length.Anders Broman1-1/+1
svn path=/trunk/; revision=48234
2013-03-10r30032 again, actually make emem_verify_pointer() works with glib chunks.Jakub Zawadzki1-2/+2
after allocating glib chunk, amount_free should be 0, and free_offset should be set to chunk size. svn path=/trunk/; revision=48233
2013-03-10Use explicit casts.Anders Broman5-65/+63
svn path=/trunk/; revision=48232
2013-03-10Actually remove slab.h from the makefile.Evan Huus1-1/+0
svn path=/trunk/; revision=48231
2013-03-10Update usage info for valgrind script. We almost need a proper man page forEvan Huus1-1/+1
this now. svn path=/trunk/; revision=48230
2013-03-10Glib docs recommend using the slice API if you know you won't need to realloc.Evan Huus3-14/+14
svn path=/trunk/; revision=48228
2013-03-10Remove slab.h and replace its last remaining usage with glib slices.Evan Huus4-93/+3
Take the opportunity to deduplicate some code that was common to both an if block and its else block. svn path=/trunk/; revision=48227
2013-03-10[Automatic manuf, services and enterprise-numbers update for 2013-03-10]Gerald Combs3-8/+151
svn path=/trunk/; revision=48225
2013-03-10Add two missing NULL checks, fixes most ofEvan Huus1-14/+31
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8456 svn path=/trunk/; revision=48224
2013-03-10Make the memory limit (in bytes or packets) used for storing packetsMichael Tüxen2-20/+55
configurable via command line options and print specific drop numbers at the end. This allows to tune the buffering when using multiple threads. This also fixes a logic arrow in enforcing the limits. The patch for the enhanced counters is from Anders Broman. svn path=/trunk/; revision=48223
2013-03-10Only cast the variable after checking it.Michael Tüxen1-3/+3
svn path=/trunk/; revision=48222
2013-03-10Add -t to synopsis.Michael Tüxen1-0/+1
svn path=/trunk/; revision=48221
2013-03-09Add the appropriate new WS_DLL_* declarations to the wmem API.Evan Huus5-0/+29
svn path=/trunk/; revision=48220
2013-03-09Remove the wmem slab. It was an optimization mimicking the emem slabEvan Huus10-221/+7
(removed in r48218) which did nothing particularly useful. Also lets us remove another debugging environment variable. svn path=/trunk/; revision=48219
2013-03-09Remove the emem slab feature (sl_* functions) completely, replacing it withEvan Huus6-151/+8
glib memory slices. - We weren't doing anything with the emem slab that couldn't be done with glib slices. - Removes a fair bit of code as well as one debugging environment variable. - Glib slices are much cache-friendlier and are multi-threading friendly (if we ever go there). - Allows glib to actually return slices to the OS on occasion. The emem slab would hold onto its memory forever which resulted in a great deal of wasted memory after closing a large file. svn path=/trunk/; revision=48218
2013-03-09Use explicit casts.Anders Broman10-90/+90
svn path=/trunk/; revision=48217
2013-03-09[NPL] Misc fixesJakub Zawadzki4-100/+391
svn path=/trunk/; revision=48216
2013-03-09From Thomas Wiens via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8455Evan Huus1-1/+1
Don't add an extra 16 to offset, we've been updating it as we go. Fixes cases where valid AMS packets were marked as malformed. svn path=/trunk/; revision=48215
2013-03-09Two instances of s/delete/delete_id/ to satisfy C++ that were missed inEvan Huus1-2/+2
r48212 and were causing build failures. svn path=/trunk/; revision=48214
2013-03-09Update lex and yaccAnders Broman2-4/+4
svn path=/trunk/; revision=48213
2013-03-09Use explicit casts.Anders Broman9-57/+57
svn path=/trunk/; revision=48212
2013-03-09Make checkAPIs HappyAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48211
2013-03-09From Jose Pico via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8377 ↵Alexis La Goutte8-457/+984
NEW FEATURE IMPLEMENTED: SMB2 SUPPORT FOR EXPORT->OBJECTS->SMB Added functionality: - SMB2 support for Export->Objects->SMB - support for SMB_COM_CREATE, SMB_COM_OPEN, SMB_COM_READ and SMB_COM_WRITE commands - Ability to choose between File Id and full file name as identifier for file re-building. Implemented as an option under Edit->Preferences->Protocols->SMB and Edit->Preferences->Protocols->SMB2. Other minor changes and fixes: - Full filename in file - Inclusion of IP of SMB server when treeid name (i.e. hostname) is not known - UTF-8 filenames encoding before passing them to Export Object Window - Re-written insert_chunk function of export_object_smb.c to make it easier to debug - Fixed of an error in insert_chunk function of export_object_smb.c (the verification of next free_chunk was always skipped after deleting one free_chunk). - Removed duplicated code by inserting the function feed_eo_smb in packet-smb.c and packet-smb2.c - Changed the label of Export->Objects->SMB menu into Export->Objects->SMB/SMB2 svn path=/trunk/; revision=48210
2013-03-09Put items in the tree we just created, mark an unused param as _U_.Evan Huus1-2/+2
Fixes GCC build. svn path=/trunk/; revision=48209
2013-03-09Update URLs to specs.Jeff Morriss1-3/+4
svn path=/trunk/; revision=48208
2013-03-09Switch to WinPcap 4.1.3.Gerald Combs5-6/+8
svn path=/trunk/; revision=48207
2013-03-09RTPS Cleanup, Part 2Michael Mann4-3814/+1167
1. Convert more proto_tree_add_text to proto_tree_add_<something else>/expert_info. checkAPIs.pl is happy (for packet-rtps.c), but the raw number is a bit deceiving because of macros and wrappers. 2. Fixed the offending "uses snprintf + strlen to assemble strings" in packet-rtps.c. The exact same code is used in packet-rtps2.c, so just proper refactoring will fix it. There is still too much unnecessary use of g_snprintf/g_strlcpy/strlen, but that's for a later date. 3. Removed most of the "useless" wrapper functions. Again, the number of proto_tree_add_text is deceiving, so the number of hfs that really need to be created is much larger. 4. Whitespace cleanup. Removed a lot of whitespace so I could see more code on the screen, to help determine duplication between packet-rtps.c and packet-rtps2.c Comments/descriptions of fields remain untouched. The more I trim, the more I think this should all be in a single dissector file, which will be the goal of the next update. Trying to patch this in somewhat manageable chunks. Also need to submit sample traces generated for (fuzz)testing. svn path=/trunk/; revision=48206
2013-03-09From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8414Evan Huus1-1/+1
Fix minor cut-and-paste error in USB-Video dissector caught by cppcheck. svn path=/trunk/; revision=48205
2013-03-08freekdesktop.org says all themes must fall back to 'hicolor' if they don't findJeff Morriss2-21/+21
a theme-specific icon (and as such hicolor is where applications should install their icons). So: don't install some of our icons in the gnome area, install them all in hicolor. While we're at it, go ahead and install all the icon sizes we have. If we're on SuSE, use their desktop-file-updater macro; without that they won't recognize our desktop file. Fix bug which prevented the MIME database from being updated if our install prefix is not /usr . svn path=/trunk/; revision=48204
2013-03-08The Icon is not supposed to have an extension; remove it.Jeff Morriss1-1/+1
svn path=/trunk/; revision=48203
2013-03-08Use explicit casts.Anders Broman3-74/+74
svn path=/trunk/; revision=48202
2013-03-08Dissect the DCCP header by stepping through it a field at a time andGuy Harris1-170/+162
adding the fields to the protocol tree as we fetch them, rather than fetching a bunch of them up front. That way, if the packet was cut short by a snapshot length, we'll dissect what we have. Create the top-level tree item at the beginning, with an unknown length, and set the length when we're done. If we're putting details into that item, update the item as we process each field; also update the Info column as we process each field. Don't use tvb_bytes_exist() to do our own tvbuff bounds-checking; let the tvbuffs themselves do that. Do not use it to do header-length checking; check the actual header length value instead. Do not fail if the *captured* data in the tvbuff is too short; we're selected by an IP protocol number, which we can expect to definitively identify us, not by a transport-layer port number, which is often an unreliable identifier. Do header length checks as we go along, and bail as soon as we identify the header length as wrong. (We do the first check once we get the X bit, so we know whether the generic header is 12 or 16 bytes long.) Treat a too-*large* header as a protocol violation, not a malformed packet indication. Use tvb_get_ntoh24() and tvb_get_ntoh48() to fetch the sequence number, rather than fetching it in pieces and putting them together ourselves. Correctly pluralize "byte". Don't use tvb_length_remaining() to check whether we have a payload, use tvb_reported_length_remaining(), so we base it on whether the packet actually had the data, not on whether we actually captured it. svn path=/trunk/; revision=48201
2013-03-08Add a debug function (ifdef'ed out by default) and fix another two bugs found byEvan Huus1-1/+56
reading it's output. svn path=/trunk/; revision=48198
2013-03-08Add another pair of assertions.Evan Huus1-0/+2
svn path=/trunk/; revision=48197
2013-03-08Add /SD defaults to every MessageBox call (even if they're commentedGerald Combs3-8/+8
out). Fixes bug 8451. Don't yell at the user so much. svn path=/trunk/; revision=48196
2013-03-08Update to V11.5.0 (2012-12).Anders Broman25-167/+996
svn path=/trunk/; revision=48195
2013-03-08Use only simple allocators until I can work out the kinks with the blockEvan Huus1-2/+2
allocator. svn path=/trunk/; revision=48194
2013-03-08Should fix assertion failure seen by Anders on -dev.Evan Huus1-1/+17
https://www.wireshark.org/lists/wireshark-dev/201303/msg00081.html svn path=/trunk/; revision=48193
2013-03-08Add new SIP headers.Anders Broman1-278/+343
svn path=/trunk/; revision=48192
2013-03-08Switch to c-ares 1.9.1.Gerald Combs4-4/+5
svn path=/trunk/; revision=48191
2013-03-08From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8414Evan Huus3-0/+3253
Dissector for USBVIDEO. svn path=/trunk/; revision=48190
2013-03-08Don't try to show an IP address if none is present.Irene Rüngeler2-24/+30
svn path=/trunk/; revision=48189
2013-03-08Prettify a bit dissection of sr-ProhibitTimer-r9 and drxShortCycleTimerPascal Quantin2-8/+18
svn path=/trunk/; revision=48188
2013-03-08Use explicit casts.Anders Broman3-40/+37
svn path=/trunk/; revision=48187
2013-03-08Use explicit casts.Anders Broman4-56/+56
svn path=/trunk/; revision=48186