aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-10-02LBMSRS: Break out of a loop.Gerald Combs1-1/+1
Break out of a loop if our offset advances. Fixes #16886.
2020-10-02Qt: point to Lua wiki page now on GitlabChuck Craft1-1/+1
2020-10-02QUIC: fix dissection of Short Header packets with Grease QUIC bitPeter Wu1-1/+1
The condition aimed to avoid interpreting padding bytes after the Initial Packet as Short Header to avoid breaking decryption. However it also prevents actual Short Header packets from being matched that have the QUIC bit cleared. To avoid breaking the latter, strengthen the condition to match the former only. Tested with quic-31_grease_quic_bit__with_keys.pcapng (from !429). Regression tested against a private Firefox Nightly trace.
2020-10-02TECMP: Adding CAS flag for FlexRayDr. Lars Völker1-0/+5
This adds the CAS (Collision Avoidance Symbol) to the TECMP dissector. Signed-off-by: Dr. Lars Völker <lars.voelker@technica-engineering.de>
2020-10-01Version: 3.3.1 → 3.3.2.Gerald Combs4-3/+7
2020-10-01Build: 3.3.1.Gerald Combs4-14/+128
2020-10-01EAP: Fix Dead StoreAlexis La Goutte1-4/+10
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-10-01Qt: Use … instead of UTF8_HORIZONTAL_ELLIPSIS in translated strings.Gerald Combs33-70/+70
Run $ gsed -i -e 's/\(tr *(.*".*\)" *UTF8_HORIZONTAL_ELLIPSIS/\1…"/' $( ag -l 'tr *\(.*" *UTF8_HORIZONTAL_ELLIPSIS' ) $ gsed -i -e 's/\(tr *( *\)UTF8_HORIZONTAL_ELLIPSIS *"/\1"…/' $( ag -l 'tr *\( *UTF8_HORIZONTAL_ELLIPSIS *"' ) in ui/qt. As discussed in #16812, the UTF8_ macros were required at one time because we only allowed ASCII in our source code. However, that requirement has since been relaxed and Qt's translation framework doesn't handle concatenating strings and macros very well.
2020-10-01http: don't try to dissect zero-length bodiesRonnie Sahlberg1-0/+3
Closes #16844 Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
2020-09-30github: fix macOS build.Dario Lombardo1-0/+4
Use xcode from command line tools. See: https://www.wireshark.org/lists/wireshark-dev/202004/msg00065.html
2020-09-30Tools: Handle leading "#"s in gen-bugnote.Gerald Combs1-1/+1
GitLab's version of Markdown denotes issue IDs with a leading "#".
2020-09-30Docs: Note that you can group filter buttons.Gerald Combs2-2/+10
Note that you can group filter buttons in the release notes and in the filter toolbar docs.
2020-09-30GTPv1: Highlight only the value part of "TEID Control Plane"Anders Broman1-5/+2
While at it use proto_tree_add_item_ret_uint(). Closes #16881
2020-09-29lithionics: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-09-29dcerpc: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-09-29gtp: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-09-29mbim: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-09-29smb2: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-09-29RTCP: Add dissection of Application mccp TS 24.380Anders Broman3-24/+240
2020-09-29SMB2: add reasonable upper limit to pattern_v1 repetitionAurelien Aptel1-1/+1
MAX_UNCOMPRESSED_SIZE is currently 16MiB. Fix Coverity report CID 1467509: Insecure data handling (TAINTED_SCALAR) Using tainted variable "times" as a loop boundary.
2020-09-29Remove leftover cruft from previous comment.Guy Harris1-1/+0
2020-09-28Qt: Handle palette changes in the packet diagram.Gerald Combs2-14/+37
Handle ApplicationPaletteChange (e.g. dark / light mode switching) events in the packet diagram. Add resetScene() and call it where needed.
2020-09-28IEEE 802.11: Use common filter string for action_codeMartin Mathieson1-1/+1
For radio measurements, use same filter string as most others, i.e. wlan.fixed.action_code.
2020-09-28quic: fix reassembly issue for smb2 (and other protocols)Ronnie Sahlberg1-3/+19
If we did not find an msp that matched the current segment we would try to find the msp for set-1 instead. This will only work IFF we do not know the the exact size of the PDU and where it ends, i.e. DESEGMENT_ONE_MORE_SEGMENT and friends. In the case where "get msp for seq-1" gives us an msp where we know the exact PDU boundary and the current seq is beyond the end of that boundary, then we should not use the msp for seq-1 but instead treat this as a brand new PDU. This fixes issues with SMB2-over-QUIC dissection that can be seen in the sample capture for the "add smb2-over-quic" bug where only the first multi-segment PDU would be dissected correctly for each direction. Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
2020-09-28Add some more string encodings.Guy Harris15-174/+358
Add an encoding for "unpacked" 3GPP TS 23.038 7-bit strings, in which each code position is in a byte of its own, rather than with the code positions packed into 7 bits. Rename the packed encoding to explicitly indicate that it's packed. Add an encoding for ETSI TS 102 221 Annex A strings. Use the new encodings.
2020-09-28Qt: Make sure the packet diagram always has a field value.Gerald Combs1-0/+4
Have FieldInformation::toString return "[no value for field]" instead of an empty string so that the packet diagram always has something to display.
2020-09-28Fix some more wrong filter names.Martin Mathieson24-31/+31
These are duplicates detected seen by running check_typed_item_calls.py --consecutive. There are still quite a few more to go.
2020-09-28extract_asn1_from_spec.pl: add version into exported asn fileTom Yan1-0/+4
2020-09-28QUIC: update to draft-31Nardi Ivan1-4/+5
2020-09-28Add Metaswitch vendor-specific AVPs for DiameterBen Bass3-0/+87
2020-09-28check_typed_item_calls.py: add --consecutive flagMartin Mathieson3-16/+59
Add a check to point out where consecutive items have the same filter but different labels. Quite a few of these look like bugs. Also, make some REs raw strings, as identified as an issue in https://gitlab.com/wireshark/wireshark/-/merge_requests/346
2020-09-28Release notes: Add an item about Npcap 1.00.Gerald Combs1-0/+2
2020-09-27Add /*build*/ to .gitignoreJeff Widman1-1/+1
A common pattern is to build the source artifacts within a *build* dir. For example, the wiki instructions for [building `wireshark` on `macOS` specify to create a `./build` directory](https://gitlab.com/wireshark/wireshark/-/wikis/BuildingAndInstalling#macos): ``` mkdir build && cd build && cmake ../ && make ``` So this commit adds this directory to `.gitignore` to prevent accidentally committing build artifacts. The specific format `/*build*/` protects against the following: 1. The leading slash makes sure only top-level directories that match this pattern are ignored. 2. The trailing slash makes sure that only directories (and not files) are ignored. 3. The wildcards catch all the various variations on `build` folder name that are used...
2020-09-27Fix some wrong filter names.Martin Mathieson19-26/+26
These were detected by running check_typed_item_calls.py with --consecutive, which flags items that have different labels but the same filter string. Usually this is because of copy/paste. Quite a few similar bugs still exist, will address in a future commit.
2020-09-27[Automatic update for 2020-09-27]Gerald Combs5-17/+145
Update manuf, services enterprise numbers, translations, and other items.
2020-09-27Windows: upgrade Npcap to 1.00Pascal Quantin2-5/+5
2020-09-26Qt: Fix the packet diagram start offset arithmetic.Gerald Combs1-14/+8
572c1ae5a3 introduced a bug that allowed for negative diagram item start values. Fixup our arithmetic so that that doesn't happen.
2020-09-26Qt: Reset the packet diagram between captures.Gerald Combs1-1/+15
QGraphicsScene::clear() doesn't reset the scene's the size and scroll position. This is useful when we switch between packets, but we should do a hard reset when switching between captures.
2020-09-26Fix issues discovered by common python lintersJeff Widman22-243/+262
Fix some issues discovered by common python linters including: * switch `None` comparisons to use `is` rather than `==`. Identity != equality, and I've spent 40+ hours before tracking down a subtle bug caused by exactly this issue. Note that this may introduce a problem if one of the scripts is depending on this behavior, in which case the comparison should be changed to `True`/`False` rather than `None`. * Use `except Exception:` as bare `except:` statements have been discouraged for years. Ideally for some of these we'd examine if there were specific exceptions that should be caught, but for now I simply caught all. Again, this could introduce very subtle behavioral changes under Python 2, but IIUC, that was all fixed in Python 3, so safe to move to `except Exception:`. * Use more idiomatic `if not x in y`--> `if x not in y` * Use more idiomatic 2 blank lines. I only did this at the beginning, until I realized how overwhelming this was going to be to apply, then I stopped. * Add a TODO where an undefined function name is called, so will fail whenever that code is run. * Add more idiomatic spacing around `:`. This is also only partially cleaned up, as I gave up when I saw how `asn2wrs.py` was clearly infatuated with the construct. * Various other small cleanups, removed some trailing whitespace and improper indentation that wasn't a multiple of 4, etc. There is still _much_ to do, but I haven't been heavily involved with this project before, so thought this was a sufficient amount to put up and see what the feedback is. Linters that I have enabled which highlighted some of these issues include: * `pylint` * `flake8` * `pycodestyle`
2020-09-26SMB2: add tests for chained compression and pattern_v1Aurelien Aptel2-0/+16
2020-09-26SMB2: add new pattern_v1 decompression supportAurelien Aptel1-0/+66
Simple decompression algorithm that encodes a single byte and the number of times it is repeated. This algorithm can only be used in chained compression packets.
2020-09-26SMB2: handle chained compressionAurelien Aptel1-16/+163
The compression header "reserved" field is now a flags field. If the flags have the CHAINED bit, the meaning of the offset field changes and becomes a length field. "old" compressed method: [COMPRESS_TRANSFORM_HEADER with Flags=0] [OPTIONAL UNCOMPRESSED DATA] [COMPRESSED DATA] new "chained" compressed method: [fist 8 bytes of COMPRESS_TRANSFORM_HEADER with Flags=CHAINED] [ sequence of [ COMPRESSION_PAYLOAD_HEADER ] [ COMPRESSED PAYLOAD ]
2020-09-26SMB2: stick the compress header items under the header treeAurelien Aptel1-3/+3
This makes it behave like the other headers.
2020-09-26SMB2: label decompressed data as such and mark as generatedAurelien Aptel1-2/+6
2020-09-25Fix some more doc folder spelling errors.Martin Mathieson4-11/+11
2020-09-25README.developer: Fix some quotation marks around function namesThomas Vogt1-2/+2
2020-09-25SDAP: Show presence in configuration, and summary in root.Martin Mathieson1-4/+29
2020-09-25extract_asn1_from_spec.pl : fix export of S1APTom Yan1-2/+10
2020-09-25Qt: Collapse packet diagram items correctly.Gerald Combs1-35/+45
Move our overlap and gap adjustments to the first pass and offset our item start bits based on our collapsed length. Collapse 64-bit items correctly.
2020-09-24docbook: Fix wiki links.Gerald Combs1-1/+1
Add a trailing slash to the wireshark-wiki-url macro. Fixes #16871.
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-09 16:22:04 +0000