aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-03-20NAS 5GS: improve dissection of SUCIPascal Quantin1-8/+42
- a SUCI with null scheme is always a MSIN, name it accordingly - add breakout of scheme output for profiles A and B Change-Id: I3453336291cbd515809054057a6e53902590e896 Reviewed-on: https://code.wireshark.org/review/36514 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-20couchbase: Add new DCP commandsJim Walker1-0/+50
Add support for: * DCP seqno advanced * DCP oso snapshot Change-Id: I6461ac3d1a16829e36e5c259a50943ef254b197d Reviewed-on: https://code.wireshark.org/review/36506 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-20gsmtap: Support dissection of non CS-1 (E)GPRS data blocksPau Espin Pedrol1-1/+217
Work based on current code from epan/dissectors/packet-gsm_abis_pgsl.c, as well as on initial patch from Holger Hans Peter Freyther [1]. Tested with one downlink MCS1 data block generated by osmo-pcu. [1] https://osmocom.org/issues/1542 Change-Id: I01a8bd1cdb78d1c236a451fbee37854eb688fa14 Reviewed-on: https://code.wireshark.org/review/36489 Reviewed-by: Harald Welte <laforge@gnumonks.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-20CMake: FindGLIB2 depends on FindWSLibrary modulePaul Aurich1-0/+1
Beginning in Wireshark 3.2, the FindGLIB2 cmake module depends on FindWSLibrary (see 990e409273b), so FindWSLibrary needs to be installed as well, or attempting to build an out-of-tree plugin fails. Simple example CMakeLists.txt: cmake_minimum_required(VERSION 2.8) project(myplugin) find_package(Wireshark) LIST(APPEND CMAKE_MODULE_PATH "${Wireshark_LIB_DIR}/wireshark/cmake") find_package(GLIB2) Fails: -- Checking for one of the modules 'glib-2.0' CMake Error at /usr/local/lib/wireshark/cmake/FindGLIB2.cmake:49 (include): include could not find load file: FindWSLibrary Call Stack (most recent call first): CMakeLists.txt:5 (find_package) CMake Error at /usr/local/lib/wireshark/cmake/FindGLIB2.cmake:50 (FindWSLibrary): Unknown CMake command "FindWSLibrary". Call Stack (most recent call first): CMakeLists.txt:5 (find_package) -- Configuring incomplete, errors occurred! Change-Id: Id765d671e74fe15a60add38b95e62536abf60a79 Reviewed-on: https://code.wireshark.org/review/36509 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-19Windows: upgrade Npcap to 0.9989Pascal Quantin2-5/+5
Change-Id: I33b58029d2017cda090a55960089b048de7f9224 Reviewed-on: https://code.wireshark.org/review/36508 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-19SOMEIP: SD did not register port for IPv6 correctly (bugfix)Dr. Lars Völker1-3/+4
SOME/IP-SD did not register a port learned correctly, so that packets with this port number were not dissected. Bug: 16448 Change-Id: Ic648a50bf08dcab65c49182e08257cf6660261a5 Signed-off-by: Dr. Lars Völker <lars.voelker@technica-engineering.de> Reviewed-on: https://code.wireshark.org/review/36503 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-19s_addr -> src_addr, d_addr -> dst_addr.Guy Harris1-37/+37
On at least some platforms (at least some versions of the Windows SDK, and netinet/in.h on Illumos and thus possibly Solaris, and possibly others), struct in_addr's only member is a union, with some members of the union being substructures with fields corresponding to the pre-CIDR parts of an IPv4 address, with s_addr #defined to be the member of the union corresponding to the IPv4 address as a 32-bit integral value. That's presumably maintained for source compatibility with really old programs written before CIDR, on platforms where they worry about that. The *BSDs don't care, and macOS came out post-CIDR and never supportede the pre-CIDR code in the first place, so they don't do that; the same probably applies to Linux. This causes problems when s_addr is used as a variable name. In addition, inside Wireshark we tend to use "src" rather than just "s" as a prefix to refer to source addresses and ports - and "dst" or "dest" rather than just "d" as a prefix to refer to destination addresses and ports. So just go with that. Change-Id: I6010d5ea9697d2333597c06756fa393a5898364e Reviewed-on: https://code.wireshark.org/review/36504 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-19NR RRC: fix dissection of q-RxLevMin parameterPascal Quantin2-6/+10
Change-Id: Ia8aa965e19d7ad55d7197cb636b203140abfba5b Reviewed-on: https://code.wireshark.org/review/36501 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-19RTPS: hf_rtps_nokey_data_frag_number is FT_UINT32John Thacker1-3/+3
In (deprecated) NOKEY_DATA_FRAG, the frag_number field is a uint32 so ret_uint should be used, etc. Fixing to be like DATA_FRAG. Change-Id: I75848dfbde114cf6e4bdc6864d0690a75ca58d1d Reviewed-on: https://code.wireshark.org/review/36500 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-03-19CMake: fix detection of Lua development packagePascal Quantin1-3/+3
See https://www.wireshark.org/lists/wireshark-dev/202003/msg00054.html Change-Id: I10a854a4dcd5320fce8ca3e6ff5722225c56c5d9 Reviewed-on: https://code.wireshark.org/review/36494 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-19packet-kerberos: split out a decrypt_krb5_data_asn1() helper functionStefan Metzmacher2-43/+63
If decrypt_krb5_data_private() is available we use it directly in order to pass down kerberos_private_data_t. Change-Id: I864d3e7d9adda454c96384d7b146ec774cd05d5f Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36491 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-19packet-kerberos: split out a decrypt_krb5_data_private() functionStefan Metzmacher2-19/+61
This allows passing 'kerberos_private_data_t' down to used_encryption_key(). This will be used in order to implement Kerberos FAST decryption. For now we'll pass a zeroed kerberos_private_data_t, but in future code can use decrypt_krb5_data_private() directly and pass in the result of kerberos_get_private_data(actx). Change-Id: Iffdd3c3168eca3ed90cfa0a924248df9fac98a0c Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36490 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18travis: remove redundant jobs, update to xcode11.3Peter Wu1-43/+2
* Remove amd64+gcc-8 NOPCAP in favor of the faster clang NOPCAP. GitLab CI builds showed that both builds would catch the same issues. * Remove NOPCAP macOS, it is very uncommon so do not waste cycles on it. * Remove amd64+gcc-8 as amd64+gcc-9 covers the same plus more. * Remove unnecessary PPA, gcc-8 is included with bionic by default. * Remove Xcode10.3 build to save resources. * Update Xcode11.2 to the latest Xcode11.3, no compiler changes. Change-Id: Iddaa20b865fe16380844f266fc68d394f979a14c Reviewed-on: https://code.wireshark.org/review/36478 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-18packet-kerberos: rename some generated fields to avoid name conflictsStefan Metzmacher2-41/+44
The following changes would otherwise create conflicts. Change-Id: I80bf9270aa1bdc1b92602ef68c9bfbf2b2b7ee37 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36471 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect PA_REQ_ENC_PA_REPStefan Metzmacher3-24/+33
Change-Id: Ib0adf5a74e0872c6fc84dbd1dae27d0622f797ef Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36470 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect new RFC6113 errors messagesStefan Metzmacher3-30/+56
Change-Id: I2b95bc257762cc8734386171da1bf574220c4530 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36469 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: remove unused line '#EncryptedData/etype encryptedData_etype'Stefan Metzmacher2-33/+32
Change-Id: I544e22bfd7977021bd40b88df8bd549201f97a36 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36468 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect names of new PAC_* typesStefan Metzmacher2-18/+120
For now we don't dissect the details, but it's already useful, if they are not unknown elements. Change-Id: I38b521262b688ba0afbbb9c58b99c3b50dbd2b24 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36467 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: Encrypted{AuthorizationData,Authenticator} are not the sameStefan Metzmacher4-42/+173
We need to dissect them differently... Change-Id: Idb6d65800b1787b9cb6fca2630373547b9b7b1bc Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36466 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: we only need PA-PAC-REQUEST onceStefan Metzmacher4-74/+68
Change-Id: I6c3d3810456d30877802fbd5d8d8ee64df2417f7 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36465 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: decrypt PAC_CREDENTIAL_INFO from [MS-PAC]Stefan Metzmacher2-32/+154
In future we could further dissect the details, but seeing the decrypted bytes is already very useful. Change-Id: Id03664513e66b089e2815140a061ec90b9a49232 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36464 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect AD_GSS_API_ETYPE_NEGOTIATIONStefan Metzmacher3-13/+21
Change-Id: Ic4f0e92847151c467f7cc5fca3495e51586d8fd8 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36463 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect AD_TARGET_PRINCIPAL from [MS-KILE]Stefan Metzmacher3-13/+65
This is not yet within [MS-KILE], but I'll dochelp@microsoft.com to document this in the next version. Change-Id: Ie7017fe31125edc0315653c13831373ac3e67be8 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36462 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18NAS-5GS: PDU session reactivation result error cause wrong PDU typeJoakim Karlsson1-1/+1
Change-Id: I14552a44ef5d7dc4557d7a7ea4624c6f5299f5fa Reviewed-on: https://code.wireshark.org/review/36488 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect AD_AP_OPTIONS from [MS-KILE]Stefan Metzmacher3-13/+85
Change-Id: Ic0c69dab9db66c967741a82cb25d2c9fe19137ce Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36461 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect KERB-AD-RESTRICTION-ENTRY from [MS-KILE]Stefan Metzmacher4-13/+65
Change-Id: Ib5b000927343e091ada10caf786d7af5277455b6 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36460 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect PA_SUPPORTED_ENCTYPES from [MS-KILE]Stefan Metzmacher3-29/+183
Change-Id: I20e09b33ef7a15dd5f5faa4e224de459f0040309 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36459 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18Added RDMnet protocolJimSchaettle2-2932/+9252
Transmit RDM packet over Ethernet using ACN protocol. http://rdmprotocol.org/rdm/rdmnet/ Change-Id: I5bc1819e05b0d7a3c207b57cf2d86dc08aa9d1c3 Reviewed-on: https://code.wireshark.org/review/36194 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: dissect PA_ENC_TIMESTAMP messagesStefan Metzmacher3-40/+68
Change-Id: I4a2ec6793f6a85f46455bcbfdbcca746d00ad883 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36458 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: add more AUTHDATA-TYPE values and generate AUTHDATA_TYPE_valsStefan Metzmacher5-160/+106
The new AUTHDATA-TYPE values are from RFC6113 and MS-KILE. Change-Id: I269e498f6d0e7f707b5c45fab848114b2d57df03 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36457 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-{kerberos,pkinit}: Add support for Windows based PKINITStefan Metzmacher10-54/+278
Change-Id: I472884ed84f7d630aede5a2bb65e87c5ad1e76a4 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36456 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: more PADATA-TYPE values/generate kerberos_PADATA_TYPE_valsStefan Metzmacher4-388/+265
The new PADATA-TYPE values taken from rfc6113.txt Change-Id: I42e50996c5694c34fc4714189b2e004bbbd501cf Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36453 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: always remember the toplevel msg_type in MESSAGE-TYPEStefan Metzmacher2-75/+40
This will be useful in the following commits. In the end there will be some recursion when dissecting FAST messages and we'll need to know if the toplevel message. Change-Id: I20f7ea81a8328c422785a44e3647ae2f749b89cc Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36455 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18packet-kerberos: avoid using actx->private_data for two different thingsStefan Metzmacher3-20/+32
Let's always use kerberos_private_data_t and give it a pointer to the optional callbacks. Change-Id: I521bc62b98a5294ae7c307a47b64d2bd117a810e Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36473 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-18Add support for more monitor opcodes.Guy Harris1-19/+351
Support more of what current Linux kernels generate. We don't yet dissect control event payloads. While we're at it: Opcodes are defined in the kernel source in decimal; define and show them as decimal. Use #defines for a bunch of enumerated values, such as opcodes Show the opcode's numerical value in the Info column if it's not one we know about. Change-Id: I915981a46d1a4a544a5e036e69d9a9de8cb8cb30 Reviewed-on: https://code.wireshark.org/review/36487 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-17f5ethtrailer: Add support for version 4 of low noise trailerJason Cohen1-64/+203
Change-Id: Ibdcfdd675f5c1e86b15f36f9a6c28b73e13c1616 Reviewed-on: https://code.wireshark.org/review/36480 Reviewed-by: Jason Cohen <kryojenik2@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-17CIP Safety: Change MacID to NodeIDDylan Ulis2-51/+52
This matches the wording in the Spec. Change-Id: I566da78e88ff5aaa832c657dd74b5c590ee6b4aa Reviewed-on: https://code.wireshark.org/review/36479 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-17rtcp: extend mantissa and bitrate to 64 bit.Dario Lombardo1-3/+3
This is required to allow the maximum valid exponent (63) to be used. Bug: 16445 Change-Id: I1473cebbe74a59785f03a882e3bc1af4b881d444 Reviewed-on: https://code.wireshark.org/review/36451 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-16wslua: Fix crash on TvbRange:__tostring for a zero-length TVBMoshe Kaplan2-4/+9
Fields such as 'frame.time_delta' have no byte selection, they are added with offset 0 and length 0, and evidently 'ws_tvb' is NULL. As tvb_bytes_to_str expects a non-NULL tvb, explicitly check for this and add a dummy placeholder. This is intended to be a human-readable string, so prefer `<EMPTY>` over an empty string. Change-Id: I32efe4cbefc6bcf0fa9fb94fcf25d7bf1628f3a7 Reviewed-on: https://code.wireshark.org/review/36440 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-16tools: do not install doxygenPeter Wu5-5/+1
Most people will never generate API documentation by running the 'wsar_html' target and will not notice any feature degradation. On Ubuntu 18.04, doxygen depends on libclang1-6.0 (and indirectly libllvm6.0), 108M can be saved by not installing these. Change-Id: I51b58f4106696b5475c48afcdaed256f9a97cc81 Reviewed-on: https://code.wireshark.org/review/36416 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-16packet-dcerpc-netlogon: dissect and verify NETWORK_LOGON messagesStefan Metzmacher1-105/+211
We try to dissect the NTLMv2 blob and verify the nthash against our keytab. Change-Id: Ia33e91bcd89f72e7468f61756f0eafe9df92356d Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36406 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-16packet-dcerpc-netlogon: remove unused '#ifdef HAVE_KERBEROS'Stefan Metzmacher1-9/+1
get_md4pass_list() is always available, it just returns 0 if HAVE_KERBEROS is not available. Change-Id: I7fd8613b48c5b02f8693fa6ee15f5f38ed10643e Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/36447 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2020-03-16Fix reporting of interface-list-fetching errors.Guy Harris1-8/+25
If the attempt to fetch the list of local interfaces failed, the model will be empty, so "model is empty" doesn't imply "no interfaces found". First, check whether there was an error, and report the error string; otherwise, if the list is empty, report "No interfaces found." (and fix the capitalization while we're at it) and, otherwise, return an empty string. Also, if pcap support wasn't configured in at compile time, skip all that, and just return a string indicating that. Change-Id: I498226888272e1bdede2355cc902f8a74b0cce72 Reviewed-on: https://code.wireshark.org/review/36446 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-16Qt: Improve tcptrace graph drag responsivenessTomasz Moń2-3/+32
Subclass QCPErrorBars with implementation that never accepts clicks. This prevents a lot of square root computations in QCustomPlot mousePressEvent handle and results in usable tcptrace graph. An alternative solution to the poor performance problem could be using QCP::srmCustom SelectionRectMode. I don't know how to implement graph drag with QCP::srmCustom, and thus I went with simple subclass approach. Bug: 16281 Change-Id: Id4178e59bdbd2222db4669d0635ff741ebde839f Reviewed-on: https://code.wireshark.org/review/36413 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-15capture-wpcap: gracefully exit when has_wpcap is false.Dario Lombardo1-10/+17
Fix rawshark crash. Bug: 16442 Change-Id: Id65f160d86a4ab204eedd1369e3ed9fa36f9c9e0 Reviewed-on: https://code.wireshark.org/review/36445 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15Remove unwanted newline.Guy Harris1-1/+1
The error message is included in parentheses as part of a larger error message, so you don't want a newline at the end. Change-Id: Iabff74941972504770c45b94b124e25d124b512c Reviewed-on: https://code.wireshark.org/review/36441 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15USB HID: add missing usage pagesFilipe Laíns1-28/+850
- Haptics - Eye and Head Tracker - Sensor - Brailie Display - Lighting and Illumination - Gaming Device - FIDO Alliance Change-Id: I1e90bd8544b8327f376143226c7a1ea427c01277 Signed-off-by: Filipe Laíns <lains@archlinux.org> Reviewed-on: https://code.wireshark.org/review/36410 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-03-15debian: Ship codecs libraries in libwireshark0Balint Reczey1-0/+1
Bug: 16430 Change-Id: I2f9b07be780d39c75898bba06fa6fb66b9895c88 Signed-off-by: Balint Reczey <balint.reczey@canonical.com> Reviewed-on: https://code.wireshark.org/review/36433 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15More modeline fixes to put HT tab stops every 8 characters.Guy Harris3-9/+9
Change-Id: If3ea65f24e33b89784b3d9a1e7009d09728d4f7a Reviewed-on: https://code.wireshark.org/review/36437 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-15WSUG: Update the Service Response Time section.Gerald Combs6-42/+37
Update the Service Response Time section of the User's Guide. The sample captures page had a nice SMB2 capture file, so use that for the example. Use title case for "Diameter" to match the RFCs. Change-Id: Icff510dbe2d77db9cd42548ad58439d17282e851 Reviewed-on: https://code.wireshark.org/review/36421 Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 03:50:45 +0000