aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()krj236-538/+528
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29446 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Add a new function, tvb_new_subset_remaining(), which is a sligtly optimized ↵krj2-3/+39
version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1. The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29445 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Remove unused parameterskrj1-4/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29444 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Remove the non-thread safe usage of 'last_tvb' variable in tvb_new_subset()krj1-27/+29
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29443 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Make some of the check_XXX functions accept the length/reported length of ↵krj1-35/+53
the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset() git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29442 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Remove a non thread-safe usage (useful when/if we ever support threading) of ↵krj2-22/+19
a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29441 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Use the slice allocator if GLIB >= 2,10,0krj1-2/+48
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29440 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Switch over to using GPtrArray instead of manually g_renew'ing. This switch ↵krj3-38/+36
has some benefits: 1) We don't have to manually resize 2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29439 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Mark function paramter as unused with _U_ to please gcc.sfisher1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29438 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Try to please build botetxrab1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29437 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Prepare for storing column data in packet list store.etxrab1-9/+75
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29436 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Inline a few checks in the add_packet_to_packet_list() function since it's ↵krj1-3/+8
called in tight loop. This will help us to avoid calling functions that simply returns. This is especially the case when we're dealing with the new packet list due to its dissect-on-demand nature where colour/column construction is delayed until the row becomes visible. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29435 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Bromankrj1-0/+17
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29434 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Add a missing DISSECTOR_ASSERT in tvb_init()krj1-0/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29433 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Make mem chunk statickrj1-4/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29432 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Use HFILL instead of hard coding the valueskrj2-8/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29431 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Switch over to using GLib's g_malloc/g_free in the name of consistency.krj1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29430 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15This should have been part of r29428. This patch forces ↵krj1-0/+3
proto_field_is_referenced() to respect the fake_protocols flag set by Protocol Hierarchy stats tap. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29429 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15The frame dissector contains a kludge to workaround the fact that the ↵krj1-20/+12
Protocol Hierarchy stats tap always needs the protocol node to appear even though no color, display filter etc. reference it. This is no longer needed due to r29380. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29428 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15This patch introduces packet_add_new_data_source() which effectively ↵krj9-14/+51
deprecates add_new_data_source(). This is based on the following observation: 1) The tvb + name (aka. data_source) is only used when the protocol tree is visible The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify. A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated! git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29427 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Micro optimize by storing PACKET_LIST(tree_model) into a local variable and ↵krj1-8/+8
using that instead of computing PACKET_LIST(tree_model) each time. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29426 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Avoid superfluous g_strdup()krj1-7/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29425 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Enable 'Mark Packet' in the Edit menukrj1-1/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29424 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Add support for mark/unmark all frames in our new packet listkrj3-11/+37
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29423 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Find next/previous mark is also supported so don't exclude itkrj1-0/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29422 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Don't exclude functionality we already supportkrj1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29421 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-15Allow s1ap not to be dissected (to avoid seeing errors, possibly due to ↵martinm1-1/+13
proprietary variants). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29420 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Make 'Apply as filter'/'Prepare filter' work for new packet list.krj5-34/+46
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29419 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Remove the hacky row_from_iter() function and use ↵krj1-17/+5
new_packet_list_get_record() instead. Alas, new_packet_list_get_record() is also somewhat hacky in its nature, but hey at least we're using one less hacky thing. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29418 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Make mark/unmark frame work with the new filter modelkrj1-32/+27
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29417 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Remove unused functions/prototypeskrj1-11/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29416 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14New packet list: right clicking on a row now selects the given row.krj2-29/+38
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29415 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Make first/last frame work again with the new filter model.krj1-3/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29414 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Make next/previous frame work again with the new filter model.krj1-31/+57
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29413 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Typos.etxrab2-44/+50
Fixes: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3878 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29412 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Don't attach our original packet list model in new_packet_list_thaw(). It's ↵krj1-14/+7
pointless because we override it in filter_function(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29411 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14From Artem Tamazov via. 3899:krj1-1/+1
Remove superfluous /MP git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29410 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Make display filtering work for NEW_PACKET_LIST. This didn't work previously ↵krj1-7/+19
because we would simply append the new filtered packets onto the existing ones. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29409 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-14Always add packet to the new packet list regardless of whether the packet ↵krj1-12/+13
passed the display filter test or not. We do this because we do the filtering inside the new packet list. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29408 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13Start to implement display filtering.etxrab1-0/+43
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29407 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13Get the pointer to the packet list record and use the data directly.etxrab2-39/+24
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29406 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13Add needed header due to stack allocated 'edt' structurekrj1-0/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29405 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to ↵krj13-167/+193
initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29404 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13Make sure that we find the "data" dissector during handoff else we might ↵krj1-0/+1
crash if the received payload was less than 2 bytes. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29403 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13fix build failure without GnuTLSkukosa1-0/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29402 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVCkukosa1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29401 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13Fix SSL decryption failure if client and server have the same TCP portkukosa4-64/+113
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29400 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-13From Gerasimos Dimitriadis:etxrab1-15/+181
DTAP decoding of Mobile Station Classmark 3 (R7 and R8) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29399 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-12From Gerasimos Dimitriadis:etxrab1-21/+237
DTAP decoding of Mobile Station Classmark 3 (R6). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29398 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-12White space changeskrj1-192/+192
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29397 f5534014-38df-0310-8fa8-9805f1628bb7