AgeCommit message (Collapse)AuthorFilesLines
2020-09-05F1AP: upgrade dissector to v16.2.0Pascal Quantin24-1033/+15875
2020-09-05NGAP: fix a comment in the header file and add it to CMakeLists.txtPascal Quantin3-2/+3
2020-09-05Tools: Clean up checkAPI and add ui/qt.Gerald Combs37-68/+98
Remove the --check-addtext and --build flags. They were used for checkAddTextCalls, which was removed in e2735ecfdd. Add the sources in ui/qt except for qcustomplot.{cpp,h}. Fix issues in main.cpp, rtp_audio_stream.cpp, and wireshark_zip_helper.cpp. Rename "index"es in packet-usb-hid.c.
2020-09-05(G)QUIC: improve dissection capabilities (Q050, T050 and T051)Nardi Ivan3-25/+134
Fix support for Q050 and add support for T050 and T051. For these 3 versions, add dissection of (at least) Initial Packets. For salts and other info, see: "A Guide to Parsing QUIC Client Hellos for Network Middlebox Vendors" https://docs.google.com/document/d/1GV2j-PGl7YGFqmWbYvzu7-UNVIpFdbprtmN9tt6USG8/preview Note these versions are actively used by Chrome right now. Based on https://code.wireshark.org/review/#/c/37492/ done by @alagoutte
2020-09-05Fix some detected spelling errors in ASN1 dissectors.Martin Mathieson9-11/+11
Done by scanning the asan1 template files. If there are spelling mistakes in the specifications, we should ignore. Note that for z3950, I had already found and accidentally fixed the same errors in the generated file (before I taught my script to ignore gnerated dissector files).
2020-09-04S1AP: fix a field maskPascal Quantin2-2/+2
2020-09-04X2AP: fix a field maskPascal Quantin2-2/+2
2020-09-04XnAP: dissect a few more fieldsPascal Quantin3-75/+165
2020-09-04GTP NR RAN Extension Header: Update to latest spec.Martin Mathieson1-117/+189
Type 2 (Assistance Information Data) is still missing.
2020-09-04FCOE: Autodetect Ethernet FCS by examining EOFJohn Thacker1-10/+57
In the T11 version of FCOE, the length field was removed. If the last four reported bytes don't look like the EOF plus padding, but the four bytes before that do, then the Ethernet FCS is almost surely present so treat it that way. Closes the other case of #4594
2020-09-04RTP: always add rtp.payload field but hide it if a subdissector is foundPascal Quantin1-5/+8
This is useful to dump the RTP payload using tshark without the need to deactivate the sub dissector
2020-09-04github: fix windows build.Dario Lombardo1-1/+3
Downgrade winflexbison3 to Related: #16824.
2020-09-04README.developer: Note that sources can use UTF-8.Gerald Combs2-11/+13
We started allowing source files to be encoded as UTF-8 in April 2019 in bd75f5af0a. Update README.developer to match. README.developer no longer has a "Code style" section, so update the Developer's Guide to point to the "Portability" section.
2020-09-04tools: Make the "Allow commits" error more obnoxious.Gerald Combs1-7/+10
Add ANSI codes and emoji so that the error stands out in the pipeline output. Clarify the text.
2020-09-04Fix a couple of spelling errors in docbook files.Martin Mathieson2-3/+3
2020-09-04Query #define was being used in reply processor.Chuck Craft1-1/+1
2020-09-04Diameter 3GPP: Pretify dissection of 3GPP AVP 524 Codec-DataAnders Broman1-0/+68
2020-09-03Fix some typos detected in man pages.Martin Mathieson3-3/+3
2020-09-03Qt: Use UTF8 middle dot for non-printable charactersStig Bjørlykke1-5/+9
Use UTF8 middle dot for non-printable characters in ShowPacketBytes to clearly show the difference between a non-printable character and '.', and to align with the PacketBytes view.
2020-09-03GTPv2: fix dissection of Target Identification IEPascal Quantin1-10/+43
Closes #16822
2020-09-03XnAP: upgrade dissector to v16.2.0Pascal Quantin15-827/+11616
2020-09-03WSDG: Add a note about "Allow commits from members..."Gerald Combs1-0/+4
Recommend checking "Allow commits from members..." when creating merge requests.
2020-09-02tools: Force "Allow commits from members..." in merge requests.Gerald Combs1-0/+38
Add a verify_merge_request routine to validate-commit.py. If the required CI_MERGE_REQUEST_XXX environment variables are set it uses them to query the GitLab API to see if "allow_collaboration" is true in the current merge request. This is a ham-fisted way of ensuring that committers can rebase and can be removed if and when https://gitlab.com/gitlab-org/gitlab/-/issues/23308 is fixed.
2020-09-02USB HID: Avoid allocating a huge amount of memory.Gerald Combs1-0/+3
Make sure we don't pass a huge number to wmem_array_grow. Closes #16809.
2020-09-02gitlab-ci: Enable the Windows MR build.Gerald Combs1-12/+10
Git is currently broken in gitlab-runner 13.3.0 + Windows + Docker... https://gitlab.com/gitlab-org/gitlab/-/issues/239013 ...but it appears to work fine in gitlab-runner 13.2.0. I reverted the build machine to that version, so we can enable the merge-request:windows build.
2020-09-02Fix the Windows build.Gerald Combs1-1/+1
Fetch time zone names using _tzname.
2020-09-02GitLab CI: Set up ccache.Gerald Combs1-4/+16
Set up a per-job cache directory and enable ccache as described at https://gould.cx/ted/blog/2017/06/10/ccache-for-Gitlab-CI/ and https://docs.gitlab.com/ee/ci/yaml/README.html#cache Enable ccache in the merge-request steps. Export DEB_BUILD_OPTIONS=nocheck while we're here.
2020-09-02multipart: fix deallocation of invalid partsGeorge Hopkins1-5/+4
Fixes #16741
2020-09-02RTPS: Fixing typo in a mask, it should be app_id instead of host_idJuanjo Martin1-1/+1
2020-09-02Fix some spelling mistakes found among plugins.Martin Mathieson5-15/+15
2020-09-01get_zonename(): don't convert _tzname[] values to UTF-8.Guy Harris1-28/+20
Now that we're setting the C-language locale to use the UTF-8 code page, they're already *in* UTF-8; g_locale_to_utf8() doesn't treat the C-language locale's code page as the "locale" code page, it uses the system code page, so it reads a UTF-8 string as being in some local code page's encoding and proceeds to mangle it in the process of converting it to UTF-8. Closes #16811 (closed)
2020-09-01USB HID: Fix a double free.Gerald Combs1-0/+4
Make sure we allocate a new field.usages array for USBHID_MAINITEM_TAG_OUTPUT as we do for USBHID_MAINITEM_TAG_INPUT. Closes #16818.
2020-09-01Fix some spelling errors detected in epan/prefs.cMartin Mathieson1-10/+10
Ignored "st_sort_casesensitve", as it will not normally be seen by users, and changing it would lose the previous setting (if set).
2020-09-01TCP: do not use an unknown status when the checksum is 0xffffPascal Quantin1-1/+1
Otherwise it triggers an assert when adding the column as the field is defined as BASE_NONE and not BASE_DEC or BASE_HEX. Thus an unknown value (not in proto_checksum_vals[)array) cannot be represented. Mark the checksum as bad even if we process the packet. Closes #16816
2020-09-01MBIM: dissect new UICC commands of MBIM extended version 1.0Odysseus Yang1-0/+689
2020-09-01Portcontrol: Implemented option code 130Peter Oettig1-24/+94
Portcontrol: Added support for option code 130 / Port-Set (RFC 7753) Portcontrol: Made info column for Map Request / Response more helpful
2020-09-01ErlDP: support features of Erlang/OTP 23George Hopkins1-58/+178
2020-09-01CI+tools: Install lintian.Gerald Combs2-7/+8
Install lintian instead of devscripts (which pulls in lintian + many other packages) in .gitlab-ci.yml. Add lintian to DEBDEPS_LIST in debian-setup.sh.
2020-09-01GTpv2: Add expert info for zero length IEAnders Broman1-1/+5
Add an Expert info for zero length 8.76 CSG Information Reporting Action IE.
2020-08-31FCOE: (Pre-T11) Help Ethernet dissector guess about Ethernet FCSJohn Thacker1-0/+4
The pre-T11 (pre August 2007) version of FCOE has a frame length, so it's possible to set the length in order to help the Ethernet dissector determine if a capture includes the Ethernet FCS, like how other dissectors do it. This isn't possible in the standardized version, since the length field was removed. Closes #4594.
2020-08-31NGAP: fix ngap.MDT_Location_Information.reserved definitionPascal Quantin2-2/+2
2020-08-31cl3: (trivial) drop _U_ for a parameter that is usedMartin Kaiser1-1/+1
Fix the following compiler warnings packet-cl3.c:120:39: warning: 'tree' was marked unused but was used [-Wused-but-marked-unused] ti = proto_tree_add_protocol_format(tree, proto_cl3, tvb, 0, header_length, "CableLabs Layer-3 Protocol (CL3) Version %u", (guint)version); packet-cl3.c:136:32: warning: 'tree' was marked unused but was used [-Wused-but-marked-unused] dissect_cl3_v1(tvb, pinfo, tree, ti, cl3_tree, header_length);
2020-08-31More spelling fixes, last part of 2nd pass of dissectors.Martin Mathieson36-107/+102
2020-08-31More spelling fixes, part 2 of 2nd pass of dissectors.Martin Mathieson19-50/+50
There will likely be one for for this pass. Further improvements to the script are possible, i.e. filtering out (usually filter) strings such as 'onetwothree' - may not be worth it though.
2020-08-31More spelling fixes, part 2 of 2nd pass of dissectors.Martin Mathieson28-86/+86
2020-08-31EBHSCR: Add CAN and TS, update ETH dissectorsAna Pantar1-80/+535
Added new CAN and TS packet dissectors, ETH dissector updated with the latest EBHSCR changes, each protocol is handled in a separate function
2020-08-30More spelling fixes, start of second pass of dissectors.Martin Mathieson24-144/+144
Now easier to find errors due to script improvements and more complete dictionary file.
2020-08-30ITS: enable decoding of UDP datagram as ITS messageIgor Passchier2-0/+6
By default, ITS messages are send based on the geonetworking protocol. Several tools send these messages via UDP as well This patch enables "Decode As ITS" for UDP packets
2020-08-30[Automatic update for 2020-08-30]Gerald Combs6-33/+141
Update manuf, services enterprise numbers, translations, and other items. /target_branch master
2020-08-30Fix build where compilers can't initialise multi-field struct with {0}Martin Mathieson3-6/+12