aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-12-18macOS: More ChmodBPF signing updates.Gerald Combs2-1/+2
Run osx-extras.sh before building the ChmodBPF installer package. Change-Id: Iec3f88da86e48b5aac385369c7e68f23babc4c34 Reviewed-on: https://code.wireshark.org/review/35491 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-18Qt: Don't crash when disabling all protocols.Gerald Combs1-0/+3
Ensure that a protocol can be disabled before attempting to do so. Fixes crash described at https://ask.wireshark.org/question/13573/wireshark-crashes-in-the-enabled-protocols-dialog-box/ Change-Id: Ib774bb6d636e82b79c5a922272a39126da85b71d Reviewed-on: https://code.wireshark.org/review/35489 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-18Uncrustify: Change line length to 100 charsOrgad Shaneh1-1/+1
80 is too small. Change-Id: I79a702449f72fcf66ae00e3508546389b022b900 Reviewed-on: https://code.wireshark.org/review/35484 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-18macOS: Sign the ChmodBPF script.Gerald Combs2-0/+88
Add macosx/osx-extras.sh, which can be used to sign the ChmodBPF script. Bug: 15782 Change-Id: I9929dd6db067f8bc1097faac28ab9467f5a89a82 Reviewed-on: https://code.wireshark.org/review/35481 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-18ieee802.11: Support the latest band id values and fix MHz.Richard Sharpe1-5/+6
Change-Id: I4ef686f5dc9a43f94db34cab0f7fe466ef271585 Reviewed-on: https://code.wireshark.org/review/35482 Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-18De-camel-ize "Wireshark" in a few places.Gerald Combs5-32/+31
The _wslua_main struct / WireShark class appears to have never been used, so remove it. Change-Id: Id80fb2c2065accedf632ea4cc467d566d10870de Reviewed-on: https://code.wireshark.org/review/35480 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-17Windows: Get rid of textify.ps1.Gerald Combs3-122/+23
We used textify.ps1 to ensure that the .txt files in our Windows installers would render properly in Notepad if the user double-clicked on them. Newer versions of Windows have a more sane Notepad, so this is no longer necessary: https://devblogs.microsoft.com/commandline/extended-eol-in-notepad/ Copy COPYING, NEWS, README.md, and README.windows once. Update README.windows. Change-Id: Ibb8b749725f13e0e49d2a2abe04603d9f2be7960 Reviewed-on: https://code.wireshark.org/review/35470 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-17MsgPack: add dissector to UDP port decode as listPascal Quantin1-1/+9
Bug: 16278 Change-Id: I08082733f838364edc46c0fc8b3d1d95241c0c00 Reviewed-on: https://code.wireshark.org/review/35477 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17test: add suite_extcaps.Dario Lombardo4-6/+102
All the shipped extcaps will be tested against: --help --extcap-interfaces --extcap-interface <IFACE> --extcap-dtls --extcap-interface <IFACE> --extcap-config Bug: 16268 Change-Id: I7949103940c95c9c23fc5dd3743c15995d3a152d Reviewed-on: https://code.wireshark.org/review/35409 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-12-17dissectors: re-use most of the existing spoolss container dissectorsGünther Deschner4-34/+107
Guenther Change-Id: Ifa261265112da2433f6f55385aba9dff9546551a Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/35425 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17Add new DCE/RPC IRemoteWinspool dissectorGünther Deschner7-0/+10981
Guenther Change-Id: I75d0251ff6324c7133f710b33282d9115651f972 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/35424 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17PROFINET: Profienergy record dissectionBasak Kalfa1-6/+283
According to specification, missing profienergy records and alarms are dissected. Change-Id: I36eec046f0aff7f4b1235e50b6dc469847c1ac8d Reviewed-on: https://code.wireshark.org/review/35389 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17WSUG: Update the Expert Information and Status Bar docs.Gerald Combs6-121/+139
Update the Expert Information section of the User's Guide. Use the term "Expert Information" to describe the dialog and "expert information item" to describe each generated item. Update related text elsewhere. Update the expert icon and other parts of the status bar docs. Change-Id: I0c2cba0cbb3c74a1f6e3a37d4a2a592faccb350f Reviewed-on: https://code.wireshark.org/review/35462 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17WSUG: Update the filter dialog section.Gerald Combs2-61/+28
Change-Id: I394780c366afd832a1fbfcb93d6c1722edcea54c Reviewed-on: https://code.wireshark.org/review/35442 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17FAQ: Update and remove entries.Gerald Combs1-39/+5
Generalize the "missing bpf.h" entry. Remove the UCD SNMP and Fink entries. Change-Id: I276f2387c4bf017c7ba4f0a37cce525efd1c24ae Reviewed-on: https://code.wireshark.org/review/35469 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-17CMake: fix CMake 3.16 warning about CMP0071Peter Wu1-0/+6
Prevent a file from being processed by moc/uic as it is not needed. This addresses a new CMake warning "Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files." Change-Id: I8ed458099cdf29472dad29168786cf16b95595fa Reviewed-on: https://code.wireshark.org/review/35468 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-16TPNCP: Update tpncp.datOrgad Shaneh1-1693/+3305
Change-Id: I15d2bca76126607f395647000a042365020950f7 Reviewed-on: https://code.wireshark.org/review/35466 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-16wcp: fix indentation.Dario Lombardo1-94/+87
Change-Id: I3830b721715361a8ffdeded3eb64d19323e813f0 Reviewed-on: https://code.wireshark.org/review/35460 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-16profiles: Try to better sync on disk config stateJim Young5-8/+16
Profile specific column settings are split across the `preferences' file and the `recent' file. At any given moment the GUI column settings held within the `preferences' file and the `recent' file may be inconsistent with one another and with the GUI itself. These inconsistencies occur because of when the GUI chooses to write config changes to disk. If Wireshark is not shutdown gracefully (for example when killed or should crash) the column preferences saved on disk may not be consistent between the current profile's `preferences` and `recent` files and the most recently used profile may not be recorded within the `recent_common' file. On restarting Wireshark these config file inconsistencies can lead to unexpected artifacts. Normally the column config state saved within the current profile's `preferences' and `recent` files are made consistent when a different profile is selected or when Wireshark is closed gracefully. This patch set attempts to improve the constancy of the on disk config state with the GUI state by invoking the functions to write the `recent' and `recent_common' files in a more timely manner. Fix a typo while here. Change-Id: I2af9d9eb2dcf9cc0d422e9840aa05f4f6b1aa086 Reviewed-on: https://code.wireshark.org/review/35407 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-15Reorganize long option valuesJaap Keuter7-52/+35
For long options, without corresponding short options, to be processed they need to be assigned a value, preferably outside of the range of all possible short options. The code in various places tries to stay clear of these low values, but further coordination is missing, easily leading to issues when option processing code gets extended and/or reorganized. This change introduces a single location from where each catagory of command line long option can derive a base value, which should minimize potential option value collisions. Change-Id: Ic8861a347d0050f74002de3aa1fcfb01202866e5 Reviewed-on: https://code.wireshark.org/review/35459 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-15extcap: remove potential leak.Dario Lombardo1-3/+11
Found by clang. Change-Id: I84359a2f7985bca8b0089200b3c37d04e06effe2 Reviewed-on: https://code.wireshark.org/review/35354 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com>
2019-12-15[Automatic update for 2019-12-15]Gerald Combs14-3216/+687
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Id1d9cd2c1f311247df53f41397169ce0490bf7a7 Reviewed-on: https://code.wireshark.org/review/35443 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-15MPLS: fix Downstream Detailed Mapping TLV label stack dissectionJaap Keuter1-3/+4
The label stack is its own TLV, which adheres to the same format as others, with a tag and length (obviously). The length to be used for this TLV is not the remaining length of this packet, but its own length. Bug: 16273 Change-Id: I469b55c5d78d1899d87030f3c0a15fd1afdf3f85 Reviewed-on: https://code.wireshark.org/review/35436 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-15WiFi: Properly parse bitmap sections (CID-1451085)Jaap Keuter1-3/+3
Compressed block acks, in the form of 256 bit bitmaps, are parsed per 64 bit section. Scanning along a section needs to be done by indexing this section, not the full 256 bits of the complete bitmap. Change-Id: Id0e6a7299e14be1ad68dd1cf6d736123008854ac Reviewed-on: https://code.wireshark.org/review/35440 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-15H265: properly index 2D array (CID 1450950)Jaap Keuter1-6/+6
In the expression it seems to simply have been missed this is a 2D array. Adding the 2nd index, as elsewhere in this function. Change-Id: I21ce5a6fa70408f84cb61bbd09e7d3aeff9c1d85 Reviewed-on: https://code.wireshark.org/review/35441 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-14RTCP/MCPT: Limit list of SSRCs (CID 1455251)Jaap Keuter1-0/+1
When listing the SSRCs actually count down the number of SSRCs when adding tree items. Change-Id: Iad81dfc2dfd8d611b20d8ad564d8dbacb4a9980f Reviewed-on: https://code.wireshark.org/review/35438 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-14WSUG+WSDG: Remove description list formatting.Gerald Combs4-71/+79
Remove the last of our description list term formatting. This is better handled using CSS. Update the filter expression dialog DL text. Change-Id: Ib21e2ee5265c9b476d960e7d73ac99b25b646141 Reviewed-on: https://code.wireshark.org/review/35437 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-14WSUG: Update the mailing list section.Gerald Combs1-9/+8
Remove some formatting and link to the list archives. Change-Id: I45c5a24b4a6d01234aafab71dc080cf98f4e22cf Reviewed-on: https://code.wireshark.org/review/35435 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-14test: fix comment.Dario Lombardo1-1/+1
Change-Id: I71a28535f2c9081e965004f02ec85ff500f9278b Reviewed-on: https://code.wireshark.org/review/35428 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-12-13cmdline: cleanup option string definitionsJaap Keuter3-10/+10
Option string composition has grown organically over time and is depending on compilation options also. This results in somewhat complex macro definitions and the use of the string concatenation feature of the C compiler. This change tries to clean up some of this magic by removing definitions of empty strings and merging of adjacent strings. Change-Id: I968449ea9b564915bee468a0cac0e114983ceebe Reviewed-on: https://code.wireshark.org/review/35429 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-13m3ap: Info column lost at filtering.Anders Broman2-13/+9
Remove if (tree) Change-Id: I1bb38fd8cdea85e026837ea1dc9bcd72b7432f1e Reviewed-on: https://code.wireshark.org/review/35430 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13DCERPC: Add dissect_hresult helperGünther Deschner2-0/+27
Guenther Change-Id: I62bac46ac43189f7ea07aacf19147d85f6649a5d Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/35423 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13H.264: add dissection of SPS with seq_scaling_matrix_present_flag equal to 1.Xiaoxia Lang1-26/+37
H.264: fix dissection of se(v). Change-Id: I38ad153a3f8860726ea3f430433f5202f534a5fa Reviewed-on: https://code.wireshark.org/review/35419 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13html2text: Skip generating footnotes for self-links.Gerald Combs1-0/+4
Fixes the issue described at https://www.wireshark.org/lists/wireshark-users/201912/msg00003.html Change-Id: Ie3fd338ab1c6b216b05eeca002545868d3474bbb Reviewed-on: https://code.wireshark.org/review/35426 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13Uncrustify: Remove newline between for and braceOrgad Shaneh1-1/+1
Change-Id: Ib89a159bbc7125b3afcfd72d1a218cb6d7c4af39 Reviewed-on: https://code.wireshark.org/review/35421 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13Uncrustify: Add spaces between else and bracesOrgad Shaneh1-0/+9
Change-Id: Ida8f8638ee226b99804293158e57f4be7a045be8 Reviewed-on: https://code.wireshark.org/review/35420 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-12PER: Add a couple of NULL checks.Gerald Combs1-3/+8
Check for NULLs in a couple of places found by scan-build. Fix a typo. Change-Id: Idde75db6031fa9f2ffa36b7fa10b37bf676e0904 Reviewed-on: https://code.wireshark.org/review/35427 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-12pcfp: add missing Usage Report Trigger indicationJoakim Karlsson1-0/+8
Oct7, Bit 2: TEBUR Change-Id: If3668ba53b163c692fe81163c5e895fcd38b9539 Reviewed-on: https://code.wireshark.org/review/35422 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-12couchbase: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Icd18de17e7564b946ea177df252dffd2370ff1a0 Reviewed-on: https://code.wireshark.org/review/35408 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-11NAS 5GS: fix LADN Indication ID in Registration RequestPavel Strnad1-1/+1
Change-Id: I46df64d47144eb943e8feee192d9bacb137b22c5 Reviewed-on: https://code.wireshark.org/review/35410 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-11Qt: Add some null checks.Gerald Combs2-13/+24
Add some null checks identified by scan-build. Switch some dynamic_casts to qobject_casts. Change-Id: I2b97ee8cb71db4fc883b4081568f9a5db8af85b3 Reviewed-on: https://code.wireshark.org/review/35403 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-11CMake: Fixup a variable in FindLZ4.cmakeGerald Combs1-1/+1
Set "LZ4_PDB" instead of "LZ4_pdb" in FindLZ4.cmake so that CMake 3.16 will convert "${LZ4_DLL_DIR}/${LZ4_PDB}" to the full path to the LZ4 .pdb instead of its parent directory. This in turn ensures that we don't pass a directory as a source argument to `cmake -E copy_if_different`, which causes it to crash. Bug: 16271 Change-Id: Id6f37584379bd07bc929bc5cb5e80cbe60a3c77e Reviewed-on: https://code.wireshark.org/review/35400 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-11radiotap: Detect 11ad based on the frequency.Guy Harris1-2/+22
This works around the lack of a defined radiotap field for 11ad. Bug: 16272 Change-Id: Ia851c644aee52ff9a138a36b16015d4112b5bf92 Reviewed-on: https://code.wireshark.org/review/35401 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-10Windows: update c-ares 1.15.0 packagePascal Quantin1-4/+4
Library was regenerated using g000e963fff596d817d03f366cd49b1fd2d6ec961 to have the proper version info. Change-Id: I33f26d70ba1ea244aa467e5121b6fb586d8ebd8a Reviewed-on: https://code.wireshark.org/review/35398 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-10LNET: fix malformed packet error on RDMA Read RequestJorge Mora1-1/+1
Check the number of remaining bytes before comparing the next four bytes to the LNet magic number to find out whether or not this is an LNet layer. In the case for an RDMA Read Request which does not have any payload data, the LNet dissector now gracefully will not process this packet as an LNet layer instead of labeling it as a malformed packet. Bug: 16269 Change-Id: I5d6abea8b79619849e8fbc1bc6b585995736b56e Reviewed-on: https://code.wireshark.org/review/35392 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-12-10Revert "extcap: Pass --extcap-version if extcap supports it"Gerald Combs2-66/+20
This reverts commit 9910d8c913d2a1874c7f98ef3bf3ad2921dd67e4. Reasons for revert: - We need to improve the reliability of extcap-version=x.y detection. - WSDG_chapter_capture.adoc needs to be more clear about extcap-version=x.y support. - Our extcap utilities need to be updated. Change-Id: Ic8dd2018489f5ec03c35b18e6b09faf69defd59b Reviewed-on: https://code.wireshark.org/review/35393 Reviewed-by: Rafał Kuźnia <rafal.kuznia@protonmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-12-10More Qt minimum version updates.Gerald Combs6-142/+77
Update the minimum version in various documents. Remove some no-longer-needed code from scripts that call windeployqt. Change-Id: I16da4bced9780c9f1b1969aae7c52e2fce1968aa Reviewed-on: https://code.wireshark.org/review/35391 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-10Qt: Remove a comment.Gerald Combs1-4/+0
Remove a comment that's no longer relevant as of g14e4759b56. Change-Id: I919631810c37e34ebc0cf5b78ab4dfbee5f5c687 Reviewed-on: https://code.wireshark.org/review/35390 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-10ZigBee: Maintain APS extended counter for nodesKenneth Soerensen2-47/+65
Each node maintains one APS counter and not one per conversation. Therefore, remove the conversation handling and maintain the counter for each node instead. Bug: 15021 Change-Id: I3a225db008f5dd716246674aafb9d3d04c7d402f Reviewed-on: https://code.wireshark.org/review/35371 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10btatt: check the opcode against the current data.Dario Lombardo1-22/+30
While here: - some indentation fixes - add defines for missing ATT_OPCODEs Bug: 16258 Change-Id: I2cd8172bcff9c209bbddc4729573c008a8e81fec Reviewed-on: https://code.wireshark.org/review/35339 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 16:09:07 +0000