aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-07-08cppcheck: Fixup some comparisons.Gerald Combs1-3/+3
Change-Id: I6901c31cdea7399bc18dbf968c14c477f71a90dd Reviewed-on: https://code.wireshark.org/review/37777 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-07-07Fix Wpointer-sign warnings.Anders Broman5-21/+21
Change-Id: Ia51998293b967f363856d2b9ac92f498a9f54d76 Reviewed-on: https://code.wireshark.org/review/37769 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-07cppcheck: Bail if "-l <n>" or "-o" don't find any files.Gerald Combs1-3/+18
If we've been passed "-l <n>" and the last <n> commits don't match any C or C++ files or we've been passed "-o" and no files have been changed, simply exit instead of testing the entire code base. We use "cppcheck.sh -l <n>" in our CI system and the former behavior is much more useful (and faster) than the latter. Change-Id: I1127eabefa854d68f80b0a2dfd05e6895658abc0 Reviewed-on: https://code.wireshark.org/review/37773 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-07-07USB HID: fix memory leak when saving report descriptorsFilipe Laíns1-7/+14
Change-Id: I5cb5598be557823cf3b39cda30bed6febee297d3 Signed-off-by: Filipe Laíns <lains@archlinux.org> Reviewed-on: https://code.wireshark.org/review/37561 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-07-07Fix Wpointer-sign warnings.Anders Broman3-14/+14
Change-Id: I69a266bc945441bc9351b97bd1de0af7f9be46a0 Reviewed-on: https://code.wireshark.org/review/37768 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-07Fix -Wpointer-sign warnings.Anders Broman2-16/+16
Change-Id: Ide037ee1d2f9e52cb024f7335154e12ce09ac010 Reviewed-on: https://code.wireshark.org/review/37767 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-07file-rbm: Fix -Wpointer-sign warnings.Anders Broman3-8/+8
Change-Id: I53e84e172e1c03849158ba6df83aa2ff9cfb3054 Reviewed-on: https://code.wireshark.org/review/37766 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-07tn3270: improve on some of IBM's painful prose.Guy Harris1-17/+17
The "true" string in a struct true_false_string is used only if the bit is set to 1, so "if set to logic 1" is redundant. Just have the strings say, respectively, what significance the bit being on ("set to logic 1") has and what signficance the bit being off ("set to logic 0") has. Use active voice. Change-Id: If1fe7b35a0c85dcdb40ac348ca23a0ac5e3dc1da Reviewed-on: https://code.wireshark.org/review/37753 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Guy Harris <gharris@sonic.net>
2020-07-07USB HID: fix parsing {logical ,phys }{min,max} in the report descriptorFilipe Laíns1-4/+4
Right now, for eg., a -32767/32767 min/max gets dissected as 0/1 which is wrong. Change-Id: Iffc649e0af4490827e722cae7f692ec4d0c245b8 Signed-off-by: Filipe Laíns <lains@archlinux.org> Reviewed-on: https://code.wireshark.org/review/37751 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-07-07USB HID: introduce a report descriptor parserFilipe Laíns1-1/+235
Change-Id: Ief63059fc5009cf8eff903d14d1c4dd2f35728b6 Signed-off-by: Filipe Laíns <lains@archlinux.org> Reviewed-on: https://code.wireshark.org/review/37559 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com>
2020-07-07extcap: Lazily load our interface list.Gerald Combs3-38/+143
Add extcap_ensure_all_interfaces_loaded, which calls extcap_load_interface_list if our interface list is empty. Call it in each of our public functions that require a valid interface list. Clean up the extcap API documentation and note which routines initialize the interface list. In tshark, don't unconditionally call extcap_register_preferences and instead rely on lazy loading. Change-Id: I8493ae5f4d703b0fd767246557d17723bcf207c6 Ping-Bug: 15295 Reviewed-on: https://code.wireshark.org/review/37750 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06TDS: Fix field abbrev for RPC nameJaap Keuter1-1/+1
Found by conflict check Change-Id: Id37c53cbfb9df796c609e602c6edc0f0940bf80c Reviewed-on: https://code.wireshark.org/review/37745 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06SPOOLSS: make reserved field value presentation meaningfulJaap Keuter1-2/+2
Detected by conflict check Change-Id: Ie534564085884afd6f7c9329b6ee637440533f29 Reviewed-on: https://code.wireshark.org/review/37738 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06TN5250: Fix two true_false strings so they are differentiatingJaap Keuter1-4/+4
Found by conflict check Change-Id: Ic0348945b8519bc434bc5a10b5ed5951a7cdcb21 Reviewed-on: https://code.wireshark.org/review/37746 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06BSSAP: Fix field abbrev for IMEISV IEJaap Keuter1-1/+1
Found by conflict check Change-Id: Id14d12543902d75ae54b5b3944a44b63321dc479 Reviewed-on: https://code.wireshark.org/review/37747 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06file-pcapng: Try to fix -Wpointer-sign warnings.Anders Broman1-21/+21
Change-Id: I66f6e26080926f8bb0a4ac84a42963de61604194 Reviewed-on: https://code.wireshark.org/review/37743 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06epan: Fixup our ENABLE_CHECK_FILTER warnings.Gerald Combs1-5/+5
Make sure we use g_warning to print each ENABLE_CHECK_FILTER warning. g_warning automatically appends a newline, so there's no need for us to do so. Change-Id: I4ddb60f0e3e0382fb3ca6e996ad47410fe05d8be Reviewed-on: https://code.wireshark.org/review/37748 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-07-06DVB-S2-BB: Add the next-header protocol types from RFC4326, section 4.4.1Martin Mathieson1-7/+29
Change-Id: Ieb35ffb94a0e3c2f27768cefce91e0c93619ff94 Reviewed-on: https://code.wireshark.org/review/37733 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06mbim: Try to fix -Wpointer-sign warnings.Anders Broman1-4/+4
Change-Id: I56eccab845dae0bb903ee052130bb3ac00dba863 Reviewed-on: https://code.wireshark.org/review/37744 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06Windows: Set our locale to ".UTF-8".Gerald Combs8-11/+63
In each of our executables we were calling "setlocale(LC_ALL, "")" at startup. This told Windows that output was encoded using the current system code page. Unless the code page was 65001 (UTF-8), this was a lie. We write UTF-8 to stdout and stderr, so call "setlocale(LC_ALL, ".UTF-8)" at startup on Windows. This lets the CRT translate our output correctly in more cases. Clarify and expand the OUTPUT section in the tshark man page. Bug: 16649 Change-Id: If93231fe5b332c292946c7f8e5e813e2f543e799 Reviewed-on: https://code.wireshark.org/review/37560 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-07-06rtps-utils: fix no previous prototype for functioAlexis La Goutte1-1/+2
packet-rtps-utils.c:85:6: warning: no previous prototype for ‘dissect_mutable_member’ [-Wmissing-prototypes] Change-Id: Id87118f36e50db8bf4a27ca021bbceae220034d4 Reviewed-on: https://code.wireshark.org/review/37742 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06nfapi: Try to fix -Wpointer-sign warnings.Anders Broman1-28/+28
Change-Id: I71dadf67fc2c096001af6711650261336729d5b9 Reviewed-on: https://code.wireshark.org/review/37737 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06http2: fix no previous prototype for functioAlexis La Goutte1-1/+2
packet-http2.c:285:6: warning: no previous prototype for ‘decode_as_http2_populate_list’ [-Wmissing-prototypes] Change-Id: Ife66469b7016437c1e2b6d41df99571e73159851 Reviewed-on: https://code.wireshark.org/review/37741 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06enip: fix no previous prototype for functionAlexis La Goutte1-1/+1
packet-enip.c:1102:19: warning: no previous prototype for ‘create_connection_id_list’ [-Wmissing-prototypes] Change-Id: I6e0caa29f5617a5688cddaa4d8001a260228294e Reviewed-on: https://code.wireshark.org/review/37740 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06SDP: Try to fix -Wpointer-sign warnings.Anders Broman1-8/+7
Change-Id: Ia08bec34b64374fcad8c746274720e1a3ccd2689 Reviewed-on: https://code.wireshark.org/review/37739 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06Add all supported charsets to Show Packet Bytes/Follow StreamJohn Thacker8-69/+120
Use the QT text codec support to add charset conversions for all character encodings supported by QT to Show Packet Bytes and Follow Stream (Save As will convert to UTF-8.) Note that this is dynamic and the exact list will depend on the version of QT and if libicu support is enabled. This does make the list of codecs pretty long, so hopefully it shows up well on all the different QT styles. This does not yet support when multibyte characters span more than one packet in Follow Stream, though the current code doesn't do that for UTF-8 or UTF-16 already. This is probably most useful for HTTP captures. Bug: 16137 Change-Id: I6d5cd761a5d9d914b7a787fe8eb02b07b19642e6 Ping-Bug: 16630 Reviewed-on: https://code.wireshark.org/review/37707 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2020-07-06slsk: Try to fix -Wpointer-sign warnings.Anders Broman2-29/+29
Change-Id: Ic93368c4e3481f09c09ac6fd545683418dd335bd Reviewed-on: https://code.wireshark.org/review/37730 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06tls_utils: Try to fix -Wpointer-sign warnings.Anders Broman2-3/+3
Change-Id: Ia03499ae77dbbc840dc50ecf3ce56c399d939a6a Reviewed-on: https://code.wireshark.org/review/37729 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06umts_fp: Try to fix -Wpointer-sign warnings.Anders Broman1-12/+12
Change-Id: I649556aa97c34a653109caf1d0311b856a71bc09 Reviewed-on: https://code.wireshark.org/review/37728 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06GSM-SMS: Fix max of a range value.Martin Mathieson1-1/+1
value_range_string error: Reason (gsm_sms.dis.field_st_reason) entry for "Values specific to each SC" - max(15 0xf) is less than min(16 0x10) Change-Id: Iaa1ceee018d873b13ddc8eac9bc530ee2b37ad6e Reviewed-on: https://code.wireshark.org/review/37727 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-07-06DVB-S2-BB: For GSE Protocol Type, separate Next-Header and Ethertype subtypes.Martin Mathieson1-16/+25
For Ethertype, use etype_vals (don't know how likely types not named as examples in specs are likely to be seen). Fixes warnings from previous range_string that tried to cover both types, but where "not implemented" catch-all ranges preceded and hid individual types. ** (process:24396): WARNING **: 21:24:48.760: value_range_string error: Protocol (dvb-s2_gse.proto) hidden by earlier entry (prev="not implemented": 0 0x0 -> 255 0xff) (this="NCR": 129 0x81 -> 129 0x81) ** (process:24396): WARNING **: 21:24:48.760: value_range_string error: Protocol (dvb-s2_gse.proto) hidden by earlier entry (prev="not implemented": 0 0x0 -> 255 0xff) (this="Signaling Table": 130 0x82 -> 130 0x82) ** (process:24396): WARNING **: 21:24:48.760: value_range_string error: Protocol (dvb-s2_gse.proto) hidden by earlier entry (prev="not implemented": 2049 0x801 -> 34524 0x86dc) (this="VLAN": 33024 0x8100 -> 33024 0x8100) Tested with dvb-s2_bb_example.pcap (where the only Protocol Type value set is for IPv4). Change-Id: I7c8d8669c3f3e76974db8472783284975e063c12 Reviewed-on: https://code.wireshark.org/review/37711 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06GBCS: fix field abbreviation for firmware hashJaap Keuter1-1/+1
Found by conflict check. Change-Id: I95d05852ad3c8cd415e3235d3137ee3c85438817 Reviewed-on: https://code.wireshark.org/review/37725 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06Nettrace: Try to fix -Wpointer-sign warnings.Anders Broman1-9/+9
Change-Id: Ib2fe089939513f2fa32235312cdc70c9148cdfc3 Reviewed-on: https://code.wireshark.org/review/37723 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-06UDPCP: Move link from original specification to Wayback Machine archive.Martin Mathieson1-1/+1
Change-Id: I2dfda0d505a8d538d1c85fe35ed16d67fdf96223 Reviewed-on: https://code.wireshark.org/review/37726 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-07-06ncp2222: Try to fix -Wpointer-sign warnings.Anders Broman1-28/+28
Change-Id: I3928a137fe56387e1640b5a72e2c1c122dc54aec Reviewed-on: https://code.wireshark.org/review/37724 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-07-06ieee80211: Remove duplicate and erroneous entries in the status code table.Richard Sharpe1-3/+1
Also, the status code 125 is duplicated. This mistake was probably introduced from Draft P802.11Revmd_D3.0.pdf. I have commented out that status code while I get clarification on the real value. Change-Id: Id41e1da953a28ca6b098f6c96d6410dff04dc6d7 Reviewed-on: https://code.wireshark.org/review/37708 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-07-06nordic_ble: Avoid identical true and false stringsStig Bjørlykke1-10/+4
Change field 'MIC' (nordic_ble.mic_not_relevant) to avoid using identical true and false strings. Change-Id: I204cc096e4af6d6000a6aa7e70e7885221fb211f Reviewed-on: https://code.wireshark.org/review/37721 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05DVB-S2-BB: update list of standards.Guy Harris1-1/+13
We refer to part 1 of ETSI TS 102 606, i.e. to ETSI TS 102 606-1. Add other parts if appropriate. That ultimately ends up pointing to RFC 4326, which, in turn, mentions two IANA registries. Change-Id: Ief3ff36bd4c92ab6b94f07f0a6b6a3aeacb2fa12 Reviewed-on: https://code.wireshark.org/review/37716 Reviewed-by: Guy Harris <gharris@sonic.net>
2020-07-05UNISTIM: Remove useless bit field true_false_stringJaap Keuter1-5/+1
This true_false_string does not provide anything in relation to the whole bitfield. The field itself is questionable as a boolean anyway. This is reported by the conflict checker. Change-Id: I4a67db6755038b5a07ce4402181a0ea2a3a2b392 Reviewed-on: https://code.wireshark.org/review/37710 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05DVB-S2-BB: update a URL.Guy Harris1-1/+4
The URL no longer works; use the Wayback Machine. Change-Id: I80223dc675d0f578dd4f1d58848bc0eea17426c8 Reviewed-on: https://code.wireshark.org/review/37712 Reviewed-by: Guy Harris <gharris@sonic.net>
2020-07-05kafka: lz4: free the composite tvb only onceMartin Kaiser1-8/+11
Try to clean up the composite tvb handling during lz4 decompression. If we detect an error straight away before doing any lz4 decompression, we don't allocate a composite tvb at all. The comments in the tvb code say explicitly that we must not call tvb_new_composite() without adding at least one piece of data. If we start decompressing and run into problems after creating the composite tvb and linking it to the packet's main tvb, we must not free the composite tvb manually. The epan library will do this for us when dissection of the packet is finished. While at it, make sure that we always finalize the composite tvb if we allocated it and added data to it. Bug: 16672 Change-Id: I3e3fb303a823640d7707277a109019fc3aad22f2 Reviewed-on: https://code.wireshark.org/review/37696 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05mplog: increase the max packet length to 4096Martin Kaiser1-1/+1
iso14443 packets can now be up to 4k long. Change-Id: I120e18146cc40c0e9230c654cc31072e03ad3489 Reviewed-on: https://code.wireshark.org/review/37691 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05iso14443: support larger frame sizesMartin Kaiser1-1/+1
Recent updates to the iso14443 specifications increased the maximum frame size from 256 to 4096. This affects FSC, FSD and type b's max frame size. Append the optional sizes >256 to the array of possible frame sizes. Change-Id: I12ffb3a4bbd019dc38030de179526f7ec96b19cb Reviewed-on: https://code.wireshark.org/review/37690 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05Revert "ISO14443: Update some commands"Martin Kaiser1-189/+13
This reverts commit fe8744026c5f23fac15069ea597f7e99f7072d44. The commands that fe8744026c ("ISO14443: Update some commands") adds are not part of iso14443. It seems that these are mifare commands. (There's a couple of different mifare variants, not all of them support those commands.) Adding the commands unconditionally breaks iso14443 dissection. An iso14443 block with a pcb byte of 0xA2 is an R-ACK block for block number 0. This is not a "write block". If we want to support mifare cards, we have to detect the card type during activation. We can then add a mifare dissector which handles the messages after activation if we are actually talking to a mifare card... Change-Id: I86164cc4c1618204641ae00566694d0f98871785 Reviewed-on: https://code.wireshark.org/review/37689 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05[Automatic update for 2020-07-05]Gerald Combs15-15/+193
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4a369852fe1fbe2917932ba2a1f56eeb0fc4db28 Reviewed-on: https://code.wireshark.org/review/37703 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-07-05Add missing CAT001 fieldsMarko Hrastovec1-47/+208
- After bug 16662 was reported it was discovered that Category 001 does not have all fields decoded, because at the beginning not all fields were added due to lack of sample data. Later, for other categories all fields were decoded, while 001 was left out. Missing fields for Category 001 are added now. Change-Id: I3711004e742dbdaa7f785b110c62e420280e71a4 Reviewed-on: https://code.wireshark.org/review/37652 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05Enable display filter autocomplete on find packet search.Martin Mathieson4-5/+23
Bug: 16638 Change-Id: Ifd9c9e4392fdc3d32b2aa4466d5a7f2835893338 Reviewed-on: https://code.wireshark.org/review/37682 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05BFD: Adjust BDF echo message filter nameJaap Keuter1-1/+1
The field filter name and protocol name are identical, where the field filter name has to adhere to the protocol.field format. This is picked up by conflict check. Change-Id: I8ea0f0845916666ac39726b16ef3d907737c38b3 Reviewed-on: https://code.wireshark.org/review/37694 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-05dvb-s2-table: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I27580222b0d0fb93a38254eba69676e90360f1cb Reviewed-on: https://code.wireshark.org/review/37699 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-04ajp13: fix the type of elements of an array of pointers to hf_ values.Guy Harris1-3/+3
"int * const a[]" means "array of const pointers to (non-const) int". so the array elements are all const; "const int *a[]" means "array of (non-const) pointrs to const int". Change-Id: I8f1a0fd7b0f3d06ebf4cf6b993c74cfd47a0db26 Reviewed-on: https://code.wireshark.org/review/37702 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 04:09:37 +0000