aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-05-16Eliminate some unneeded header checks.Guy Harris19-48/+7
sys/stat.h and sys/types.h date back to V7 UNIX, so they should be present on all UN*Xes, and we're assuming they're available on Windows, so, unless and until we ever support platforms that are neither UN*Xes nor Windows, we don't need to check for them. Remove the CMake checks for them, remove the HAVE_ values from cmakeconfig.h.in, and remove all tests for the HAVE_ values. Change-Id: I90bb2aab37958553673b03b52f4931d3b304b9d0 Reviewed-on: https://code.wireshark.org/review/27603 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16Qt: Fix a memory leak.Gerald Combs1-0/+1
Make sure the Capture Information dialog deletes its UI data. Change-Id: I2613cfb6ca4b1a72e9fcfaad5a7792d95ab4764c Reviewed-on: https://code.wireshark.org/review/27588 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16Add a few more notes to git-export-release.sh.Gerald Combs1-0/+6
Change-Id: I8a2250387cc3187ecd5ca8abb6e29442668398a9 Reviewed-on: https://code.wireshark.org/review/27604 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16Qt: Save the Capture Information dialog geometry.Gerald Combs2-1/+2
Change-Id: I0acaa54ebbe0e16a9ea486fcdf74329b6cc1aea7 Reviewed-on: https://code.wireshark.org/review/27579 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16CMake: Skip more header checks on Windows.Gerald Combs2-8/+13
Prepopulate our header variables at the top of CMakeLists.txt. Add HAVE_STDINT_H and HAVE_STDDEF_H. Change-Id: I78cbe9d6dc3775caad5c565de0100863a9dc8054 Reviewed-on: https://code.wireshark.org/review/27587 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16GSM MAP: Dissect SM-RP-SMEAVasil Velichkov6-3/+27
According to 3GPP TS 29.002 this parameter contains an address field which is encoded as defined in 3GPP TS 23.040. Change-Id: If82a09e43729a90ede1619da34e50ed5d14e869a Reviewed-on: https://code.wireshark.org/review/27569 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-16Update a comment.Guy Harris1-0/+6
Change-Id: I0ea38f9d5c0e474cf669857d427310e56d1fb7a6 Reviewed-on: https://code.wireshark.org/review/27582 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16WSUG: Fix an attribute.Gerald Combs1-1/+1
Change-Id: I48a81ada4b9be0f5af9c81532845e3fea23eed21 Reviewed-on: https://code.wireshark.org/review/27581 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16travis: remove duplicate line.Dario Lombardo1-1/+0
Change-Id: I39c3aa14b9d4b7dbe78a1be697aa67bf4609dbc5 Reviewed-on: https://code.wireshark.org/review/27578 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-05-16travis: enable apt update.Dario Lombardo1-0/+1
Change-Id: I102b669238dcbf3b8fce8b7429da08f471a20811 Reviewed-on: https://code.wireshark.org/review/27575 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-05-16Not GTK+-only any more.Guy Harris1-1/+1
Change-Id: Ic4290fbaca37dd1353d44d9ab1ce29750aa4f747 Reviewed-on: https://code.wireshark.org/review/27574 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16Get rid of a GTK+-only field.Guy Harris2-4/+0
Change-Id: Iab68aaf0507fc94ff85deaf41c8ee23818d568c1 Reviewed-on: https://code.wireshark.org/review/27573 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16pfcp: add message length checkJoakim Karlsson1-0/+9
According to TS 29.244, 7.2.2.4.1, message length shall exlude the mandatory part of the PFCP header (the first 4 octets) Change-Id: I46d6ab65d71eb6c6e574b47d0c8f18f7b40a092e Reviewed-on: https://code.wireshark.org/review/27567 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16Minimum supported QT-Version is 5.2Joerg Mayer1-1/+1
Change-Id: I9652a4d19b73a95022b39f738d6ad01dd458df94 Reviewed-on: https://code.wireshark.org/review/27572 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-05-16Not GTK+-only any more.Guy Harris1-1/+1
Change-Id: Id286252e4e59e141fce962020813f522f0b817bb Reviewed-on: https://code.wireshark.org/review/27571 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16Qt: Implement the capture info dialog.Gerald Combs12-62/+336
Add back the capture info dialog. Draw sparklines for each protocol. Update the User's Guide. Bug: 12004 Change-Id: I45be8a0df4752255831a8b139ee84bb34d675ba9 Reviewed-on: https://code.wireshark.org/review/27565 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16Windows: Make sure more native dialogs handle HiDPI.Gerald Combs32-64/+199
Add a WiresharkFileDialog class, which is a thin wrapper around a few QFileDialog functions that sets per-monitor v2 DPI awareness before showing native dialogs and resets the awareness context afterward. Use it where we call QFileDialog::getXXX. Change-Id: Ib711a70aa94b693a2515804a729f666ea7fbd673 Reviewed-on: https://code.wireshark.org/review/27568 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16megaco: fix issue found PVS Studio (V517)Alexis La Goutte1-6/+0
The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Change-Id: Id3e4584d1cafebd6643dd97c21916ef6b1818d9d Reviewed-on: https://code.wireshark.org/review/27510 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16CMake 3.11.0 has problems on Lion; use 3.5.2, which works.Guy Harris1-1/+1
We're using 3.5.2 on the buildbot. 3.11.0 appears to be getting tripped up by the libc++ on Lion, cutting off lines at 1024 characters in generated Makefiles. Change-Id: Iff1a2fb13ef873e5d0976544f3c8248239a9772d Reviewed-on: https://code.wireshark.org/review/27570 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16ldap: fix issue found by PVS Studio (V1001)Alexis La Goutte2-5/+3
The 'offset' variable is assigned but is not used until the end of the function Change-Id: Ib626b81f78b1b59547f451952cbdfb1bf04d2205 Reviewed-on: https://code.wireshark.org/review/27507 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16wbxml: fix issue found by PVS Studio (V1001)Alexis La Goutte1-1/+1
The 'len' variable is assigned but is not used until the end of the function Change-Id: I98f0cc298e503412e0bdf8919a4a7be8ef45a2f9 Reviewed-on: https://code.wireshark.org/review/27506 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16smpp: fix issue found by PVS Studio (V1001)Alexis La Goutte1-1/+0
The 'offset' variable is assigned but is not used until the end of the function Change-Id: Idd5bc657bb0c64020fda0833a7eead357b463be7 Reviewed-on: https://code.wireshark.org/review/27505 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16rtps: fix issue found by PVS Studio (V1001)Alexis La Goutte1-4/+1
The 'offset' variable is assigned but is not used until the end of the function Change-Id: I699c8ea4c6533b9834aefbd12b920b04876773ee Reviewed-on: https://code.wireshark.org/review/27504 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16h264: fix issue found by PVS Studio (V1001)Alexis La Goutte1-1/+1
The 'bit_offset' variable is assigned but is not used until the end of the function Change-Id: Id71b12177b6259decd3db801e9833dd46419bdc4 Reviewed-on: https://code.wireshark.org/review/27503 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15ber: clamp BER lengths to avoid integer overflowPeter Wu1-0/+5
Many callers treat the length as signed integer, so ensure that the length fits in such a number. Failure to do so can have unintended consequences (such as calling "tvb_memdup(tvb, 0, -1)" and assuming that the length is actually 2^32-1). Although an exception could be thrown as well, let's give the caller a chance to handle this themselves. Change-Id: If92545f7d3603250f75741040435000ba879b7e3 Ping-Bug: 14682 Reviewed-on: https://code.wireshark.org/review/27563 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15ber: fix buffer overrun (read) in dissect_ber_constrained_bitstringPeter Wu1-3/+3
The length is an unsigned integer, but some users (such as tvb_memdup) expect signed integers and treat negative values specially. Bug: 14682 Change-Id: Ic3330d23d964b5cc44718b61c8985880f901674d Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8011 Reviewed-on: https://code.wireshark.org/review/27562 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15tvbuff_zlib: reject negative lengths to avoid buffer overrunPeter Wu1-1/+1
Negative lengths and empty buffers are not uncompressable, reject them. A buffer overrun (read) could occur otherwise due to unsigned "avail_in" becoming insanely large. Bug: 14675 Change-Id: I20b686cc6ad6ef8a8d1975ed3d2f52c8eb1f1c76 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7166 Reviewed-on: https://code.wireshark.org/review/27561 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15ISMP: fix tuple decodingPeter Wu1-10/+17
EDP_TUPLE_HOLD dissection was broken due to a length parameter mixup in v1.99.1rc0-224-g6720c80bab. The TLV length calculation was changed in commit ed5453d892, but the only pcap I could find for which it made a difference includes the TL lengths in the length field. Since commit 067a076179, the IPXNET type was wrongly decoded, fixed now. Check IPX address length to avoid a buffer overrun (read) in get_ether_name by at most 5 bytes. Bug: 4943 Bug: 14672 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6451 Change-Id: Ia99ab15578ecae6d5a3ec22989507d64f9926933 Reviewed-on: https://code.wireshark.org/review/27554 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15dissectors: fix uint to int wrong sign promotion.Dario Lombardo2-4/+4
The result of guint16 * guint16 can lead to a wrong sign promotion, when the result is assigned a uint64. Fixed by forcing the operands to be guint32. CIDs: 1247713 1111813 1111812 1111811 1111810 1111809 1111808 1111807 Change-Id: Ibca08ee3766f6c79b933c3db7ccd1f8f906cb3fe Reviewed-on: https://code.wireshark.org/review/27441 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15x509: Add decoding of UseridAndersBroman3-8/+38
"0.9.2342.19200300.100.1.1" "id-userid" Bug 14655 Change-Id: Ia5d9a5655f411fe47ec60ad897254adec2d28b47 Reviewed-on: https://code.wireshark.org/review/27564 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15umts_rlc, umts_mac: fix memory leaks (found via ASAN)Ivan Nardi2-5/+4
Such leaks are triggered by malformed packets Change-Id: Ie392834b235cf9c5a249ede7fffb5a0dbdb360e5 Reviewed-on: https://code.wireshark.org/review/27556 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-15wiretap: Add a reader for files in the PEM-like format specified by RFC 7468Роман Донченко7-2/+242
Change-Id: I8109025120d01c915f3a9d5550aa9272ec83893a Reviewed-on: https://code.wireshark.org/review/27334 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-15gsm_a_dtap: fix off-by-one buffer overflow (write)Peter Wu1-1/+1
The output buffer needs one more byte for the string terminator. Bug: 14688 Change-Id: I7d606aa8fb769fd65ba894f0472ada3543a1e3cd Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6420 Reviewed-on: https://code.wireshark.org/review/27539 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15lwm2mtlv: Add Resource name tablesStig Bjørlykke2-63/+503
Add one fixed table for OMA (Normative) defined resource names and one table for user defined resource names. All resources are identified by a object ID and a resource ID. Show number of elements in arrays instead of number of bytes. Next iteration will add proper hf entries for OMA elements. Change-Id: I4d6c053a7c448cc65692ba1d1e92a2033ff3b397 Reviewed-on: https://code.wireshark.org/review/27551 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15CMake: require at least CMake 3.5Peter Wu9-125/+63
CMake 3.11 with the Ninja generator started complaining about CMP0058 related to ui/qt/CMakeFiles/qtui_autogen.dir/RCCstock_iconsInfo.cmake amd other files (AUTORCC). While the policy could be set explicitly, let's try to modernize the CMake configuration: - Drop CMP0042, if this gives issues with macOS, then it must be solved in a different way using non-deprecated methods. - Drop CMP0054 and ensure that all if("${foo}") and if(${foo}) are converted to if(foo). - Remove string comparison against "-NOTFOUND", it already evaluates to false in an if condition. - Use CXX_STANDARD/CXX_STANDARD_REQUIRED for Qt 5.7 and newer. - Assume that copy_if_different can accept multiple sources (CMake 3.5). - Consistency: Out of the 60 CMake 3.11 FindXxx.cmake files that use find_library, 34 contain "XXX_LIBRAR" while 16 contain "Xxx_LIBRAR". Let's assume uppercase variables (now custom MaxMindDB include dirs are correctly used). CMake 3.5 was chosen as the next version because of its wide support. Ubuntu 14.04 ships with cmake3 3.5.1, Debian jessie-backports has 3.6.2, EPEL for CentOS/RHEL6 includes cmake3 3.6.1 and SLES12 SP2 has 3.5. Change-Id: I2fa7b94bf8cc78411f414987d17bab3a33dfb360 Reviewed-on: https://code.wireshark.org/review/27444 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15CMake: fix Git binary parameterJoakim Karlsson2-3/+3
if (${GIT_EXECUTABLE}) never worked, hence the variable GIT_BIN_PARAM never had any value, and by so never added the Optional git-bin parameter to make-version.pl Make-version.pl now handle optional git-bin argument with value. Change-Id: I089539a3d33455b8de09928b54e0ea39d1aecbb8 Reviewed-on: https://code.wireshark.org/review/27485 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-15Update Eugene Adell's email in .mailmapPascal Quantin1-1/+1
Followup of g548f7547fe Change-Id: I700d9bde2dc73ce2953e804350bfe054817b1818 Reviewed-on: https://code.wireshark.org/review/27552 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-15Mention how to get Ninja, and speak more of UNIX and UNIX-like platforms.Guy Harris1-19/+36
And put hyphens in "out-of-tree" and "in-tree". Change-Id: I55c54a1334f490f948310139741fecf27203a359 Reviewed-on: https://code.wireshark.org/review/27550 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15Don't speak of "UNIX".Guy Harris1-7/+8
macOS is a UNIX(R) and FreeBSD isn't a UNIX(R), but we mentioned macOS along with UNIX but didn't mention FreeBSD along with UNIX. Instead, just speak of "UN*Xes" and give Linux, macOS, and *BSD as examples. Feel free to add Solaris, AIX, or HP-UX if you want, assuming you can build Wireshark on them. Change-Id: I85be3861fa0bc603b93d077a2d9d587d43cb6e7e Reviewed-on: https://code.wireshark.org/review/27549 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15Give Ninja build instructions if we've installed Ninja.Guy Harris1-2/+7
Change-Id: I629f0e48e1b66ae9bb65f025669fd94b2480e765 Reviewed-on: https://code.wireshark.org/review/27548 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15Download and install Ninja.Guy Harris1-0/+50
The Developer's Guide recommends Ninja for all UN*Xes, so download it rather than having to say "but on macOS use make". Change-Id: I147b96144c25d01151c68e13d249172023b1fccc Reviewed-on: https://code.wireshark.org/review/27544 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15Get rid of debugging printout.Guy Harris1-1/+0
Change-Id: I6641aca753b40a8a06ce8d3baf47d37cdf0c420a Reviewed-on: https://code.wireshark.org/review/27543 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15Clean up Qt installation.Guy Harris1-46/+96
We don't support 32-bit builds on macOS, so get rid of the now-unused TARGET_PLATFORM variable and the comment about how to build 32-bit libraries. Follow the complex rules that Qt's download directories unfortunately require to get the .dmg for a given release. Drop support for installing Qt 4. CMake doesn't use pkg-config to find the Qt frameworks, so we don't need to fix up the .pc files (which aren't even shipped with later versions of Qt). Change-Id: I5edc69f8b34dac47bb2310689f296ce37347f495 Reviewed-on: https://code.wireshark.org/review/27542 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-14Update a comment.Guy Harris1-1/+1
Change-Id: Ia5971b466f2e2da40730933b44bba5672d94c399 Reviewed-on: https://code.wireshark.org/review/27541 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-14Builds require CMake, so always install it.Guy Harris1-35/+12
Don't have an option not to install it. (If we want to avoid installing it when it's already been installed by something other than this script, we should check for its existence before installing, and skip the installation step for it.) Get rid of the instructions for autotools builds; always show the instructions for CMake builds. We wouldn't get to the uninstall stage if it hadn't been installed by this script; remove the comment asking about that. Change-Id: I276ee96bf955ef4ff33dea87bc27c21111301ea0 Reviewed-on: https://code.wireshark.org/review/27540 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-14changing Author's email for Eugene AdellEugene Adell1-1/+1
Change-Id: Ic8318d63110e4b27c06310467aad4bd71226e93d Reviewed-on: https://code.wireshark.org/review/27538 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-14Qt: MainWindow::dropEvent fixes.Gerald Combs1-1/+8
Limit our dropped file count to 100. Make sure we always accept our proposed action and either accept or ignore the event. Blind attempt at fixing bug 14609. Change-Id: Id08b179b6eb63529aa15bce7284460fbd19f7fec Ping-Bug: 14609 Reviewed-on: https://code.wireshark.org/review/27462 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-14rtcp: fix buffer overflow in transport-cc dissectionPeter Wu1-12/+29
When the packet status chunks cover more packets than advertised in the packet status count field, fail rather than writing past the end. https://tools.ietf.org/html/draft-holmer-rmcat-transport-wide-cc-extensions-01#section-3.1.2 Bug: 14673 Change-Id: If90baef3610d8f884b0772a4b81d6dcb4ebc9227 Fixes: v2.5.0rc0-2533-ga584eab239 ("New RTCP dissector for transport-cc") Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6464 Reviewed-on: https://code.wireshark.org/review/27527 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Rui Zhang <rzhang@grandstream.cn> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-14Free g_array_free-related memory leaksPeter Wu7-21/+9
g_array_free(a, FALSE) returns "a->data". Callers that do not handle this will leak memory. Convert other users to use the return value instead of direct access to "a->data". Change-Id: I0a29864e8106c0bf09e9573ef29e4474179c4171 Reviewed-on: https://code.wireshark.org/review/27438 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-14Free g_ptr_array_free-related memory leaksPeter Wu9-13/+11
g_ptr_array_free(a, FALSE) returns "a->pdata". Callers that do not handle this will leak memory (e.g. "tshark -G plugins"). Convert other users to use the return value instead of direct access to "a->pdata". Change-Id: I29835477d587f5f54bf0d94cdae9f375e3da3ce3 Reviewed-on: https://code.wireshark.org/review/27437 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 03:20:57 +0000