aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-10-18Increase maximum USBPcap packet size to 128 MiBTomasz Moń1-2/+2
It turned out that 1 MiB is not enough as atleast the URBs sent by Android fastbool tools are greater than 1 MiB (1 MiB payload + USBPcap pseudoheader). Raise the maximum packet size all the way up to 128 MiB. 128 MiB is the upper bound of maximum packet that can be captured by all official USBPcap releases. Bug: 15985 Change-Id: Ibbf41f7efae6e0f841e36d39664394e8a8eae77d Reviewed-on: https://code.wireshark.org/review/34793 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-17Wi-Fi NAN: Fix rval_to_channel_set reading past end of op_class_ch...Connor Newton1-1/+3
Looks like I broke it by fixing it... Added the table terminator again. The real solution to this when there is time is to use the 802.11 dissector for operating classes, as this is a duplicate and not fantastically thought out implementation. Bug: 16123 Change-Id: Ide7071b71825b1595e14a474bcb0c57ee8eb0bf5 Reviewed-on: https://code.wireshark.org/review/34792 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-16androiddump: Fix tcpdump encap type signed/unsigned conversion errorMikael Kanstrup1-1/+1
androiddump determines encap type by reading the data link type value from pcap content generated by tcpdump running on the device. The data link type is converted from an uint type to an int type because int is what the pcap/wtap API expects. However the signed to unsigned conversion is performed on an 8-bit data value rather than the full 32-bit value making DLT values larger than 127 fail. Fix the unsigned to signed conversion by determining DLT from the full 32-bit "network" field from pcap global header instead of the 8-bit data char array. While at it also take caore of device to host endianness conversion. Fixes: v2.5.1rc0-65-gbfef57ebb7 ("androiddump: Fix and simplify tcpdump capture") Fixes: v2.9.0rc0-694-gafd0eef4f6 ("androiddump: Fix tcpdump encap type when libwiretap is used") Change-Id: I71629b166a6893763b16e9df33408fee8c99cbd2 Reviewed-on: https://code.wireshark.org/review/34788 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-16wslua: Improve parameter check in ProtoField.new()Stig Bjørlykke2-11/+44
Improve paremeter check in ProtoField.new() when using ftypes.CHAR: - Check valid base types and give an error when not supported instead of terminate in a g_error() (base.DEC is not supported). - Give an error if used with base.UNIT_STRING instead of silently remove the flags. - Support base.RANGE_STRING instead of removing the flag. Support using base.NONE with a valuestring. Add ftypes.CHAR to the list of supported types. Change-Id: I0e3f9698074c807f5da0de23ccd1be7446271135 Reviewed-on: https://code.wireshark.org/review/34783 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-16wslua: Add ProtoField.char()Stig Bjørlykke1-4/+29
ProtoField.new() already support ftypes.CHAR, so add ProtoField.char() to complete the support for FT_CHAR in Lua. Change-Id: I0568f874fd667f834584a07af14bdda9bb03856b Reviewed-on: https://code.wireshark.org/review/34784 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-15Lua: Use space for indentStig Bjørlykke1-6/+6
Remove use of TAB. Change-Id: Ic2a08f6b325e1fc52a5b043aa09e8f98dacd8c5e Reviewed-on: https://code.wireshark.org/review/34780 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-10-14Add in a comment explaining the huge hack being done.Guy Harris1-1/+17
Change-Id: Ic1811d59cd25f8e7facc343bf967db878c1b9f53 Reviewed-on: https://code.wireshark.org/review/34779 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-14Lua: Support FT_CHAR in FieldStig Bjørlykke1-0/+1
Add support for fetching FT_CHAR field values. Bug: 16129 Change-Id: I0e3b0c784277e259fb7cd1725254fc7a723f6d1e Reviewed-on: https://code.wireshark.org/review/34775 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-10-14AT: Add ZUSIM commandDarien Spencer1-0/+40
Change-Id: I691e8aa2277866f49bf93b33668b69b4662f6d75 Reviewed-on: https://code.wireshark.org/review/34774 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-10-14Wi-Fi NAN: Fix NULL g_str_has_suffix errors in NAN beacon type detectConnor Newton1-2/+16
Should only occur with malformed data. Checks and notices added. Bug: 16119 Change-Id: Id0bbc699e587c238dbdd2c0e4c873d6bb6026005 Reviewed-on: https://code.wireshark.org/review/34762 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14GTPv2: 8.38 MM Context check end of IE.Anders Broman1-0/+8
Change-Id: I109c78186fcffe635bac13ceb7174749451bf0d1 Reviewed-on: https://code.wireshark.org/review/34773 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14NAS-5GS: EPS bearer identity only uses bit 8 - 5.Anders Broman1-1/+1
Change-Id: I592d5d69d874fbd29ba7e5af83df311daaa37ebe Reviewed-on: https://code.wireshark.org/review/34772 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14mqtt: fix conflictAlexis La Goutte1-2/+2
'mqtt.willmsg' exists multiple times with NOT compatible types: FT_STRING and FT_BYTES 'mqtt.msg' exists multiple times with NOT compatible types: FT_STRING and FT_BYTES Change-Id: Iaace2464c3e7174bbd6adc7550fe51e614b4d0bb Reviewed-on: https://code.wireshark.org/review/34750 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14Wi-Fi NAN: Fix defererence NULL in 802.11 channel set lookupConnor Newton1-3/+4
Bug: 16119 Change-Id: I1d10f6ff85c32490d069ba98121e1301c75ccbab Reviewed-on: https://code.wireshark.org/review/34760 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14Protobuf: Support leading dot for the message/enum type of fieldHuang Qiangxiong1-1/+14
The message/enum type of field is allowed to start with '.' (for example, .foo.bar.Baz), that means to search the message/enum to start from the outermost scope instead. Please refer to: https://developers.google.com/protocol-buffers/docs/proto3#packages-and-name-resolution Please find example capture file from Bug: 16118 Ping-Bug: 16118 Change-Id: I78702d0b2316b4071f04aba9fc7d185e382e4cbf Reviewed-on: https://code.wireshark.org/review/34752 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14Protobuf: Add show_details preferences. Fix two bugs.Huang Qiangxiong8-58/+155
1. Add show_details preferences. Disable it will hidden names of message/field/enum, field number, and other details. 2. Have only one popup message with all the errors listed, that are found during parsing .proto files. (Buffer errors and print once) Loading .proto files and checking message types of UDP port will be done only when protobuf dissector has been called. 3. Support parsing .proto files in legacy MAC file format (that newline is '\r') or mixed newline (\r + \n) file format. Change-Id: I97bcde000957e4cd1cce98a7f61120d03027423e Reviewed-on: https://code.wireshark.org/review/34736 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14Qt: Fix export dissection dialogTomasz Moń2-17/+17
The export got broken in f67eccedd9836e6ced1f57ae9889f57a5400a3d7 as it didn't account for ExportDissectionDialog::exec() override. Change-Id: Ieaed669cb1b12c7a069f685429bf5a82f89d7391 Reviewed-on: https://code.wireshark.org/review/34771 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-13[Automatic update for 2019-10-13]Gerald Combs10-42/+111
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I8fb64d783d963cbf378cac3ddda0d63f18495b99 Reviewed-on: https://code.wireshark.org/review/34766 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-13We don't compile Qt, we just install a binary.Guy Harris1-1/+1
Change-Id: Ieeaa2b393775ae58782c0f2447b51fd068ffc185 Reviewed-on: https://code.wireshark.org/review/34763 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-11NAS 5GS: fix null_decipher preference textPascal Quantin1-2/+2
Change-Id: I0ce8f529ac0a0eb7a573544b1abfc033331aea3c Reviewed-on: https://code.wireshark.org/review/34759 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-10CMake: Remove some header defines.Gerald Combs2-10/+0
It looks like HAVE_SYS_TYPES_H, HAVE_STDINT_H, and HAVE_STDDEF_H were required for check_type_size via test_big_endian, but we don't use that any more. HAVE_LRINT was used by the GTK+ UI. Change-Id: I6474c118bac4413791b3613d34d263e38107600a Reviewed-on: https://code.wireshark.org/review/34754 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-10Revert "CMake: Don't install HTML manuals twice"João Valverde16-161/+98
This reverts commit f1285fcf061669702ca1accd7b2c50ebc8198993. NSIS package is broken with this commit. Change-Id: Ief22a308edad188fa2d5fab79355f19493359fa6 Reviewed-on: https://code.wireshark.org/review/34758 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-10-10NAS-5GS: In IE Service area list, present num elements(+1).Anders Broman1-1/+21
Change-Id: I711ff35ee8ef539f5829f378ec9f96e4dab27dc3 Reviewed-on: https://code.wireshark.org/review/34756 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-09Register NetFlow dissector for NetFlow protocolFrancois Nguyen1-0/+2
Register the NetFlow dissector so it can be found by other dissectors and they can simply find_dissector("cflow"); Change-Id: I06312aede519c361de1566468f52edfffaab21eb Reviewed-on: https://code.wireshark.org/review/34753 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-09CMake: Don't install HTML manuals twiceJoão Valverde16-98/+161
HTML docs are installed to both $docdir and $pkgdatadir. Fix that to install to $docdir only. Change-Id: I115158585b6df9170d9a01249adbc8548df91f14 Reviewed-on: https://code.wireshark.org/review/34640 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-10-09QUIC: Remove some field of Preferred Address TP before draft-18Alexis La Goutte2-22/+1
Ping-Bug: 13881 Change-Id: Iae8a547d1726ae5977c59ab94f581c856225b38f Reviewed-on: https://code.wireshark.org/review/34702 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-09QUIC: Add support of GREASE Transport ParameterAlexis La Goutte2-2/+22
Bug: 13881 Change-Id: Iaf72a14e227f0406edc8e8cbb71a63be95ec7eed Reviewed-on: https://code.wireshark.org/review/34701 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-09LoraWan: fixed downlink decryptionAchuthan Paramanathan1-1/+1
using uplink parameter as input for calc. the nonce for decryption Bug: 16110 Change-Id: I3da1afbe80629a378a9ecc63157b5854729c6159 Reviewed-on: https://code.wireshark.org/review/34751 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-09mqtt: Dissect connect last will message as bytesAli Sabil1-1/+13
The MQTT specification says "The Will Message defines the Application Message that is to be published to the Will Topic", Application Messages are defined as being application specific. Change-Id: I3fad1cb5f676b0232ba9e29af0d213b536ce4ef6 Reviewed-on: https://code.wireshark.org/review/34749 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-10-08Get rid of some unnecessary string operationsJoerg Mayer1-9/+7
Change-Id: I5e92ed52616dd7eb0837228abc5c3975d7f9228b Reviewed-on: https://code.wireshark.org/review/34734 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-08amp: remove duplicate copyrightAlexis La Goutte1-14/+0
Only need SPDX-License-Identifier Change-Id: Ib7bae961acb5810d99a3e44d4f5a7fe437bb6133 Reviewed-on: https://code.wireshark.org/review/34748 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-08Release notes: Remove an item.Gerald Combs1-1/+0
The recent macOS installer changes were backported to master-3.0, so they're no longer new in master. Change-Id: I357e0f8facbc2266c3780bcf8d696b5c2b00602d Reviewed-on: https://code.wireshark.org/review/34745 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-08Update some ACI field namesJoerg Mayer1-17/+16
Change-Id: I2add057ae4ebd9e2faca5e9ff201817810e10562 Reviewed-on: https://code.wireshark.org/review/34735 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2019-10-08Update qt 5.12.1 -> 5.12.4 and update a comment (twice)Joerg Mayer1-3/+3
Change-Id: I2eab2f73305918a354b8b9b9c5616ef290a40284 Reviewed-on: https://code.wireshark.org/review/34733 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2019-10-08Update ASCIIDOCTOR to current version(s)Joerg Mayer1-2/+2
Change-Id: Ieb87169ffc7dae709954e2f361202cec88d3dedb Reviewed-on: https://code.wireshark.org/review/34732 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2019-10-08Wi-Fi NAN: Add support for Wi-Fi NAN protocolKingson Chan5-205/+4371
Add support for the WFA Neighbor Awareness Networking (NAN) protocol. Bug: 16087 Change-Id: Ideeeea2551c8db722b5578340bef4e504ea73dcf Reviewed-on: https://code.wireshark.org/review/34635 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08Qt: Simplify Wireshark Dialog classRoland Knall2-41/+22
Simplify class handling and clear up some names Change-Id: I8a3dd80c0b4dd97aee6164d94ca9cf60068f427b Reviewed-on: https://code.wireshark.org/review/34730 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-08GTPv2: Add basic dissection for Monitoring Event Extension InformationAnders Broman1-1/+11
Change-Id: Ic3bd56d383840e3cf9521feb77a7d6bfbdc50aa4 Reviewed-on: https://code.wireshark.org/review/34729 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08protobuf: Fix typo in error messageStig Bjørlykke1-2/+2
Change-Id: I0a3ef1a2c690148672aa65a8385f230e7f070e57 Reviewed-on: https://code.wireshark.org/review/34728 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-10-08WSUG: Clean up opening sentencesMoshe Kaplan1-3/+2
Change-Id: I7c1443459f5705a1a087dfe3e3af8c3826dc1f08 Reviewed-on: https://code.wireshark.org/review/34727 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-08WSDG: Fix duplicate 'the the'Moshe Kaplan1-1/+1
Change-Id: Iaa383391daa6deb569852fe4bb464f7cda3658dd Reviewed-on: https://code.wireshark.org/review/34726 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08WSUG: Clean up duplicated wordsMoshe Kaplan4-5/+5
Used egrep "\b([a-zA-Z]+) \1\b" docbook/wsug_src/*.adoc to find instances where words were erroneously duplicated. Change-Id: Ie390fa4f1c61a288ff0ed77aa84c4fb01f4de27e Reviewed-on: https://code.wireshark.org/review/34725 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-07Qt: Reduce use of CaptureFileRoland Knall3-22/+29
In preparation of having just a single instance of CaptureFile dialogs are redesigned to not use CaptureFile Change-Id: I2bff036d6f9e946954873c90b935b6653fbeb474 Reviewed-on: https://code.wireshark.org/review/34723 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-07protobuf: add support for Protocol Buffers Language (*.proto) filesHuang Qiangxiong10-159/+3174
1. A C-style Protocol Buffers Language (PBL) parser for *.proto file is added. It contains protobuf_lang_scanner.l (lex scanner), epan/protobuf_lang.y (grammar parser), and protobuf_lang_tree.h/c (grammar tree implementation). 2. The protobuf-helper.h/cpp is an interface wrapper layer. If one day C++ is allowed, we can create a protobuf-helper.cpp file, which using offical protobuf C++ library, to replace protobuf-helper.c. That keeps packet-protobuf.c unchanged. 3. User can specify protobuf search paths, and the UDP ports to protobuf message type maps at the Protobuf protocol preferences. 4. Other dissectors can pass the message type to Protobuf dissector by data parameter or pinfo->private_table["pb_msg_type"] (pinfo.private["pb_msg_type"] in lua). Some Sample of GRPC with Protobuf captures can be found in Bug: 13932. Bug: 13932 Change-Id: Ife16c2f7b381296f8db4740dabe5f8362a456f48 Reviewed-on: https://code.wireshark.org/review/22892 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-07SMB: fix dissection of Directory Information field in Search (0x81) responseManfred1-1/+1
The dissector assumed 46 instead of 43 as Directory Information field length Bug: 15817 Change-Id: I25f1c95a202c0f0156062eda93a3690911ef50aa Reviewed-on: https://code.wireshark.org/review/33464 Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Roland Knall <rknall@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-06dumpcap: fix capture library version display on WindowsPascal Quantin1-13/+11
Ensure to call load_wpcap() berfore building the version info string. Bug: 16108 Change-Id: Ida7ecf6ad5186f816e1bf33902a0ae70f7f36b40 Reviewed-on: https://code.wireshark.org/review/34719 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-06FTDI FT: Register OpenVizsla USB VID/PIDTomasz Moń1-0/+3
In case of OpenVizsla the FTDI FT dissector is useful for toubleshooting host software issues. Change-Id: Iac5d2960ca04e6c4fa4619f204bce0c1c4de3b3e Reviewed-on: https://code.wireshark.org/review/34718 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-06[Automatic update for 2019-10-06]Gerald Combs16-62/+209
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I1489711e2f2cd69512f05eab85c93729349271f1 Reviewed-on: https://code.wireshark.org/review/34715 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-05GPRS RLC/MAC: clarify defcription of hf_global_tfiVadim Yanitskiy1-1/+1
According to 3GPP TS 44.060, section 12.10 "Global TFI", the first bit of that IE defines whether it's an Uplink (0) or Downlink (1) TFI (Temporary Flow Identity). Before this patch: Global_TFI .1.. .... = UL TFI: (Union) ..01 110. = DL TFI: 14 After: Global_TFI .1.. .... = Uplink (0) or Downlink (1) TFI: (Union) ..01 110. = DL TFI: 14 Change-Id: Idcf25b007bce8ee065fd10753dbd3292ab0ce95e Reviewed-on: https://code.wireshark.org/review/34713 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-05GSM RLC/MAC: distinguish TA Index / TS number for Uplink and DownlinkVadim Yanitskiy1-6/+49
According to 3GPP TS 44.060, section 12.12a "Global Packet Timing Advance", there may be five optional fields in this IE: - TIMING_ADVANCE_VALUE, - UPLINK_TIMING_ADVANCE_INDEX, - UPLINK_TIMING_ADVANCE_TIMESLOT_NUMBER, - DOWNLINK_TIMING_ADVANCE_INDEX, - DOWNLINK_TIMING_ADVANCE_TIMESLOT_NUMBER. For the last 4 fields we should clearly distinguish between the Uplink and Downlink. Otherwise it looks confusing: Common_Timeslot_Reconfigure_Data.Global_Packet_Timing_Advance ..0. .... = TIMING_ADVANCE_VALUE Exist: 0 ...0 .... = TIMING_ADVANCE_INDEX Exist: 0 .... 1... = TIMING_ADVANCE_INDEX Exist: 1 .... .001 0... .... = TIMING_ADVANCE_INDEX: 2 .110 .... = TIMING_ADVANCE_TIMESLOT_NUMBER: 6 After this patch: Common_Timeslot_Reconfigure_Data.Global_Packet_Timing_Advance ..0. .... = TIMING_ADVANCE_VALUE Exist: 0 ...0 .... = UPLINK_TIMING_ADVANCE_INDEX Exist: 0 .... 1... = DOWNLINK_TIMING_ADVANCE_INDEX Exist: 1 .... .001 0... .... = DOWNLINK_TIMING_ADVANCE_INDEX: 2 .110 .... = DOWNLINK_TIMING_ADVANCE_TIMESLOT_NUMBER: 6 Change-Id: I65d7fa579ebbd7af49c03875810444352333a5a0 Reviewed-on: https://code.wireshark.org/review/34712 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 11:25:51 +0000