aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-12-08Kafka: Decrease our maximum decompression buffer size.Gerald Combs1-1/+3
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockOutputStream.java maxes out at 2^22, so use that.
2020-12-08GitLab CI: Update lintian excludes.Gerald Combs1-1/+1
Add "copyright-excludes-files-in-native-package" to the lintian exclude list. The wireshark/wireshark-ubuntu-dev image was updated to 20.04 recently, and its lintian added https://lintian.org/tags/copyright-excludes-files-in-native-package.html.
2020-12-07SMB/SMB2: FS Name is always UnicodeUli Heilmeier3-5/+5
According to MS-CIFS sections 2.2.8.2.6 [1] FS Name (or Label) string is in unicode. [1]: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-cifs/1011206a-55c5-4dbf-aff0-119514136940 Fixes: wireshark/wireshark#17064
2020-12-07Qt: column list model: remove unused ListElement componentMartin Kaiser1-1/+0
Selecting Edit / Preferences on my asan+ubsan build brings up the following warning from ubsan: /media/sf_wireshark.git/ui/qt/models/column_list_model.cpp:273:9: runtime error: load of value 25, which is not a valid value for type 'bool' The problem is in ColumnListModel::populate(), where a ListElement is populated from fmt_data. The ListElement's "changed" component is not initialized, though. It looks like "changed" is not used anywhere. This patch removes it from the ListElement struct.
2020-12-07Windows: update libs cleanup pathsPascal Quantin1-2/+3
2020-12-07Qt: Fix packet bytes hover rectangle positionStig Bjørlykke2-6/+16
For Qt 5.11 and newer use horizontalAdvance() instead of boundingRect().width() to calculate the width of a QString to position the hover rectangle position, and to select which byte(s) to highlight. Closes #17033.
2020-12-07TPNCP: Minor cleanupOrgad Shaneh1-4/+23
Change-Id: I23a370c7a62cdef4c28ba487f8f2c73bb5455857
2020-12-07Snort: Try to address confusion from issue 17062.Martin Mathieson1-2/+8
2020-12-07packet-radius.c: Replace gcry_md_copy() with gcry_md_reset()Moshe Kaplan1-12/+4
Instead of successively calling gcry_md_copy() and gcry_md_close(), call gcry_md_reset(), to avoid creating and releasing contexts. Besides the minor performance improvement, this should also fix Coverity 1450263 and 1450848, which detect two resource leaks.
2020-12-06Four trivial comment typo fixes of ‘ad’ to ‘as’Jim Young4-4/+4
2020-12-06[Automatic update for 2020-12-06]Gerald Combs7-69/+294
Update manuf, services enterprise numbers, translations, and other items.
2020-12-06Fix reported_len in Lua framewark when creating tvb from range.George Powers1-1/+2
This bug affects Lua plugin dissectors for encapsulation protocols like GRE. Typically the dissector creates a range for the payload packet, then calls the next dissector with a tvb derived from the range, using TvbRange_tvb(). The original version calls tvb_new_subset_length_caplen() using the remaining capture length for the reported_len argument. The fix passes -1 as the reported length, and tvb_new_subset_length_caplen() calculates the new reported_len as required. The bug only affects large packets captured with a snaplen and truncated, then decoded with a Lua plugin for the encapsulation header. Here's the typical bug symptom, gleaned from tshark decode of an encapsulated IP payload: [Expert Info (Error/Protocol): IPv4 total length exceeds packet length (114 bytes)] [IPv4 total length exceeds packet length (114 bytes)] Closes #15655.
2020-12-05editcap: add IDBs to second and subsequent output files.Guy Harris1-11/+63
Remember all the IDBs we've seen from the input file so far and, if we're writing multiple files (splitting an input file into multiple output files), add all those IDBs to each of the output files. Fixes issue #17060.
2020-12-05DOCSIS: Add FDX Sub-band TLV support in MDD Downstream Active Channel ListAndrii Vladyka1-0/+5
2020-12-05Windows: Upgrade c-ares and nghttp2.Gerald Combs1-6/+6
Upgrade c-ares to 1.17.1 and nghttp2 to 1.42.0.
2020-12-04Add a documentation comment for wtap_dump_add_idb().Guy Harris1-0/+11
2020-12-04wlan: don't commit to the "OLPC"/"Atheros" stuff being either of them.Guy Harris1-8/+9
We don't necessarily know why that stuff is there; is it some stuff used in OLPC mesh networks (mesh control header), is it something added by Ruckus wireless devices, is it something added by Atheros used by the Ruckus devices, or something else? Sometimes the Ruckus devices seem to add an OLPC-like 0x00 0x00, and sometimes they seem to add a copy of the sequence number. So just call it "Mysterious extra OLPC/Ruckus/Atheros/??? stuff".
2020-12-05Release notes: Wireshark now supports reading ETWOdysseus Yang1-0/+5
2020-12-04wlan, llc: support EPD and LPD for 802.11 frames.Guy Harris2-23/+135
Replace the special-purpose hack in the 802.2 LLC dissector for WSMP, Ethertype 0x88DC, with a general mechanism in the 802.11 dissector to attempt to determine whether the frame uses Ethertype protocol discrimination (EPD) or LLC protocol discrimination (LPD) at the LLC sublayer, as defined in IEEE Std 802-2014.
2020-12-04NGAP: don't include packet-ngap.h twiceMartin Mathieson2-9/+7
2020-12-04Initial try at y_axis_factor for I/O graphThomas Stewart2-7/+18
2020-12-04Qt: Prevent multiple check marks in custom columnStig Bjørlykke1-2/+10
This was prevented before but was broken in g3a7966c7.
2020-12-04column-info.h : increase COL_MAX_LEN from 256 to 2048Tom Yan1-1/+1
2020-12-04Aruba(IAP): fix typo for Gemini typeAlexis La Goutte1-1/+1
2020-12-04Bluetooth: Fix l2cap reassembly resuming old reassemblyJoakim Andersson1-1/+6
Fix l2cap reassembly resuming reassembly on old fragment that has failed when a new packet arrives that matches the remaining segmentation length of the failed reassembly. Update the l2cap_index and set segmentation started to false so that this does not happen anymore. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
2020-12-04Lua: Improve Listener error handlingStig Bjørlykke4-14/+44
Fix error handlers in Listener draw() and reset() to avoid getting LUA_ERRERR from lua_pcall(). Added error handler for Listener draw() callback. Handle LUA_ERRERR from lua_pcall() to avoid assert on this. Changed some capitalized words in various error message. Closes #16974.
2020-12-04wlan: fix a bug-number typo in comments.Guy Harris1-2/+2
2020-12-04Qt: Increase ring buffer file number limitDylan Ulis1-1/+1
Notes: 1. Wireshark internal max limit for ring buffer files is 100,000 2. Wireshark internal limit before warning the user is 65,535 3. GTK: The old GUI did not limit the value for this parameter 4. Qt: This value was limited to 1,000 Change: Set the GUI limit to match the warning limit (65,535)
2020-12-04IEEE1722: describe CVF H264 PTV fieldDmitry Buzdyk1-2/+9
2020-12-04DOCSIS: Fixed FDX Sub-band ID/offset TLVs dissectionAndrii Vladyka1-21/+23
2020-12-04fix display data of unknown vendor specific pppoe tagmirkodeckert1-1/+1
2020-12-04Qt: UAT editor column widths, italic pathnameChuck Craft6-9/+49
Closes #15968 #17059 - set width of pull down list so items are visible - allow user to resize columns in UAT editor - resize columns on open and changing data - if a UAT file does not exist, display the UAT name in lower right where pathname is displayed for files - pad pathname on right to account for right tilt of italic fonts Note: a future change may be to not resize columns where user has changed width.
2020-12-04GSM A-bis/OML: Fix ipaccess specific GPRS NSVC obj classPau Espin Pedrol1-4/+2
All NSVCs share the same object class, and the NSVCI is encoded in the FOM Object Instance TRX byte.
2020-12-04Lemon: import fresh lemon from upstreamJaap Keuter11-211/+447
- get latest lemon from upstream (SQLite) - update and apply the patches - introduce CC0-1.0 license indication - update documentation
2020-12-04GTPv1: Implement SGSN Number and Node IdentifierJohn Thacker1-13/+59
Implement GTPv1 3GPP TS 29.060 7.7.47 SGSN Number and 7.7.119 Node Identifier. Fixes #16611.
2020-12-04smb2: reduce the length of the negotiate contexts to the correct valueRonnie Sahlberg1-0/+1
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
2020-12-03RadioTap: skip present bits for vendor NS.Teyut1-0/+4
An error messages was shown when more than 1 present bits was set for a vendor NS because these bits were not skipped properly. Closes https://gitlab.com/wireshark/wireshark/-/issues/17047
2020-12-03wlan: never treat DMG frames as if they have an HT Control field.Guy Harris1-51/+171
At least one ns-3 capture has DMG frames (as indicated by the channel number being in the 60 GHz band - radiotap currently has no DMG metadata field) that have the +HTC/Order flag subfield set but have no HT Control field, causing them to be misdissected. 802.11-2016 says that DMG frames should never have +HTC/Order set; if it *is* set in a QoS frame known to be a DMG frame, flag it with an expert info item and don't treat it as having an HT Control field. Update a bunch of comments to give more information, put comments in the appropriate places, and speak of 802.11-2016 rather than older standards. While we're at it, update the title and description of the +HTC/Order flag to reflect its name as of 802.11-2016.
2020-12-03packet-mq: Improve MQINQ Displayrobionekenobi3-16/+38
Improve the display of MQINQ Segment, by adding dec/hex/Name of selector in MQINQ/MQINQ_REPLY and trying to display dec/hex/Name value of Integer Value when possible in MQINQ_REPLY
2020-12-03PI_MALFORMED is not a valid error severity; fix it to PI_ERROR.Guy Harris1-2/+2
2020-12-03GMR-1 RR: revert g165b56afe7Pascal Quantin1-2/+11
We cannot use tvb_new_octet_aligned() for this GSM 7bits packed buffer. Moreover tvb_free() call not removed was leading to a double free attempt. Closes #17055
2020-12-03Aruba(IAP): Add IAP-500 Series (Gemini)Alexis La Goutte1-0/+1
2020-12-03qt+export objects: Don't sort the header in with the content typesJohn Thacker1-8/+12
The Export Objects Content-Type filter combobox should not sort the header of "All Content-Types" in with the list of content types, but should ensure that it is always the first item, especially as the first item position is used to show all content. This is particularly an issue in some localizations; e.g., すべてのコンテントタイプ alphabetizes after actual content types. Fixes bug #17048
2020-12-03Support to dissect PXU and PXUCThiyagarajan P1-0/+186
Added support for dissecting the PXU element IEEE80211-2016, section 9.4.2.116 Added support for dissecting the PXUC element IEEE80211-2016, section 9.4.2.117
2020-12-03RPCoRDMA: fix reassembly for Position-Zero Read ChunkJorge Mora3-4/+20
A Long Call or Position-Zero Read Chunk (PZRC) MUST include appropriate XDR roundup padding to maintain proper XDR alignment of their contents. For a PZRC, padding has already been added to the payload stream thus all padding added by the InfiniBand layer must be removed before adding the fragment to the reassembly table. See: https://tools.ietf.org/html/rfc8166#section-3.5 (Section 3.5.3) Closes #17054
2020-12-03USB HID: Usage Minimum and Usage Maximum are inclusiveJohn Thacker1-3/+9
Usage Minimum and Usage Maximum are an inclusive, closed interval. This fixes an fencepost error where the Usage Maximum value was not being included as a possible value in the bitfield. Related to #17014
2020-12-03packet-lwm:Move gcry_cipher_open() and gcry_cipher_close() out of loopMoshe Kaplan1-4/+4
Instead of calling gcry_cipher_open() and gcry_cipher_close() in a loop, call gcry_cipher_reset to avoid creating and releasing contexts. Besides the performance improvement, this should also fix Coverity 1450453, which detects the multiple calls to gcry_cipher_close() as a double-free.
2020-12-02Lua: make TvbRange:raw() return a subset #12046 v2David Perry2-12/+110
My initial fix caused several double-offset errors in TvbRange_raw() because I was adjusting for the TvbRange's offset too early in the process. The proper fix is to only adjust for it in the final call to get the data. I also simplified some of the bounds checks to be based on the values in the TvbRange instead of calling `tvb_captured_length()` and the like, because its bounds are already checked against the backing Tvb when it's first taken. Massively expanded the lua test suite to account for every combination of passing offsets and lengths to a Tvb or TvbRange and to the subsequent `:raw()` call.
2020-12-02Kafka: Limit our decompression size.Gerald Combs1-24/+32
Don't assume that the Internet has our best interests at heart when it gives us the size of our decompression buffer. Assign an arbitrary limit of 50 MB. This fixes #16739 in that it takes care of ** (process:17681): WARNING **: 20:03:07.440: Dissector bug, protocol Kafka, in packet 31: ../epan/proto.c:7043: failed assertion "end >= fi->start" which is different from the original error output. It looks like *that* might have taken care of in one of the other recent Kafka bug fixes. The decompression routines return a success or failure status. Use gbooleans instead of ints for that.
2020-12-02epan: Fix a memory leak.Gerald Combs1-1/+1
Make sure _proto_tree_add_bits_ret_val allocates a bits array using the packet scope, otherwise we leak memory. Fixes #17032.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 02:54:59 +0000