aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-03-07Qt: rework routine in module_preferences_scroll_area.Dario Lombardo1-2/+5
This removes a check that confuses clang and generates a false poritive. Change-Id: Ib28b88b40e16ad300ba6d3df8334bd752a4fa7f1 Reviewed-on: https://code.wireshark.org/review/26171 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-03-07bluetooth: Update Assigned NumbersStig Bjørlykke1-19/+100
Update URLs for sources. Change-Id: Ia70bc657210e867abea1eb25c5feab189c53a230 Reviewed-on: https://code.wireshark.org/review/26324 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-03-07Qt: Handle UAT editor dialogs explicitly.Michael Mann6-82/+181
QAbstractItemView assumes that editors are widgets, not windows. QAbstractItemView::edit calls QAbstractItemViewPrivate::openEditor, which simply calls show() and setFocus() on the editor widget. If that widget happens to be a native dialog, its event loop might not be processed. This is the case on macOS at least. Create widgets derived from QLineEdit that edit the value directly along with a button that can open the associated modal dialog. Install event filters so that we keep the correct tab behavior between fields of the UAT. Bug: 13958 Ping-Bug: 14031 Bug: 7761 Change-Id: Ie5f0a5cbde33bb9add8217029c2063a0bbfd804a Reviewed-on: https://code.wireshark.org/review/23015 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-03-07Fix another leak, which happens with -E occurrence=l.Guy Harris1-4/+20
For each occurrence, if there was already an occurrence in the array, we were just removing it. not freeing what it pointed to. While we're at it, expand comments. and always check the array size with "!= 0", not "> 0" - the value is unsigned, so they're equivalent, but this makes the code more self-consistent. Change-Id: I538f46b296a7721a39ba4366c2f6269e7e097b0d Reviewed-on: https://code.wireshark.org/review/26328 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-07WIP:ieee80211: HotSpot 2.0 fixes.Richard Sharpe2-25/+581
This bring the IEEE802.11 dissector further into conformance with the HS2.0 spec. I have concerns at how complex the handling of dissect_advertisement_protocol_common has become. I also have some bugs reported by the WFA to deal with. Change-Id: I69caca7d568562b752a70e5f73a7fa395364bc23 Reviewed-on: https://code.wireshark.org/review/26279 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com>
2018-03-07print: free memory if not used (found by clang).Dario Lombardo1-2/+5
Change-Id: Ib6dc913ab1eeff7b29e18930b66b728080629773 Reviewed-on: https://code.wireshark.org/review/26183 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07ieee802154: fix 'wpan.tsch.timeslot' exists multiple times with NOT ↵Alexis La Goutte1-1/+1
compatible types: FT_UINT16 and FT_NONE Change-Id: I36ca5c469281f17e3ed9aebe1899648533a9b1a5 Reviewed-on: https://code.wireshark.org/review/26323 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07nas_5gs: fix duplicate entryAlexis La Goutte1-1/+1
Field 'Request type' (nas_5gs.mm.req_typ) has a conflicting entry in its value_string: 3 is at indices 2 (Initial emergency request) and 3 (Existing emergency PDU session) Change-Id: I64c6222033efa64c3f730b2be7e92c731d71d43c Reviewed-on: https://code.wireshark.org/review/26322 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07Plug another leak for Wiretap errors.Guy Harris1-8/+10
Clean up comments while we're at it. Change-Id: I7e218ba3f998804045e3d7fab08d85d09a293d69 Reviewed-on: https://code.wireshark.org/review/26320 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-07IEEE 802.15.4: Add expert warning for Payload IE in headerEd Beroset1-1/+8
Change-Id: I34f4814ff0a93f9ef149241fd9899b50199955c5 Reviewed-on: https://code.wireshark.org/review/26280 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07failure_message.c: fix a memory leak if err is not negativePascal Quantin1-5/+3
Bug: 14489 Change-Id: I958cfae824c50263913ba9df8128e34e9466cb67 Reviewed-on: https://code.wireshark.org/review/26294 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07PCP: allocate conversation info in file scopePascal Quantin1-1/+1
Bug: 14488 Change-Id: I9bb85cfd58ace721ba8b957bc3351f6c017a8b69 Reviewed-on: https://code.wireshark.org/review/26293 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07H223: fix a memory leak in conversation managementPascal Quantin1-1/+1
Bug: 14487 Change-Id: I75089ccfa2896b357f775fea67fd6b76500fc5dc Reviewed-on: https://code.wireshark.org/review/26292 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07SMB1/2: Update some FileFS fields with new flagsRonnie Sahlberg2-8/+123
Change-Id: I7fbf874c8f9f7fcbcdecd07b04762688d080b961 Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com> Reviewed-on: https://code.wireshark.org/review/26300 Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-07multipart: use packet scope memory to avoid leaking in case an exception is ↵Pascal Quantin1-5/+11
triggered by subdissectors Bug: 14486 Change-Id: I275f8c962f126ad55fc7086012e7b67cc0dc60b3 Reviewed-on: https://code.wireshark.org/review/26291 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07GIOP: use wmem packet scope for get_modname_from_repoid()Pascal Quantin1-1/+1
Bug: 14484 Change-Id: Ie2a4cc179ba25a1e3e50d689e21f003001a301fa Reviewed-on: https://code.wireshark.org/review/26289 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07LAPD: fix some memory leaks in conversation managementPascal Quantin1-2/+2
Bug: 14482 Change-Id: Ia49705e13f1071a69d61ba1d6bd331e3e7734d81 Reviewed-on: https://code.wireshark.org/review/26287 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07SMB2: use file scope to avoid leaking memoryPascal Quantin1-5/+5
Bug: 14483 Change-Id: I1532fa57cd9a847c0408db95744eb7af3a6f4ee5 Reviewed-on: https://code.wireshark.org/review/26295 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com>
2018-03-07Add additional dissect information in the ZCL Level Control Cluster.Paul Zander1-1/+37
Change-Id: I46f5ee8cc0aff39a01289be5f9cea86640f0a72d Reviewed-on: https://code.wireshark.org/review/26282 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-07ISUP: plug some memory leaksPascal Quantin1-0/+2
Bug: 14481 Change-Id: I940dc4c7ac197deb1f925418bbcdebb30285a775 Reviewed-on: https://code.wireshark.org/review/26286 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07oids.c: fix a memory leak in oid_string2subid()Pascal Quantin1-0/+1
Bug: 14485 Change-Id: Ia0ccd4480808c4f5da228975c7a076cd3f5d332b Reviewed-on: https://code.wireshark.org/review/26290 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com>
2018-03-07Eliminate unused structure members and an unused list.Guy Harris1-10/+0
We don't use the addresses, and don't use the inbound port. We also don't need a list of tn5250_conv_info_t's - they're allocated with wmem, so they get freed when we're done with a file, and they're attached to conversations, so we don't need a list to find them. Change-Id: Id3b44fb11cf353d7d15a58938883f2460cf642a0 Reviewed-on: https://code.wireshark.org/review/26301 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-07NSIS, WiX: Handle the presence or absence of mmdbresolve.Gerald Combs8-17/+31
Only install mmdbresolve if MAXMINDDB_FOUND is true. Fixup the Qt about box and WiX GTK defines while we're here. Change-Id: I7ac3c21ddb4aebc1dae1c3d8cfd2bcafc4139d2e Reviewed-on: https://code.wireshark.org/review/26299 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06mmdbresolve: Process our command line arguments by hand.Gerald Combs1-13/+15
Visual Studio doesn't ship with a getopt implementation, so process our arguments ourselves. Note that if we add support for more flags we'll probably want to use GOption. Change-Id: Ie78204aa64321ca68f3e66195b8c39e47ca410d9 Reviewed-on: https://code.wireshark.org/review/26288 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06Get rid of unused information.Guy Harris1-9/+1
We only need to know the outbound port, so we can determine whether this is to or from the host. Fix a comment to reflect reality while we're at it. Change-Id: If01df5aeb73900850a0de9f9f9731c6fa7f094bb Reviewed-on: https://code.wireshark.org/review/26298 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-06TN3270: fix memory leaks in conversation managementPascal Quantin1-2/+2
Bug: 14480 Change-Id: I9148bef80492426195a1673f8367a39c02c432ce Reviewed-on: https://code.wireshark.org/review/26285 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-06maxmind_db.c: fix a memory leakPascal Quantin1-0/+1
Change-Id: Ie3484e863363a8d2b9ccb435088886020678d15d Reviewed-on: https://code.wireshark.org/review/26284 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-06maxmind_db.c: add an explicit cast to please gcc 7.3.1Pascal Quantin1-1/+1
Change-Id: Idb2ae052804fb523d6769fe50b5bb4ba45e40f79 Reviewed-on: https://code.wireshark.org/review/26283 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06IEEE 802.15.4: individual functions for MHR/PIE/payload processingRobert Sauter2-99/+209
- reduce scope of special handling for ZBOSS and 'options' - move -2015 command byte handling to corresponding function - fix data handling for unimplemented command types Rationale: this allows reusing the individual functions for protocols that are based on IEEE 802.15.4 but require additional transformation of the payload without adding special cases within the functions. Change-Id: I5447620f6779031c4f9b280b16de9678b255b06f Reviewed-on: https://code.wireshark.org/review/26262 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Ed Beroset <beroset@ieee.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-06Docs: Updates for xsltproc and Asciidoctor.Gerald Combs2-16/+60
Change-Id: I3cfe2121beaab0fe09228ec277997d68fe824693 Reviewed-on: https://code.wireshark.org/review/26281 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06CMake: Fixup our Chocolatey bin path discovery.Gerald Combs5-14/+21
Search for choco.exe directly instead of using PATHS + PATH_SUFFIXES. Look in %ChocolateyInstall%\bin first. CHOCOLATEY_BIN_PATH is the binary path. There's no need to append /bin to it. Change-Id: I732db398bd989bf12222a5cee2c79c0bd4161638 Reviewed-on: https://code.wireshark.org/review/26276 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06CMake: Remove SH from the packate list.Gerald Combs1-1/+1
Change-Id: Idafd85df598e0c58fc8252574ce0478b3e1464a9 Reviewed-on: https://code.wireshark.org/review/26278 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06Transition from GeoIP Legacy to MaxMindDB.Gerald Combs55-1503/+1524
MaxMind is discontinuing its legacy databases in April in favor of GeoIP2, which use a newer database format (MaxMind DB). The reference C library (libmaxminddb) is available under the Apache 2.0 license which isn't quite compatible with ours. Add mmdbresolve, a utility that reads IPv4 and IPv6 addresses on stdin and prints resolved information on stdout. Place it under a liberal license (MIT) so that we can keep libmaxminddb at arm's length. Add epan/maxmind_db.[ch], which spawns mmdbresolve and communicates with it via stdio. Migrate the preferences and documentation to MaxMindDB. Change the IPv4 and IPv6 asnum fields to FT_UINT32s. Change the geographic coordinate fields to FT_DOUBLEs. Bug: 10658 Change-Id: I24aeed637bea1b41d173270bda413af230f4425f Reviewed-on: https://code.wireshark.org/review/26214 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06CMake: Remove FindSH.Gerald Combs1-36/+0
We haven't used SH_EXECUTABLE since the Asciidoctor migration. Change-Id: I93e8245ea02ed994ebb62942d5ea4ec890e35a97 Reviewed-on: https://code.wireshark.org/review/26277 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06ipsec: zero memory in get_full_ipv6_addr (found by clang).Dario Lombardo1-0/+2
Change-Id: I5a1c8cccd40867b70e64c8763a56da6a77c164b2 Reviewed-on: https://code.wireshark.org/review/26116 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-03-06dcm: Fixed crash in dissector, and other bugs Some tag descriptions which ↵david-aggeler1-169/+226
are added to the parent item (32 tags). If one of those was empty a crash occurred. Mainly the RTPlan modality was affected. Fixed length decoding for OD, OL, UC, UR Fixed hf_dcm_assoc_item_type to be interpreted as 1 byte Fixed pdu_type to be interpreted as 1 byte Fixed decoding of AT type, where value length was wrongly reported in capture as 2 (instead of n*4) Removed tailing white spaces Please merge to 2.4 once ok. Bug: 14415 Change-Id: I7857ef107e7e599c7dd9f8d069daa5b3bfb4122f Reviewed-on: https://code.wireshark.org/review/26268 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-06Use the generic function decode_zcl_time_in_100ms instead of the local ↵Paul Zander1-8/+2
zcl_fmt_time_tenths. Change-Id: Id79b59c77083e6fb236d4137820182616f5b83c1 Reviewed-on: https://code.wireshark.org/review/26275 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-06[Diameter] Added extended AVPs for Gx and RxJoakim Karlsson2-0/+50
Change-Id: Ic795a84dfb42868a34707142ce31ec77cd855e44 Reviewed-on: https://code.wireshark.org/review/26273 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-06[Diameter] fixed valid Diameter xmlJoakim Karlsson5-97/+140
Change-Id: Iacbbbb359885468e056dee3f8fa401223a38ca3c Reviewed-on: https://code.wireshark.org/review/26271 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-06VLAN: define a recursion depth limitPascal Quantin1-2/+16
Altough the dissection consumes 4 bytes each time it is called, it can trigger a stack overflow for big packets. Let's limmit the number of allowed VLAN tags for a given packet. Bug: 14469 Change-Id: Ieb6834ab3350dc7e8c301e6479577855a253897e Reviewed-on: https://code.wireshark.org/review/26270 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-06extcap: add g_free to extcap_free_toolbar_value (found by clang).Dario Lombardo1-0/+1
Change-Id: I81ca1665913f54333fe638208c99c4eef4ed2cc7 Reviewed-on: https://code.wireshark.org/review/26139 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-03-05wisun: fix, improve, and refactor Wi-SUN IEsRobert Sauter1-98/+104
Change-Id: I6e67d01c06536da5b41f9cf5b09b5f44393e6956 Reviewed-on: https://code.wireshark.org/review/26266 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-05Add missing ZigBee ZCL Scene cluster commands.Paul Zander3-17/+175
The following commands are added: 0x40 - Enhanced add scene 0x41 - Enhanced view scene 0x42 - Copy scene Change-Id: If7f921f7ede7518ecbb88395d6200f600a47bd85 Reviewed-on: https://code.wireshark.org/review/26202 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-03-05IEEE 802.15.4: always allocate protocol data if not presentPascal Quantin1-3/+2
When using 2 passes, L2TP dissector can set a session info for previous packets, breaking the assumption that IEEE 802.15.4 dissector will always be called on first pass. Let's always allocate the protocol data if missing, even if this is not the first pass. Bug: 14468 Change-Id: I4cb7ea2e54c1b763a48b99c0d64f542552789d18 Reviewed-on: https://code.wireshark.org/review/26260 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-03-05NBAP: avoid linking a DCH-ID to itselfPascal Quantin3-11/+11
Otherwise it can create an infinite loop, leading to a buffer overflow. Also add explicit cheks on the buffer usage and set its maximum size to 128 instead of 32 per ASN.1 description. Bug: 14471 Change-Id: I805f4ce09347bc35143b010b4a558a0d090c0159 Reviewed-on: https://code.wireshark.org/review/26259 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-03-05wisun: dissect Wi-SUN Netricity IEsRobert Sauter1-0/+75
Change-Id: Icae32b9934549891fab0683fa055fe16d01fdd90 Reviewed-on: https://code.wireshark.org/review/26258 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-046LoWPAN: fix cast-qual warningRobert Sauter1-5/+5
Change-Id: I688c2052b2e242664d31d995583330715ace37cd Reviewed-on: https://code.wireshark.org/review/26261 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-04dof: use tvb_memdup instead of g_memdup.Dario Lombardo1-10/+2
Change-Id: I0d1e6a09fa6fcf09c40c6e77b79cc97e0723bff5 Reviewed-on: https://code.wireshark.org/review/26144 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-04dot11decrypt: free memory on exit (found by clang).Dario Lombardo1-0/+2
Change-Id: I1af895accdd52fe64fc156905c549e719aaba304 Reviewed-on: https://code.wireshark.org/review/26182 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-03-04RTSP: Fixed missing space in column info between multiple pipelined messagesJiri Novak1-0/+7
When there is multiple RTSP messages in one packet, info column shows its headers right next to each other. It is ugly: Reply: RTSP/1.0 200 OKReply: RTSP/1.0 200 OK Patch adds ', ' between messages: Reply: RTSP/1.0 200 OK, Reply: RTSP/1.0 200 OK Ping-Bug: 14450 Change-Id: I151dbc72b669002ed02d91af43d683c5fc4fe4ba Reviewed-on: https://code.wireshark.org/review/26222 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 09:24:33 +0000