| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Remove the redundant BASE_FLOAT field display type. The name
BASE_FLOAT is meaningless and the value aliased to BASE_NONE.
Require BASE_NONE instead of BASE_FLOAT (corresponding to
the printf() %g format).
Add new float display types using BASE_DEC, BASE_HEX and BASE_EXP
corresponfing to %f, %a and %e respectively.
Add support for BASE_CUSTOM with floats.
|
|
Most style guides recommend against capitalizing preposition in titles
with less than 5 letters or so.
For example KDE: https://develop.kde.org/hig/style/writing/capitalization/
|
|
Uncapitalize Open Source Software. Prefer the well established umbrella
term "free and open source software". Add specifics about the license
version.
Most references use an hyphen with "open-source". Do that as well.
|
|
To maintain familiarity and keep to expectations do an exact copy.
The last sentence to check the man page is an exception because it
is an addenda and recognizing that this clipboard information will
be used mostly in bug reports, it might get annoying.
|
|
Move Acknowledgements to a separate file to enable some code
simplification and improve maintenance and discoverability
for acknowlegements.
Convert the Acknowledgements file to Github flavored markdown
and display it in rich text using QTextBrowser.
Add Acknowledgements.md to NSIS installer
|
|
|
|
ZVT uses card type 46 for Maestro cards. Add this type to the value string.
|
|
Set _U_ only for parameters which are really unused.
Make sure that the prototype and the definition of a function use the same
_U_ settings.
|
|
Update manuf, services enterprise numbers, translations, and other items.
Asterix failed.
|
|
For QUIC, we explicitly know the server direction. Use that
in order to correctly mark which packets are from the server
verus from the client, instead of assuming that the first packets
in a stream are from the client (which is true for a connection
generally but not necessarily a stream). This also allows us to track
direction across connection migration instead of marking all
packets after migration as from the server.
|
|
|
|
|
|
|
|
Similar to commit 2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c,
replace the RTP payload type preferences with automatic
dissectors.
This reduces the number of preference module callbacks.
|
|
|
|
packet-aeron.c:652:18: warning: Array access (from variable 'addr_data') results in a null pointer dereference [core.NullDereference]
packet-aeron.c:658:17: warning: Array access (from variable 'addr_data') results in a null pointer dereference [core.NullDereference]
|
|
|
|
|
|
Both CLI and Qt interfaces spin GLib mainloop. Move the capture pipe
polling into common code to reduce code duplication.
|
|
ISO C Std § 6.7.2, 5: "for bit-fields, it is implementation-defined
whether the specifier int designates the same type as signed int or the
same type as unsigned int." (See also the note in § 6.7.2.1 and ISO C
Std Appendix J.3.9.)
A gboolean is a typedef'd gint. Therefore, many implementations,
including gcc and clang, treat a gboolean bitfield of width 1 as
signed, meaning that it has two possible values: 0 and -1, any time
the integer promotions occur (which is all the time.) Constructs like this:
dgram_info->from_server = TRUE;
if (dgram_info->from_server == TRUE) ws_warning("True");
will not work as expected, though gcc (but not clang) will give an
error:
/home/johnthacker/wireshark/epan/dissectors/packet-quic.c:3457:37: error: comparison is always false due to limited range of data type [-Werror=type-limits]
3457 | if (dgram_info->from_server == TRUE)
|
proto_tree_add_debug_text(quic_tree, "Connection: %d %p from_server:%d", pinfo->num, dgram_info->conn, dgram_info->from_server);
Connection: 1 0x7fc4b47f2be0 from_server:0
Connection: 2 0x7fc4b47f2be0 from_server:-1
Connection: 3 0x7fc4b47f2be0 from_server:0
Connection: 4 0x7fc4b47f2be0 from_server:-1
At worst this can cause buffer overruns.
If a bitfield is desired, to guarantee expected behavior the standard
_Bool/bool should be used instead.
|
|
|
|
|
|
prefs_find_module() looks up a module by module name, which is
the same as the protocol filter name, case-insensitively.
dissector_table_get_dissector_handle() looks up a dissector handle
in the table by the protocol short name (which is the module _title_)
deprecated_port_pref() used the same string for both lookups.
For some protocols this worked, because the short name is the same
as the filter name only with different capitalization. For others,
it either wouldn't find the module to add to the migrated preference,
or wouldn't find the dissector handle in order to set Decode As
properly.
Fix this, by using the module title for the second lookup, and
changing all the module_name values to be correct. For good
measure, change all the module names that happened to work because
they're differently-cased versions of the filter name in order
to avoid confusion when new entries are added.
|
|
Switch back to bcg729 1.0.4. Version 1.1.0 and later are GPLv3.
https://gitlab.linphone.org/BC/public/bcg729/-/issues/3
This reverts commit 0ccfdfbf5c6fbc6c336170a19bccc6be8bb24077.
|
|
Dependencies need to be set via add_custom_command.
|
|
The "Last updated" footer time is the last modified time of the source
file. We could make it reproducible using something like
git-restore-mtime, but it's easier (and IMHO less ugly) to just remove
the footer.
|
|
Update our version to 3.7.3.
[skip ci]
|
|
This reverts commit ddcb429979851d28c55b0e3df09258f5c7084599
|
|
|
|
|
|
Q.713 s1.5 states optional parameters may be received in any
order. Q.714 s1.1.42 states unrecognized parameters within a
message are ignored.
This patch fixes Wireshark's compliance with the specs and allows
the segmentation parameter to occur anywhere with the options
|
|
The proto_layers map maps to values of curr_proto_layer_num,
not curr_layer_num.
|
|
SCCP places a limit of 255 bytes on DATA parameters, and
segments data beyond that. Some tracing tools will externally
reassemble data, writing a single message with an indicated
length of 255 octets but with a longer payload. Allow the pref
setting introduced in 086feb2f098903229a14fd25754cac06c625b647
to work for all message containing DATA, such as XUDT messages.
(Note that some tools leave the optional SEGMENTED parameter
in when externally reassembling, and some do not.) Add an
expert info to hint to the user when the setting might be
worth changing. (Perhaps it should be default to TRUE?)
Fix #10515
|
|
`match.groups()` is a function, not an attribute. Add () as needed to access match group items.
|
|
[skip ci]
|
|
[skip ci]
|
|
|
|
Use the timer polling approach on Windows. GLib timer callbacks execute
in main thread. Remove useless mutex as there is no point in protecting
resources if only can thread can access the resources. Simply wait on
capture child handle instead of periodically checking process state.
On Unix systems, register the pipe fd for polling inside GLib mainloop.
|
|
Do the first ftype-can check in an arithmetic expressions before
evaluating the second term to be sure we do not allow FT_NONE as a
valid LHS ftype.
$ dftest '_ws.ftypes.none + 1 == 2'
Filter: _ws.ftypes.none + 1 == 2
dftest: FT_NONE cannot +.
_ws.ftypes.none + 1 == 2
^~~~~~~~~~~~~~~
|
|
rubygems-asciidoctor was released 2022-05-18 for EPEL 8
( https://bugzilla.redhat.com/show_bug.cgi?id=1820896 )
so we don't need to special case it for RHEL/Centos 8.
|
|
|
|
This patch adds support for the Counter Event and the TimeSync Event.
|
|
Use the common functions to dissect the MCC and MNC from
packet-e212.c Remove some now no longer used static functions,
arrays, and fields.
|
|
Ping #16265.
|
|
1. Passing header name/value map to sub-dissector in packet-http.c.
Headers can also be used by dissectors other than grpc in the future.
2. Try to get the grpc-encoding header value in packet-grpc.c.
This header contains decompression algorithm.
|
|
The field description and filter for type of ciphering algorithm
was copied from the previous field.
|
|
|
|
Update c-ares to 1.18.1, nghttp2 to 1.46.0, and pcre2 to 10.40.
Ping #16265.
|
|
Qt5Concurrent is needed since 0438fca96b11bd299d92aa59d2d9e66e769d329b
Add it to the spec file requirements, since it's a separate package
on openSUSE.
|
|
Replace QTexteEdit with QTextBrowser and enable external
hyperlinks.
|
