aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-21plugins: Minor interface improvementJoão Valverde8-17/+50
Change the plugin compatibility check to make it more convenient to define and check the major.minor Wireshark version. Change-Id: I2a6d2a746682c29504311cce5c457e0a852c3daf Reviewed-on: https://code.wireshark.org/review/29224 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-08-21Regenerate ASN.1 dissectorsJoão Valverde3-51/+51
Change-Id: I1b7fb95df061e97de2e236d19221b8e2a5da0d92 Reviewed-on: https://code.wireshark.org/review/29226 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-08-21Use the standard test/[ command.Guy Harris1-1/+1
We use it elsewhere; use it here, as FreeBSD's /bin/sh doesn't support [[ as a test operator. Change-Id: I183b10cc6f4aceec9725027474848061e8ea4fd9 Reviewed-on: https://code.wireshark.org/review/29232 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21Clean up includes for SIOCGIFDESCR.Guy Harris1-5/+9
Change-Id: Ib92f7d85355540cff23f7bb08db911f200541f5f Reviewed-on: https://code.wireshark.org/review/29231 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21We use errno, so we need to include <errno.h>.Guy Harris1-0/+1
Change-Id: Ic6d88c508594aa9daf36bd0a6a9f2fe4f0db71bd Reviewed-on: https://code.wireshark.org/review/29230 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21Wrong snprintf() wrapper.Guy Harris1-1/+1
Change-Id: I7d8d83cd1829bed8cc940fa3d9c86cdc94f361af Reviewed-on: https://code.wireshark.org/review/29229 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21We need sys/sockio.h to define SIOCGIFDESCR.Guy Harris1-0/+4
Change-Id: Ief8830d7a5ce47ea7f486a4700f49859003519db Reviewed-on: https://code.wireshark.org/review/29225 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21plugins: Fix CMake build exampleJoão Valverde1-15/+12
Fix combination of pkg-config and CMake variables for feature detection. Remove non-system installation option. Just copy it manually for now. Change-Id: Ia80c703c6ec3df0a49f8d56f1bd6da69471c523f Reviewed-on: https://code.wireshark.org/review/29223 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-08-21GTP: Only put "T-PDU" in the top level tree.Anders1-1/+0
Change-Id: I94db5692320daddf67faa5f38f7e132e9edbb2fa Reviewed-on: https://code.wireshark.org/review/29222 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21Fuzz: Reduce the Valgrind packet limit to 10,000.Gerald Combs1-2/+2
Limit Valgrind to the first 10,000 packets in each file. Change-Id: I27be212ddb437c643ffb413bb9d1c809dbe98a55 Reviewed-on: https://code.wireshark.org/review/29210 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-21nordic_ble: Set PHY display type to BASE_DECStig Bjørlykke1-1/+1
Change-Id: I4a2e2142bbaf08e11a735d125a201c8651cdc857 Reviewed-on: https://code.wireshark.org/review/29217 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-08-21Qt: Pop field status when closing a fileStig Bjørlykke1-0/+1
Ensure we remove the info status for a selected field when closing a capture file to bring the text back to "Ready to load or capture". Change-Id: I2946675b2c0bc47cb8c05c1d391ff8a0875e8c7f Reviewed-on: https://code.wireshark.org/review/29216 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21CMake: Remove a debug messageStig Bjørlykke1-1/+0
Remove what appears to be a debug message from CMake. Change-Id: If6d12ca07d3c3b5f012a7e7ee530f7db18c813e5 Reviewed-on: https://code.wireshark.org/review/29215 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21Don't assume Bash.Guy Harris1-3/+3
At least on my OpenBSD 6.3 VM, there's no Bash installed; just use /bin/sh. Fix two places that use csh-style ">& /dev/null" to use "> /dev/null 2>&1" instead. Change-Id: I48656c47e89b3ad09f3c2d9e3c90dfad7afabb71 Reviewed-on: https://code.wireshark.org/review/29214 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21AT: Fix suffix length checks, add no suffix caseDarien Spencer1-3/+11
Change-Id: I20a7e52635cf95ea1b5d1c85cd0ae6e8619ebff8 Reviewed-on: https://code.wireshark.org/review/29189 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21Fix search for pkg-config on FreeBSD.Guy Harris1-1/+22
1) At least with FreeBSD's "pkg search", the search does *not* do a prefix match, so if you look for "pkg-config", you can find packages whose name is *not* pkg-config but that has "pkg-config" in the middle of the name. This means that we think we have a "pkg-config" package, but we don't, and fail when we try to install it. So we force a prefix match. 2) FreeBSD 11 doesn't have a "pkg-config" packate, but has a "pkgconf" package. If we don't find "pkg-config", look for "pkgconf". Change-Id: Iad5ef9d5630981958830c03e4cb90fe2d01ce1d0 Reviewed-on: https://code.wireshark.org/review/29213 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21Remove an unused true_false_string.Guy Harris1-2/+0
The field that used it was removed in I5092d19b99fc6b9b5c870cafec2990dd67012ab1. Change-Id: Ia358f475b8fbfeaf1fe10df79e9094ac837e3dd2 Reviewed-on: https://code.wireshark.org/review/29212 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21Bash is not guaranteed to be in /usr/pkg/bin/bash.Guy Harris1-1/+1
On my FreeBSD 11 VM, it's the standard FreeBSD package, which installs it in /usr/local/bin/bash. Change-Id: Ic6427a88efd963de8909a2d333c2c3bf8586e559 Reviewed-on: https://code.wireshark.org/review/29211 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21XRA: Added decoding for SC-QAM TLVsBruno Verstuyft1-2/+52
Change-Id: I40cecd0b6ea0f3d84f36bb6d5fe3dc416c1befff Reviewed-on: https://code.wireshark.org/review/29196 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21Calculate RTP delta time even if clock rate is unknown.Johannes Singler1-0/+4
Change-Id: If61c3166774a25f2c22b68c1e06c372088cae575 Reviewed-on: https://code.wireshark.org/review/29199 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21Fix SBC packet Loudness/SNR information wrong byte compatisonValdikSS1-2/+2
Change-Id: I05b551ccdbc0630a1d24862e6121d2385c33550e Reviewed-on: https://code.wireshark.org/review/29198 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21SBC: Fix DUAL CHANNEL SBC packet dissectionValdikSS1-1/+2
Change-Id: I51f3a052d2eec67e757cc5ac5eeb2cba2c47b327 Reviewed-on: https://code.wireshark.org/review/29197 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21ISIS(LSP): Add sub tlv Prefix SID from TLV 149Alexis La Goutte1-5/+100
from draft-ietf-isis-segment-routing-extensions-19 Bug: 15015 Change-Id: Ib64f716b60d40735553b91fd601a7e27edf64335 Reviewed-on: https://code.wireshark.org/review/29207 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21ISIS(lsp): Remove not longer supported sub-TLV (from TLV 149)Alexis La Goutte1-147/+0
Next patch will add new supported TLV Bug: 15015 Change-Id: I5092d19b99fc6b9b5c870cafec2990dd67012ab1 Reviewed-on: https://code.wireshark.org/review/29206 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21ISIS(lsp): Enhance Flag of TLV 149Alexis La Goutte1-2/+30
Add missing flag from TLV 149 (from draft-ietf-isis-segment-routing-extensions-19#section-2.4.1) Bug: 15015 Change-Id: Icf1fe3ef3d8b82b9451d9aed40c552bc854c5c01 Reviewed-on: https://code.wireshark.org/review/29205 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20Increase PROTO_PRE_ALLOC_HF_FIELDS_MEMJoão Valverde1-1/+1
Required to pass the test suite. 28: Process output for suite_unittests.case_unittests.test_unit_fieldcount: 28: -- Begin stdout for command ('run/tshark', '-G', 'fieldcount') -- 28: There are 205013 header fields registered, of which: 28: 0 are deregistered 28: 2468 are protocols 28: 15147 have the same name as another field 28: 28: 205000 fields were pre-allocated. 28: * * Please increase PROTO_PRE_ALLOC_HF_FIELDS_MEM (in epan/proto.c)! * * 28: 28: The header field table consumes 1609 KiB of memory. 28: The fields themselves consume 14414 KiB of memory. 28: -- End stdout for command ('run/tshark', '-G', 'fieldcount') -- 28: -- Begin stderr for command ('run/tshark', '-G', 'fieldcount') -- 28: -- End stderr for command ('run/tshark', '-G', 'fieldcount') -- 28/29 Test #28: suite_unittests .....................***Failed 12.72 sec Change-Id: I694ed42dbd5bef99df9d2037d505d71901afd2dd Reviewed-on: https://code.wireshark.org/review/29209 Reviewed-by: João Valverde <j@v6e.pt>
2018-08-20ieee80211: dissect the TWT ElementEmmanuel Grumbach1-3/+294
It is still not very clear how to parse the element, so focus only on the Unicast TWT for now. This should be useful for the short term. Ping-Bug: 15009 Change-Id: Ia589b170966e329ce051845553841a9fb80fcd5f Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Reviewed-on: https://code.wireshark.org/review/28857 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-08-20E.212: fix 255 04 and 255 06 PLMN namesPascal Quantin1-2/+2
This fixes commit g2c89e6c448 Bug: 15068 Change-Id: Ieec7ffb039af48903f9ee3f91800f603203f811e Reviewed-on: https://code.wireshark.org/review/29201 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20gtp: T-PDU heuristic - don't call the PPP dissector as "else" branch.Anders1-1/+5
Change-Id: Ibb3038f9aba5fa3dab098ec50e7c4070d3f1c534 Reviewed-on: https://code.wireshark.org/review/29200 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20gtp: Header extesion dissector table enhancements.AndersBroman2-8/+28
- Make it possible to append text to the extension header decoding - Make it clarer that the T-PDU decoding is an heuristic - Prettify presentation of data. Change-Id: I874f3f500e4c5c3c7f88cd6bf2370fbf6a4dc8a1 Reviewed-on: https://code.wireshark.org/review/29158 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20lldp: 802.3 BT add missing Autoclass and Power Down fieldsAlexis La Goutte1-0/+60
Bug: 15035 Change-Id: If76fc996508a9e4a09665dcee985d8e14bc72450 Reviewed-on: https://code.wireshark.org/review/29187 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20NAS 5GS: Partial service area element count fixSwapnil Roy1-1/+1
Change-Id: I2c6493c7e32c908f9719cd4a3e5519e22923e338 Reviewed-on: https://code.wireshark.org/review/29183 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20appveyor.yml: add integration with AppVeyor CIPeter Wu1-0/+64
Many dependencies (Git, MSVC2015, etc.) are already installed. The only missing ones are HTMLHelp and Doxygen, but these are not used. The AppVeyor free plan has one concurrent job with 2 cores, starting with the first item in the test matrix. As everyone likely develops on 64-bit, 32-bit is more likely to break, thus prioritize it for VS2015. For testing artifacts, do create a VS2017 x64 build before that though. Cloning git and installing deps takes about 2-3 minutes. cmake takes 2-3 minutes. Wireshark.sln and test-programs build in about 11-12 minutes, tests run in about 3 minutes, nsis packages in 3-4 minutes. A single job takes 21-28 minutes (depending on environment). Change-Id: If0c738743ce3ccd7ddfb5d9e77cdb2d3a5354ac7 Reviewed-on: https://code.wireshark.org/review/28967 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-20NSIS: try harder to find VS2015/VS2017 vcredistPeter Wu1-13/+30
The vcredist version (directory name) has changed. Instead of listing all possible versions, just glob for it. I only observed a single directory anyway. As CMake can find compilers without vcvarsall.bat, it is possible that env var VCINSTALLDIR is not set. Fallback to querying the location from the registry (as was done in VS2015). The MSVC_VERSION/VS/VCRT table is partially based on https://blogs.msdn.microsoft.com/vcblog/2017/11/15/side-by-side-minor-version-msvc-toolsets-in-visual-studio-2017/ Change-Id: I58107597c5037ab597a0d620925cb870e6ef7793 Reviewed-on: https://code.wireshark.org/review/28980 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-20h265: fix no newline at end of file [-Wnewline-eof]Alexis La Goutte1-1/+1
Change-Id: I05ecc82f939e140fd6b4304b19bc0d6a301b0be9 Reviewed-on: https://code.wireshark.org/review/29190 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-20Qt: fix several crashes in the SCTP DialogsVasil Velichkov15-140/+173
Store the association id instead of a pointer to the volatile "sctp_assoc_info_t" structure because it gets freed after a rescan. Bug: 14970 Change-Id: Id8fe2dfe3549bd711fc8ddef0770b217e83c2088 Fixes: v1.11.3-rc1-604-g796bf409b0 ("Add dialogs and graphs to analyse SCTP behavior similar to the GTK version.") Reviewed-on: https://code.wireshark.org/review/28711 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-19[Automatic update for 2018-08-19]Gerald Combs4-5/+109
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Iaec2f34b94bfec3b4203daad7ec7bfd10b1a8ae7 Reviewed-on: https://code.wireshark.org/review/29191 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-19AT: Add CLAC commandDarien Spencer1-0/+7
Change-Id: I84dbc146fe4300e22dfed21572b97e57b449af54 Reviewed-on: https://code.wireshark.org/review/29186 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-19kerberos: Fix several memory leaksVasil Velichkov2-7/+43
valgrind --tool=memcheck --leak-check=full ./run/tshark \ -r ../test/captures/krb-816.pcap.gz \ -o "kerberos.decrypt:TRUE" \ -o "kerberos.file:../test/keys/krb-816.keytab" \ -Tfields -e kerberos.keyvalue 24 bytes in 2 blocks are definitely lost in loss record 37 of 117 at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) by 0xCB9FE1F: krb5_ktfileint_internal_read_entry.isra.5 (kt_file.c:1359) by 0xCBA1436: krb5_ktfileint_read_entry (kt_file.c:1409) by 0xCBA1436: krb5_ktfile_get_next (kt_file.c:510) by 0x7A55A4F: read_keytab_file (packet-kerberos-template.c:324) by 0x7A55922: read_keytab_file_from_preferences (packet-kerberos-template.c:249) by 0x7A55EC4: decrypt_krb5_data (packet-kerberos-template.c:383) 141 (80 direct, 61 indirect) bytes in 2 blocks are definitely lost in loss record 99 of 117 at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) by 0xCB9F9D9: krb5_ktfileint_internal_read_entry.isra.5 (kt_file.c:1237) by 0xCBA1436: krb5_ktfileint_read_entry (kt_file.c:1409) by 0xCBA1436: krb5_ktfile_get_next (kt_file.c:510) by 0x7A55A4F: read_keytab_file (packet-kerberos-template.c:324) by 0x7A55922: read_keytab_file_from_preferences (packet-kerberos-template.c:249) by 0x7A55EC4: decrypt_krb5_data (packet-kerberos-template.c:383) 8,343 (24 direct, 8,319 indirect) bytes in 1 blocks are definitely lost in loss record 116 of 117 at 0x4C30B06: calloc (vg_replace_malloc.c:711) by 0xCB9F129: krb5_ktfile_resolve (kt_file.c:198) by 0xCB9DE82: krb5_kt_resolve (ktbase.c:175) by 0x7A559BC: read_keytab_file (packet-kerberos-template.c:310) by 0x7A55922: read_keytab_file_from_preferences (packet-kerberos-template.c:249) by 0x7A55EC4: decrypt_krb5_data (packet-kerberos-template.c:383) Change-Id: Ia6f62d8576f3812e8832acc747eac84de8383756 Reviewed-on: https://code.wireshark.org/review/29146 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-18Docs: AUTHORS formatting updates.Gerald Combs4-90/+51
Switch the AUTHORS heading markup from underscores to equals. This makes it easier to transform to Pod headings. Update the AUTHORS-SHORT-FORMAT output so that the author lists are verbatim paragraphs. Add a style for the author lists instead of wrapping everything in a <pre>. The AUTHORS files are UTF-8 and wireshark.pod sets "=encoding utf8". There's no need to translate characters. Change-Id: I43cf18ff86774421b08edb84d968a9410be177fe Reviewed-on: https://code.wireshark.org/review/29181 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-18AT: Add CGSN/GSN CommandsDarien Spencer1-0/+14
Change-Id: Ie383c0de07e4114f00e6c8833b6c18fcbaa4a07f Reviewed-on: https://code.wireshark.org/review/29185 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-18pfcp: fix no previous prototype for ‘pfcp_is_cause_accepted’ ↵Alexis La Goutte1-1/+1
[-Wmissing-prototypes] Change-Id: I0d5da3e747e45b815c8a99ea5d41c19d4fa32624 Reviewed-on: https://code.wireshark.org/review/29188 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-18Docs: Make our Pod documentation encoding uniform.Gerald Combs23-0/+115
We've set "=encoding utf8" in wireshark.pod for a long time. Do so in the rest of our .pod files. Change-Id: I3ef0fb3a88ed63275b4ff4362b6afbf13d79a0bc Reviewed-on: https://code.wireshark.org/review/29182 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-08-18pfcp: added session trackingJoakim Karlsson1-246/+633
PFCP session tracking follows the Session Endpoint Identifier, SEID. Function is Disable by default. Change-Id: I14ebe0745d8159ec90f31a985bcf46e6453c1361 Reviewed-on: https://code.wireshark.org/review/29168 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-18If we run out of lines, stop dissecting.Guy Harris1-4/+3
Change-Id: I19cbbd0af9debff33f1382f77272aeecd54a9cd2 Reviewed-on: https://code.wireshark.org/review/29184 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-17tshark: free exp_pdu_filename and capture_opts->save_fileVasil Velichkov2-2/+6
valgrind --tool=memcheck --leak-check=full ./run/tshark -r sctp.pcap -U "OSI layer 3" -w exported.pcap 13 bytes in 1 blocks are definitely lost in loss record 20 of 93 at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) by 0xB27B3C5: g_malloc (gmem.c:99) by 0xB294D22: g_strdup (gstrfuncs.c:363) by 0x117B5D: capture_opts_add_opt (capture_opts.c:889) by 0x118C0E: main (tshark.c:1112) Change-Id: I9b794015aa4d2626b43a5743864c2d732c6acaa1 Reviewed-on: https://code.wireshark.org/review/29125 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-17GTPv2: Document parsing of 8.107 Node IdentifierAnders1-0/+41
Change-Id: I81b11d1d1b667f94e0a73765c339e653910a751e Reviewed-on: https://code.wireshark.org/review/29173 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-17Syslog: skip timestamp field if not presentPascal Quantin1-2/+5
Bug: 15063 Change-Id: I08ca03be495ee172e0995fc949e0ba06c49b0dae Reviewed-on: https://code.wireshark.org/review/29177 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-08-17tds: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+2
Change-Id: I8d21c81c86dc63cbc9035fb26372b373191baeb8 Reviewed-on: https://code.wireshark.org/review/29179 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-17ieee80211: fix spelling-error-in-binary found by lintianAlexis La Goutte1-1/+1
Paramater -> Parameter Change-Id: I88c6a273c03dbde4c0b7964762aeef82f8fef2d6 Reviewed-on: https://code.wireshark.org/review/29174 Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-14 19:03:04 +0000