aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-03-02Add support for protocol broadcast by EERO Mesh AP'sCharlie Lenahan4-0/+141
Bug: 15540 Change-Id: Ia6d266f8fb27d438906cda420a4b52aed5acfdc2 Reviewed-on: https://code.wireshark.org/review/32191 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-02IEEE 802.15.4-2015 CCM* nonce for TSCH modeJames Ko2-20/+82
Enable decryption in TSCH mode which requires ASN in nonce. Change-Id: Iae24add3a15cef00ef0037acd99f30b684e97ae2 Reviewed-on: https://code.wireshark.org/review/32142 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-02Support unsigned stream identifiers for Follow StreamPeter Wu10-29/+34
tcp.stream and udp.stream are already unsigned identifiers. An upcoming http2.hashed_stream identifier can exercise the full unsigned 32-bit number space, so be sure not to treat the stream identifier as signed integer. Change-Id: Ic5d398b2bda7eba7555e385ef3fcd44b490f78c9 Reviewed-on: https://code.wireshark.org/review/32287 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Alexander Gryanko <xpahos@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-02vwr: fix Uninitialized argument value found by Clang (Analyzer)Alexis La Goutte1-2/+2
Change-Id: Ic4b5c2d34eafccaa115256e8d3e0a5518621ba76 Reviewed-on: https://code.wireshark.org/review/32288 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-01ZBEE ZCL: updated ZCL DRLC Cluster dissection.Nikita Ryaskin1-11/+642
Implemented commands payload dissectors. Change-Id: Ie62c25c5efd8d41256eb92455d94985d5a3749af Reviewed-on: https://code.wireshark.org/review/32259 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-01IMSI based filtering for SCCP/RANAPAnders Broman5-104/+132
Bug: 9074 Change-Id: Iae7e233d03367678a6925c732bf4b6d78c211cd8 Reviewed-on: https://code.wireshark.org/review/32286 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-01ieee802154: fix compilation with gcc-4.Dario Lombardo1-1/+1
Error: ../epan/dissectors/packet-ieee802154.c: In function 'dissect_ieee802154_header_ie': ../epan/dissectors/packet-ieee802154.c:3788:10: error: variable 'remaining' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered] gint remaining = tvb_reported_length_remaining(tvb, offset) - IEEE802154_MIC_LENGTH(packet->security_level); ^ Change-Id: I6dadaa9e502f8f38bf476b690395727c836172fd Reviewed-on: https://code.wireshark.org/review/32283 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-01DHCPv6: catch the NTP server suboptions being longer than the whole packetUwe Kleine-König1-0/+4
A router here sends the type and length of suboptions of the NTP Server option in dhcpv6 replies in little endian. So the NTP Server option looks like: 01:00:10:00:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:ff:fe:xx:xx:xx instead of 00:01:00:10:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:ff:fe:xx:xx:xx . This makes the dissector throw an exception "Malformed Packet" which results in the following options not being dissected. So check the suboption's length before adding the subtree. This improves diagnostics ("suboption too long" instead of "Malformed Packet") and results in the suboptions after the bogus one being parsed. Bug: 15542 Change-Id: Ifbafc23b3dbb7ca389b89936e9d1d15ecc82396e Reviewed-on: https://code.wireshark.org/review/32223 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-01Put a fake "FCS OK" value into the tree if we don't have FCS information.Guy Harris1-17/+10
That was what was being done before; do it in the main dissector routine, as 1) the main dissector routine doesn't call the FCS or TI CC24xx dissector if we don't have an FCS or TI CC24xx metadata trailer and 2) that means we pull duplicate code out of those dissectors. Also, those routines are only called if we have the full FCS/metadata available, so there's no need for them to check for that. (Arguably, they should be called if the data is present, according to the reported length, even if it's not available in the captured data, so we mark the frame as having been cut off so the full data isn't available.) Change-Id: I6be2a1f71a27bc41aea93e3c92743fc12c997c94 Reviewed-on: https://code.wireshark.org/review/32281 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-01Pull some common code from the FCS/metadata dissectors.Guy Harris1-26/+15
Put the "mark frames with an invalid CRC" stuff into the main dissector code, as it's the same regardless of whether you have an FCS that can be checked or metadata with an "FCS bad" flag. Change-Id: I2540c1934032c91f22b66babd81fb928212f18b5 Reviewed-on: https://code.wireshark.org/review/32280 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-01Have separate routines to dissect an FCS and TI CC24xx metadata.Guy Harris1-27/+68
Those fields have nothing in common. Change-Id: Ida29ce36a8a3e311b58a900a5631e314ebc39662 Reviewed-on: https://code.wireshark.org/review/32279 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-01Don't use a global variable for the FCS length.Guy Harris1-47/+44
Use local variables and parameters instead. Change-Id: If491ef9c4e961848bb59f48d107157372f93e43f Reviewed-on: https://code.wireshark.org/review/32278 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28Don't use the same variable for the configured FCS type and the tap FCS type.Guy Harris1-57/+81
There's the value the user configured, which should neither be used nor modified by the 802.15.4 TAP dissector; that dissector should just set the FCS length variable. It should also call the common dissector, as most of the other top-level dissectors do. That lets us have separate types for the "configured FCS type" and "tap FCS type" variables; do so. Speaking of calling the common dissector, the "non-ASK" dissector should do so as well. Make it so. While we're at it, fail if there's an unknown FCS type in the tap header. Change-Id: Ib0de81764670302c771be3851e9717f0a8399ac6 Reviewed-on: https://code.wireshark.org/review/32277 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28Clean up ITU-T vs. CCITT, fix some comments.Guy Harris1-14/+38
The CCITT was part of the ITU, and was renamed the ITU-T: https://en.wikipedia.org/wiki/ITU-T#History so just say ITU-T. As for whose idea those particular 16-bit and 32-bit CRC generator polynomials originally were, I don't know. 802.15.4 speaks of "a 32-bit CRC equivalent to ANSI X3.66-1979", but there ain't no 32-bit CRC in that standard, and its 16-bit CRC is Yet Another x^16 + x^12 + x^5 + 1 CRC that they claim came from CCITT/ITU-T V.41; V.42 has both 16-bit and 32-bit CRCs. Clean up more comments about the TI CC24xx metadata trailer. The "non-ASK PHY" name may have made sense when the type was created, as all the PHYs other than ASK, at the time, may have had the same preamble/SFD/PHR, but that's no longer true. List, in a comment, the ones to which it applies, all of which have 16-bit CRCs. Change-Id: Ie509dc06d06aec9738447f8da254c4edc5971a92 Reviewed-on: https://code.wireshark.org/review/32276 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28Replace another tvb_new_subset_length_caplen() call.Guy Harris1-1/+1
tvb_new_subset_length() is sufficient, and correctly calculates the captured length of the tvbuff, rather than possibly setting it too large by setting it based on the length of the TLV header. Change-Id: I510ee6742fcbc08ae7331585a65c768e98e6b3d9 Reviewed-on: https://code.wireshark.org/review/32271 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28Replace a tvb_new_subset_length_caplen() call with tvb_new_subset_remaining().Guy Harris1-1/+1
It's simpler, and is not incorrectly using the *captured* length to set the *reported* length. Change-Id: If4b7f1c431f4c39dcc568698358667a1b4fc1a12 Reviewed-on: https://code.wireshark.org/review/32268 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28Remove FCS length checks from code that's handed a tvbuff without an FCS.Guy Harris1-21/+48
Data handed to dissect_ieee802154_decrypt() should have, and does, have the FCS stripped off, so we don't need to use the FCS length. While we're at it: Update more comments for CC24xx metadata not being an FCS. Do the header IE processing loop with a "data remaining" counter, explain why we're doing a "data remaining" check and why it includes the MIC length, and note that we should use the "data remaining" counter to do more checks for invalid frames. Change-Id: I928dbf6142b5876b6a25b954f798936c9e97ac0d Reviewed-on: https://code.wireshark.org/review/32267 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28Add IEEE 802.15.4 TAP link typeJames Ko6-22/+680
New link type for IEEE 802.15.4 with pseudo-header and optional meta-data TLVs, PHY payload exactly as it appears in the spec (no padding, no nothing), and FCS if specified by FCS Type TLV. Specification at https://github.com/jkcko/ieee802.15.4-tap Bug: 15429 Change-Id: I67bd154891ad5818be9a1630aa5cbb863b55509a Reviewed-on: https://code.wireshark.org/review/32141 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-28CMake: Don't build Windows package targets by default.Gerald Combs3-7/+28
Explicitly exclude our various Windows package targets from the Visual Studio default build. This will hopefully keep the 32-bit Windows builder from trying to build the portableapps_runtime target when it shouldn't. Change-Id: Id8481e92abda9b1a4784b8c8e8b5a1b3f1b4647e Reviewed-on: https://code.wireshark.org/review/32256 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-28ISUP(ANSI) Backwards Call Indicators decoded incorrectlyAnders Broman1-4/+59
Add ANSI decoding for BCI. Bug: 9564 Change-Id: I4a9396473abf13b798377a17de2bd87468deb4a1 Reviewed-on: https://code.wireshark.org/review/32261 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-28.mailmap: update of November, December (2018) and start of 2019Alexis La Goutte2-6/+14
(January and February 2019) Change-Id: I25a146c94868b7ec96d5910d9515778dec41e444 Reviewed-on: https://code.wireshark.org/review/32242 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-28ZBEE ZCL: updated ZCL Metering dissection.Nikita Ryaskin1-36/+229
Updated payload dissectors. Change-Id: Ia800bba9f0b0d747a0926afb9bd833b2f3dc3666 Reviewed-on: https://code.wireshark.org/review/32144 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27Fix the FCS handling.Guy Harris2-17/+88
All the complicated stuff to see whether the captured data includes all of, some of, or none of the FCS is necessary, and should not have been removed. The previous code would sometimes dissect packet data at the end as both payload *and* FCS. This also means that the decryption code doesn't have to worry about the FCS, and expects the payload handed to it *not* to have the FCS. Update callers to handle that. This puts back the changes from e4d3916530aed332fcb39d4017e633bd51c4277c, for which the comment was: Clean up the way we handle the FCS. For the "802.15.4 with FCS" link-layer type, strip what FCS we find, if any, off and use that new tvbuff for all dissection except for checking and dissection of the FCS itself. For the "802.15.4 without FCS" link-layer type, don't fake an uncaptured FCS by increasing the reported length, just use the tvbuff as is. This means we handle 802.15.4 the same way we handle other link-layer types where the FCS might, or might not, appear as part of the captured data. "Handling stuff at the ends of packets is hard, let's go shopping!" Change-Id: Iaf3e8392efec9d1c35f73966e22f2a3ae91317a1 Reviewed-on: https://code.wireshark.org/review/32254 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-27QUIC: update ref draft url to draft-18Alexis La Goutte1-2/+2
Change-Id: Iaa10528a061f3feef4a213eb6d872586677a0ba4 Reviewed-on: https://code.wireshark.org/review/32241 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27Fix a comment.Guy Harris1-1/+1
There's no MIC at the end of an unencrypted packet, and thus we're not removing any MIC. Change-Id: Ie19790afc573b66f5dd09a4f8afc0fe69895eabe Reviewed-on: https://code.wireshark.org/review/32249 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-27Fix subset-tvbuff creation.Guy Harris1-4/+2
Use tvb_new_subset_length(), rather than (incorrectly) attempting to calculate the captured length ourselves. Change-Id: I9f608ee5bf59f261111b2a75900dddad12fb5554 Reviewed-on: https://code.wireshark.org/review/32245 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-27More "It's not a CRC, it's metadata".Guy Harris1-6/+8
Also ask, in a comment, how long the CRC is if we *do* have a CRC rather than metadata. Change-Id: I92da4d3ade9b69f65b39ea058915f3ee4530b786 Reviewed-on: https://code.wireshark.org/review/32237 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-27ANSI ISUP: Dissect Transit Network Selection and Carrier Identification.Anders Broman1-5/+109
Bug: 15532 Change-Id: Id24150a2143473754853497ecbca0a7ef5511a24 Reviewed-on: https://code.wireshark.org/review/32233 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27rpcap: check conversation existence before dereferencing it.Dario Lombardo1-1/+2
Bug: 15536 Change-Id: I370b7f4b3f647243490cbfadc120f0198c62b09b Reviewed-on: https://code.wireshark.org/review/32232 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27More "it's not an FCS, it's metadata" comment updates.Guy Harris1-4/+3
Change-Id: I2c0be3fe7cd900cd93d9fb64475a911e5bb3f9ac Reviewed-on: https://code.wireshark.org/review/32230 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-27The TI CC24xx chips put metadata, not an FCS, at the end of the packet.Guy Harris2-25/+24
Don't call it an "FCS" in the CC24xx case. It's not an FCS; it's not even just an "FCS OK" bit. Display the metadata in question in bit order, from the "CRC OK" bit downwards. Change-Id: I8da29bbb1f8b5ef3905af75dd34c1563b904a4d8 Reviewed-on: https://code.wireshark.org/review/32228 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-27pcap: Update link_type_valsStig Bjørlykke1-0/+3
Change-Id: I39e7434af7fed5ed0ecb0f6041aa2ac761f07426 Reviewed-on: https://code.wireshark.org/review/32225 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-02-27Add IEEE 802.15.4 ACK trackingJames Ko1-1/+271
Add flag to protocol configuration to enable ACK tracking. Fix duplicate strings in dissector. Change-Id: I245f2f2c9aad408a8e8429e8ac5ea5dac37a4f69 Reviewed-on: https://code.wireshark.org/review/32140 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27Add support for IEEE 802.15.4 32-bit FCSJames Ko3-140/+162
Make FCS length a variable. Modify protocol configuration to include FCS type option. Change-Id: I1e08f5b6b43907833464c20d798163343ce67a76 Reviewed-on: https://code.wireshark.org/review/32139 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27Fix ieee802.15.4 wpan-zboss abbreviationsJames Ko1-4/+4
Change-Id: Iab6e71938003e4088d0290df103ea78ade82a89f Reviewed-on: https://code.wireshark.org/review/32213 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-27MS Proxy: Initialize a variable.Gerald Combs1-1/+1
Zero-initialize a variable. This should fix bug 15534, although I can't reproduce it here. Bug: 15534 Change-Id: I7ee685e99e225d054386ead998cb4de681a2e759 Reviewed-on: https://code.wireshark.org/review/32211 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-26The non-flag arguments to tshark aren't necessarily a capture filter.Guy Harris1-1/+1
They're a capture filter if you're capturing live traffic; they're a display (read) filter if you're reading a capture file. Change-Id: Ia2f5bcdb0098bf3c2b4a3d99da5bfe768e09b5a0 Reviewed-on: https://code.wireshark.org/review/32207 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-26Qt: Info label fixes in the Profile dialogStig Bjørlykke1-2/+25
When copying from another profile which has been renamed: show the new profile name in the info label "Created from". When copying from another profile which is later deleted: append "(deleted)" to the info label to indicate that the origin profile is not in the list. Do not show "Renamed from" when a profile name if renamed back to it's original name. Change-Id: I0bf0c868c5dfd150a23b2ef887e7c70030b48d05 Reviewed-on: https://code.wireshark.org/review/32201 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-02-26IEEE 802.15.4 Fix duplicate stringsJames Ko1-2/+2
RX Wait is duplicated hf_register_info table for hf_ieee802154_tsch_timeslot_ack_wait and hf_ieee802154_tsch_timeslot_turnarount Change-Id: Ib519491d8baca6ef1e6ada1e53bb39d879eb39ee Reviewed-on: https://code.wireshark.org/review/32202 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-02-26netscaler: fix multiple out-of-bounds reads.Dario Lombardo1-6/+60
Multiple bugs have been found in the provided bug. Some of them have been fixed in gefe920a, others here. The main problem is when malformed files give wrong lenghts to the code, that casts and dereference it without checking, causing oob reads. The fix introduces a check function that prevents to go beyond the limits, early returning with a malformed file message. Other bugs have been fixed by forcing the string terminator that allows the use of strlen() and MIN() that prevent wrong reads. Bug: 15497 Change-Id: I8411208b5ea0f1a0720a17b882f704d03296d1c4 Reviewed-on: https://code.wireshark.org/review/32194 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-26sbus: Add multi-media telegram dissectionchrisdurrer1-121/+423
Added multi-media telegram dissection for multiple requests in one telegram Added read/write datablock telegram dissection Change-Id: Iaefba194bbc463340a6ed20998122c6ed14d67ca Reviewed-on: https://code.wireshark.org/review/32127 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-26wslua: simplify __WSLUA_REGISTER_META and _CLASSMartin Kaiser1-8/+8
Get rid of ATTRS_BLOCK, which is either empty or sets a value for attr. We can initialize attr in any case, either to NULL or to the attributes provided by the caller. This makes the code a bit easier to read (at least for me). Change-Id: Ib26ea5ec099b365303de5aaf407470ad48b126f9 Reviewed-on: https://code.wireshark.org/review/32186 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-25macos-setup: Update our GMP build flags.Gerald Combs1-1/+2
Configure GMP with --enable-fat. Neither --with-libgcrypt nor --without-p11-kit appear to be supported, so don't pass those flags. Change-Id: Ib96e805064b95be72d5fa3bd28057a5092064d8a Reviewed-on: https://code.wireshark.org/review/32190 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-25H265: Check range of H265_MAX_NUM_SHORT_TERM_REF_PIC_SETSAnders Broman1-2/+12
Check that value read from tvb is within protocol specified value. Bug: 15531 Change-Id: Icbfebef380aeb00f0d47a377a3bf3764f9cb1de0 Reviewed-on: https://code.wireshark.org/review/32189 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-25mate: Memory leak in mate_grammar.lemon's recolonize function.Anders Broman1-1/+2
Bug: 15525 Change-Id: I42728bc7b029618d8012cbbbec470b48a8fb2d92 Reviewed-on: https://code.wireshark.org/review/32188 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-25GSM MAP: Dissect several LocationInformationEPS's subparametersVasil Velichkov7-24/+127
Change DiameterIdentity's field type to FT_STRING and add dissection of - E-UTRAN Cell Global Identity - Tracking Area Identity - GeographicalInformation - GeodeticInformation Change-Id: Ifff52b511f495b281318778f6007be896748e4ce Reviewed-on: https://code.wireshark.org/review/32128 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-24Fixed a bug found in the BACnet-APDU dissectorJonathan Fleming1-2/+2
Bug: 15530 Change-Id: I1f9f84560b8cc288796f87cc0434bd957ce72aad Reviewed-on: https://code.wireshark.org/review/32167 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-24Qt: Remove save_file when restartStig Bjørlykke1-0/+6
Throw away the old temporary filename when restart capture to create a new temporary file. This was omitted from the previous restart capture fix. Change-Id: I39396d26563ec3d424161f81667864440a13e6d2 Reviewed-on: https://code.wireshark.org/review/32184 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-02-24[Automatic update for 2019-02-24]Gerald Combs11-46/+138
Update manuf, services enterprise numbers, translations, and other items. Change-Id: If37808291aca1f9bdd75d064bbfb738b89945eb8 Reviewed-on: https://code.wireshark.org/review/32180 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-24Put back the NCP Group Type item for LIP Echo packets.Guy Harris3-17/+21
Change-Id: Ifc26e939ed204ec55eb508f26d0f47c4a6f38484 Reviewed-on: https://code.wireshark.org/review/32179 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 10:22:06 +0000