aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-08-29wiretap: always allocate a block for a record.Guy Harris59-26/+90
Without that, you could add a comment to a record in a file format the reading code for which doesn't allocate blocks, but the comment doesn't get saved, as there's no block in which to save the comment option. This simplifies some code paths, as we're either using the record's modified block or we're using the block as read from the file, there's no third possibility. If we attempt to read a record, and we get an error, and a block was allocated for the record, unreference it, so the individual file readers don't have to worry about it.
2021-08-29NSIS: add ntar to AdditionalTasksPage screenChuck Craft2-13/+12
2021-08-29USB HID: Fix Usage Maximum typoBerk Akinci1-4/+2
Fix typo preventing 'Usage Maximum' values from being parsed. Values were were reported as 'Usage:'.
2021-08-29USB HID: Update to match HID Usage Tables version 1.22Berk Akinci1-206/+534
Add camera control page (0x90). Usages are up to date with HID Usage Tables for USB version 1.22.
2021-08-29Thrift: make some functions static.Martin Mathieson1-4/+4
2021-08-29New dissector for EXOS internal capture extra headerJörg Mayer4-1/+323
2021-08-29nordic_ble: Update text for channel to include indexJoakim Andersson1-1/+1
Update channel to include index to clear up possible confusion if this is RF channel, or channel index. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
2021-08-29btle: Update text for channel to include indexJoakim Andersson1-1/+1
Update channel to include index to clear up possible confusion if this is RF channel, or channel index. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
2021-08-29BTHCI: Add new Bluetooth v5.3 HCI commands/event dissectionAllan Møller Madsen2-5/+165
New HCI commands/event dissected: - LE Set Data Related Changes Command - LE Set Default Subrate Command - LE Subrate Request Command - LE Subrate Change Event 5.3 version number added, LE event mask, supported commands and LE feature bitmaps updated.
2021-08-29nordic_ble: Mark failure to decrypt reason as CRC error over MIC errorJoakim Andersson1-1/+7
A packet that has been received by the sniffer with CRC errors will not decrypted properly by the sniffer. Mark the decrypt failure reason as CRC error instead of MIC error. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
2021-08-29[Automatic update for 2021-08-29]Gerald Combs15-8090/+4835
Update manuf, services enterprise numbers, translations, and other items.
2021-08-29epan: remove a few more uses of wmem_packet_scopeEvan Huus3-7/+11
2021-08-29Cmake: misplaced quote in epub asciidoctor_optsChuck Craft1-1/+1
Follow up to !3988
2021-08-29Qt: fix memory leaks found by Visual Leak DetectorTomasz Moń4-16/+11
Set PacketDiagram as parent of QGraphicsScene so the scene is destroyed together with PacketDiagram. Dynamically allocate WiresharkApplication and explicitly call its destructor when no longer needed. This results in deletion of FunnelAction objects created in register_menu_cb() and QAction objects created in TapParameterDialog::registerDialog(). For some reason, when breakpoint was set inside WiresharkApplication destructor it would not get triggered on exit, and so the child objects would get reported as memory leaks. Delete main window and application only after epan_cleanup(). This makes lua plugins actually call ops during cleanup (e.g. destroy_text_window) and makes it possible to free the memory allocated in FunnelStatistics constructor.
2021-08-29lapd: clean up variable names, remove unnecessary initialization.Guy Harris1-7/+7
Use "flags" for the OPT_PKT_FLAGS option value, as we do elsewhere. Use "lapd_flags" for the variable holding the LAPD flags. We don't need to initialize flags, as we extract the OPT_PKT_FLAGS option into it immediately after initializing it (if the attempt to get that option fails, it's not set, but it's not used, either).
2021-08-29Qt: stop capture syntax worker thread on exitTomasz Moń4-106/+89
Instead of creating endless loop and synchronizing using QWaitCondition, execute the syntax worker check in its thread by emitting signal. The syntax worker thread affinity is set to worker thread so the slots handling takes place within the worker thread context.
2021-08-29pcapng: remove include of wtap_opttypes.h.Guy Harris1-1/+0
It's already included by wtap/wtap.h, which this file includes, and it doesn't need to be included that early, so that #include isn't necessary.
2021-08-29peektagged: set rec->block right after rec->rec_type.Guy Harris1-1/+1
That's how it's done in other files, and the two are somewhat connected (the record type and block type are somewhat correlated).
2021-08-28packet-frame: assorted cleanups.Guy Harris1-6/+6
Remove unnecessary initializations. Rename the variable for the packet ID option to match the name of the option (it's epb_packetid in the pcapng spec, with no underscore between "packet" and "id").
2021-08-28pcapng: whitespace and other cleanups.Guy Harris1-12/+3
Remove some extra blank lines, add a blank line where it belongs, and get rid of a stray #-only line.
2021-08-28pcapng: fix handling of byte-swapped sysdig event blocks.Guy Harris1-0/+1
We weren't setting wblock->rec->rec_header.syscall_header.nparams for byte-swapped event blocks.
2021-08-28IEC104: Added Substituted / Not substituted dissection of CP56Time2aJiří Engelthaler1-0/+6
Closing #17209
2021-08-28capture file: remove redundant API ref_time_packets()Developer Alexander2-10/+4
Redundant API ref_time_packets() gets removed. cf_reftime_packets() gets a better dokumentation.
2021-08-27pcapng: fix output of comment and DNS server name options.Guy Harris1-1/+1
Copy to the buffer the string value, not the structure that contains it.
2021-08-27GitLab CI: Fix a command.Gerald Combs1-1/+1
BSD stat doesn't support `--format`.
2021-08-27Some spelling fixes.Martin Mathieson7-13/+41
2021-08-27GitLab CI: Print package sizes and hashes.Gerald Combs1-0/+5
Print the sizes of our source, Windows, and macOS packages. Print the hash of our macOS package.
2021-08-27Version: 3.5.0 → 3.5.1.Gerald Combs3-3/+3
2021-08-27wtap_opttypes: fix a typo.Guy Harris1-1/+1
2021-08-27Packaging: Try to fix git-export-release.sh.Gerald Combs1-6/+9
Attempting to release 3.5.0 failed with No local changes to save Creating ./wireshark-3.5.0.tar.xz fatal: not a valid object name: stash@{0} Use CI_COMMIT_SHA for our export commit if it exists.
2021-08-27Build: 3.5.0.Gerald Combs3-2173/+2858
[skip ci]
2021-08-27AMQP: Fix dissection of PDUs split across TCP segmentsJohn Thacker1-0/+5
AMQP calls a subdissector table before tcp_dissect_pdus() is used to desegment PDUs (see commit 27c10ed72ea2451bfbb6c0eb50af4280e65a3fcf), so pinfo->can_desegment needs to be restored before it is decremented a second time. Fixes #14217.
2021-08-27pcapng: process uint32 options like uint64 options.Guy Harris2-23/+56
Move the extraction of the option value from the option content from the callers of pcapng_process_uint32_option() to pcapng_process_uint32_option() itself.
2021-08-27SMB: Don't canonize filenames to ASCII for Export ObjectsJohn Thacker1-3/+2
Windows can allow Unicode in filenames now, and export_object.c has its own eo_massage_str function that the GUI and CLI already call to create safe filenames when they are saved. There's no need for an individual dissector like SMB to have its own (worse) implementation of the same functionality, and to call it before filenames are displayed. Fix #17530
2021-08-27Isobus-VT: Fix description of auxiliary input status enable messageJeroen Sack1-2/+10
Show if message indicates that auxiliary input was enabled or disabled
2021-08-27Isobus: Change email addressJeroen Sack2-2/+2
Used my work email previously, but have not been working for them for a long time already.
2021-08-27pcapng: remove some old code left behind by the previous change.Guy Harris1-2/+1
2021-08-27pcapng: export routines to do the option-section processing.Guy Harris3-57/+261
That way, add-on modules to handle block types not handled by the core pcapng code can use pcap_process_options() to process a block's options and can use the routines to handle the "standard" option value types to handle particular options. Also, allow both everything-is-little-endian and everything-is-big-endian Custom Block types in pcap_process_options().
2021-08-27Thrift: Complete handling of Binary & Compact protocolsTriton Circonflexe7-651/+3234
- Make sure reassembly requests & errors are properly propagated from any point in the PDU, no matter how many sub-structure levels. - Handle the sub-dissection methods as well: - Ensure the sub-dissection methods handle errors from previous calls. - Reduce the error handling needed in sub-dissector implementations. - Add missing sub-dissection methods for list, set, and map. - Add the handling of sub-structure. - Handle Compact protocol in addition to the existing binary protocol. - Include and improve MR !3171 - Handle reassembly the same way as for binary protocol. - Handle sub-dissection with the same functions. => Sub-dissectors only depend on .thrift files. Additional changes: - Use of constants instead of hard-coded values. - Removed U64 support (never supported by thrift code generator, only referenced in the C++ thrift library header but not supported in reality. - Removed references to UTF-8 and UTF-16 string for the same reason. - Replaced references to UTF-7 string with just string (same reason). - Replaced references to byte with i8 as the documentation explicitly states that byte is a compatibility name. Documentation reference: - https://thrift.apache.org/developers - https://thrift.apache.org/docs/idl.html - https://github.com/apache/thrift/blob/master/doc/specs/thrift-compact-protocol.md - https://erikvanoosten.github.io/thrift-missing-specification/ - https://diwakergupta.github.io/thrift-missing-guide/ Closes #16244 Additional changes: - Add authors and improve consistency - Fix typo and clarify documentation
2021-08-27Add initial support for BBLog filesMichael Tuexen10-78/+1286
2021-08-27CMake: Use "'" instead of "’" in our guide filenames.Gerald Combs3-12/+13
Use an apostrophe instead of RIGHT SINGLE QUOTATION MARK in our PDF and EPUB filenames. Some programs (notably Okular) can't open filenames with extended characters, at least on Windows.
2021-08-27Release notes: Various updates.Gerald Combs1-11/+17
Add 64-bit PortableApps and macOS Arm items. Fix an issue from a previous commit. Add new dissectors.
2021-08-27woww: Fix Dead Store (Found by Clang Analyzer)Alexis La Goutte1-1/+0
2021-08-26USBLL: Reassemble transactions into transfersTomasz Moń3-16/+734
Create pseudo URB and pass the reassembled data to USB URB dissector. Reassembly for control transfers is not problematic as the transfer length is known. For bulk transfers assume the transfer can span across multiple transactions, however for periodic (interrupt and isochronous) assume the transfer never spans across multiple transactions. Rely on USB dissector to provide endpoint maximum packet size. Actual interface/configuration handling in USB dissector needs to be reworked as the code assumes that there is only one configuration and alternate interface configurations have matching endpoints. While the reassembly bulk transfers and never reassemble periodic transfers result in pretty good dissection, the USB class dissectors need a mechanism to provide transfer size hints to USBLL dissector. Such hint is not needed for software USB capture as software sniffers essentially capture URBs and every transfer is associated with one URB. The problem can be seen for example in Mass Storage Class where it is common for data transfers length to be multiple of endpoint maximum packet size. Because USBLL dissector doesn't know expected transfer size, it combines together data and status transport. Related to #15908
2021-08-26gsm_sim: add decoding for GET IDENTITY and GET DATAReinhard Speyerer1-0/+6
Add support for decoding instruction byte 78 (GET IDENTITY) from TS 102 221 v15.11.0 and instruction byte CA (GET DATA) which is used to retrieve the EID for eSIMs according to GSMA SGP.02 v4.2 available from https://www.gsma.com/esim/esim-m2m-specifications/. Closes #17548.
2021-08-26gtp: alternative GSN address decodersMichail Koreshkov1-603/+668
All fields with GSN address were decodes as common hf_gsn_addr. But if ETSI order is used, it's possible to specify alternative decoder depending on message type and field position. Alternative decoder for GSN address was added for mandatary fields and optional/conditional field in the case there is single GSN address in message. Added new function as common dissector for all addr types.
2021-08-26EPL: fix length detection of SDO 'read by index'Christian Krump1-2/+2
correction of the length-calculation of SDO 'read by index' payload data
2021-08-26cmake: add an "uninstall" target.Guy Harris2-0/+52
Based on the uninstall target I added to libpcap and tcpdump's CMake files. cmake_uninstall.cmake.in is BSD-licensed, so I can use it here and in libpcap/tcpdump without adding any GPL stuff to libpcap/tcpdump.
2021-08-26Signal PDU: Speed up dissectionDr. Lars Völker1-5/+13
This patch speeds up the dissection of signal pdus, if not filtering. With an example trace file full of signal PDUs, I gained about a 4x speed up in opening the trace.
2021-08-26PROFINET: DCP Option dissection updatedVahap Emin Agaogullari1-5/+1
DCP Frames with Reserved Option dissection changed short time ago. There isn't a predefined suboption for Reserved option in the standard. But in this implementation it dissected like control suboption. This is not true and creates malformed frames in some dcp pcaps. This implementation is reverted. Wireshark will dissect undefined bytes as paddings just like before.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 13:31:34 +0000