aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-10-22DCERPC: Strengthen heuristic, fix PDU lengthJohn Thacker1-6/+22
The fragment length field of DCERPC connection-oriented PDUs includes the length of the fixed header, and so must be at least that large. Don't return a (bogus) PDU length zero from get_dcerpc_pdu_len, because tcp_dissect_pdus interprets that as "need one more segment" instead of as a bogus value; instead return one, which the TCP dissector will correctly recognize as bogus. Also, take into account the offset passed into get_dcerpc_pdu_len (it is almost always 0, which is why the code previously worked), and increase the fixed length value passed to tcp_dissect_pdus to the real fixed header length (so that the TCP dissector will recognize more bogus values as bogus.) Fix #14728.
2021-10-22Qt: Add back some Q_OBJECT calls.Gerald Combs17-5/+41
They're needed in some places for translations.
2021-10-22dumpcap: don't tell users to bother the Npcap developers.Guy Harris1-21/+13
The issue in question is Npcap issue 250, for which work is being considered in Npcap issue 506; this is all apparently due to Windows tearing down and reassembling the networking stack in various sitations. See @jtippet's comments in Npcap issue 250. We just tell users that this is a known problem, work is being done on it, so there's no need to report it.
2021-10-22Tools: Fix some fuzzing logic.Gerald Combs1-1/+1
Fix a conditional that was inadvertently inverted in d7bdd77a4c.
2021-10-22Autosar IPDU Multiplexer: make some functions staticMartin Mathieson2-4/+8
Also fix up check_static.py - dissectors.c.o has moved.wq
2021-10-22EVS: Decode Reserved bit for 48/96/128 kbpsNan Xiao1-8/+3
2021-10-22rdp: dissect fastpath packetsDavid Fort1-7/+641
This patch adds basic decoding of fastpath packets.
2021-10-22rdp_multitransport: fill the info columnDavid Fort1-1/+4
Nothing was set for CreateRequest and CreateResponse messages.
2021-10-22rdp: fix dissecting of bandwidth messagesDavid Fort1-3/+3
There was a swap between server and client messages, the patch correct this.
2021-10-22wireshark.h: Remove wmem dependency.João Valverde5-37/+51
Start smaller. Remove the return macros from wslog.h because that pulls in a wmem dependency and the interface is not very stable yet.
2021-10-22Windows: Fix warnings using flexJoão Valverde10-0/+15
Fix some warnings complaining of macro redefinitions with stdint.h. Include stdint.h via wireshark.h everywhere so it stays fixed.
2021-10-22Add wslog.h to wireshark.hJoão Valverde2-1/+4
wslog has a small surface, few dependencies and is near essential for Wireshark development and debugging. Pulling wmem.h is not a problem either, the library is self contained and again memory allocation and general data structures are essential components.
2021-10-22Add new global header wireshark.h with guidelineJoão Valverde26-39/+173
Remove ws_diag_control.h from config.h because that was a workaround for the lack of a public global header. Fix the resultant build errors.
2021-10-22AUTOSAR I-PduM dissectorDr. Lars Völker7-5/+1261
This patch adds the AUTOSAR I-PduM dissector.
2021-10-22Ensure a single Follow Stream is running onlyEugene Adell2-1/+20
When changing one of the selection parameters in the Follow Stream dialog while a filtering task is already running, the result is inaccurate. While a filtering task is already running in the Follow Stream dialog, any filter change which triggers a new filtering gives a wrong result. Both the displayed data and the Save As functions are impacted. Closes #15637
2021-10-22EVS: Decode BW for 9.6/16.4/48/96/128 bpsNan Xiao1-0/+28
2021-10-22bittorrent: Do some PDU length validity checkingJohn Thacker1-4/+128
We know the lengths (or at least bounds on them) for most message types, so if we have a nonsense value assume that we're actually seeing Continuation Data (or unsupported Message Stream Encryption.) Also support the extended message type a little bit, at least to display the bencoded dictionary when it's type ID 0.
2021-10-22TCP: Contiguous ACK unseen segments are not wantedEugene Adell1-4/+28
In rare circumstances, a pure ACK will be followed by a series of TCP ACK unseen segments in the opposition direction. Only the first packet of this series should be marked as such. Closes #11624
2021-10-21docs/tshark: proper name is lopsided CamelCase (TShark)Chuck Craft10-25/+25
This is a first pass that covers the WSDG, WSUG, man page, a code comment and a README. Plenty left to do in the Debian files, a few Lua examples and other misc files.
2021-10-21ieee1905: Add missing offset incrementOkan Palaz1-0/+1
In dissect_unassociated_sta_link_metric_response, offset wasn't being incremented after sta_count was read. The same byte was being read as the first octet of the MAC address.
2021-10-21debian/rules: Run dh_dwz with debhelper (>= 12.6) onlyBalint Reczey1-0/+4
2021-10-21EVS: Support decoding Primary 7.2/8.0 kbps packetsNan Xiao1-0/+33
2021-10-21TCP, UDP, SCTP: Try user specified ports firstJohn Thacker6-38/+201
When the user has manually registered to a port a dissector other than the default subdissector (through Decode As, or the preferences registered via dissector_add_uint_[range_]with_preference), try those ports with a custom dissector first. There's a few dissectors (e.g., GTP) that have port preferences that haven't been migrated to use the DECODE_AS_ preferences for various reasons; this won't change anything when their preferences are changed from the default, though it can still work via Decode As. Fixes #6223 and #12168.
2021-10-21CBOR: Add support for CBOR sequence dissectionBrian Sipos1-0/+21
2021-10-21CMake: Compile dissectors.c independently.Gerald Combs2-1/+22
Move dissectors.c to a separate object library so that the rest of the dissectors don't have to wait for it to be generated. This reduces build time here by a few seconds when ccache is enabled.
2021-10-21CMake: Place all of the documentation in the "Documentation" folder.Gerald Combs4-6/+6
2021-10-20tcpcl: Fix warnings found by Clang AnalyzerAlexis La Goutte1-3/+1
packet-tcpcl.c:1071:9: warning: Value stored to 'frm' is never read [deadcode.DeadStores] packet-tcpcl.c:1706:21: warning: Value stored to 'sep' is never read [deadcode.DeadStores] packet-tcpcl.c:1762:21: warning: Value stored to 'sep' is never read [deadcode.DeadStores]
2021-10-20ieee80211: Fix warnings found by Clang AnalyzerAlexis La Goutte1-6/+0
packet-ieee80211.c:17423:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores] packet-ieee80211.c:17424:9: warning: Value stored to 'tag_len' is never read [deadcode.DeadStores] packet-ieee80211.c:17430:10: warning: Value stored to 'offset' is never read [deadcode.DeadStores] packet-ieee80211.c:17431:10: warning: Value stored to 'tag_len' is never read [deadcode.DeadStores] packet-ieee80211.c:17437:10: warning: Value stored to 'offset' is never read [deadcode.DeadStores] packet-ieee80211.c:17438:10: warning: Value stored to 'tag_len' is never read [deadcode.DeadStores]
2021-10-20evs: Fix warning found by Clang AnalyzerAlexis La Goutte1-1/+0
packet-evs.c:668:17: warning: Value stored to 'bit_offset' is never read [deadcode.DeadStores]
2021-10-20bt-utp: Fix warning found by Clang AnalyzerAlexis La Goutte1-1/+1
packet-bt-utp.c:1052:5: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
2021-10-20bpv7: Fix warning found by Clang AnalyzerAlexis La Goutte1-1/+0
packet-bpv7.c:1646:13: warning: Value stored to 'sep' is never read [deadcode.DeadStores]
2021-10-20BT-UTP: Make a function statisMartin Mathieson1-1/+1
2021-10-20github: update no-options workflow.Dario Lombardo1-1/+3
2021-10-20CMake+Docs: Update our man page targets.Gerald Combs2-20/+6
Remove the generate_*_pages targets that were recently introduced, since they're not really needed. Only add the "manpages" target if we have Asciidoctor.
2021-10-20EVS: Fix TCX/HQ-MDCT core valuesNan Xiao1-2/+2
2021-10-20http2: fix the stream mode reassembly issueHuang Qiangxiong3-25/+58
- Point all MSP related DATA frames to their MSP instead of using wmem_tree_lookup32_array_le(). - Add test_grpc_streaming_mode_reassembly testcase for verifying this feature. close #17633
2021-10-20csn1: Avoid storing existence bit as true if content was actually NULLPau Espin Pedrol1-9/+36
If we decode Exist bit as "1" but we are at the end of the message, and all the Next items we'd read are expected to be possibly NULL, then swap the Exist bit in the decoded structure as "0" in order to tell the decoder user that the related information structure is actually unset, as if "0" was received. This patch is a port from patch fixing same issue in the osmo-pcu.git copy of csn1 decoder: https://git.osmocom.org/osmo-pcu/commit/?id=1859ec38cc4f4e3788e495a100fdec3787d25020 And fixup patch for that one: https://git.osmocom.org/osmo-pcu/commit/?id=9ecdc11eb6b983748ae2fd6a1d07849c8106826f
2021-10-20csn1: Avoid failing if optional DownlinkDualCarrierCapability_r7 is missingPau Espin Pedrol3-32/+47
All additional release fields in RadioAccesCapabilities are considered optional, and the CSN_DESCR for Content_t already marks almost all as such, except DownlinkDualCarrierCapability_r7. It has been found that some MS transmits a MS RA Capability with a Length=61 bits where the last bit in the buffer is setting the Exist bit for DownlinkDualCarrierCapability_r7 as 1. Hence, the CSN1 decoder failed to decode the whole message because it expected to keep reading there despite there's no more bytes to read. While this is could actually be considered an MS bug, let's relax our expectancies and simply consider the case { 1 <end> } as it was { 0 }, and mark skip decoding DownlinkDualCarrierCapability_r7. That what wireshark (packet-gsm_a_gsm.c) or pycrate do for instance. This patch itself doesn't fix the problem where actually the Exist bit is stored as 1 in the output decoded structure, but simply allows keep ongoing with decoding until the end. This issue will be fixed in a follow-up patch. This patch is a port from patch fixing same issue in the osmo-pcu.git copy of csn1 decoder: https://git.osmocom.org/osmo-pcu/commit/?id=ebdc0d8c170ee2dbf23b19056d6c2d0ef316b3c2
2021-10-20E212: Update MCC listJohn Thacker1-25/+36
Op. Bulletin No. 1117 (1.II.2017) has an annexed list of Mobile Country Codes that includes a number of which are not mentioned in the MCC/MNC combined list in Op. Bulletin No. 1161 (1.XX.2018), possibly because the MNCs are not reported to the ITU in a timely fashion or because the assigned number is not actually used (e.g., Vatican City). See: https://www.itu.int/dms_pub/itu-t/opb/sp/T-SP-OB.1117-2017-OAS-PDF-E.pdf
2021-10-20gtpv2: Update to 3GPP TS 29.274 V17.3.0Joakim Karlsson4-185/+274
2021-10-20Fix some spelling errorsMartin Mathieson5-4/+26
2021-10-20RTP Analysis: Fix of mean_jitter calculationJirka Novak1-2/+2
Calculation used current_diff in place current_jitter in mean_jitter calculation so it produced incorrect results. This patch fixes it. Closes #17600.
2021-10-20Added Allied Telesis Loop Detection FramesMartin Mayer5-1/+176
2021-10-20EVS: Support decoding Primary 2.8 kbps packetsNan Xiao1-1/+33
2021-10-20EVS: Fix bug in decoding SID frame CNG typeNan Xiao1-1/+1
In 3GPP 26.449 Codec for Enhanced Voice Services (EVS); Comfort Noise Generation (CNG) aspects, Computational details and bit allocation: For the EVS primary modes, the SID payload consists of 48 bits. The first bit of the payload determines the CNG scheme, where 0 stands for the LP-CNG and 1 for the FD-CNG.
2021-10-19Docs: Move includes to the top of our man pages.Gerald Combs26-26/+26
Move our attributes.adoc includes to the very top of each man page. Older versions of Asciidoctor complain if it's not at the top. and additionally generate <file>.man instead of <file>.<section> if we don't explictly supply an output file.
2021-10-19CMake+Docs: Generate man pages all at once.Gerald Combs3-54/+96
Asciidoctor lets us generate multiple documents at once, so do so for our man pages. If we're using AsciidoctorJ this minimizes the number of JVM instances we have to spin up. This reduces the build time on my Windows VM here quite a bit, and will hopefully do so on the CI builders. Add a .editorconfig file in cmake/modules.
2021-10-19wslua: Initialize Proto members on creationStig Bjørlykke1-3/+3
Set all pointers in Proto to NULL and check for valid pointers when wslua_deregister_protocols(). Fixes #17668
2021-10-19QUIC: fix compilation on RaspberryNardi Ivan5-23/+27
2021-10-19RTPS: ixed dissection of unions in user data.ismaelrti1-33/+25
Removed the type_id check when dissecting user data. That check avoids dissection in valid cases.
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-23 21:30:05 +0000