aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-06-20Define OPTSTRING_CAPTURE_COMMON as nothing if we don't have pcap.Guy Harris2-15/+3
No capturing, no capture options. Change-Id: I0023184b9c358d5876f19a098590f34d641c8649 Reviewed-on: https://code.wireshark.org/review/2493 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20Add some long options for capture short options.Guy Harris4-41/+63
The names match tcpdump trunk's names for the corresponding options. Also have capture_opts.h provide a #define for the part of the short option string that corresponds to the capture short options that all our programs that take capture short options take (those are largely the ones we have in common with tcpdump). Change-Id: Ia209425959c801725850b56a7d63441ee99b5001 Reviewed-on: https://code.wireshark.org/review/2492 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20Add --help and --version long options.Guy Harris4-14/+35
Also, make the convention for long-only options be that their case-statement values start at 128, so they avoid colliding with any ASCII code points, including control characters. Make the tables of long options "static const" while we're at it, and get rid of unnecessary casts. Change-Id: I55702a85e9bc078b1cd0f2803ebb68a710405bab Reviewed-on: https://code.wireshark.org/review/2491 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20TCP: update the list of options and put Kind and Length items in the right ↵Pascal Quantin1-49/+98
subtree Bug: 10211 Change-Id: Ide37f2a2b33f0d6d7cdff897eed02a8c1ea24f7d Reviewed-on: https://code.wireshark.org/review/2488 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-20Fix documentation generation on WindowsPascal Quantin1-1/+1
Change-Id: I7166528e312c99b8477361140869ebeb2b7c03b9 Reviewed-on: https://code.wireshark.org/review/2487 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-20Revert part of svn revision 52045 (git b38ee917)Stig Bjørlykke2-79/+128
This fix does change the format printed for values using bitmasks (because the bit values are printed first) and is not always wanted in this dissectors (because of readability). We should have a better way of doing what I want in this dissectors, so I'll have a look at this later. Change-Id: I2477aa6b1d0c42a7ad5848bba3cb74dce3bba1f0 Reviewed-on: https://code.wireshark.org/review/2485 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-06-20One more change to dissector_add_for_decode_as.Guy Harris1-1/+1
Change-Id: Icd272fc9ae749728a601966de573843390e278ab Reviewed-on: https://code.wireshark.org/review/2484 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris133-183/+189
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20remove duplicate offset=0Martin Kaiser1-2/+0
Change-Id: I6653b733dfd2c587909371e50fd0c2efc4649dcd Reviewed-on: https://code.wireshark.org/review/2482 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-06-20no need for if(tree)Martin Kaiser1-6/+4
Change-Id: I5762fb30f57d0f9bc3e5fc786577ed1cc49b64d7 Reviewed-on: https://code.wireshark.org/review/2481 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-06-20fix printf argument indexEvan Huus1-2/+1
Change-Id: I56aae95d61930c74ac9962225e1bcda72079595e Reviewed-on: https://code.wireshark.org/review/2477 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-20Add proto_tree_add_subtree and proto_tree_add_subtree_formatMichael Mann2-0/+66
This is intended as a replacement for all of the proto_tree_add_text followed by proto_item_add_subtree calls. Change-Id: I892136d7b9d8b4e100996097eff62ce7af9512d2 Reviewed-on: https://code.wireshark.org/review/2472 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20add cast to fix buildbotEvan Huus1-1/+1
Change-Id: I945830a6dd9c34adf9802fa9e9948e2e90d8aba8 Reviewed-on: https://code.wireshark.org/review/2476 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-20Don't hide tcp option kind/len fieldsEvan Huus1-36/+18
Hidden fields are deprecated, and we were hiding them inconsistently anyways. Bug:10211 Change-Id: Iaf1576ae7bc04c0c0bd896c096b117f1b8af2e9e Reviewed-on: https://code.wireshark.org/review/2474 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-20batch of tvb-length conversionsEvan Huus17-104/+103
Change-Id: I5e40df8af6841e3dad71c41d7e43c7971611b15f Reviewed-on: https://code.wireshark.org/review/2473 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-20Cleanup display filters reported by checkfiltername.plMichael Mann23-107/+87
Also ensured some files have their correct names at the top so they are more easily grepped Change-Id: Ib0f5ddf14eb1616a93dee496107dc0eb09048825 Reviewed-on: https://code.wireshark.org/review/2452 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Improve the tolerance of checkfiltername.pl so it can be added to the ↵Michael Mann1-10/+150
pre-commit script. 1. Correctly identify ASN.1 dissectors (so checkfiltername.pl can be more lenient on them) 2. "Whitelist" known (good) filters Change-Id: Iea662190b6655a1919bf08bc35e7978eb2693509 Reviewed-on: https://code.wireshark.org/review/2453 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20packet-vnc.c: Improve re-assembly.Bill Meier1-7/+16
Essentially: When more data is needed to continue dissecting a PDU, use DESEGMENT_ONE_MORE_SEGMENT instead of repeatedly requesting additional bytes (for one or a few more fields). - Improves the efficiency of the dissection; - Prevents 'one-pass' tshark dissection from redissecting the PDU repeatedly many, many times with each time dissecting the PDU with one or a few more additional fields. This generated *lots* of (repeated) output since a reassembled VNC PDU can contain many fields (each of short length). - (A comment in packet-tcp.c states, in effect, that repeatedly requesting a specific amount of more bytes to dissect a PDU will "break reassembly" although I note that the reassembly did seem to work (in-efficiently)). Note: Although this patch improves the handling of reassembly, the dissector has significant issues. For example. see Bug #5366. I expect this fixes the Bug #10134 issue: "Cannot allocate memory"; Before the fix, 'tshark -nVxr' for the input file generated trees with multiple hundreds of thousands of entries and generated reassembled PDUs consisting of many, many small fragments. Change-Id: I970037c346fbaa4bffa5726fd5bee5f69396eabf Reviewed-on: https://code.wireshark.org/review/2471 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-19Add casting and license info to fix buildbotsEvan Huus4-6/+12
Change-Id: Iea53b17480d758c16822d80778fa4f186a188a91 Reviewed-on: https://code.wireshark.org/review/2470 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Make cmake build work for msvc 2013 (Graham Bloice)Joerg Mayer1-3/+3
Change-Id: I8e026dd75085723b95eb2542e102b4383379dfc8 Reviewed-on: https://code.wireshark.org/review/2469 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-19Optimize reseting epan_dissect_t when filtering.Jakub Zawadzki1-6/+10
Don't destroy interesting_hfids hash table, just remove all values. Change-Id: I119aaebf91aca8916aea0f15376ff2cb9d3fbc35 Reviewed-on: https://code.wireshark.org/review/2467 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Changed a cast (from guint to guint64) in a call to gtk_tree_store_set(). ↵dameiss1-1/+1
The data is actually 64-bit, and was being fetched that way - but not stored that way - leading to some very strange (and large) values. Change-Id: I2235ae7f1bab7f48f99afac70109a7d8f9b38e2b Reviewed-on: https://code.wireshark.org/review/2468 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Removed SVN Id tagDario Lombardo3-5/+0
Change-Id: I41931121ab8854e4737aeb565b4f51be87426fa9 Reviewed-on: https://code.wireshark.org/review/2375 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Add dissectors to match the groups of display filters they represent instead ↵Michael Mann1-17/+14
of all coming from proto_zbee_nwk. Change-Id: I8049e84af4670b3dec436d2bab143d59557c07aa Reviewed-on: https://code.wireshark.org/review/2450 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Save the size and position of the expert info dialogChris Maynard10-13/+77
Set initialize position to center on parent bug: 3817 Change-Id: Iad48aa762d892908d50f742606160c8305084f48 Reviewed-on: https://code.wireshark.org/review/2459 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2014-06-19Remove "pkg" prefix from display filters.Michael Mann3-239/+239
Also rename base protocol filter name to match prefix of all other fields Change-Id: Iff234c1443252b9f8e6d87fd7a76925746b5e513 Reviewed-on: https://code.wireshark.org/review/2449 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Cleanup filter fields that checkdisplayfilter.pl was complaining about.Michael Mann1-141/+141
Cleaned up filter names that were shared, but had different types (which can cause problems in a display filter compare) Also cleaned up many [FIELDDESCR] that effectively mimicked the field name. Even more could probably be done (and/or rename field name to be more descriptive), but I was being conservative. Change-Id: I2e072b4f411c390b9430a0a0d903133d6decae5e Reviewed-on: https://code.wireshark.org/review/2448 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Update User GuidePascal Quantin4-21/+50
Change-Id: I947085e2bffa3141dac20e3fe92077c515801297 Reviewed-on: https://code.wireshark.org/review/2466 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Optimize dissect_sip_route_header()Jakub Zawadzki1-4/+5
Don't manually fetch each character to find ',' use tvb_find_guint8() Change-Id: I29711421469e868a86bf2edd7adf8dcc85ed26eb Reviewed-on: https://code.wireshark.org/review/2446 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19calling subdissectors shouldn't be conditional on a treeMichael Mann1-133/+130
Change-Id: I59ad726c16d4a85dd065f4a21bdf5d86e47c82cd Reviewed-on: https://code.wireshark.org/review/2451 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Cleaned up some CLang dead assignment warnings.dameiss1-3/+2
Change-Id: Ibd2fa6c791253e4dbac9a21532e894db3327ce57 Reviewed-on: https://code.wireshark.org/review/2465 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19handle TS packet reassembly for PES packets with 0 length fieldMartin Kaiser1-2/+15
(unknown length) this fixes bug 9527 Change-Id: I255ae9662dfeea06e61e4b0891e0ea8eaa254d0f Reviewed-on: https://code.wireshark.org/review/2462 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-06-19no need to initialize these two varsMartin Kaiser1-2/+2
Change-Id: Ie1a71046b791bcbbf3cf02ddd1c4ddc88b388302 Reviewed-on: https://code.wireshark.org/review/2461 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-06-19Don't crash when closing the Summary window if the file has been closed.Jeff Morriss1-1/+1
Yes, this is a Gtk-UI fix but it's a one-liner and easy enough. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8715 Bug: 8715 Change-Id: I554b6c953e83ff3d8cb57029e844f2f481b751dd Reviewed-on: https://code.wireshark.org/review/2460 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-06-19Protocols sending the OS's AF_INET6 value are OS-specific or broken.Guy Harris2-16/+32
Check for all the different AF_INET6 values that are on various OSes. If Totem is, and will forever be, used *ONLY* on one particular OS, feel free to remove the uses of other _AF_INET6 values (but do *not* change back to using the OS's AF_INET6; this should dissect the protocol correctly on *all* OSes). Add a common AF_INET definition to epan/aftypes.h while we're at it, and use that; as most OSes picked up 4.2BSD's AF_INET value, most if not all of them use 2, but IPv6 came out after 4.2BSD, and various OSes all picked their own values for AF_INET6. Change-Id: Iae15dfdd15203ed3ecd078a6499821dc09139a98 Reviewed-on: https://code.wireshark.org/review/2458 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Fix indent (use 4 spaces) and add modelinesAlexis La Goutte2-32/+58
Change-Id: Ieb231d9f551f3e157197f56378088fb0069388d3 Reviewed-on: https://code.wireshark.org/review/2455 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19batch of manual tvb_length conversionsEvan Huus19-36/+39
Change-Id: Ifea45514bdba8be5f62b9dc560027077297f631e Reviewed-on: https://code.wireshark.org/review/2456 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19gtk_table_new is deprecated in GTK3. Change to use grid instead, and usedameiss1-7/+9
ws_gtk_grid_attach_extended() to do the heavy lifting. Change-Id: I1c9d12556857196f53fadbce70f206a3cc41f7a5 Reviewed-on: https://code.wireshark.org/review/2433 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-19batch of manual tvb_length conversionsEvan Huus16-30/+30
Change-Id: Ib3a1ddc4342a7a8648d6ed8bfcb35aa229c56a27 Reviewed-on: https://code.wireshark.org/review/2445 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Removed SVN Id from epan dir.Dario Lombardo10-20/+2
Change-Id: I487a3451344796447f0d5621b993cc89c29e93b5 Reviewed-on: https://code.wireshark.org/review/2383 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Kerberos: fix dissection of packets when Record Mark is presentPascal Quantin2-2/+2
Bug: 10200 Change-Id: Ied8db64120131c029e276d66aeff8b81a45a7286 Reviewed-on: https://code.wireshark.org/review/2447 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Long and short names are invertedPascal Quantin1-1/+1
Change-Id: Ief3c86562d5eadb845b5a32dc704a61ccd27fdf6 Reviewed-on: https://code.wireshark.org/review/2443 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19address_to_str() *does* take a const pointer.Guy Harris1-4/+1
At least now it does. (So does ep_address_to_str().) Change-Id: I5fdf15ca42faac802fd21b4b6f5b750ed402bd05 Reviewed-on: https://code.wireshark.org/review/2442 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Fix underflow causing infinite loop in openflow dissectorEvan Huus1-4/+9
Bug:10208 Change-Id: I8aff9523fd33cf9e0802153100ea032139966b26 Reviewed-on: https://code.wireshark.org/review/2440 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Those address_to_str() calls were in packet scope, and were safe.Guy Harris2-2/+2
Change-Id: Ic727eca800a1b8972cf1a09cf2cf4ef8cfe4d0ba Reviewed-on: https://code.wireshark.org/review/2439 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Use address_to_str(NULL, ...) for strings allocated outside dissectors.Guy Harris6-24/+81
ep_address_to_str() doesn't crash if called outside packet scope, but it's still not correct to use outside packet scope. Use address_to_str(NULL, ...) to allocate those strings, and then explicitly free them when we're done; exceptions don't get thrown between the allocate and free, so there's no risk of a leak. Change-Id: Iea2af93b0757e648d399e2ba64249224eb7e9e3c Reviewed-on: https://code.wireshark.org/review/2438 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Add sys/socket.h which should fix solarisEvan Huus1-0/+4
Change-Id: Ic6f9e8dce860c2bd54bb4c5e0f2d0526178fc720 Reviewed-on: https://code.wireshark.org/review/2437 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Update PIDL source files with the API changes done in g021e7af"Pascal Quantin4-7/+7
This reverts commit e09d127a9a08b587903a957145d3df655b190954. Change-Id: Id34b9f5875b1d63aaeed96b3ffdc8ece63ab4134 Reviewed-on: https://code.wireshark.org/review/2436 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Revert "Update ASN.1 source files with the API changes done in g021e7af"Pascal Quantin95-405/+405
This reverts commit e308e7c4de81c2ff7159e444b865ac59de4faa2b. Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071 Reviewed-on: https://code.wireshark.org/review/2435 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19rename variable to avoid shadow warningEvan Huus1-3/+3
Change-Id: I5934120da2dddf9076972ea3a471191f7dc9596a Reviewed-on: https://code.wireshark.org/review/2434 Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 18:15:48 +0000