aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-01-24byte_view_text (qt): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte1-1/+1
Warning found by Clang Change-Id: Ibfaac5e1d8cc30d6bb8917d0c0e10a79e059a53e Reviewed-on: https://code.wireshark.org/review/25452 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-24Windows: Modify position of compress checkbox in Export Packets dialogGraham Bloice1-28/+28
The "Compress with gzip" checkbox was over on the right and cut-off. Move it to a (somewhat) better place. Change-Id: I241e6216ba69c5fa4e4709e311d45dfecdad2c2d Reviewed-on: https://code.wireshark.org/review/25448 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-01-24CVS pserver: fix infinite loopPascal Quantin1-1/+1
Bug: 14364 Change-Id: I49377c5b06a7b3f2e919c8f8ae2c4d95b9b2c7eb Reviewed-on: https://code.wireshark.org/review/25446 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-01-24[PFCP] Fixed Outer Header Creation IEMatej Tkac1-10/+12
3GPP TS 29.244 V14.2.0 (2017-12) Change-Id: If99b0701541a32e393d3fd19bbd013fd4abcbcc8 Reviewed-on: https://code.wireshark.org/review/25447 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24Add duplicate value_string in check filterMichael Mann1-4/+4
Change-Id: Ie00d057f5bc36d65b6bba790169543a65b068e47 Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-on: https://code.wireshark.org/review/20744 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24wiretap/k12: fix memory leak.Jakub Zawadzki1-0/+1
Free state.bb in error path. Found by clang. Change-Id: Ic9f2e1383a5219de465a6f22f7b382ac8b1f9cbf Reviewed-on: https://code.wireshark.org/review/25443 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24ui: don't g_assert() in get_args_as_string(), but return empty string for no ↵Jakub Zawadzki1-3/+6
arguments case. Rework e861a112103ed4d1f2fa153932bcf86f120e3907 by returning empty string. g_assert() seems to be not understand by clang scan. Change-Id: Iade2d81aa22eecf563a465cb86e694e3e0f853df Reviewed-on: https://code.wireshark.org/review/25441 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24CMake: Compile and link flag updates.Gerald Combs1-26/+31
Add /guard:cf and /Qspectre to the Visual C++ 2015 compile and link flags. Don't bother trying to pass -Wl,--as-needed or -pie to Visual C++. Remove some unneeded quotes. Change-Id: I4d89d61ce9dd579e7cfbcd49df6116810bfb0178 Reviewed-on: https://code.wireshark.org/review/25356 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24wslua: fix nstime memory leak after passing unknown encoding to ↵Jakub Zawadzki1-3/+5
TvbRange_nstime() Move checking of encoding before allocating nstime. Found by clang. Change-Id: I3c1de5fae6fcf52393cc38302359f21f17808087 Reviewed-on: https://code.wireshark.org/review/25442 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24SDP: Added support for "a=rtcp" and "a=rtcp-mux".Robert Jongbloed1-5/+20
Modern SIP endpoints often use non adjacent, or the same, port for the RTCP protocol as the RTP protocol. This is indicated via attributes in the SDP, which should be used to set up the correct dissector for the correct port on this SIP session. Change-Id: I37bf30b71541b6f924fbda5ac1cb29f3ba171515 Reviewed-on: https://code.wireshark.org/review/25430 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24CMake: Copy multiple data files at a time.Gerald Combs1-11/+94
Copy the DTD, DIAMETER, RADIUS, and profile files all at once instead of individually. Change-Id: I7c75c4a784956b998a82fd627dd17843820096ff Reviewed-on: https://code.wireshark.org/review/25439 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24cvspserver: Add basic cvs pserver protocol dissectorJaap Keuter4-0/+100
Change-Id: I049c8b9b9a0a1da2243217532186ba5a19cf5671 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-24Qt: Add back the "ready to go" startup message.Gerald Combs1-4/+2
The stdin capture test and at least one external application depends on the "Wireshark is up and ready to go" startup message, so we need to print it even when DEBUG_STARTUP_TIME isn't defined. Print the startup time in seconds. Change-Id: Ic1683b751f9cce30b8ca8a6122eddff44fcda015 Reviewed-on: https://code.wireshark.org/review/25440 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-24sharkd: try to fix clang uninitialized value stored to field 'protocol'.Jakub Zawadzki1-3/+6
Instead of using g_memdup(), make it more C-like. Change-Id: Ifde75801a261f9e269391fabf323f34a4e3508ac Reviewed-on: https://code.wireshark.org/review/25395 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-23Docbook: Generate one PDF paper size.Gerald Combs4-113/+34
Generate a single PA4-sized PDF. PA4 is the approximate intersection of A4 and Letter[1]. This gives us one less file to build and distribute. If you're printing out hard copies of the guides this wastes a few pages compared to an A4-sized PDF, but if you're printing out hard copies of the guides you've already made a strong commitment to waste paper. Page counts: Guide Size Pages WSDG A4 203 WSDG Letter 217 WSDG PA4 217 WSUG A4 192 WSUG Letter 204 WSUG PA4 205 [1] https://en.wikipedia.org/wiki/Paper_size#PA4_or_L4 Change-Id: If43d4b19947c77a51b3943a2b329dbab45025d79 Reviewed-on: https://code.wireshark.org/review/25438 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-23QUIC: fix build with older LibgcryptRichard Sharpe1-0/+4
RHEL7 ships with Libgcrypt 1.5.3 which does not support AEAD, add guards to fix -Wunused-function errors. Change-Id: I230a66eff0dca9a882bf87f2f740ee0d36cd1dc6 Reviewed-on: https://code.wireshark.org/review/25434 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-23[MEGACO] Priority value gets displayed as Termitation Id.AndersBroman1-7/+29
Change-Id: If176231d1c71692b1d6a2627934d211e4f2476a7 Reviewed-on: https://code.wireshark.org/review/25433 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-23USBMS: fix endianness of GET MAX LUN and RESETPascal Quantin1-9/+13
While we are at it, let's add the protocol item to allow filtering on protocol. Bug: 14360 Change-Id: I4973a6e657dccd71af4f798584cc118b75bedd20 Reviewed-on: https://code.wireshark.org/review/25425 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-23LTE RRC: register dissectors for UERadioAccessCapabilityInformation(-NB) and ↵Pascal Quantin6-178/+206
UERadioPagingInformation(-NB) Change-Id: Idb3c3fe2cab4ce7aff2bfe108a6bd4fb07fe44b3 Reviewed-on: https://code.wireshark.org/review/25426 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-22gtk: fix memory leak in profile dialog.Jakub Zawadzki1-0/+1
fill_list() don't break the loop when it founds first profile matching name, and it can memleak if somehow it found more than one. Don't break the loop to avoid regressions. Just g_free() previously found. Found by clang. Change-Id: I082b3f1d16f07580a6d7c814d2a8ee5463a44b0f Reviewed-on: https://code.wireshark.org/review/25422 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-22gtk: Fix memory error/double free.Jakub Zawadzki1-2/+1
pathname is freed by caller of firewall_save_as_ok_cb(). Make pathname const. Found by clang scan. Change-Id: I3a0ab85494a9194edb825bae33eca979c7f8faf3 Reviewed-on: https://code.wireshark.org/review/25417 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-22traffic table: Fix memory leakJakub Zawadzki1-0/+1
Free tpl_line in error path. Founded by clang scan. Change-Id: Iaaaaed155d859171ee880d520c11594b2d4d0b59 Reviewed-on: https://code.wireshark.org/review/25420 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-22gtk: Fix memory leak.Jakub Zawadzki1-0/+1
free buffer in error path. Found by clang scan. Change-Id: I7c271b74e3e5ac9d4f2a550f3c83988a4594133d Reviewed-on: https://code.wireshark.org/review/25416 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-22gtk: fix multiple memory leaks in prefs_captureJakub Zawadzki1-26/+16
All leaks follow the same pattern if not gtk_tree_model_get_iter_first(), than memory allocated was not used/ freed. Put memory allocation under gtk_tree_model_get_iter_first() block. Found by clang scan. Change-Id: I8f9671ae5fb043343ab5dcdc39a57f1d28fec15b Reviewed-on: https://code.wireshark.org/review/25418 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-22packet-ieee80211: fix dead store/ dead increment and assignment.Jakub Zawadzki1-2/+6
offset was not used after increment/assignment, just return it to relax clang. Found by clang scan. Change-Id: I21dece4e31075ca2da8d3ba942336fb4858636b6 Reviewed-on: https://code.wireshark.org/review/25419 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-22release-notes: Add note about support of 802.11axAlexis La Goutte1-0/+1
Change-Id: I361dceb79bed6c2a201db115dba1fad3cad2f659 Reviewed-on: https://code.wireshark.org/review/25414 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-22ZigBee: Add a preference to choose ZigBee Smart Energy version used for ↵Martin Boye Petersen3-9/+43
dissecting Some ZigBee commands within the Smart Energy Profile does not have the same payload across different specifications. With this preference it is possible to choose what version of the specification to use when dissecting payloads. The default version is set to the latest one, which is Smart Energy 1.4, even though it is still under development. Change-Id: Iaec5528f2a418aeec4e39cfa087a58e531570d42 Reviewed-on: https://code.wireshark.org/review/25409 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-22ERF: Fix broken erf_open ethernet checkingAnthony Coddington1-3/+3
Was copying 8 byte extension header instead of 2 byte ethernet padding subheader. Introduced recently by I8ede5c733867ccc98ab2d470181d1e4a29ae5b49. Change-Id: I95a8604ed6204dff33f1794601342e090f6b7eb3 Reviewed-on: https://code.wireshark.org/review/25410 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-22ieee80211: 802.11ax support.Richard Sharpe2-37/+2166
This is based on Draft 2 of the standard. Draft 2 did not get approved, but is close to what the final version will be and support is needed now by the teams working on this. Change-Id: I837df05a288b815e1e455883f4f165721104d51f Reviewed-on: https://code.wireshark.org/review/24861 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-22tap-httpstat: cast memory instead of reallocate it in glib hash table.Dario Lombardo1-14/+11
Change-Id: I74db1247f15bdd12fb3ef7fa258d0018605caa30 Reviewed-on: https://code.wireshark.org/review/25346 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-21QUIC: Add define value for Long Packet Type (Initial, Handshake...)Alexis La Goutte1-5/+8
Bug: 13881 Change-Id: Ia733a9e84e6a7dea58a62bcc1c9d79f51e5b46ff Reviewed-on: https://code.wireshark.org/review/25401 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21QUIC: Remove draft-05 and draft-06Alexis La Goutte1-201/+47
All tools use draft-07 or draft-08 Bug: 13881 Change-Id: I539e34324f16149fe8c0d05d938bae1298b9eb15 Reviewed-on: https://code.wireshark.org/review/25399 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21QUIC: Update IETF draft URL (draft-08)Alexis La Goutte1-1/+2
and add also IETF QUIC TLS (-08) draft Bug: 13881 Change-Id: I5662faeb5d1738c896ba66b6857e70baafd3afee Reviewed-on: https://code.wireshark.org/review/25400 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Translate files in subdirectories.Gerald Combs8-143/+3931
Make sure we pass ui/qt/*/*.{cpp,h} to lupdate. Make update-tx a bash script and make sure it passes ShellCheck. Add a -n flag, which disables pushing back to Transifex. Change-Id: Ia7d6564bbdbf69285f1f9b88cde09e37da4f916c Reviewed-on: https://code.wireshark.org/review/25382 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Proto tree fixesGerald Combs2-6/+5
Make sure ProtoTree::toString stops at the right place. Don't emit fieldSelected when we're processing a context menu event. It doesn't appear to be needed and it triggers unwanted automatic scrolling when prefs.gui_auto_scroll_on_expand is enabled. Change-Id: I351a6974d07aea6fdd3eb0b5c1975a1b8d8eb7da Reviewed-on: https://code.wireshark.org/review/25396 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Implement ProtoTreeModel::flags.Gerald Combs2-0/+10
QTreeView checks to see if Qt::ItemNeverHasChildren is set in various places, particularly when updating its set of expanded items. Implement ProtoTreeModel::flags and set Qt::ItemNeverHasChildren when needed so that QTreeView won't mark a leaf node expanded. Otherwise ProtoTree::isExpanded will return true when it shouldn't and break the iterator in ProtoTree::toString. Bug: 14355 Change-Id: Id89be9911aa14dbbb52725f7203ac26a747c42fc Reviewed-on: https://code.wireshark.org/review/25376 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Create byte views at the proper zoom level.Gerald Combs3-3/+12
Add a zoomed argument to WiresharkApplication::monospaceFont so that we can easily fetch the font at its current zoom level. Set the zoomed font when we create new ByteViewTexts. Change-Id: I1293f206e37bb798247b1ac4b314fdfe88d4c55c Reviewed-on: https://code.wireshark.org/review/25371 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21CMake: File copy updates.Gerald Combs2-104/+45
Switch from `xcopy`-ing single files to `cmake -E copy_if_different`-ing multiple files on Windows. Add a comment about using copy_if_different for our data files. Switch from `cmake -E copy` to `cmake -E copy_if_different` in a couple of other places. Change-Id: I6bf72f02a66c46a4440280305479f41ffb4e987a Reviewed-on: https://code.wireshark.org/review/25402 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-21autotools: Rework the plugin MakefilesJaap Keuter19-86/+191
The plugin.c generation in an autotools build comes in from an included Makefile.am file. The various types of plugins need different parameters for the generation script. Put the plugin.c production rule is a seperate include file so each plugin type build can include its own variant. Also amend the README.plugins file with regards to the new directory structure and the fact that there are multiple types of plugins, not just dissector plugins. Change-Id: I3a815d0d767baa555356cf428861b18697401355 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25398 Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-21Qt: Initialize a struct (found by Coverity)Gerald Combs1-0/+1
CID: 1427679 Change-Id: I2ed276f0da413b4853b7dc9ccde3530e655ad760 Reviewed-on: https://code.wireshark.org/review/25403 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-21[Automatic update for 2018-01-21]Gerald Combs10-65/+773
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I60c7bef36988fd487d9088880b1d27818723f0b7 Reviewed-on: https://code.wireshark.org/review/25404 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-20wiretap: use SPDX identifiers (partial work).Dario Lombardo96-1248/+96
Change-Id: I28436e003ce7fe31d53e6663f3cc7aca00845e4b Reviewed-on: https://code.wireshark.org/review/25392 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-20wiretap: more SPDX license convertions.Dario Lombardo23-328/+23
Change-Id: I12695d0713b1d7fe58f09b2037303fab523085e9 Reviewed-on: https://code.wireshark.org/review/25394 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-19radiotap: Updates to the radiotap dissector to avoid confusion.Richard Sharpe2-44/+307
If a field is indicated as not known, then display that field as reserved which will prevent people from searching for fields that are not known and makes more sense. Also, rename some of the hf fields to be more in line with standard practice. Change-Id: I5cbbd682acbea3713b7b19325fe1a36cc0e36aa1 Reviewed-on: https://code.wireshark.org/review/25397 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-19Qt: Force integer font metrics in the byte view.Gerald Combs1-12/+15
Force the layout engine to use integer arithmetic so that we don't run into wierd rounding artifacts. Include the leading when applying formats. Restrict the hover line width to either 0.5 or 1 logical pixels. Change-Id: Icc992e085e96e328ed4ed247271f75ddd69637bc Reviewed-on: https://code.wireshark.org/review/25381 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-19ieee1905: Bring AP Metric TLVs into conformance with the SPECRichard Sharpe1-15/+68
There was a missing field in the initial version of the spec. Add the flags bits that define the subsequenct fields. Change-Id: Ie237075f4f7f30adc4b280358fe5c985c63f5281 Reviewed-on: https://code.wireshark.org/review/25375 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-19Qt: add sanity check in InterfaceTreeCacheModel (found by clang).Dario Lombardo1-3/+1
Change-Id: I8f73254d8ac4b560937431b592a81ad726ce43a9 Reviewed-on: https://code.wireshark.org/review/25370 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-19Qt: remove leak from PathChooserDelegate (found by clang).Dario Lombardo1-2/+3
Change-Id: I71d73c8464450f8cbc655f8f99f54bd34eddd344 Reviewed-on: https://code.wireshark.org/review/25374 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-19epl: Correctly display the error for available bytesRoland Knall1-3/+4
Don't break the remaining length by setting and invalid one Change-Id: Ia32798db73937ada6c99a6927cc87402603a9e75 Reviewed-on: https://code.wireshark.org/review/25391 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-19file: free memory on exit (found by clang).Dario Lombardo1-1/+3
Change-Id: I8d57ae2f6aa114f64d7cd11ca63ce6ae88fd4b68 Reviewed-on: https://code.wireshark.org/review/25385 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 08:37:09 +0000