aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-08-22Gitlab-CI: Disable Qt6 for Windows Qt5 buildJoão Valverde1-1/+1
2022-08-22CMake+etc: Enable Qt6 by default for Unix buildsJoão Valverde8-24/+24
Linux builds were left behind on the Qt transition, presumably because our Ubuntu CI image does not support Qt6. Enable Qt6 by default and explicitly disable it for slower or more conservative Linux distros. Drop experimental status for Qt6, because we are using it to build official Windows and macOS releases.
2022-08-22Qt: Add dfilter error location to tooltipJoão Valverde3-4/+35
If display filter compilation fails and the expression has a syntax error and associated location, it will be displayed in the filter tooltip, using a textual underline. As far as I can tell using a graphical squiggly underline seems extremely difficult for an object inheriting from QLineEdit, so the tooltip textual method was used instead.
2022-08-22HTTP: Send binary Continuation Data to Follow StreamJohn Thacker1-5/+23
If we shortcut the HTTP header check because the file starts with a non-ASCII character, but we think that it is Continuation Data because we've seen real HTTP in the same conversation, mark the data as file data and send it to the follow tap, just as we would if it failed the more extensive checks for being a header. Deals with cases where desegmentation isn't performed (whether because of prefs, missing packets, bad checksums, etc.) Related to #13918.
2022-08-22Qt: Fix export objects memory leakJohn Thacker2-0/+8
The export object entries were never getting freed, creating a pretty serious memory leak. =1307558==ERROR: LeakSanitizer: detected memory leaks Direct leak of 2237664 byte(s) in 46618 object(s) allocated from: #0 0x55ac70d80457 in malloc (/home/johnthacker/wireshark-clang/run/wireshark+0x1a4a457) (BuildId: ad576854e9259fb05a7d0aacbff6e3e1f8e41157) #1 0x7fe8ff2f4278 in g_malloc (/lib64/libglib-2.0.so.0+0x5a278) (BuildId: 8a4c270219135729dff508e4bb3cc03099af40e8) #2 0x7fe910912ff4 in tap_push_tapped_queue /home/johnthacker/wireshark/epan/tap.c:366:15 #3 0x7fe910711548 in epan_dissect_run_with_taps /home/johnthacker/wireshark/epan/epan.c:640:2 #4 0x55ac7263288d in retap_packet /home/johnthacker/wireshark/file.c:2241:5 #5 0x55ac7263201c in process_specified_records /home/johnthacker/wireshark/file.c:2207:14 #6 0x55ac726315fc in cf_retap_packets /home/johnthacker/wireshark/file.c:2292:11 #7 0x55ac712aed41 in ExportObjectDialog::show() /home/johnthacker/wireshark/ui/qt/export_object_dialog.cpp:173:15 ... Indirect leak of 1700955 byte(s) in 139854 object(s) allocated from: #0 0x55ac70d80457 in malloc (/home/johnthacker/wireshark-clang/run/wireshark+0x1a4a457) (BuildId: ad576854e9259fb05a7d0aacbff6e3e1f8e41157) #1 0x7fe8ff2f4278 in g_malloc (/lib64/libglib-2.0.so.0+0x5a278) (BuildId: 8a4c270219135729dff508e4bb3cc03099af40e8) ... SUMMARY: AddressSanitizer: 3961187 byte(s) leaked in 186587 allocation(s).
2022-08-21SMTP: Move the request handling into a functionJohn Thacker1-301/+317
This makes the code easier to read and will enable handling multiple PDUs in a message easier (needed for full pipelining support.)
2022-08-21SMTP: Move response handling into functionJohn Thacker1-173/+187
Make the code a little easier to read
2022-08-21DCT2000: Don't assign to tag unused valueMartin Mathieson1-1/+2
2022-08-21[Automatic update for 2022-08-21]Gerald Combs18-465/+216
Update manuf, services enterprise numbers, translations, and other items.
2022-08-21epan: Handle subset tvbuffs with non-zero offets and length -1John Thacker1-0/+10
According to tvbuff.h, tvb_new_subset_length() with length -1 should behave like tvb_new_subset_remaining(). That means that the reported length should subtract off the offset into the original tvb.
2022-08-21blf: change description and add/extend comments.Guy Harris2-3/+15
Call the Vector Informatik BLF format "Vector Informatik Binary Logging Format (BLF) logfile", to give more details to people who don't necessarily know what "BLF" means (British Lung Foundation?). Note that in the introductory comments to blf.c and blf.h as well. Note that we should perhaps report unknown flags/packet timestamp type values as errors or warnings. Note that we can, and should, report at least some 802.11 radio information to our caller.
2022-08-21BLF: Adding ObjectHeader format 2 and 3Dr. Lars Völker2-118/+148
This patch adds the format 2 and 3 of the ObjectHeader, so that the blf code does not stop reading the file, when one of these header formats is present. Minor refactoring was necessary.
2022-08-20Add missing debian symbolsJohn Thacker1-0/+2
Add new symbols from commit 005169491e72e22a3aa7f7035e2e3cf60b05c6f1
2022-08-20RLC Graph: store secs in time_tMartin Mathieson3-4/+4
2022-08-20ieee80211: Improve A-MSDU dissectingChien Wong1-4/+27
Fix subframe length issue. Add padding. Signed-off-by: Chien Wong <m@xv97.com>
2022-08-20ieee80211: Add Transition Disable KDE dissectingChien Wong2-0/+72
Signed-off-by: Chien Wong <m@xv97.com>
2022-08-20pcapng: add support displaying hash from pcapngStephen Hemminger4-4/+209
Add support for displaying one or more packet hashes that have been recorded in EPB options. A patch to add support for EPB hash option is pending for next DPDK release. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
2022-08-19Windows: Upgrade libgcrypt to 1.10.1.Gerald Combs4-17/+26
2022-08-19QUIC: In stateless reset only set from_server if token foundJohn Thacker1-2/+4
When calling quic_find_stateless_reset_token, only change the from_server pointer is the reset token is actually found. Fixes a few cases where a new Initial connection is sent with client and server reversed. Also fixes an error failing to dereference a pointer to a boolean.
2022-08-19Use `register_dissector()` for more protocolsDavid Perry42-161/+140
2022-08-19Fix some spelling errorsMartin Mathieson7-12/+23
2022-08-19Protobuf: correct the starting offsets of the field name and type tree itemshuangqiangxiong1-2/+3
2022-08-19QUIC: Add support for stateless resetJohn Thacker3-6/+136
Fix #17938
2022-08-19TLS:support decrypt TLS_SM4_GCM_SM3 ciphersuitezhangzhilei2-0/+2
ECC_SM4_GCM_SM3 is defined in RFC8998,and it defined how to use SM3 and SM4 in tls1.3.
2022-08-19TLS:support decrypt ECC_SM4_GCM_SM3 ciphersuitezhangzhilei1-3/+3
ECC_SM4_GCM_SM3 is defined in GB/T38636-2020 Information security technology-Transport layer cryptography protocol which is a Chinese national standard. the gcm behaviour of ECC_SM4_GCM_SM3 is the same as TLS1.2.
2022-08-19RTPS: Added new Security PIDs in Participant and Endpoint Discoveryismaelrti1-3/+296
Added dissections for the following PIDs: - PID_PARTICIPANT_SECURITY_DIGITAL_SIGNATURE_ALGO - PID_PARTICIPANT_SECURITY_KEY_ESTABLISHMENT_ALGO - PID_PARTICIPANT_SECURITY_SYMMETRIC_CIPHER_ALGO - PID_ENDPOINT_SECURITY_SYMMETRIC_CIPHER_ALGO
2022-08-19TLS:support decrypt ECC_SM4_CBC_SM3 ciphersuitezhangzhilei1-1/+8
ECC_SM4_CBC_SM3 is defined in GB/T38636-2020 Information security technology-Transport layer cryptography protocol which is a Chinese national standard. prf alg of ciphersuites defined in GB/T 38636-2020 are the same as TLS1.2.
2022-08-19Falco Bridge: Add a NULL check.Gerald Combs1-1/+1
2022-08-19rdpudp: fix leaking copy_address.Dario Lombardo1-1/+1
Fix: #18224.
2022-08-19TCP: Implement AccECNMichael Tuexen2-50/+260
This work is based on https://www.ietf.org/archive/id/draft-ietf-tcpm-accurate-ecn-20.html In particular, add support for the AccECN option, the experimental AccECN option, the AE flag and the ACE field.
2022-08-18macOS: Make sure we rpathify QtNetwork.Gerald Combs1-0/+3
QtNetwork might be linked with brotli, so make sure we fix up its rpath.
2022-08-18GSUP: add missing Number of Vectors Requested IEVadim Yanitskiy1-0/+9
This IE was introduced back in 2019, see: https://gerrit.osmocom.org/q/Iaecc47280f8ce54f3e3a888c1cfc160735483d0f https://cgit.osmocom.org/libosmocore/commit/?id=49ddef610a003f1000422284bf31a653249cf09e
2022-08-18GSUP: add missing Supported/Current RAT Types IEsVadim Yanitskiy1-0/+35
These IEs were introduced back in 2018, see: https://gerrit.osmocom.org/q/I93850710ab55a605bf61b95063a69682a2899bb1 https://cgit.osmocom.org/libosmocore/commit/?id=1b729ce106f474e29e7bbd57c01c3472e75a8b25 Below is an example PDU containing them: GSUP SendAuthInfo Request, IMSI: 901700000043352 Message Type: SendAuthInfo Request (8) IE: IMSI, 901700000043352 Information Element Identifier: IMSI (1) Information Element Length: 8 IMSI: 901700000043352 [Association IMSI: 901700000043352] Mobile Country Code (MCC): International Mobile, shared code (901) Mobile Network Code (MNC): Clementvale Baltic OÜ (70) IE: Supported RAT Types Information Element Identifier: Supported RAT Types (41) Information Element Length: 1 Supported RAT Type: EUTRAN (SGS) (3) IE: Current RAT Type Information Element Identifier: Current RAT Type (42) Information Element Length: 1 Current RAT Type: EUTRAN (SGS) (3)
2022-08-18macOS: Try to make sure we can find brotli.Gerald Combs1-0/+11
libbrotlidec and libbrotlicommon show up in `otool -L` without any path information on the macOS builders, similar to what's described at https://github.com/google/brotli/issues/934 Try to work around this in osx-app.sh.
2022-08-17GitLab CI: Fix our macOS Intel deployment target.Gerald Combs1-1/+1
2022-08-18TCP: Add support for TARR optionMichael Tuexen1-0/+49
Based on https://datatracker.ietf.org/doc/html/draft-gomez-tcpm-ack-rate-request-05.
2022-08-17TCP: Use RFC 6994 for experimental optionsMichael Tuexen3-30/+90
Modernize the handling of experimental TCP options based on RFC 6994. In particular use ExID instead of magic (which in the context of RFC 6994 are the last two bytes of a 32-bit ExID) and add a desciption of ExID based on the current state of the IANA registry.
2022-08-17GitLab CI: Enable Qt6 for the macOS builds.Gerald Combs1-2/+2
2022-08-17TCP tap: check if have seglen before using itDavid Perry1-1/+3
2022-08-17GitLab CI: Switch the macOS builds to Qt 6.2.4.Gerald Combs1-1/+2
2022-08-17Add support for Addd Path in EVPN NLRIMichael Pergament1-1/+8
2022-08-17CMake: Break on GLib criticals by default in MSVCTomasz Moń1-0/+8
Set G_DEBUG=fatal-criticals environment variable when debugging with Visual Studio. Setting the environment variable conveniently triggers breakpoint whenever there is a programmer error.
2022-08-17Docs: Add a SharkFest link to the release notes.Gerald Combs1-0/+3
2022-08-17CMake: Add a Logray patch version.Gerald Combs1-1/+2
2022-08-17Bluetooth: Decode LL_VERSION_IND packets with version 5.3Rubin Gerritsen1-0/+1
Bluetooth 5.3 was released 2021-07-13. Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
2022-08-17smb: Squash small leak in export objectJohn Thacker1-0/+1
After a free chunk is removed from the list of free chunks, it should be freed.
2022-08-17BTATT: Fix bitmask for btatt.battery_power_stateUli Heilmeier1-4/+4
Fixes: #18267
2022-08-17tiff(file): Don't add a proto item when heuristics failJohn Thacker1-4/+8
Don't add the protocol to the tree if heuristics fail. Make sure that we have enough bytes to perform the heuristics. If the magic number is wrong, don't go on to retrieve the ifd offset.
2022-08-16ascend: make the time stamp in the parser state a time_t.Guy Harris1-1/+1
It's set from the result of mktime(), which returns a time_t, and it's assigned to a time_t that's ultimately assigned to the time_t secs member of an nstime, so no reason for it to be a guint32. This should squelch Coverity CID 1509354.
2022-08-165views: don't allow out-of-range time stamps.Guy Harris1-1/+10
This should squelch Coverity CID 1509355.