aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2011-02-17On Windows, try putting __declspec(noreturn) in front of declarations ofGuy Harris9-15/+52
routines that don't return. (This requires that some files include config.h to get WS_MSVC_NORETURN declared properly.) svn path=/trunk/; revision=35989
2011-02-17Fix some Visual C++ analysis warnings.Gerald Combs6-136/+145
svn path=/trunk/; revision=35988
2011-02-17Apparently, if the argument to the cd command in an nmake file containsGuy Harris1-1/+1
spaces, it needs to be quoted, the fact that, if the argument to a cd command typed at cmd.exe contains spaces, it *doesn't* need to be quoted nonwithstanding. svn path=/trunk/; revision=35987
2011-02-17Fix gcc compilation errors.Gerald Combs1-7/+7
svn path=/trunk/; revision=35986
2011-02-17Fix various Visual C++ analysis warnings.Gerald Combs7-18/+18
svn path=/trunk/; revision=35985
2011-02-17Don't allocate a bunch of memory on the stack for strings that will beGerald Combs1-54/+30
fed to col_append_fstr; columns have a maximum length of 240 characters (ITEM_LABEL_LENGTH). Make sure our column text is properly formatted. svn path=/trunk/; revision=35984
2011-02-17Fix dead initialization error found by clang:Stephen Fisher1-1/+1
"Value stored to 's' during its initialization is never read" (it's assigned by a later g_hash_table_lookup call) svn path=/trunk/; revision=35983
2011-02-17Remove some of the many dead assignments found by clangStephen Fisher1-30/+30
svn path=/trunk/; revision=35982
2011-02-17It wasn't complaining about that null pointer reference.Guy Harris1-1/+1
svn path=/trunk/; revision=35981
2011-02-17Fixed no_sua_assoc init.Stig Bjørlykke1-1/+2
svn path=/trunk/; revision=35980
2011-02-17- Introduce association tracking(might not work well with multihoming).Anders Broman1-304/+510
- prefix hf variables with sua ( hf_sua...) svn path=/trunk/; revision=35979
2011-02-17Is there an SAL tag that says "this function never returns"?Guy Harris1-0/+5
svn path=/trunk/; revision=35978
2011-02-17Can we reassure Microsoft's static analyzer that 0 <= mask <= 48?Guy Harris1-0/+6
svn path=/trunk/; revision=35977
2011-02-17Oops, wrong pointer comparison.Guy Harris1-2/+3
svn path=/trunk/; revision=35976
2011-02-17OK, let's try a couple more explicit checks against NULL, to see whetherGuy Harris2-2/+2
that de-confuses Microsoft's code analyzer. svn path=/trunk/; revision=35975
2011-02-17From Alexis La Goutte :Jaap Keuter1-5/+51
A patch to add Vendor ID of VIA Client & Remote AP (from Aruba Networks) Also add ett_ value for rohc, ike & ike2. svn path=/trunk/; revision=35974
2011-02-17Use "XXX != NULL" rather than "XXX" to test for a null pointer; eitherGuy Harris1-33/+32
I'm missing something or the MSVC++ code analyzer doesn't realize that in if (XXX) dereference XXX will not dereference XXX if it's null - maybe "if (XXX != NULL)" will do the trick (if so, the code analyzer is buggy, because "if (XXX != NULL)", "if (XXX != 0)", and "if (XXX)" mean the exact same thing if XXX is a pointer-valued expression, really, truly, even if a null pointer isn't represented as all zero bits or if it's wider than an int). Clean up indentation. svn path=/trunk/; revision=35973
2011-02-17Squelch a warning from the MSVC++ static analyzer (it's worried thatGuy Harris1-5/+29
GetModuleHandle() could return a null pointer, which is possible, although if it returns one when handed "kernel32.dll", you have bigger problems...). Add some comments. svn path=/trunk/; revision=35972
2011-02-17Fix some Visual C++ static analyzer complaints.Gerald Combs7-51/+57
svn path=/trunk/; revision=35971
2011-02-16Fix Visual C++ code analysis errors.Gerald Combs2-3/+25
svn path=/trunk/; revision=35970
2011-02-16Change protocol column from "IEEE 802.11" to "802.11" so it fits inStephen Fisher1-1/+1
the default column width. svn path=/trunk/; revision=35969
2011-02-16Put the "MCS known information" field into the protocol tree; yes, it'sGuy Harris1-4/+49
somewhat redundant, as items aren't displayed if they're not known, but it can make it a little clearer to people who aren't familiar with the gory details of radiotap (which people just looking at network traffic might not be). Clean up some capitalization of field names. svn path=/trunk/; revision=35968
2011-02-16Fix compilation on Windows.Gerald Combs2-1/+15
svn path=/trunk/; revision=35967
2011-02-16More cleanup toward being able to compile with GTK+ 3.0. Mostly replacingStephen Fisher4-9/+269
deprecated GtkToolTips with new functions. svn path=/trunk/; revision=35966
2011-02-16Generate correct type (FT_OID) for "x420.compression_algorithm_id".Stig Bjørlykke2-3/+3
I suspect this should have been fixed in asn2wrs... svn path=/trunk/; revision=35965
2011-02-16Make swap_mac_addr() take a pointer to a TVB and an offset rather thanJeff Morriss1-6/+6
(generally) a pointer into the TVB. svn path=/trunk/; revision=35964
2011-02-16Use tvb_ether_to_str()Jeff Morriss1-8/+8
svn path=/trunk/; revision=35963
2011-02-16Use tvb_ether_to_str().Jeff Morriss1-4/+2
There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). svn path=/trunk/; revision=35962
2011-02-16Use tvb_ip_to_str() when it can eliminate a tvb_get_ptr() call.Jeff Morriss1-6/+2
svn path=/trunk/; revision=35961
2011-02-16Use tvb_ether_to_str() when it can eliminate a tvb_get_ptr() call.Jeff Morriss1-3/+1
svn path=/trunk/; revision=35960
2011-02-16Use tvb_ether_to_str()Jeff Morriss1-4/+4
svn path=/trunk/; revision=35959
2011-02-16Rename the _to_str() functions in this dissector to tvb_*_to_str() and makeJeff Morriss1-30/+20
the functions take a pointer to a TVB and an offset rather than (generally) a pointer into a TVB. Use NULL as the value_ptr in proto_tree_add_bytes_format() since the bytes are coming straight from the TVB anyway. Remove unnecessary include file. svn path=/trunk/; revision=35958
2011-02-16Return an error value for the new error return; it "can't happen" (butGuy Harris1-1/+7
either the VC++ analyzer can't determine that or it *can*, in fact, happen). Pick an error code that's not too far off. svn path=/trunk/; revision=35957
2011-02-16Check the index before storing into the array.Guy Harris1-1/+1
svn path=/trunk/; revision=35956
2011-02-16Fix checkapi.Gerald Combs1-64/+64
svn path=/trunk/; revision=35955
2011-02-16Fix errors found by the Visual C++ analyzer.Gerald Combs9-10/+13
svn path=/trunk/; revision=35954
2011-02-16Fix a buffer overflow found by the Visual C++ analyzer.Gerald Combs1-0/+7
svn path=/trunk/; revision=35953
2011-02-15Update a few comments about the use of LOCAL_CFLAGS, STANDARD_CFLAGS and ↵Bill Meier1-2/+4
WARNING_ARE_ERRORS svn path=/trunk/; revision=35952
2011-02-15Enable /analyze:WX- only if ENABLE_CODE_ANALYSIS is defined ...Bill Meier1-2/+2
svn path=/trunk/; revision=35951
2011-02-15Previously 1 byte TCP payload to port 2000 got interpreted as malformed SkinnyJörg Mayer1-0/+4
svn path=/trunk/; revision=35950
2011-02-15From Matthew Parris:Jaap Keuter1-4/+4
Display "Day of Year" for January 1 as 1, not 0. svn path=/trunk/; revision=35949
2011-02-14From Ania:Jaap Keuter1-47/+117
Patch enables decoding CM 7.1(3b) messages and CM5 CallInfoMessage (0x14A). svn path=/trunk/; revision=35948
2011-02-14Make sure RTP conversations are created.Jaap Keuter1-2/+2
svn path=/trunk/; revision=35947
2011-02-14Enable Enterprise Code Analysis via the ENABLE_CODE_ANALYSIS environmentGerald Combs1-2/+2
variable. svn path=/trunk/; revision=35946
2011-02-14Put error messages and expert info for illegal UTCTime elements as aStig Bjørlykke1-18/+20
subtree on the UTCTime element. svn path=/trunk/; revision=35945
2011-02-14Disallow invalid char's in the filename passed to idl2wrs. Fixes bug 1129.Chris Maynard3-3/+22
svn path=/trunk/; revision=35944
2011-02-13From Fulko Hew:Jaap Keuter1-0/+2
The 'upper bound field is not being displayed in Register and Unregister PDU's. svn path=/trunk/; revision=35943
2011-02-13[Automatic manuf, services and enterprise-numbers update for 2011-02-13]Gerald Combs2-22/+235
svn path=/trunk/; revision=35940
2011-02-13Advance offsets in the "default" branch to avoid infinite loops.Anders Broman1-0/+6
** (tshark.exe:4392): WARNING **: Dissector bug, protocol GSM BSSMAP, in packet 194520: More than 1000000 items in the tree -- possible infinite loop https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5688 svn path=/trunk/; revision=35939
2011-02-13Register BICC by name.Anders Broman1-0/+1
svn path=/trunk/; revision=35938