aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-10-18Use proto_tree_add_expert_format instead of proto_tree_add_textHannes Mezger1-12/+16
Change-Id: Ia017fa9535cbc7570ce6bd442972eedd2143825a Reviewed-on: https://code.wireshark.org/review/4729 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-18Converted numerous proto_tree_add_none_format() calls for bitmask/flag items ↵David Ameiss5-1479/+1181
to proto_tree_add_bitmask(). Correctly set the length of LBT-RM and LBT-RU header blocks. Various other cosmetic cleanups. Change-Id: If19bbdeb10176b8059fd4cf657719b3b9817bc6a Reviewed-on: https://code.wireshark.org/review/4776 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-18Add URL to a description of the attributesJoerg Mayer1-2/+10
Add comments about additional attributes Change-Id: Ic73039ee6fde954e147a44e0f98def76a7e88fb3 Reviewed-on: https://code.wireshark.org/review/4812 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-10-18Commit 54b733ce9a0d1cd4ab9b142479368a5e696360be broke compilation ofJoerg Mayer1-15/+18
echld by removing TS_PREC_AUTO_USEC. Replace its use by TS_PREC_AUTO. No idea whether that's correct but it compiles again. Trying to commit this brought complaints by checkapi, so fixed them as well. Maybe the echld code should be removed, it seems to be unmaintained. Change-Id: Id9a0a6fc129abd1b8c93629c31a89c2d9ea2243f Reviewed-on: https://code.wireshark.org/review/4811 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-10-18Get rid of unnecessary includes of ctype.h.Guy Harris6-24/+18
Change-Id: I9e2cd7a9fed33fc2f4b0c0da3603690450f6952d Reviewed-on: https://code.wireshark.org/review/4809 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-18Check for printable ASCII in an ENBName.Guy Harris3-19/+17
I'm not sure why the check is only for alphabetical characters; if that's correct, change this to use g_ascii_isalpha, and change is_printable_ascii to is_ascii_alpha or something such as that. Don't use ctype.h routines, as they are locale-dependent. Change-Id: I61d0672350d35ad918e95d7e96ed5dd263102da9 Reviewed-on: https://code.wireshark.org/review/4805 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-18Get rid of unnecessary includes of ctype.h.Guy Harris3-3/+0
Change-Id: Ibf9385715b85186f5c7289165acea7233b3fabde Reviewed-on: https://code.wireshark.org/review/4804 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Get rid of some no-longer-necessary casts.Guy Harris1-4/+4
g_ascii_isXXX() can be handed a char value safely; they won't try to use it as an index into a table before checking it. Change-Id: Icf80163fb5f9dccd0b97917e318b1db0bf3e0cf8 Reviewed-on: https://code.wireshark.org/review/4801 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use ctype.h routines.Guy Harris5-13/+8
That avoids locale dependency and handles possibly-signed chars(which we weren't always doing before). Change-Id: I89e50678abb8c3e535081c92ca25bc1bab672c68 Reviewed-on: https://code.wireshark.org/review/4798 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Get rid of unnecessary includes of ctype.h.Guy Harris5-5/+0
Change-Id: Ibb194cd839d174af9c96f7bb1e2941b3dd6c1ce1 Reviewed-on: https://code.wireshark.org/review/4797 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use ctype.h routines.Guy Harris8-55/+46
That avoids locale dependency and handles possibly-signed chars (which we weren't always doing before). Change-Id: Ieceb93029252f646397b6488f2df8a57c6d2a23d Reviewed-on: https://code.wireshark.org/review/4794 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17strptime.c needs ctype.h.Guy Harris1-0/+1
Change-Id: Icf4020426d3a5e0a6bd2012a266cf07be9928abf Reviewed-on: https://code.wireshark.org/review/4793 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Get rid of unnecessary include of ctype.h.Guy Harris1-1/+0
Change-Id: Ib83e707ebbbb420ce269a652ede6b7366d24240e Reviewed-on: https://code.wireshark.org/review/4792 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Get rid of unnecessary includes of ctype.h.Guy Harris4-5/+0
Change-Id: Ic23203f13fd6627b664e8ed1438d328c46328b9f Reviewed-on: https://code.wireshark.org/review/4790 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use ctype.h routines.Guy Harris1-3/+1
That avoids locale dependency and handles possibly-signed chars (which we weren't doing before). Change-Id: I189222eff624ad2d2e960bc0b69f3f22d35f351f Reviewed-on: https://code.wireshark.org/review/4787 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Get rid of unused includes of <ctype.h>.Guy Harris2-2/+0
Change-Id: Iab9eaeb0f5765748b2582177396264e4e69bc6d1 Reviewed-on: https://code.wireshark.org/review/4786 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use ctype.h routines.Guy Harris8-47/+39
That avoids locale dependency and handles possibly-signed chars (which we weren't doing before). Change-Id: I70f3d993c9a8fbf870901f12b430d733968c3fa8 Reviewed-on: https://code.wireshark.org/review/4781 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Use proto_tree_add_bitmask for ExpandedNodeId EncodingMaskHannes Mezger1-9/+16
Instead of adding the items using proto_tree_add_item, use proto_tree_add_bitmask in parseExpandedNodeId(). Also, the redundant 'NodeId ' text is removed from hf_opcua_nodeid_... items for better readability. Change-Id: Ie68f1d280dd733fd2eede0b2b73ad8d7f28396b3 Reviewed-on: https://code.wireshark.org/review/4730 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-17SGsAP Update to V12.6.0 except for IE TMSI based NRI container.AndersBroman2-8/+62
Change-Id: Iafb62a27589de1810d4d3bd1e32f1c89898e9171 Reviewed-on: https://code.wireshark.org/review/4777 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-17Add argument 'packet_info *pinfo' to all dissecting functionsHannes Mezger15-1623/+1624
Change-Id: Ie02326e365ee3f620fcbe3f2e8e45dc5300d3418 Reviewed-on: https://code.wireshark.org/review/4728 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-17Dissect CDMA2000 PDU if GCSNA dissector exists.AndersBroman3-51/+90
Change-Id: I866fb9bbc3e94df63231959d6745f3d45ca84020 Reviewed-on: https://code.wireshark.org/review/4772 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-17isdigit -> g_ascii_isdigit to make the build work.AndersBroman1-1/+1
Change-Id: I670b7b83976a9db9491e017015d570a4dc8f433d Reviewed-on: https://code.wireshark.org/review/4771 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-17Eliminate include of <ctype.h>.Guy Harris1-11/+0
This is not built if we have glibc (as we already have getopt() from it), and it's not part of glibc, so.... Change-Id: Iae4ff944c78fc55a8cd2eaf523a3696c47b741d7 Reviewed-on: https://code.wireshark.org/review/4769 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Remove unnecessary includes of <ctype.h>.Guy Harris14-18/+0
Change-Id: I8eacec5fa8d57b10d40a3627197461dae89c6cb2 Reviewed-on: https://code.wireshark.org/review/4768 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Use g_ascii_isspace() instead of isascii() && isspace().Guy Harris1-2/+1
This eliminates one more use of <ctype.h> macros; we're using g_ascii_isXXX() instead of isXXX() elsewhere. Change-Id: I184caeefab95dda2cf207acf9539eabbd7c32a51 Reviewed-on: https://code.wireshark.org/review/4767 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.Guy Harris4-9/+5
This avoids locale-dependent tests, and fixes cases where we passed signed char values to those macros (which is not safe with char being signed, as it is on most, but not all, platforms). Change-Id: Iea962cd7e4dfaf33c3c873ba43814cc6ed298d94 Reviewed-on: https://code.wireshark.org/review/4764 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Remove unnecessary include of <ctype.h>.Guy Harris1-1/+0
Change-Id: I596b252d5fb41e654961483cb530754442f25bc7 Reviewed-on: https://code.wireshark.org/review/4763 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.Guy Harris1-6/+5
This avoids locale-dependent tests, and fixes cases where we passed signed char values to those macros (which is not safe with char being signed, as it is on most, but not all, platforms). Change-Id: I51d9716fe3eb02a6e98208334285c07597a6be79 Reviewed-on: https://code.wireshark.org/review/4761 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.Guy Harris2-3/+1
This avoids locale-dependent tests. Change-Id: I709ff6b1a837fb0390b29f911d3b9ef1015a2d1e Reviewed-on: https://code.wireshark.org/review/4758 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use ctype.h routines.Guy Harris1-2/+9
That avoids locale dependency and handles possibly-signed chars (which we weren't doing before). Change-Id: I2afab254044e0d39dfa67acd840b9fe4ff1e6d08 Reviewed-on: https://code.wireshark.org/review/4756 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17Don't use <ctype.h> macros.Guy Harris4-7/+3
They're locale-dependent (although those *particular* ones might not be). Remove no-longer necessary (or not-even-necessary-before-this-change) includes of <ctype.h> Change-Id: I1384e3ae4ccba6af9220a08773abcde7ea320573 Reviewed-on: https://code.wireshark.org/review/4755 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-17No need for our own wrappers around tolower() and toupper().Guy Harris1-20/+3
We can just use g_ascii_tolower() and g_ascii_toupper(); Change-Id: I8a88a096d16ce8c60dd9151e5bdddf6747702145 Reviewed-on: https://code.wireshark.org/review/4754 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Use g_ascii_isalnum() rather than isalnum().Guy Harris1-3/+2
That way, we don't have to worry about casting the argument (which, in one place, was done wrong - casting to int preserves the sign-extension done with signed chars), and don't have to worry about a locale in which particular 8-bit byte values are considered alphanumeric characters. Change-Id: I129b4bfdad70ade4ab6e0a1d2c13d59ae9e6f524 Reviewed-on: https://code.wireshark.org/review/4751 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Just have get_mac_lte_rapid_description() return the description string.Guy Harris1-16/+12
If get_mac_lte_rapid_description() returned FALSE, we always used "" as the description string; just have it return the string, or return "" if rapid ranges haven't been configured, and just use the string. (If the code ever needs to determine in other places whether rapid ranges have been configured, it can check s_rapid_ranges_configured, or get_mac_lte_rapid_description() could return NULL in that case and the code using the string can check for a null value.) This should squelch some incorrect used-but-not-set warnings from at least one compiler. Change-Id: I3ed495a4beb4a553e453e7bca764d1d8a07c5e53 Reviewed-on: https://code.wireshark.org/review/4750 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Make sort_alphabet() not fail too badly with characters in [128,255].Guy Harris1-4/+8
Treat all values in the alphabet as unsigned. Change-Id: I4476c75352f32673a9cd131ea233465f3376fa25 Reviewed-on: https://code.wireshark.org/review/4747 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16use supported/unsupported for the bitfield elementsMartin Kaiser1-24/+24
order them from MSB to LSB Change-Id: Ie758285c2cf5d19e00d6d256c49acca15ce81168 Reviewed-on: https://code.wireshark.org/review/4746 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-10-16smartcard descriptor: start a bitfield for the featuresMartin Kaiser1-2/+23
Change-Id: I636cfdfcd61d6d5dc041f9dbc657244d94e88b7f Reviewed-on: https://code.wireshark.org/review/4745 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-10-16GTPv2 in Complete Request Message call the NAS dissector with a tvb onlyAndersBroman1-2/+2
containing the IE not the rest of the tvb. Change-Id: I3eead5047b4f8de47e280ac447c66b110592bccd Reviewed-on: https://code.wireshark.org/review/4744 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-16Oops, I missed one "cast a char to int and use it as a subscript" case.Guy Harris1-1/+1
Casting a signed char with a negative value to int will preserve the value, so it'll still be a negative subscript. Cast to guchar instead, to make sure 0x80 through 0xFF are treated as 128 to 255, not -128 to -1. Change-Id: I1f0b33ba3686e963d45317b45465ff335431d17f Reviewed-on: https://code.wireshark.org/review/4742 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Better fix - just check that the upper and lower nibbles are >= 0xA.Guy Harris1-17/+5
An unsigned 8-bit integer is always <= 0xFF; that was the cause of the warning. To see whether a byte, when represented as hex, has letters for its upper and lower nibbles, just check whether both nibbles are >= 0xA. Cast the extracted nibbles to make sure there's no sign-extension. Change-Id: If4c7717a5d2fe341c02e9309ee6b89973a6ac292 Reviewed-on: https://code.wireshark.org/review/4739 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Added italian translation to qt.Dario Lombardo9-0/+9364
Change-Id: If58ed29e78a9994fc488a4d01cf665f7e8d82830 Reviewed-on: https://code.wireshark.org/review/4707 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-16gchar is not guaranteed to be signed; use gint8.Guy Harris1-1/+1
C does not guarantee that char is signed (that's why there's a keyword "signed"). Use gint8, to indicate that it's not a character, it's an 8-bit signed integer. Change-Id: Id632df23352840cbc86a4d88f4c7dade95ab7837 Reviewed-on: https://code.wireshark.org/review/4736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Fix some more "char is unsigned" issues, and a possible "char is signed" one.Guy Harris2-8/+8
C neither guarantees that char is signed nor that it's unsigned. Make the str_to_nibble tables arrays of gint8, to make sure they can hold numbers between 0 and 15 as well as -1. Cast gchar to guchar, not int, when using it as a subscript into that array, so that the subscripts are in the range 0 to 255, not -128 to 127. Change-Id: Ib85de5aa4e83ae9efd808c78ce3f86f45b4a3f2a Reviewed-on: https://code.wireshark.org/review/4734 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Fix issues in some ARM compilers, due to char being unsigned?Guy Harris1-8/+17
I'm not 100% certain the comparisons were right even with signed char; make the comparisons unsigned vs. unsigned, regardless of whether char is signed or not. (No, C doesn't require it to be signed; that's why there's a "signed" keyword.) Change-Id: Icbbd1019a2f7d4ebb40d821255834f825cd7c5a7 Reviewed-on: https://code.wireshark.org/review/4731 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Replace proto_tree_add_text in non-generated filesHannes Mezger2-36/+39
As requested by Michael Mann, most of the occurences of proto_tree_add_text/proto_item_add_subtree are replaced with proto_tree_add_subtree(_format) or proto_tree_add_item/proto_item_append_text in the non-generated files. Change-Id: I27cccde88780adef43c78efd26333f47af098ad6 Reviewed-on: https://code.wireshark.org/review/4726 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-16ETSI CAT: fix a typo and remove deprecated API callPascal Quantin1-14/+14
Change-Id: I7df02d6a605ca0912c179caa04a405c5c18eb552 Reviewed-on: https://code.wireshark.org/review/4727 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-16Replace proto_tree_add_text with proto_tree_add_subtree(_format) in ↵Hannes Mezger2-432/+431
generated files As requested by Michael Mann, all occurences of proto_tree_add_text/proto_item_add_subtree are replaced with proto_tree_add_subtree(_format) in the generated files. Our generator templates have also been updated accordingly. Change-Id: I49ddd664dffef4b3ceda77edd1b2d7e01da363f3 Reviewed-on: https://code.wireshark.org/review/4725 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-16Don't try to compute time stamps for files from Packet Builder.Guy Harris1-8/+18
I don't trust Packet Builder's ability to convert time stamps between Capsa format and pcap. Change-Id: I0ac2e14216e37127d81d5bf1c6d48a2c20841a8e Reviewed-on: https://code.wireshark.org/review/4721 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Fix a debugging printout.Guy Harris1-2/+2
Change-Id: I06bc40bece3ea98578a252217c9de4748276a440 Reviewed-on: https://code.wireshark.org/review/4720 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Get rid of some set-but-no-longer-used variables.Guy Harris1-6/+0
Change-Id: Iaf7267b6ee3d4ab288c8ffa487f5de736bc4aead Reviewed-on: https://code.wireshark.org/review/4719 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 22:32:28 +0000