aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-08-20If packet was modified fallback to generic cloneJakub Zawadzki1-4/+5
svn path=/trunk/; revision=51443
2013-08-20Fix clang warnings: Value stored to '[offset|length]' is never read.Chris Maynard1-6/+0
svn path=/trunk/; revision=51442
2013-08-20Fix clang warnings: Value stored to '[decrypted_]offset' is never read.Chris Maynard1-13/+8
svn path=/trunk/; revision=51441
2013-08-20Fix clang warning: Value stored to 'netl' is never read.Chris Maynard1-427/+436
Other misc. whitespace changes. svn path=/trunk/; revision=51440
2013-08-20Fix several instances of clang warnings: Value stored to 'length' is never readChris Maynard1-513/+581
Also, whitespace changes (tabs ->spaces, indentation) and add modelines. svn path=/trunk/; revision=51439
2013-08-20Fix for Jörg Mayer1-0/+5
[ 6%] Building C object epan/CMakeFiles/epan.dir/addr_resolv.c.o /home/jmayer/work/wireshark/svn/trunk/epan/addr_resolv.c:1927:1: error: unused function 'get_ipxnetbyname' [-Werror,-Wunused-function] get_ipxnetbyname(const gchar *name) ^ /home/jmayer/work/wireshark/svn/trunk/epan/addr_resolv.c:2009:1: error: unused function 'add_ipxnet_name' [-Werror,-Wunused-function] by #if 0/#endif the functions. If they really are not needed any more they should be removed. svn path=/trunk/; revision=51438
2013-08-20Mark an unused parameter.Anders Broman1-1/+1
svn path=/trunk/; revision=51437
2013-08-20Use g_hash_table() for ipxnet name resolution.Anders Broman2-41/+44
svn path=/trunk/; revision=51436
2013-08-20From Tommy Wu:Anders Broman1-6/+49
Update Octet 7 of Indication IE. svn path=/trunk/; revision=51435
2013-08-20Add a valgrind suppressions file set to suppress the zlib error which otherwiseEvan Huus2-1/+17
pops up immediately on the fuzzbot. Hopefully there won't be too many more of these. svn path=/trunk/; revision=51434
2013-08-19Another acknowledgment number tweak: If the ACK flag wasn't set such that ↵Chris Maynard1-1/+3
the base_seq wasn't subtracted from it, then if we need to recover absolute values later on, don't add the base_seq value back either. svn path=/trunk/; revision=51433
2013-08-19When using relative sequence numbers, don't scale acknowledgment numbers ↵Chris Maynard1-1/+3
unless the ACK bit is actually set; otherwise doing so results in many erroneous packets matching a filter such as, "(tcp.ack > 0) && (tcp.flags.ack == 0)". With this change, the number of expert infos noting non-zero acknowledgment numbers when the ACK bit is not set is the same as the number of packets that are displayed when applying the above display filter regardless of whether using relative or absolute sequence numbers. (Tested using the menagerie's mond.pcap file) svn path=/trunk/; revision=51432
2013-08-19Someone is bound to miss these expert info items, so add back expert info ↵Chris Maynard1-4/+16
items for ack and urgent pointer when their respective flags are not set; however, don't indicate "Broken TCP" and only add them as Notes rather than as Warnings as was previously the case prior to r51356 since nowhere does it indicate these fields must be zero when their respective bits aren't set. Speaking of r51356, a clarification to its commit message is in order: Initially my intention was to only add the urgent pointer field when the URG bit was set; however, I then noticed that the acknowledgment number field was always being added irrespective of the ACK bit. Had I made the change as I originally intended, it would have introduced an inconsistency. After some deliberation, I opted for consistency, but botched the commit message. svn path=/trunk/; revision=51431
2013-08-19Fix Coverity CID 1063335: Unused pointer value.Chris Maynard1-1/+1
svn path=/trunk/; revision=51430
2013-08-19Gather together dedicated DRX configuration, and make sure that itMartin Mathieson3-88/+648
is internally consistent. TODO: include r11 sequence that can overwrite some of these values. TODO: actx->private_data gets reused for several purposes, need to separate these uses out and avoid possible conflicts... svn path=/trunk/; revision=51429
2013-08-19Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9053 :Pascal Quantin2-10/+46
Update DDS RTPS Vendor and Product Ids based on http://portals.omg.org/dds/content/page/dds-rtps-vendor-and-product-ids svn path=/trunk/; revision=51428
2013-08-19Change some dissectors to use pinfo memory pool instead of malloc if it can ↵Pascal Quantin17-136/+70
trigger an exception between between buffer allocation and tvb_set_free_cb call svn path=/trunk/; revision=51427
2013-08-19Do not use ephemeral memory when adding a new data sourcePascal Quantin3-6/+10
svn path=/trunk/; revision=51424
2013-08-19Do not use ephemeral memory when adding a new data sourcePascal Quantin11-19/+38
svn path=/trunk/; revision=51423
2013-08-19Bugfix SGI Nsym disambiguation is unconditionally displayed when dissecting ↵Michael Mann2-3/+12
VHT, bug 8989 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8989) From Karl Beldan BACKPORT(1.8,1.10) svn path=/trunk/; revision=51422
2013-08-18One more 64/32-conversion fix for rtpproxyEvan Huus1-1/+1
svn path=/trunk/; revision=51421
2013-08-18Take another stab atEvan Huus1-1/+1
packet-rtpproxy.c:226: warning: implicit conversion shortens 64-bit value into a 32-bit value svn path=/trunk/; revision=51420
2013-08-18Add a cast to try and fixEvan Huus1-1/+1
packet-rtpproxy.c:226: warning: implicit conversion shortens 64-bit value into a 32-bit value I'm not quite sure what's going on here, all the values in use are either gint or guint so they should all be the same size? svn path=/trunk/; revision=51419
2013-08-18Use epan scope for one XML DTD string to fix a small leak.Evan Huus1-1/+1
svn path=/trunk/; revision=51418
2013-08-18From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8326Evan Huus4-0/+812
Dissector for the Sippy RTPproxy controlling protocol. RTPproxy is a well-known (among SIP-engineers) application and it operates using its own simple text-based protocol. There are several competing products but all of them implements it (sometimes slightly extending). svn path=/trunk/; revision=51417
2013-08-18addr_resolution_dlg.c: In function 'ipv6_hash_table_to_texbuff':Anders Broman1-1/+1
addr_resolution_dlg.c:185: warning: unused parameter 'key' svn path=/trunk/; revision=51416
2013-08-18Use g_hastable() for IPv6 name reslution.Anders Broman3-62/+117
svn path=/trunk/; revision=51415
2013-08-18[Automatic manuf, services and enterprise-numbers update for 2013-08-18]Gerald Combs2-15/+53
svn path=/trunk/; revision=51412
2013-08-18Bluetooth: HCI: Synchronize and update Voice command. Bug 9050 ↵Michael Mann3-40/+59
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9050) From Michal Labedzki. svn path=/trunk/; revision=51411
2013-08-18HCI: Full dissection of EIR/AD and little improve filtering, bug 9050 ↵Michael Mann4-184/+566
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9050) From Michal Labedzki. From me: 1. Have boolean filters use tfs_true_false instead of NULL (because it appears previous functionality had "TRUE" and "FALSE"). Perhaps other tfs_ values could be used, but tfs_true_false makes a good placeholder. 2. Add FT_ETHER field as a proto_tree_add_item. svn path=/trunk/; revision=51410
2013-08-18Create individual filters for HCI LMP features. Bug 9050 ↵Michael Mann1-290/+388
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9050) From Michal Labedzki svn path=/trunk/; revision=51409
2013-08-17Various fixes for dissection bugs from bug 9045 ↵Michael Mann1-12/+65
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9045) - Expert info for CRC 0x5935 got wrongly attached to Slim SSDO packages - SPDO Data Requests that fit in the last bytes of a frame got missed - Slim SSDOs got detected, that actually are not Slim SSDOs, to prevent this in the future, two checks have been added - The reported length of a Slim SSDO must be larger than 0 (correct Slim SSDOs always have at least 1 byte) - Both crc's must differ from another. There is a very unlikely possibility, that they may collide, but in such a case openSAFETY in itself would be flawed by design. svn path=/trunk/; revision=51408
2013-08-17Commit far from being perfect conversation tool from hfindex to hfinfo.Jakub Zawadzki1-0/+89
svn path=/trunk/; revision=51407
2013-08-17Another tv_buff reference.Guy Harris1-1/+1
svn path=/trunk/; revision=51406
2013-08-17Just call it a tvbuff, with no underscore.Guy Harris1-1/+1
svn path=/trunk/; revision=51405
2013-08-17Squelch a (bogus) warning about next_tvb being unused initialised.Martin Mathieson1-1/+1
svn path=/trunk/; revision=51404
2013-08-17Convert few more dissectors to new proto API.Jakub Zawadzki4-502/+584
svn path=/trunk/; revision=51403
2013-08-17Fix subtree ett value.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=51402
2013-08-17Fix few concept of new api tree:Jakub Zawadzki7-183/+225
- (for now) keep ABI, restore prototype of old proto_tree_add_item, add new proto_tree_add_item_new - add few helpers for boolean, time, string which will do ->id - don't use HFI_INIT directly, use it by another macro (MSVC has very small limit for section name) svn path=/trunk/; revision=51401
2013-08-17Move "aggregate" fields containing bit subfields before the bitGuy Harris1-93/+196
subfields. Rename some of their hf_ variable names to match the hf_ variable names of the subfields, and rename one field to be a prefix of its subfields. For the 64-bit UNIX capabilities, use proto_tree_add_item() for the flags. Get rid of a #if 0'ed out field that is duplicated by one of the newly-added fields. svn path=/trunk/; revision=51400
2013-08-17Get rid of an unused variable.Guy Harris1-20/+8
For some routines, instead of having them check for -1 as the hf_index and using a default hf_index in that case, just pass them the default hf_index instead of -1 and just use the hf_index unconditionally. svn path=/trunk/; revision=51399
2013-08-16Fix typo (failure to remove a %).Guy Harris1-143/+155
_U_ify some no-longer-used arguments. Rename all the hf_pipe variables to hf_smb_pipe, and rename the field names and protocol name to be "smb_pipe.", for consistency. (Ceci n'est pas une pipe.) Treat and label 1-byte parameters as "byte parameters" and multi-byte opaque parameters as "bytes parameters". Format machine-added hf[] entries to match other hf[] entries. Fix indentation. svn path=/trunk/; revision=51398
2013-08-16Convert my dissectors to new proto API.Jakub Zawadzki5-749/+757
svn path=/trunk/; revision=51397
2013-08-16Introduce new proto_tree API required for hf_ variables removal.Jakub Zawadzki2-18/+67
svn path=/trunk/; revision=51396
2013-08-16Initialize val_len to avoid Clang warning: The right operand of '-' is a ↵Chris Maynard1-16/+19
garbage value. While in there, add some protection against tvb_length_remaining() possibly returning -1, or possibly being less than val_len. #BACKPORT(1.10) svn path=/trunk/; revision=51395
2013-08-16Make more filterable items courtesy of convert_proto_tree_add_text.pl.Michael Mann2-509/+340
Also converted proto_tree_add_xxx_format into proto_tree_add_xxx_format_value so that label doesn't get out of sync with hf. svn path=/trunk/; revision=51394
2013-08-16Fix 5 warnings: Value stored to 'offset' is never read. Also: misc. ↵Chris Maynard1-297/+150
whitespace changes, add modelines. svn path=/trunk/; revision=51393
2013-08-16Trivial. Fix warning: Value stored to 'str_index' is never read.Chris Maynard1-2/+1
svn path=/trunk/; revision=51392
2013-08-16Be sure to forward BIN_DIR to the valgrind script, probably also needed on theEvan Huus1-4/+6
fuzz-but. svn path=/trunk/; revision=51391
2013-08-16packet-dcerpc-pn-io.c: In function 'dissect_PNIO_C_SDU':Anders Broman1-1/+1
packet-dcerpc-pn-io.c:9220: warning: unused parameter 'drep' svn path=/trunk/; revision=51390
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 21:16:56 +0000