aboutsummaryrefslogtreecommitdiffstats
path: root/wiretap
diff options
context:
space:
mode:
authorAlexis La Goutte <alexis.lagoutte@gmail.com>2021-07-27 12:46:07 +0000
committerWireshark GitLab Utility <gerald+gitlab-utility@wireshark.org>2021-07-30 20:43:55 +0000
commita3f9c6bc4575d6f56b3248638cb629482ec76e1e (patch)
tree313a9ce37b81e437fbb81eb4dbc898fa3beff5ee /wiretap
parent17f474406a2770d78b103dce7ba79a0801c31995 (diff)
erf: Fix Dead Store (found by Clang Anlyzer)
Although the value stored to 'tagtotallength' is used in the enclosing expression, the value is never actually read from 'tagtotallength'
Diffstat (limited to 'wiretap')
-rw-r--r--wiretap/erf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/erf.c b/wiretap/erf.c
index d04bda82fb..aedbafe094 100644
--- a/wiretap/erf.c
+++ b/wiretap/erf.c
@@ -3351,7 +3351,7 @@ static int populate_summary_info(erf_t *erf_priv, wtap *wth, union wtap_pseudo_h
state.tag_ptr += tagtotallength;
state.remaining_len -= tagtotallength;
- if ((tagtotallength = erf_meta_read_tag(&tag, state.tag_ptr, state.remaining_len))) {
+ if (erf_meta_read_tag(&tag, state.tag_ptr, state.remaining_len)) {
/*
* Process parent section tag if present (which must be the first tag in
* the section).