diff options
| author | Moshe Kaplan <me@moshekaplan.com> | 2020-12-20 21:30:28 -0500 |
|---|---|---|
| committer | AndersBroman <a.broman58@gmail.com> | 2020-12-22 14:56:38 +0000 |
| commit | e16166a74cca1d66e2c302e257cf94aebb380599 (patch) | |
| tree | 8834b4b8390fca83dd7bc1b4b9e6a7bb276e1d7e /wiretap/stanag4607.c | |
| parent | 7b27b444cbd94853b399da770e0dad4b91ef23ac (diff) | |
Detect and replace bad allocation patterns
Adds a pre-commit hook for detecting and replacing
occurrences of `g_malloc()` and `wmem_alloc()` with
`g_new()` and `wmem_new()`, to improve the
readability of Wireshark's code, and
occurrences of
`g_malloc(sizeof(struct myobj) * foo)`
with
`g_new(struct myobj, foo)`
to prevent integer overflows
Also fixes all existing occurrences across
the codebase.
Diffstat (limited to 'wiretap/stanag4607.c')
| -rw-r--r-- | wiretap/stanag4607.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/stanag4607.c b/wiretap/stanag4607.c index af4b73310f..9e927cbea4 100644 --- a/wiretap/stanag4607.c +++ b/wiretap/stanag4607.c @@ -185,7 +185,7 @@ wtap_open_return_val stanag4607_open(wtap *wth, int *err, gchar **err_info) wth->file_encap = WTAP_ENCAP_STANAG_4607; wth->snapshot_length = 0; /* not known */ - stanag4607 = (stanag4607_t *)g_malloc(sizeof(stanag4607_t)); + stanag4607 = g_new(stanag4607_t, 1); wth->priv = (void *)stanag4607; stanag4607->base_secs = 0; /* unknown as of yet */ |