diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-04-29 19:04:17 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-04-30 02:04:50 +0000 |
| commit | c34cf306ab90307c23371d638478bce1d348388d (patch) | |
| tree | b2f59efe586f99b9d0fd91f3b925fedf368e1770 /wiretap/radcom.c | |
| parent | 44f72a90eaffc8a0322b377c4a66c11bf63340dc (diff) | |
Note some cases where we don't need to check the packet length.
These file formats have 16-bit packet lengths, so, even with some extra
metadata added, the packet data length will never be bigger than
WTAP_MAX_PACKET_SIZE. (No, we won't ever reduce WTAP_MAX_PACKET_SIZE.)
Change-Id: I9e1b1d90971f91cc6e5d66d0aa93841445b2bc22
Reviewed-on: https://code.wireshark.org/review/15186
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'wiretap/radcom.c')
| -rw-r--r-- | wiretap/radcom.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/wiretap/radcom.c b/wiretap/radcom.c index 6a0b6f8259..e7fc81946b 100644 --- a/wiretap/radcom.c +++ b/wiretap/radcom.c @@ -306,6 +306,11 @@ radcom_read_rec(wtap *wth, FILE_T fh, struct wtap_pkthdr *phdr, Buffer *buf, } length = pletoh16(&hdr.length); real_length = pletoh16(&hdr.real_length); + /* + * The maximum value of length is 65535, which is less than + * WTAP_MAX_PACKET_SIZE will ever be, so we don't need to check + * it. + */ phdr->rec_type = REC_TYPE_PACKET; phdr->presence_flags = WTAP_HAS_TS|WTAP_HAS_CAP_LEN; |