diff options
| author | Guy Harris <guy@alum.mit.edu> | 2017-12-28 20:58:38 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2017-12-29 04:59:13 +0000 |
| commit | 9bf40d4a6e507e10c8429a758ac190146caf48d6 (patch) | |
| tree | 0f9abc28c501dd41e785bf92855281b2718e18f5 /wiretap/pcapng.c | |
| parent | c5dbcca2e4f3613f04e74715269c611dbb5259d1 (diff) | |
Do the right check for "no name resolution information to save".
The check that the pcapng code does is "do we have a non-null
addrinfo_lists_t * and, if so, does it have a non-null ipv4_addr_list or
ipv6_addr_list"?
The check that the file-save code was using was just "do we have a
non-null addrinfo_lists_t *", so sometimes it'd think we couldn't do a
"quick save" even though we had no name resolution information to write
out to the capture file.
Make a routine that does that check, and use it in *both* places.
Change-Id: Id4720f4fe4940354320b2b7621ca5e37e45ec1f3
Reviewed-on: https://code.wireshark.org/review/25055
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'wiretap/pcapng.c')
| -rw-r--r-- | wiretap/pcapng.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/pcapng.c b/wiretap/pcapng.c index 9217781341..6d82f42a7d 100644 --- a/wiretap/pcapng.c +++ b/wiretap/pcapng.c @@ -3376,7 +3376,7 @@ pcapng_write_name_resolution_block(wtap_dumper *wdh, int *err) hashipv6_t *ipv6_hash_list_entry; int i; - if ((!wdh->addrinfo_lists) || ((!wdh->addrinfo_lists->ipv4_addr_list)&&(!wdh->addrinfo_lists->ipv6_addr_list))) { + if (wtap_addrinfo_list_empty(wdh->addrinfo_lists)) { /* * No name/address pairs to write. * XXX - what if we have options? |