aboutsummaryrefslogtreecommitdiffstats
path: root/wiretap/mp2t.c
diff options
context:
space:
mode:
authorMoshe Kaplan <me@moshekaplan.com>2020-12-20 21:30:28 -0500
committerAndersBroman <a.broman58@gmail.com>2020-12-22 14:56:38 +0000
commite16166a74cca1d66e2c302e257cf94aebb380599 (patch)
tree8834b4b8390fca83dd7bc1b4b9e6a7bb276e1d7e /wiretap/mp2t.c
parent7b27b444cbd94853b399da770e0dad4b91ef23ac (diff)
Detect and replace bad allocation patterns
Adds a pre-commit hook for detecting and replacing occurrences of `g_malloc()` and `wmem_alloc()` with `g_new()` and `wmem_new()`, to improve the readability of Wireshark's code, and occurrences of `g_malloc(sizeof(struct myobj) * foo)` with `g_new(struct myobj, foo)` to prevent integer overflows Also fixes all existing occurrences across the codebase.
Diffstat (limited to 'wiretap/mp2t.c')
-rw-r--r--wiretap/mp2t.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/mp2t.c b/wiretap/mp2t.c
index 587e2ed9e5..36ad7274ee 100644
--- a/wiretap/mp2t.c
+++ b/wiretap/mp2t.c
@@ -381,7 +381,7 @@ found:
wth->subtype_seek_read = mp2t_seek_read;
wth->snapshot_length = 0;
- mp2t = (mp2t_filetype_t*) g_malloc(sizeof(mp2t_filetype_t));
+ mp2t = g_new(mp2t_filetype_t, 1);
wth->priv = mp2t;
mp2t->start_offset = first;