diff options
author | Guy Harris <gharris@sonic.net> | 2021-08-29 19:12:13 -0700 |
---|---|---|
committer | Guy Harris <gharris@sonic.net> | 2021-08-29 19:12:13 -0700 |
commit | 3cb6403a4caecd763e8e9a45a81160aac0644515 (patch) | |
tree | 3a321d42c17675aee99bcde1a6e59b5f9f146a91 /wiretap/camins.c | |
parent | eb2037fda4e3310c00ed4afb73195f3c4a9f27c9 (diff) |
wiretap: always allocate a block for a record.
Without that, you could add a comment to a record in a file format the
reading code for which doesn't allocate blocks, but the comment doesn't
get saved, as there's no block in which to save the comment option.
This simplifies some code paths, as we're either using the record's
modified block or we're using the block as read from the file, there's
no third possibility.
If we attempt to read a record, and we get an error, and a block was
allocated for the record, unreference it, so the individual file readers
don't have to worry about it.
Diffstat (limited to 'wiretap/camins.c')
-rw-r--r-- | wiretap/camins.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/wiretap/camins.c b/wiretap/camins.c index 775c8990ee..5d9680e3a9 100644 --- a/wiretap/camins.c +++ b/wiretap/camins.c @@ -377,6 +377,7 @@ camins_read_packet(FILE_T fh, wtap_rec *rec, Buffer *buf, offset += bytes_read; rec->rec_type = REC_TYPE_PACKET; + rec->block = wtap_block_create(WTAP_BLOCK_PACKET); rec->presence_flags = 0; /* we may or may not have a time stamp */ rec->rec_header.packet_header.pkt_encap = WTAP_ENCAP_DVBCI; if (time_us) { |