diff options
| author | Nardi Ivan <nardi.ivan@gmail.com> | 2020-05-25 09:55:50 +0200 |
|---|---|---|
| committer | Roland Knall <rknall@gmail.com> | 2020-05-30 07:50:12 +0000 |
| commit | c416e2ff3792d8fc07642508e312386c4027f656 (patch) | |
| tree | a0234adf08119611d7b53aeac12ca3d86e8edc90 /ui | |
| parent | 0708fadb33a01a32efeaf04502b378851e31f974 (diff) | |
Qt: improve performance of related packet delegate
Use proper functions to lookup/iterate elements in QHash
Avoid useless lookup
Change-Id: I7a115ae5ed35b31599f33050e36bf68007167a96
Reviewed-on: https://code.wireshark.org/review/37304
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/qt/models/related_packet_delegate.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ui/qt/models/related_packet_delegate.cpp b/ui/qt/models/related_packet_delegate.cpp index 612ba48dd6..aad4ea43f1 100644 --- a/ui/qt/models/related_packet_delegate.cpp +++ b/ui/qt/models/related_packet_delegate.cpp @@ -283,14 +283,14 @@ void RelatedPacketDelegate::clear() void RelatedPacketDelegate::setCurrentFrame(guint32 current_frame) { current_frame_ = current_frame; - foreach (int frame_num, related_frames_.keys()) { - addRelatedFrame(frame_num, related_frames_[frame_num]); + foreach (ft_framenum_type_t framenum_type, related_frames_) { + addRelatedFrame(-1, framenum_type); /* No need to check if this element belongs to the hash... */ } } void RelatedPacketDelegate::addRelatedFrame(int frame_num, ft_framenum_type_t framenum_type) { - if (!related_frames_.keys().contains(frame_num)) + if (frame_num != -1 && !related_frames_.contains(frame_num)) related_frames_[frame_num] = framenum_type; // Last match wins. Last match might not make sense, however. |