aboutsummaryrefslogtreecommitdiffstats
path: root/ui
diff options
context:
space:
mode:
authorGerald Combs <gerald@zing.org>2017-11-28 11:04:16 -0800
committerAnders Broman <a.broman58@gmail.com>2017-11-29 04:43:41 +0000
commit67ffa3cf7da172df53a821d5cd4c1a6a849f4087 (patch)
treed6f0d7dd707776eaa1742da2ad1cd4f1195c0532 /ui
parent041e3e7c27c78308d0d515171f52a39f8260782b (diff)
Threads: Set lifetimes and add a compatibility routine.
Join the protocol registration threads so that they call g_thread_unref which in turn detaches/terminates the thread. This gets rid of many TSan and DRD errors here. The remaining ones appear to be false positives. Add g_thread_new to glib-compat (untested). Change-Id: I4beb6746ed08656715cf7870ac63ff80cf1ef871 Reviewed-on: https://code.wireshark.org/review/24619 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui')
-rw-r--r--ui/gtk/main_welcome.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/ui/gtk/main_welcome.c b/ui/gtk/main_welcome.c
index 202ece3b7a..27b0f21434 100644
--- a/ui/gtk/main_welcome.c
+++ b/ui/gtk/main_welcome.c
@@ -653,12 +653,8 @@ welcome_filename_link_new(const gchar *filename, GtkWidget **label, GObject *men
g_signal_connect(w, "destroy", G_CALLBACK(welcome_filename_destroy_cb), ri_stat);
g_free(str_escaped);
-#if GLIB_CHECK_VERSION(2,31,0)
/* XXX - Add the filename here? */
g_thread_new("Recent item status", get_recent_item_status, ri_stat);
-#else
- g_thread_create(get_recent_item_status, ri_stat, FALSE, NULL);
-#endif
ri_stat->timer = g_timeout_add(200, update_recent_items, ri_stat);
/* event box */