diff options
| author | Guy Harris <gharris@sonic.net> | 2020-10-04 00:59:48 -0700 |
|---|---|---|
| committer | Guy Harris <gharris@sonic.net> | 2020-10-04 00:59:48 -0700 |
| commit | 4a9c412218f5ad5d48a6685844c0ca1ac5c98b08 (patch) | |
| tree | 74ea84e45cb70ba93d1134c248f268e6bee3b28f /ui | |
| parent | d76ee2cb89def39e9d7819486442846243bce1e8 (diff) | |
Fix a Coverity complaint.
For all cases in topic_action_url(), set url and break out of the switch
statement.
For the default case, set the URL to WS_HOME_PAGE_URL - we should never
get there, as here's a g_assert_not_reached() call before that, but this
should squelch Coverity's complaint.
Should fix Coverity CID 1467697.
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/help_url.c | 27 |
1 files changed, 14 insertions, 13 deletions
diff --git a/ui/help_url.c b/ui/help_url.c index 1f0da61404..7ea8429277 100644 --- a/ui/help_url.c +++ b/ui/help_url.c @@ -81,43 +81,43 @@ topic_action_url(topic_action_e action) switch(action) { /* pages online at www.wireshark.org */ case(ONLINEPAGE_HOME): - return WS_HOME_PAGE_URL; + url = WS_HOME_PAGE_URL; break; case(ONLINEPAGE_WIKI): - return WS_WIKI_HOME_URL; + url = WS_WIKI_HOME_URL; break; case(ONLINEPAGE_DOWNLOAD): - return WS_DOWNLOAD_URL; + url = WS_DOWNLOAD_URL; break; case(ONLINEPAGE_DOCS): - return WS_DOCS_URL; + url = WS_DOCS_URL; break; case(ONLINEPAGE_USERGUIDE): - return WS_DOCS_URL "/wsug_html_chunked/"; + url = WS_DOCS_URL "/wsug_html_chunked/"; break; case(ONLINEPAGE_FAQ): - return WS_FAQ_URL; + url = WS_FAQ_URL; break; case(ONLINEPAGE_ASK): - return WS_Q_AND_A_URL; + url = WS_Q_AND_A_URL; break; case(ONLINEPAGE_SAMPLE_FILES): - return WS_WIKI_URL("SampleCaptures"); + url = WS_WIKI_URL("SampleCaptures"); break; case(ONLINEPAGE_CAPTURE_SETUP): - return WS_WIKI_URL("CaptureSetup"); + url = WS_WIKI_URL("CaptureSetup"); break; case(ONLINEPAGE_NETWORK_MEDIA): - return WS_WIKI_URL("CaptureSetup/NetworkMedia"); + url = WS_WIKI_URL("CaptureSetup/NetworkMedia"); break; case(ONLINEPAGE_SAMPLE_CAPTURES): - return WS_WIKI_URL("SampleCaptures"); + url = WS_WIKI_URL("SampleCaptures"); break; case(ONLINEPAGE_SECURITY): - return WS_WIKI_URL("Security"); + url = WS_WIKI_URL("Security"); break; case(ONLINEPAGE_CHIMNEY): - return WS_WIKI_URL("CaptureSetup/Offloading#chimney"); + url = WS_WIKI_URL("CaptureSetup/Offloading#chimney"); break; /* local manual pages */ @@ -314,6 +314,7 @@ topic_action_url(topic_action_e action) case(TOPIC_ACTION_NONE): default: g_assert_not_reached(); + url = WS_HOME_PAGE_URL; } return url; |