diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-05-05 19:07:17 +0100 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2020-05-05 18:41:30 +0000 |
| commit | 1408dd3b5022cf5b4f7545440cd5839c784a4764 (patch) | |
| tree | fc440b949827066f6203412a2e34f05c734c2fc1 /ui | |
| parent | f263df0a4542c47d90798bd30fe2c4cd9d252820 (diff) | |
Last batch of changes from PVS-Studio scan.
/opt/SourceCode/wireshark/epan/dissectors/packet-flip.c 155 warn V547 Expression 'chksum_hdr_chksum == computed_chksum' is always false.
/opt/SourceCode/wireshark/epan/dissectors/packet-zbee-zcl-meas-sensing.c 1295 err V590 Consider inspecting the '(value > 0x0000) || (value > 0xfffd)' expression. The expression is excessive or contains a misprint.
/opt/SourceCode/wireshark/ui/qt/lte_rlc_statistics_dialog.cpp 504 warn V668 There is no sense in testing the 'channel_item' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Bug: 16335
Change-Id: Ief19a82e84bd16df33c453d6cc30db37f1c589ea
Reviewed-on: https://code.wireshark.org/review/37150
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/qt/lte_rlc_statistics_dialog.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ui/qt/lte_rlc_statistics_dialog.cpp b/ui/qt/lte_rlc_statistics_dialog.cpp index e87d703df3..0bd58aad68 100644 --- a/ui/qt/lte_rlc_statistics_dialog.cpp +++ b/ui/qt/lte_rlc_statistics_dialog.cpp @@ -501,9 +501,7 @@ public: } // Update channel with tap_info. - if (channel_item != NULL) { - channel_item->update(tap_info); - } + channel_item->update(tap_info); } // Draw UE entry |