Align structs and code a bit, ultimatly code should be shared.

svn path=/trunk/; revision=43924

3 files changed, 47 insertions, 63 deletions

diff --git a/ui/gtk/iax2_analysis.c b/ui/gtk/iax2_analysis.c
index a4fc0674ea..95676346ea 100644
--- a/ui/gtk/iax2_analysis.c
+++ b/ui/gtk/iax2_analysis.c
@@ -108,7 +108,7 @@ enum
 #define NUM_COLS 7
 #define NUM_GRAPH_ITEMS 100000
 #define MAX_YSCALE 16
-#define AUTO_MAX_YSCALE_INDEX 0
+#define DEFAULT_YSCALE_INDEX 0 /* AUTO_MAX_YSCALE */
 #define AUTO_MAX_YSCALE 0
 #define MAX_GRAPHS 4
 #define GRAPH_FWD_JITTER 0
@@ -123,7 +123,7 @@ static guint32 pixels_per_tick[MAX_PIXELS_PER_TICK] = {1, 2, 5, 10};
 static const char *graph_descr[4] = {"Fwd Jitter", "Fwd Difference", "Rvr Jitter", "Rvr Difference"};
 /* unit is in ms */
 #define MAX_TICK_VALUES 5
-#define DEFAULT_TICK_INTERVAL_VALUES_INDEX 1
+#define DEFAULT_TICK_VALUE_INDEX 1
 static guint tick_interval_values[MAX_TICK_VALUES] = { 1, 10, 100, 1000, 10000 };
 typedef struct _dialog_graph_graph_item_t {
 	guint32 value;
@@ -147,11 +147,12 @@ typedef struct _dialog_graph_graph_t {
 
 typedef struct _dialog_graph_t {
 	gboolean needs_redraw;
-	gint32 interval_index; /* index into tick_interval_values array */
 	gint32 interval;       /* measurement interval in ms */
 	guint32 last_interval;
 	guint32 max_interval;  /* XXX max_interval and num_items are redundant */
 	guint32 num_items;
+	double start_time;
+
 	struct _dialog_graph_graph_t graph[MAX_GRAPHS];
 	GtkWidget *window;
 	GtkWidget *draw_area;
@@ -164,11 +165,8 @@ typedef struct _dialog_graph_t {
 	GtkWidget *scrollbar;
 	int surface_width;
 	int surface_height;
-	int pixels_per_tick_index; /* index into pixels_per_tick array */
 	int pixels_per_tick;
-	int max_y_units_index;     /* index into yscale_max array      */
 	int max_y_units;
-	double start_time;
 } dialog_graph_t;
 
 typedef struct _dialog_data_t {
@@ -1641,7 +1639,6 @@ static void yscale_select(GtkWidget *item, gpointer data)
 
 	i = gtk_combo_box_get_active (GTK_COMBO_BOX(item));
 
-	user_data->dlg.dialog_graph.max_y_units_index=i;
 	user_data->dlg.dialog_graph.max_y_units=yscale_max[i];
 	dialog_graph_redraw(user_data);
 }
@@ -1654,7 +1651,6 @@ static void pixels_per_tick_select(GtkWidget *item, gpointer data)
 
 	i = gtk_combo_box_get_active (GTK_COMBO_BOX(item));
 
-	user_data->dlg.dialog_graph.pixels_per_tick_index=i;
 	user_data->dlg.dialog_graph.pixels_per_tick=pixels_per_tick[i];
 	dialog_graph_redraw(user_data);
 }
@@ -1667,7 +1663,6 @@ static void tick_interval_select(GtkWidget *item, gpointer data)
 
 	i = gtk_combo_box_get_active (GTK_COMBO_BOX(item));
 
-	user_data->dlg.dialog_graph.interval_index=i;
 	user_data->dlg.dialog_graph.interval=tick_interval_values[i];
 	cf_retap_packets(&cfile);
 	dialog_graph_redraw(user_data);
@@ -1693,7 +1688,7 @@ create_yscale_max_menu_items(user_data_t* user_data)
 		}
 		 gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (combo_box), str);
 	}
-	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), user_data->dlg.dialog_graph.max_y_units_index);
+	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), DEFAULT_YSCALE_INDEX);
 	g_signal_connect(combo_box, "changed", G_CALLBACK(yscale_select), user_data);
 
 	return combo_box;
@@ -1713,7 +1708,7 @@ create_pixels_per_tick_menu_items(user_data_t *user_data)
 		g_snprintf(str, sizeof(str), "%u", pixels_per_tick[i]);
 		 gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (combo_box), str);
 	}
-	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), user_data->dlg.dialog_graph.pixels_per_tick_index);
+	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), DEFAULT_PIXELS_PER_TICK_INDEX);
 
 	g_signal_connect(combo_box, "changed", G_CALLBACK(pixels_per_tick_select), user_data);
 
@@ -1742,7 +1737,7 @@ create_tick_interval_menu_items(user_data_t *user_data)
 		}
 		 gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (combo_box), str);
 	}
-	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), user_data->dlg.dialog_graph.interval_index);
+	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), DEFAULT_TICK_VALUE_INDEX);
 	g_signal_connect(combo_box, "changed", G_CALLBACK(tick_interval_select), user_data);
 
 	return combo_box;
@@ -3563,8 +3558,7 @@ void iax2_analysis(
 
 	/* init dialog_graph */
 	user_data->dlg.dialog_graph.needs_redraw=TRUE;
-	user_data->dlg.dialog_graph.interval_index=DEFAULT_TICK_INTERVAL_VALUES_INDEX;
-	user_data->dlg.dialog_graph.interval=tick_interval_values[DEFAULT_TICK_INTERVAL_VALUES_INDEX];
+	user_data->dlg.dialog_graph.interval=tick_interval_values[DEFAULT_TICK_VALUE_INDEX];
 	user_data->dlg.dialog_graph.draw_area=NULL;
 #if GTK_CHECK_VERSION(2,22,0)
 	user_data->dlg.dialog_graph.surface=NULL;
@@ -3575,9 +3569,7 @@ void iax2_analysis(
 	user_data->dlg.dialog_graph.scrollbar_adjustment=NULL;
 	user_data->dlg.dialog_graph.surface_width=500;
 	user_data->dlg.dialog_graph.surface_height=200;
-	user_data->dlg.dialog_graph.pixels_per_tick_index=DEFAULT_PIXELS_PER_TICK_INDEX;
 	user_data->dlg.dialog_graph.pixels_per_tick=pixels_per_tick[DEFAULT_PIXELS_PER_TICK_INDEX];
-	user_data->dlg.dialog_graph.max_y_units_index=AUTO_MAX_YSCALE_INDEX;
 	user_data->dlg.dialog_graph.max_y_units=AUTO_MAX_YSCALE;
 	user_data->dlg.dialog_graph.last_interval=0xffffffff;
 	user_data->dlg.dialog_graph.max_interval=0;
diff --git a/ui/gtk/io_stat.c b/ui/gtk/io_stat.c
index 4b41fb2d1e..d409ab24f6 100644
--- a/ui/gtk/io_stat.c
+++ b/ui/gtk/io_stat.c
@@ -182,8 +182,8 @@ typedef struct _io_stat_t {
 	GtkAdjustment *scrollbar_adjustment;
 	GtkWidget *scrollbar;
 
-	int pixmap_width;
-	int pixmap_height;
+	int surface_width;
+	int surface_height;
 	int pixels_per_tick;
 	int max_y_units;
 	int count_type;
@@ -849,8 +849,8 @@ io_stat_draw(io_stat_t *io)
 	/*
 	 * Calculate the size of the drawing area for the actual plot
 	 */
-	draw_width = io->pixmap_width-io->right_x_border - io->left_x_border;
-	draw_height = io->pixmap_height-top_y_border - bottom_y_border;
+	draw_width = io->surface_width-io->right_x_border - io->left_x_border;
+	draw_height = io->surface_height-top_y_border - bottom_y_border;
 
 	/*
 	 * Add a warning if too many entries
@@ -864,7 +864,7 @@ io_stat_draw(io_stat_t *io)
 #else
 		cr = gdk_cairo_create (io->pixmap);
 #endif
-		cairo_move_to (cr, 5, io->pixmap_height-bottom_y_border-draw_height-label_height/2);
+		cairo_move_to (cr, 5, io->surface_height-bottom_y_border-draw_height-label_height/2);
 		pango_cairo_show_layout (cr, layout);
 		cairo_destroy (cr);
 		cr = NULL;
@@ -879,8 +879,8 @@ io_stat_draw(io_stat_t *io)
 	cr = gdk_cairo_create (io->pixmap);
 #endif
 	cairo_set_line_width (cr, 1.0);
-	cairo_move_to(cr, io->pixmap_width-io->right_x_border+1.5, top_y_border + 0.5);
-	cairo_line_to(cr, io->pixmap_width-io->right_x_border+1.5, io->pixmap_height-bottom_y_border + 0.5);
+	cairo_move_to(cr, io->surface_width-io->right_x_border+1.5, top_y_border + 0.5);
+	cairo_line_to(cr, io->surface_width-io->right_x_border+1.5, io->surface_height-bottom_y_border + 0.5);
 	cairo_stroke(cr);
 	cairo_destroy(cr);
 	if(io->max_y_units==LOGARITHMIC_YSCALE){
@@ -899,15 +899,15 @@ io_stat_draw(io_stat_t *io)
 		if(io->max_y_units==LOGARITHMIC_YSCALE){
 			if (i==ys) {
 				/* position for the 0 value */
-				ypos=io->pixmap_height-bottom_y_border;
+				ypos=io->surface_height-bottom_y_border;
 			} else if (i==tics) {
 				/* position for the top value, do not draw logarithmic tics above graph */
-				ypos=io->pixmap_height-bottom_y_border-draw_height;
+				ypos=io->surface_height-bottom_y_border-draw_height;
 			} else {
 				int j;
 				/* draw the logarithmic tics */
 				for(j=2; j<10; j++) {
-					ypos=(int)(io->pixmap_height-bottom_y_border-(draw_height-ystart)*(i+log10((double)j))/tics-ystart);
+					ypos=(int)(io->surface_height-bottom_y_border-(draw_height-ystart)*(i+log10((double)j))/tics-ystart);
 					/* draw the tick */
 #if GTK_CHECK_VERSION(2,22,0)
 					cr = cairo_create (io->surface);
@@ -915,12 +915,12 @@ io_stat_draw(io_stat_t *io)
 					cr = gdk_cairo_create (io->pixmap);
 #endif
 					cairo_set_line_width (cr, 1.0);
-					cairo_move_to(cr, io->pixmap_width-io->right_x_border+1.5, ypos+0.5);
-					cairo_line_to(cr, io->pixmap_width-io->right_x_border+1.5+xwidth,ypos+0.5);
+					cairo_move_to(cr, io->surface_width-io->right_x_border+1.5, ypos+0.5);
+					cairo_line_to(cr, io->surface_width-io->right_x_border+1.5+xwidth,ypos+0.5);
 					cairo_stroke(cr);
 					cairo_destroy(cr);
 				}
-				ypos=io->pixmap_height-bottom_y_border-(draw_height-ystart)*i/tics-ystart;
+				ypos=io->surface_height-bottom_y_border-(draw_height-ystart)*i/tics-ystart;
 			}
 			/* all "main" logarithmic lines are slightly longer */
 			xwidth=10;
@@ -929,7 +929,7 @@ io_stat_draw(io_stat_t *io)
 				/* first, middle and last tick are slightly longer */
 				xwidth = 10;
 			}
-			ypos=io->pixmap_height-bottom_y_border-draw_height*i/10;
+			ypos=io->surface_height-bottom_y_border-draw_height*i/10;
 		}
 		/* draw the tick */
 #if GTK_CHECK_VERSION(2,22,0)
@@ -938,8 +938,8 @@ io_stat_draw(io_stat_t *io)
 		cr = gdk_cairo_create (io->pixmap);
 #endif
 		cairo_set_line_width (cr, 1.0);
-		cairo_move_to(cr, io->pixmap_width-io->right_x_border+1.5, ypos+0.5);
-		cairo_line_to(cr, io->pixmap_width-io->right_x_border+1.5+xwidth,ypos+0.5);
+		cairo_move_to(cr, io->surface_width-io->right_x_border+1.5, ypos+0.5);
+		cairo_line_to(cr, io->surface_width-io->right_x_border+1.5+xwidth,ypos+0.5);
 		cairo_stroke(cr);
 		cairo_destroy(cr);
 		/* draw the labels */
@@ -969,7 +969,7 @@ io_stat_draw(io_stat_t *io)
 #else
 			cr = gdk_cairo_create (io->pixmap);
 #endif
-			cairo_move_to (cr, io->pixmap_width-io->right_x_border+15+label_width-lwidth, ypos-label_height/2);
+			cairo_move_to (cr, io->surface_width-io->right_x_border+15+label_width-lwidth, ypos-label_height/2);
 			pango_cairo_show_layout (cr, layout);
 			cairo_destroy (cr);
 			cr = NULL;
@@ -994,8 +994,8 @@ io_stat_draw(io_stat_t *io)
 		cr = gdk_cairo_create (io->pixmap);
 #endif
 		cairo_set_line_width (cr, 1.0);
-		cairo_move_to(cr, io->left_x_border+0.5, io->pixmap_height-bottom_y_border+1.5);
-		cairo_line_to(cr, io->pixmap_width-io->right_x_border+1.5,io->pixmap_height-bottom_y_border+1.5);
+		cairo_move_to(cr, io->left_x_border+0.5, io->surface_height-bottom_y_border+1.5);
+		cairo_line_to(cr, io->surface_width-io->right_x_border+1.5,io->surface_height-bottom_y_border+1.5);
 		cairo_stroke(cr);
 		cairo_destroy(cr);
 	if((last_interval/io->interval)>=draw_width/io->pixels_per_tick){
@@ -1030,8 +1030,8 @@ io_stat_draw(io_stat_t *io)
 		cr = gdk_cairo_create (io->pixmap);
 #endif
 		cairo_set_line_width (cr, 1.0);
-		cairo_move_to(cr, x-1-io->pixels_per_tick/2+0.5, io->pixmap_height-bottom_y_border+1.5);
-		cairo_line_to(cr, x-1-io->pixels_per_tick/2+0.5, io->pixmap_height-bottom_y_border+xlen+1.5);
+		cairo_move_to(cr, x-1-io->pixels_per_tick/2+0.5, io->surface_height-bottom_y_border+1.5);
+		cairo_line_to(cr, x-1-io->pixels_per_tick/2+0.5, io->surface_height-bottom_y_border+xlen+1.5);
 		cairo_stroke(cr);
 		cairo_destroy(cr);
 		if(xlen==10){
@@ -1042,8 +1042,8 @@ io_stat_draw(io_stat_t *io)
 
 			if ((x-1-io->pixels_per_tick/2-lwidth/2) < 5) {
 				x_pos=5;
-			} else if ((x-1-io->pixels_per_tick/2+lwidth/2) > (io->pixmap_width-5)) {
-				x_pos=io->pixmap_width-lwidth-5;
+			} else if ((x-1-io->pixels_per_tick/2+lwidth/2) > (io->surface_width-5)) {
+				x_pos=io->surface_width-lwidth-5;
 			} else {
 				x_pos=x-1-io->pixels_per_tick/2-lwidth/2;
 			}
@@ -1052,7 +1052,7 @@ io_stat_draw(io_stat_t *io)
 #else
 			cr = gdk_cairo_create (io->pixmap);
 #endif
-			cairo_move_to (cr, x_pos, io->pixmap_height-bottom_y_border+15);
+			cairo_move_to (cr, x_pos, io->surface_height-bottom_y_border+15);
 			pango_cairo_show_layout (cr, layout);
 			cairo_destroy (cr);
 			cr = NULL;
@@ -1265,7 +1265,7 @@ io_stat_draw(io_stat_t *io)
 #else
 	gdk_cairo_set_source_pixmap (cr, io->pixmap, 0, 0);
 #endif
-	cairo_rectangle (cr, 0, 0, io->pixmap_width, io->pixmap_height);
+	cairo_rectangle (cr, 0, 0, io->surface_width, io->surface_height);
 	cairo_fill (cr);
 
 	cairo_destroy (cr);
@@ -1408,8 +1408,8 @@ iostat_init(const char *optarg _U_, void* userdata _U_)
 #endif
 	io->scrollbar=NULL;
 	io->scrollbar_adjustment=NULL;
-	io->pixmap_width=500;
-	io->pixmap_height=200;
+	io->surface_width=500;
+	io->surface_height=200;
 	io->pixels_per_tick=pixels_per_tick[DEFAULT_PIXELS_PER_TICK_INDEX];
 	io->max_y_units=AUTO_MAX_YSCALE;
 	io->count_type=0;
@@ -1510,7 +1510,7 @@ pixmap_clicked_event(GtkWidget *widget _U_, GdkEventButton *event, gpointer g)
 	int i;
 	gboolean load=FALSE, outstanding_call=FALSE;
 
-	draw_width = io->pixmap_width - io->right_x_border - io->left_x_border;
+	draw_width = io->surface_width - io->right_x_border - io->left_x_border;
 
 	if ((event->x <= (draw_width+io->left_x_border+1-(draw_width/io->pixels_per_tick)*io->pixels_per_tick)) ||
 	    (event->x >= (draw_width+io->left_x_border-io->pixels_per_tick/2))) {
@@ -1618,8 +1618,8 @@ draw_area_configure_event(GtkWidget *widget, GdkEventConfigure *event _U_, gpoin
 			widget_alloc.height,
 			-1);
 #endif
-	io->pixmap_width=widget_alloc.width;
-	io->pixmap_height=widget_alloc.height;
+	io->surface_width=widget_alloc.width;
+	io->surface_height=widget_alloc.height;
 
 	save_bt = g_object_get_data(G_OBJECT(io->window), "save_bt");
 #if GTK_CHECK_VERSION(2,22,0)
@@ -1702,7 +1702,7 @@ create_draw_area(io_stat_t *io, GtkWidget *box)
 	io->draw_area=gtk_drawing_area_new();
 	g_signal_connect(io->draw_area, "destroy", G_CALLBACK(draw_area_destroy_cb), io);
 
-	gtk_widget_set_size_request(io->draw_area, io->pixmap_width, io->pixmap_height);
+	gtk_widget_set_size_request(io->draw_area, io->surface_width, io->surface_height);
 
 	/* signals needed to handle backing pixmap */
 #if GTK_CHECK_VERSION(3,0,0)
diff --git a/ui/gtk/rtp_analysis.c b/ui/gtk/rtp_analysis.c
index a235bda51a..898c75dcd1 100644
--- a/ui/gtk/rtp_analysis.c
+++ b/ui/gtk/rtp_analysis.c
@@ -117,7 +117,7 @@ enum
 #define NUM_COLS 9
 #define NUM_GRAPH_ITEMS 100000
 #define MAX_YSCALE 16
-#define AUTO_MAX_YSCALE_INDEX 0
+#define DEFAULT_YSCALE_INDEX 0 /* AUTO_MAX_YSCALE */
 #define AUTO_MAX_YSCALE 0
 #define MAX_GRAPHS 6
 #define GRAPH_FWD_JITTER 0
@@ -134,7 +134,7 @@ static guint32 pixels_per_tick[MAX_PIXELS_PER_TICK] = {1, 2, 5, 10};
 static const char *graph_descr[MAX_GRAPHS] = {"Fwd Jitter", "Fwd Difference", "Fwd Delta", "Rvr Jitter", "Rvr Difference", "Rvr Delta"};
 /* unit is in ms */
 #define MAX_TICK_VALUES 5
-#define DEFAULT_TICK_INTERVAL_VALUES_INDEX 1
+#define DEFAULT_TICK_VALUE_INDEX 1
 static guint tick_interval_values[MAX_TICK_VALUES] = { 1, 10, 100, 1000, 10000 };
 typedef struct _dialog_graph_graph_item_t {
 	guint32 value;
@@ -158,11 +158,12 @@ typedef struct _dialog_graph_graph_t {
 
 typedef struct _dialog_graph_t {
 	gboolean needs_redraw;
-	gint32 interval_index;  /* index into tick_interval_values_array */
 	gint32 interval;        /* measurement interval in ms */
 	guint32 last_interval;
 	guint32 max_interval;  /* XXX max_interval and num_items are redundant */
 	guint32 num_items;
+	double start_time;
+
 	struct _dialog_graph_graph_t graph[MAX_GRAPHS];
 	GtkWidget *window;
 	GtkWidget *draw_area;
@@ -175,11 +176,8 @@ typedef struct _dialog_graph_t {
 	GtkWidget *scrollbar;
 	int surface_width;
 	int surface_height;
-	int pixels_per_tick_index; /* index into pixels_per_tick array */
 	int pixels_per_tick;
-	int max_y_units_index;     /* index into yscale_max array      */
 	int max_y_units;
-	double start_time;
 } dialog_graph_t;
 
 typedef struct _dialog_data_t {
@@ -1679,7 +1677,6 @@ static void yscale_select(GtkWidget *item, gpointer key)
 	user_data=(user_data_t *)key;
 	i = gtk_combo_box_get_active (GTK_COMBO_BOX(item));
 
-	user_data->dlg.dialog_graph.max_y_units_index=i;
 	user_data->dlg.dialog_graph.max_y_units=yscale_max[i];
 	dialog_graph_redraw(user_data);
 }
@@ -1693,7 +1690,6 @@ static void pixels_per_tick_select(GtkWidget *item, gpointer key)
 	user_data=(user_data_t *)key;
 	i = gtk_combo_box_get_active (GTK_COMBO_BOX(item));
 
-	user_data->dlg.dialog_graph.pixels_per_tick_index=i;
 	user_data->dlg.dialog_graph.pixels_per_tick=pixels_per_tick[i];
 	dialog_graph_redraw(user_data);
 }
@@ -1707,7 +1703,6 @@ static void tick_interval_select(GtkWidget *item, gpointer key)
 	user_data=(user_data_t *)key;
 	i = gtk_combo_box_get_active (GTK_COMBO_BOX(item));
 
-	user_data->dlg.dialog_graph.interval_index=i;
 	user_data->dlg.dialog_graph.interval=tick_interval_values[i];
 	cf_retap_packets(&cfile);
 	dialog_graph_redraw(user_data);
@@ -1733,7 +1728,7 @@ create_yscale_max_menu_items(user_data_t* user_data)
 		}
 		 gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (combo_box), str);
 	}
-	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), user_data->dlg.dialog_graph.max_y_units_index);
+	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), DEFAULT_YSCALE_INDEX);
 	g_signal_connect(combo_box, "changed", G_CALLBACK(yscale_select), (gpointer)user_data);
 
 	return combo_box;
@@ -1753,7 +1748,7 @@ create_pixels_per_tick_menu_items(user_data_t *user_data)
 		g_snprintf(str, sizeof(str), "%u", pixels_per_tick[i]);
 		 gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (combo_box), str);
 	}
-	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), user_data->dlg.dialog_graph.pixels_per_tick_index);
+	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), DEFAULT_PIXELS_PER_TICK_INDEX);
 
 	g_signal_connect(combo_box, "changed", G_CALLBACK(pixels_per_tick_select), (gpointer)user_data);
 
@@ -1782,7 +1777,7 @@ create_tick_interval_menu_items(user_data_t *user_data)
 		}
 		 gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (combo_box), str);
 	}
-	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), user_data->dlg.dialog_graph.interval_index);
+	gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), DEFAULT_TICK_VALUE_INDEX);
 	g_signal_connect(combo_box, "changed", G_CALLBACK(tick_interval_select), (gpointer)user_data);
 
 	return combo_box;
@@ -3734,8 +3729,7 @@ void rtp_analysis(
 
 	/* init dialog_graph */
 	user_data->dlg.dialog_graph.needs_redraw=TRUE;
-	user_data->dlg.dialog_graph.interval_index=DEFAULT_TICK_INTERVAL_VALUES_INDEX;
-	user_data->dlg.dialog_graph.interval=tick_interval_values[DEFAULT_TICK_INTERVAL_VALUES_INDEX];
+	user_data->dlg.dialog_graph.interval=tick_interval_values[DEFAULT_TICK_VALUE_INDEX];
 	user_data->dlg.dialog_graph.draw_area=NULL;
 #if GTK_CHECK_VERSION(2,22,0)
 	user_data->dlg.dialog_graph.surface=NULL;
@@ -3746,9 +3740,7 @@ void rtp_analysis(
 	user_data->dlg.dialog_graph.scrollbar_adjustment=NULL;
 	user_data->dlg.dialog_graph.surface_width=500;
 	user_data->dlg.dialog_graph.surface_height=200;
-	user_data->dlg.dialog_graph.pixels_per_tick_index=DEFAULT_PIXELS_PER_TICK_INDEX;
 	user_data->dlg.dialog_graph.pixels_per_tick=pixels_per_tick[DEFAULT_PIXELS_PER_TICK_INDEX];
-	user_data->dlg.dialog_graph.max_y_units_index=AUTO_MAX_YSCALE_INDEX;
 	user_data->dlg.dialog_graph.max_y_units=AUTO_MAX_YSCALE;
 	user_data->dlg.dialog_graph.last_interval=0xffffffff;
 	user_data->dlg.dialog_graph.max_interval=0;