Qt: Disable alternating table rows.

Disable QAbstractItemView's alternatingRowColors in places where we have
that set. One of Wireshark's most heavily used features is packet
colorization; we use color in packet list and detail rows to convey
information. Simple alternating color rows doesn't do that, and as my
blatant appeal to authority^W^W^W^W^WEdward Tufte points out, "Strips
are merely bureaucratic or designer chartjunk; good typography can
always organize a table, no stripes needed."

https://www.edwardtufte.com/bboard/q-and-a-fetch-msg?msg_id=0001IV

6 files changed, 6 insertions, 25 deletions

diff --git a/ui/qt/bluetooth_device_dialog.ui b/ui/qt/bluetooth_device_dialog.ui
index 73fd59f4df..fcc7d09362 100644
--- a/ui/qt/bluetooth_device_dialog.ui
+++ b/ui/qt/bluetooth_device_dialog.ui
@@ -37,9 +37,6 @@
      <property name="dragDropOverwriteMode">
       <bool>false</bool>
      </property>
-     <property name="alternatingRowColors">
-      <bool>true</bool>
-     </property>
      <property name="verticalScrollMode">
       <enum>QAbstractItemView::ScrollPerPixel</enum>
      </property>
@@ -256,7 +253,7 @@
     <string>Mark/Unmark Row</string>
    </property>
    <property name="shortcut">
-    <string>Ctrl-M</string>
+    <string>Ctrl+M</string>
    </property>
   </action>
   <action name="actionMark_Unmark_Cell">
diff --git a/ui/qt/bluetooth_hci_summary_dialog.ui b/ui/qt/bluetooth_hci_summary_dialog.ui
index c2ba52a27a..c477500804 100644
--- a/ui/qt/bluetooth_hci_summary_dialog.ui
+++ b/ui/qt/bluetooth_hci_summary_dialog.ui
@@ -31,9 +31,6 @@
      <property name="showDropIndicator" stdset="0">
       <bool>false</bool>
      </property>
-     <property name="alternatingRowColors">
-      <bool>true</bool>
-     </property>
      <property name="selectionMode">
       <enum>QAbstractItemView::ExtendedSelection</enum>
      </property>
@@ -67,15 +64,15 @@
      <attribute name="headerCascadingSectionResizes">
       <bool>false</bool>
      </attribute>
+     <attribute name="headerMinimumSectionSize">
+      <number>100</number>
+     </attribute>
      <attribute name="headerDefaultSectionSize">
       <number>100</number>
      </attribute>
      <attribute name="headerHighlightSections">
       <bool>false</bool>
      </attribute>
-     <attribute name="headerMinimumSectionSize">
-      <number>100</number>
-     </attribute>
      <attribute name="headerShowSortIndicator" stdset="0">
       <bool>false</bool>
      </attribute>
@@ -602,7 +599,7 @@
    <item>
     <layout class="QHBoxLayout" name="horizontalLayout" stretch="0,0,0,0">
      <property name="spacing">
-      <number>-1</number>
+      <number>6</number>
      </property>
      <property name="sizeConstraint">
       <enum>QLayout::SetDefaultConstraint</enum>
diff --git a/ui/qt/credentials_dialog.ui b/ui/qt/credentials_dialog.ui
index 16e5b3361d..fc41414b30 100644
--- a/ui/qt/credentials_dialog.ui
+++ b/ui/qt/credentials_dialog.ui
@@ -15,11 +15,7 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
    <item>
-    <widget class="QTreeView" name="auths">
-     <property name="alternatingRowColors">
-      <bool>true</bool>
-     </property>
-    </widget>
+    <widget class="QTreeView" name="auths"/>
    </item>
    <item>
     <widget class="QDialogButtonBox" name="buttonBox">
diff --git a/ui/qt/resolved_addresses_dialog.ui b/ui/qt/resolved_addresses_dialog.ui
index a1a194e9d4..c77c5cc134 100644
--- a/ui/qt/resolved_addresses_dialog.ui
+++ b/ui/qt/resolved_addresses_dialog.ui
@@ -43,9 +43,6 @@
          <property name="editTriggers">
           <set>QAbstractItemView::NoEditTriggers</set>
          </property>
-         <property name="alternatingRowColors">
-          <bool>true</bool>
-         </property>
          <property name="sortingEnabled">
           <bool>true</bool>
          </property>
diff --git a/ui/qt/sctp_all_assocs_dialog.ui b/ui/qt/sctp_all_assocs_dialog.ui
index d697b4b614..d25b1ca875 100644
--- a/ui/qt/sctp_all_assocs_dialog.ui
+++ b/ui/qt/sctp_all_assocs_dialog.ui
@@ -25,9 +25,6 @@
      <property name="dragDropOverwriteMode">
       <bool>false</bool>
      </property>
-     <property name="alternatingRowColors">
-      <bool>true</bool>
-     </property>
      <property name="selectionMode">
       <enum>QAbstractItemView::SingleSelection</enum>
      </property>
diff --git a/ui/qt/sctp_chunk_statistics_dialog.ui b/ui/qt/sctp_chunk_statistics_dialog.ui
index 26d1186b00..0a12082301 100644
--- a/ui/qt/sctp_chunk_statistics_dialog.ui
+++ b/ui/qt/sctp_chunk_statistics_dialog.ui
@@ -47,9 +47,6 @@
    <property name="editTriggers">
     <set>QAbstractItemView::NoEditTriggers</set>
    </property>
-   <property name="alternatingRowColors">
-    <bool>true</bool>
-   </property>
    <property name="selectionMode">
     <enum>QAbstractItemView::SingleSelection</enum>
    </property>