diff options
| author | Jakub Zawadzki <darkjames-ws@darkjames.pl> | 2018-01-22 21:16:01 +0100 |
|---|---|---|
| committer | Jakub Zawadzki <darkjames-ws@darkjames.pl> | 2018-01-22 20:53:54 +0000 |
| commit | 3a9da2e707924ba0be453c65274d881cb845c4b1 (patch) | |
| tree | d54f4858affa31e12100c9eb399ad4bb3c44d610 /ui | |
| parent | e6eb4815cd426d8ea30d0ef3225bc27f39dab776 (diff) | |
gtk: fix memory leak in profile dialog.
fill_list() don't break the loop when it founds first profile matching
name, and it can memleak if somehow it found more than one.
Don't break the loop to avoid regressions. Just g_free() previously found.
Found by clang.
Change-Id: I082b3f1d16f07580a6d7c814d2a8ee5463a44b0f
Reviewed-on: https://code.wireshark.org/review/25422
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/gtk/profile_dlg.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/gtk/profile_dlg.c b/ui/gtk/profile_dlg.c index ca69b2c386..b1f4264bf2 100644 --- a/ui/gtk/profile_dlg.c +++ b/ui/gtk/profile_dlg.c @@ -91,6 +91,7 @@ fill_list(GtkWidget *main_w) * and use it later without any crashes. This may not be a * valid assumption. */ + g_free(l_select); l_select = (GtkTreeIter *)g_memdup(&iter, sizeof(iter)); } fl_entry = g_list_next(fl_entry); |