RTP: Code clean up

Changes:
- rtpstream_packet renamed to rtpstream_packet_cb to follow *_cb pattern
- variables/types used in iax2_analysis_dialog were created as copy of *rtp* ones, but names were left as *rtp* -> *iax2*
- struct _rtp_stream_info replaced with rtp_stream_info_t
- there was tap-rtp-analysis.h, but no tap-rtp-analysis.c - related content was moved from tap-rtp-common.c
- *rtp_stream* functions renamed to *rtpstream*
- renamed rtp_stream_info_t to rtpstream_info_t to follow *rtpstream* pattern.
- renamed ui/rtp_stream.c rtpstream_draw -> rtpstream_draw_cb

Change-Id: Ib11ff5367cc464ea1b0c73432bc50b0eb9cd203e
Reviewed-on: https://code.wireshark.org/review/28299
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 8 insertions, 7 deletions

diff --git a/ui/tap-rtp-common.h b/ui/tap-rtp-common.h
index 1f559bf739..ef27caacfb 100644
--- a/ui/tap-rtp-common.h
+++ b/ui/tap-rtp-common.h
@@ -22,29 +22,30 @@
 extern "C" {
 #endif /* __cplusplus */
 
+#include "ui/rtp_stream.h"
+
 /* type of error when saving voice in a file didn't succeed */
 typedef enum {
+    TAP_RTP_NO_ERROR,
     TAP_RTP_WRONG_CODEC,
     TAP_RTP_WRONG_LENGTH,
     TAP_RTP_PADDING_ERROR,
     TAP_RTP_SHORT_FRAME,
     TAP_RTP_FILE_OPEN_ERROR,
     TAP_RTP_FILE_WRITE_ERROR,
-    TAP_RTP_NO_DATA
-} error_type_t;
+    TAP_RTP_NO_DATA,
+} tap_rtp_error_type_t;
 
 typedef struct _tap_rtp_save_info_t {
     FILE *fp;
     guint32 count;
-    error_type_t error_type;
+    tap_rtp_error_type_t error_type;
     gboolean saved;
 } tap_rtp_save_info_t;
 
-struct _rtp_stream_info;
-
 void rtpstream_reset_cb(void*);
-void rtp_write_header(struct _rtp_stream_info*, FILE*);
-int rtpstream_packet(void*, packet_info*, epan_dissect_t *, const void *);
+void rtp_write_header(rtpstream_info_t*, FILE*);
+int rtpstream_packet_cb(void*, packet_info*, epan_dissect_t *, const void *);
 
 #ifdef __cplusplus
 }