diff options
| author | AndersBroman <anders.broman@ericsson.com> | 2017-03-24 12:52:18 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-03-24 13:39:52 +0000 |
| commit | cf97b57ede106f1bca733f9aa48d0ea29b25bf4d (patch) | |
| tree | 027b4d1ff6fceeabef64573fd4fa748742a76aa2 /ui/tap-rtp-common.c | |
| parent | ceeb757cd3c869a9da3e37b62442b63c94fd4e4f (diff) | |
[RTP Analysis] Remove check for duplicated MAC (duplicated packet
detection)
Bug: 11478
Change-Id: Ieff015e5bf55facc732beae6a40b76d2050a4aac
Reviewed-on: https://code.wireshark.org/review/20696
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/tap-rtp-common.c')
| -rw-r--r-- | ui/tap-rtp-common.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/ui/tap-rtp-common.c b/ui/tap-rtp-common.c index d4343a81d0..81687b6329 100644 --- a/ui/tap-rtp-common.c +++ b/ui/tap-rtp-common.c @@ -477,8 +477,12 @@ rtp_packet_analyse(tap_rtp_stat_t *statinfo, /* Reset flags */ statinfo->flags = 0; - - /* Chek for duplicates (src mac differs from first_packet_mac_addr) */ +#if 0 + /*According to bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11478 + * this code causes problems. A better solution is needed if there is need for the functionality */ + /* Try to detect duplicated packets due to mirroring/span ports by comparing src MAC addresses. + * Chek for duplicates (src mac differs from first_packet_mac_addr) */ + */ if( pinfo->dl_src.type == AT_ETHER){ if(!addresses_equal(&(statinfo->first_packet_mac_addr), &(pinfo->dl_src))){ statinfo->flags |= STAT_FLAG_DUP_PKT; @@ -486,7 +490,7 @@ rtp_packet_analyse(tap_rtp_stat_t *statinfo, return; } } - +#endif /* When calculating expected rtp packets the seq number can wrap around * so we have to count the number of cycles * Variable cycles counts the wraps around in forwarding connection and |