diff options
author | Jirka Novak <j.novak@netsystem.cz> | 2021-01-03 08:03:46 +0100 |
---|---|---|
committer | AndersBroman <a.broman58@gmail.com> | 2021-01-03 16:53:21 +0000 |
commit | 7928f81b10eae1133da1cb313eb53ffd82178f23 (patch) | |
tree | d998015ca76e2b3be1c7241df4e50871ff2404aa /ui/tap-rtp-analysis.h | |
parent | 85deb99637672f2be1f64ab4b07676b91613b6e0 (diff) |
RTP processing: Modified RTP sequence verification
The patch changes:
- Removed first_packet_mac_addr staff. It was commented out many years ago...
- Removed delta_timestamp item. Not used.
- Sequence verification takes into account timestamp therefore it is able to detect delayed packets more clearly. As consequence of it, #16330 is solved.
- If packet is delayed, it is not used in calculation of diff/jitter/skew. It just mess output. As consequence of it, #16330 is solved.
I checked output with many RTP streams and looks well. But I have no
sample with wrapped timestamp and I have just a few samples with
missing/reordered packets. Nevertheless all are calculated same way as
before and #16330 is solved too.
Diffstat (limited to 'ui/tap-rtp-analysis.h')
-rw-r--r-- | ui/tap-rtp-analysis.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ui/tap-rtp-analysis.h b/ui/tap-rtp-analysis.h index 7ed83b980f..99ebb72d15 100644 --- a/ui/tap-rtp-analysis.h +++ b/ui/tap-rtp-analysis.h @@ -45,12 +45,10 @@ typedef struct _tap_rtp_stat_t { /* all of the following fields will be initialized after * rtppacket_analyse has been called */ - address first_packet_mac_addr; /**< MAC address of first packet, used to determine duplicates due to mirroring */ guint32 flags; /* see STAT_FLAG-defines below */ guint16 seq_num; guint32 timestamp; guint32 first_timestamp; - guint32 delta_timestamp; double bandwidth; bw_history_item bw_history[BUFF_BW]; guint16 bw_start_index; @@ -78,7 +76,7 @@ typedef struct _tap_rtp_stat_t { guint32 total_nr; guint32 sequence; gboolean under; - gint cycles; + gint seq_cycles; guint16 pt; int reg_pt; guint32 first_packet_num; |