diff options
| author | João Valverde <j@v6e.pt> | 2021-07-26 17:22:36 +0100 |
|---|---|---|
| committer | João Valverde <j@v6e.pt> | 2021-09-17 00:43:54 +0100 |
| commit | 8df2a73594fbcc812f4ea22a72ab7a79bfb63dc3 (patch) | |
| tree | 7d30bc5be8e85c52c0dd295cb15cd717d5770dcb /ui/qt | |
| parent | 7462e76884942258bae110ead925f25ffa54e2a8 (diff) | |
Use the musl in-tree getopt_long() everywhere
Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.
Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.
The API is under the Wireshark namespace to avoid conflicts with
system headers.
Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.
Diffstat (limited to 'ui/qt')
| -rw-r--r-- | ui/qt/main.cpp | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/ui/qt/main.cpp b/ui/qt/main.cpp index d5ec5191e9..63160327ac 100644 --- a/ui/qt/main.cpp +++ b/ui/qt/main.cpp @@ -21,19 +21,6 @@ #include "ui/win32/console_win32.h" #endif -/* - * If we have getopt_long() in the system library, include <getopt.h>. - * Otherwise, we're using our own getopt_long() (either because the - * system has getopt() but not getopt_long(), as with some UN*Xes, - * or because it doesn't even have getopt(), as with Windows), so - * include our getopt_long()'s header. - */ -#ifdef HAVE_GETOPT_LONG -#include <getopt.h> -#else -#include <wsutil/wsgetopt.h> -#endif - #include <ui/clopts_common.h> #include <ui/cmdarg_err.h> #include <ui/exit_codes.h> |