diff options
| author | Tomasz Moń <desowin@gmail.com> | 2019-09-29 11:39:40 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-10-01 03:53:46 +0000 |
| commit | f67eccedd9836e6ced1f57ae9889f57a5400a3d7 (patch) | |
| tree | 5a610c687e2fc856cef83d5404f5904bee4f11c1 /ui/qt/wireshark_application.h | |
| parent | ef76d65fc61d01c2ce5184140f4b1bba0019078b (diff) | |
Qt: Do not spin unnecessary additional event loops
Show the dialogs asynchronously so no new event loops are created. This
not only simplifies stack traces (reduces the nesting level) but also
prevents hard to debug problems (eg. Bug 15743) from happening.
Change-Id: I85821a1403839a5baca504b40efce0ede2f1e0cb
Reviewed-on: https://code.wireshark.org/review/34646
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/wireshark_application.h')
| -rw-r--r-- | ui/qt/wireshark_application.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/ui/qt/wireshark_application.h b/ui/qt/wireshark_application.h index b7a7a0ac90..e7c72612b5 100644 --- a/ui/qt/wireshark_application.h +++ b/ui/qt/wireshark_application.h @@ -78,9 +78,6 @@ public: // dialogs on macOS can be problematic. Dialogs should call queueAppSignal // instead. void queueAppSignal(AppSignal signal) { app_signals_ << signal; } - // Flush queued app signals. Should be called from the main window after - // each dialog that calls queueAppSignal closes. - void flushAppSignals(); void emitStatCommandSignal(const QString &menu_path, const char *arg, void *userdata); void emitTapParameterSignal(const QString cfg_abbr, const QString arg, void *userdata); void addDynamicMenuGroupItem(int group, QAction *sg_action); @@ -206,6 +203,10 @@ public slots: void captureEventHandler(CaptureEvent); + // Flush queued app signals. Should be called from the main window after + // each dialog that calls queueAppSignal closes. + void flushAppSignals(); + private slots: void updateTaps(); |