Qt: Byte view and proto tree fixes.

Select our byte field only when we enter marked / locked mode.

Emit fieldSelected from autoScrollTo so that we always set the marked
protocol.

Don't clobber the current index in saveSelectedField.

Change-Id: I967b20608f991a5f3e6a0979b1f702f874ce27b4
Reviewed-on: https://code.wireshark.org/review/25521
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 4 insertions, 2 deletions

diff --git a/ui/qt/widgets/byte_view_text.cpp b/ui/qt/widgets/byte_view_text.cpp
index 81c2313cf7..ed16261391 100644
--- a/ui/qt/widgets/byte_view_text.cpp
+++ b/ui/qt/widgets/byte_view_text.cpp
@@ -265,14 +265,16 @@ void ByteViewText::mousePressEvent (QMouseEvent *event) {
     }
 
     if (marked_byte_offset_ < 0) {
+        // Marked mode.
         marked_byte_offset_ = byteOffsetAtPixel(event->pos());
         hovered_byte_offset_ = -1;
+        emit byteSelected(marked_byte_offset_);
+        viewport()->update();
     } else {
+        // Back to hover mode.
         marked_byte_offset_ = -1;
         mouseMoveEvent(event);
     }
-    emit byteSelected(marked_byte_offset_);
-    viewport()->update();
 }
 
 void ByteViewText::mouseMoveEvent(QMouseEvent *event)