Don't dissect twice from TapParameterDialog.

When the user applies a display filter in TapParameterDialog we're about
to start tapping. We need to set the display filter in the main window
but we shouldn't apply it.

Change-Id: I08bed5c7f470f1dbf32817a7d999f09d2c52f168
Reviewed-on: https://code.wireshark.org/review/10287
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

1 files changed, 2 insertions, 2 deletions

diff --git a/ui/qt/tap_parameter_dialog.cpp b/ui/qt/tap_parameter_dialog.cpp
index e03858e413..ead74acc05 100644
--- a/ui/qt/tap_parameter_dialog.cpp
+++ b/ui/qt/tap_parameter_dialog.cpp
@@ -107,7 +107,7 @@ TapParameterDialog::TapParameterDialog(QWidget &parent, CaptureFile &cf, int hel
 
     if (!ui->displayFilterLineEdit->text().isEmpty()) {
         QString filter = ui->displayFilterLineEdit->text();
-        emit updateFilter(filter, true);
+        emit updateFilter(filter);
     }
     show_timer_ = new QTimer(this);
     setRetapOnShow(true);
@@ -521,7 +521,7 @@ void TapParameterDialog::on_applyFilterButton_clicked()
         return;
 
     QString filter = ui->displayFilterLineEdit->text();
-    emit updateFilter(filter, false);
+    emit updateFilter(filter);
     // If we wanted to be fancy we could add an isRetapping function to
     // either WiresharkDialog or CaptureFile and use it in updateWidgets
     // to enable and disable the apply button as needed.