diff options
| author | Gerald Combs <gerald@wireshark.org> | 2021-04-15 10:39:19 -0700 |
|---|---|---|
| committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2021-04-15 21:01:28 +0000 |
| commit | 212ff30603e343929c4c22173c38b7149bc4998c (patch) | |
| tree | b4f50396b5a5389c9bd71118b89a456f96ad59ad /ui/qt/rtp_player_dialog.cpp | |
| parent | 040212119dc1d7fa6290c8bec5142a125e3d163f (diff) | |
RTP: Fixup stream ID hashing.
Update our hash value when calling add_address_to_hash. Fixes:
________________________________________________________________________________________________________
*** CID 1476121: Incorrect expression (USELESS_CALL)
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/ui/rtp_stream_id.c: 141 in pinfo_rtp_info_to_hash()
135 /* SRC PORT | DST_PORT */
136 /* SSRC */
137 /* SRC ADDR */
138 /* DST ADDR */
139 hash ^= pinfo->srcport | pinfo->destport << 16;
140 hash ^= rtp_info->info_sync_src;
>>> CID 1476121: Incorrect expression (USELESS_CALL)
>>> Calling "add_address_to_hash(hash, &pinfo->src)" is only useful for its return value, which is ignored.
141 add_address_to_hash(hash, &pinfo->src);
142 add_address_to_hash(hash, &pinfo->dst);
143
144 return hash;
145 }
146
Diffstat (limited to 'ui/qt/rtp_player_dialog.cpp')
0 files changed, 0 insertions, 0 deletions